- 03 Mar, 2020 40 commits
-
-
henrika authored
Adds more detailed native logging for the lowest audio layers for both input and output sides (Linux PulseAudio and Windows Core Audio). Focus is on Windows since that is where we have the most users and we see most error reports. Example of new output: https://paste.googleplex.com/6563757645889536 Bug: 1017219 Change-Id: If0f4f157e57f5a387b20fdffe41198f83e2fb9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062428Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#746418}
-
Alison Maher authored
The ForcedColors flag will be expiring from about:flags after the branch for 82. Extending the expiration to branch 85. Bug: 970285 Change-Id: I788ac31e6053c8577b291815973781b8aec79a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083951Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746417}
-
Paul Lewis authored
This removes the user-metrics-perf.js layout test in preference to the end-to-end test in the DevTools repo, created in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084582 Bug: 1032561, 1046784 Change-Id: Iebe9baf872302579af89cea3542e343c9681a185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084557Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746416}
-
Greg Thompson authored
- ReportGenerator can now optionally generate a report lacking full profile info. - BrowserReportGenerator and ReportGenerator are now stateless. - ReportScheduler now observes BuildState and generates/updates a minimal report for desktop Chrome when an update is available. If a trigger to generate a report arrives while a report is in-flight, its handling is deferred until the previous completes. BUG=1043624 R=zmin@chromium.org Change-Id: I7864ee467bd681869ba0a57015c718cd811dc4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036072 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746415}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I8d84f37600e97535466d8c5da717fec7fff56b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084673Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746414}
-
Sammie Quon authored
Shelf animations have operations to animate bounds to and from empty rects, so I had to make some changes to BoundsAnimator. To empty dst rect is fine, modified code that BoundsAnimator uses in ui/gfx to accept calculating transforms to empty dst rect. For empty src rect, the use_transforms option will fallback to using a bounds animation. Test: manual Bug: 1051492 Change-Id: Icbed996a77a31db9d989435b6815294b1067a87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079607Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746413}
-
Alison Maher authored
Both LinkSystemColors and NewSystemColors have been stable for several months. Removing the flags as a result. http://crrev.com/c/1829645 Bug: 1015968 Change-Id: I8e4926941c634349ff47c0c9dd86ae4d0e7749ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082996Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746412}
-
Alison Maher authored
The initial value for color has recently been updated from black to CanvasText: http://crrev.com/c/2033144. As a result, forced_colors.css and svg.css no longer need to apply this style after reverting for forced colors mode. This change should have no functional effect. Bug: 970285 Change-Id: I50bcacb1ef355ef26def9fc6768aa1aa654688c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082997Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746411}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5af67a8. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" d5af67a8 "Don't compare px rounded font sizes." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If7f675dfc06f12e0203491fe9bf434e95645f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083059Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746410}
-
Eugene But authored
NTP url path may contain trailing slash ("//newtab/"). Bug: 1046231 Change-Id: I3fd313c6489d7a78e471affa86089d6a9bcae8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081239 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746409}
-
Andrew Grieve authored
The default was changed to 2, but size builds don't need the extra info. Change-Id: I8e28af952d3452334c020f8fe4d975a395dd7d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083346 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6566156b03a0..181bb9733f83 git log 6566156b03a0..181bb9733f83 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 vapier@chromium.org luci: allow bytes in payload 2020-03-03 tbegin@google.com packages: improve uprev_ebuild_from_pin unit tests 2020-03-03 vapier@chromium.org scripts: convert random standalone programs to python3 only 2020-03-03 vapier@chromium.org cros_update: allow python2 again 2020-03-03 jrosenth@chromium.org cros_set_lsb_release: change to --unibuild flag 2020-03-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-02 vapier@chromium.org service: convert most modules to python3 2020-03-02 tbegin@google.com packages: add manifest to commit for uprev_ebuild_from_pin 2020-03-02 mikenichols@chromium.org chromeos_config: Refactor to build rapid builders from chromeos_boards. 2020-03-02 yueherngl@google.com drallion: add firmware branch builder 2020-03-02 vapier@chromium.org cros cli: convert all subcommands to python3 only 2020-03-02 saklein@chromium.org api/router: Refactor protobuf internals usage. Created with: gclient setdep -r src/third_party/chromite@181bb9733f83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ib48f591036b918ae98c71eb4889606d07f2daa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083969Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746407}
-
Kuo-Hsin Yang authored
BUG=b:149833548 Change-Id: Ibcaead958fb5b56c5bedf19649be1433644837c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082664 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#746406}
-
Gang Wu authored
Bug: 977402 Change-Id: I37f6200fbfdb4d613362e7e309ba60ed34a64f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033544Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746405}
-
Rouslan Solomakhin authored
Patch #6: Remove an unnecessary layer of methods for firing the "canmakepayment" event on Android. Bug: 1005076 Change-Id: Ia943f24e2e0931b80e7e31dd347411aab57b5748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080197Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746404}
-
Tim van der Lippe authored
This has been replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2084583 Als note that this test was erronously passing, even though the functionality under test is broken. R=aerotwist@chromium.org Bug: 1003497 Change-Id: I9cbfc67607c50125ecdca27aef8d8415f0296424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083490 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746403}
-
Kush Sinha authored
This reverts commit ea6fab21. Reason for revert: AccountReconcilor has a non-predictable end-state. It can end up in failure or success states depending on race conditions. See https://crbug.com/1053905 for details. Original change's description: > Remove OAuth2LoginVerifier > > Remove OAuth2LoginVerifier and make the OAuth2LoginManager observe > AccountReconcilor instead of doing /MergeSession. > > DD: http://doc/1fACI5GQgXvmlmEJj6aPedazXeDZAZPw9jH_E91WGe3w > > Bug: 977137 > Change-Id: Iaa21dd12f0ca6568d920f135bbfdddf3f9def088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674099 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738673} TBR=xiyuan@chromium.org,droger@chromium.org,holte@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Bug: 977137, 1053905 Change-Id: I5f7a92732c367f3fa07bc9ac0a688a5c4e3b4be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081430Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#746402}
-
Zhuoyu Qian authored
This CL update the functions GetOriginsForTypeOnFileTaskRunner and GetOriginsForHostOnFileTaskRunner of FileSystemQuotaUtil to use dedicated Origin type instead of GURL. Change PluginPrivateDataDeletionHelper::CheckOriginsOnFileTaskRunner also. Bug: 598424 Change-Id: Ica53219f4f7acbf457195a7cb964b404bf7af98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074842Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746401}
-
Manuel Rego Casasnovas authored
In r745093 we fixed an issue with sticky elements with strict containment. However that introduced a performance regression in the following test: perf_tests/paint/contain-update-layer-tree.html This change applies the fix only for sticky positioned elements so the performance tests comes back to previous numbers. Change-Id: I686e2cfee13a3e44f5f67d05ed7526b6f01d4e5f Bug: 1057255,1057257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083030Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746400}
-
Maksim Ivanov authored
Change the color of the "smart card" ("chip") icon displayed in Ash Login Screen to use the value recommended by the UX designers: #E8EAED. Implementation-wise, this desired color is denoted as "GoogleGrey200". Bug: 1024254 Test: log in via a smart card and log out, take screenshot, verify that the "smart card" icon displayed under the user pod has colors #E8EAED Change-Id: I15d53810434975b80d1ee5c0fccaba18a1b8c1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085071Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746399}
-
David Bokan authored
As a result of pre-commit input suppression (see https://crbug.com/958424 for details and CLs), old expectations in the compositor that if we receive a ScrollUpdate or ScrollEnd we must have seen a ScrollBegin are no longer true. A begin might have been suppressed. Most of input handling code already early-outs and handles this case gracefully so we just remove DCHECKs here that guard this behavior. ScrollEnd must also early-out. Bug: 1041666 Change-Id: Ie3f2b523100f40f59fee121c4be43f4a6870c8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083934Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746398}
-
Gauthier Ambard authored
Tests are passing locally. Fixed: 1054372 Change-Id: I6ad38e4ea1576eef974c542e7b03dd85637f883c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074257Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746397}
-
Tim van der Lippe authored
This was replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2046553 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: Ib7b0b4ceede6a14688e3eaa8a7cd94d7dfa45d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084812Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746396}
-
Dan Harrington authored
Task now exposes Execute(OnceClosure) instead of Run(), and can be called outside of a task queue, or from within another task. This change was made so that tasks to be composed of multiple smaller, nested tasks. We plan to use this feature in components/feed/v2. An 'upload' task can be run on its own, or as an intermediate step in a 'load' task. Change-Id: Icbe64021b8fecd8abbc09c64d2d15dfab2e2708c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078786 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746395}
-
Yann Dago authored
Bug: 1033573 Change-Id: Ia481923c34fe9deb83f785582229eac8b8a7f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083601 Auto-Submit: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746394}
-
Yi Gu authored
The test fast/scroll-snap/snaps-after-keyboard-scrolling.html started to be flaky on fast path after being enabled on it in crbug.com/878878. Bug:878878, 1056957 Change-Id: I506f9a63ac10c059b7e9e30da29c36826a2d6bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084110Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746393}
-
Aaron Leventhal authored
For <table style="display:foo">, do not immediately assume it is for layout, just because there is no table layout interface. A follow-up CL will transform IsDataTable() to rely much more on DOM interfaces, rather than layout interfaces. Bug: 1011067 Change-Id: Iebb6224d311f09b1b3bf6e6aa08efbe7393b42d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079267 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#746392}
-
Nazerke authored
This CL modernizes the ContextMenuCoordinator to use |browser| in the initializer. HistoryTableViewController was also updated to use browser to get |browserState| value. Bug: 1029346, 1050693 Change-Id: I0763c2e5c2b7f34b4b2af3cf217f830018696981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083310 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746391}
-
Mugdha Lakhani authored
Bug: 1052375 Change-Id: Iead6adcf4d00aab75be10eb8c2ef3a73dfbb5492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083454Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#746390}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/189353b3..5f37cd3c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id011a3765fb2ef6c56189d447178f8459a00dd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084831Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746389}
-
Jérôme Lebel authored
SigninCoordinators should always be stopped and released at the end. This was not done when the add account coordinator is not successful. Bug introduced with: crrev.com/c/2064945 Bug: 971989 Change-Id: Idac9d4019d499eeeeab0e36a8f73828145916748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084851 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746388}
-
Yifan Luo authored
Delete both network::features::kFetchMetadata and network::features::kFetchMetadataDestination flags. Bug: 1054543 Change-Id: Iab8ecca52fe019c48dc27ced7fc832ca576fe22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084553Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#746387}
-
Fredrik Söderquist authored
It's always the ComputedStyle of the LayoutObject passed as the first argument. Bug: 1028063 Change-Id: I3f87f42ae51d5d6013b71989054e0594f55a283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083306Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746386}
-
Maksim Ivanov authored
Introduce a separate variable that allows the user of the <pin-keyboard> Polymer element to control the "letter-spacing" attribute of the input field. This fixes the flaky issue introduced in https://crrev.com/c/2069324 that was sometimes causing the "letter-spacing" attribute to be not set on <pin-keyboard>'s input at all. (Presumably, the problem was due to self-referring to the variable from its var() expression.) Bug: 1051859 Test: start SAML login using a smart card, type 8 digits in the PIN dialog, verify that all 8 dots fit into the input field but the dots aren't touching each other Change-Id: I0deb28782ddcd320bc3b6f35ddf10c1da0491233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082378 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746385}
-
Mark Cogan authored
This CL refactors the tab restoration classes for multi-window, scoping some functions to a Browser, and removing use of TabModelList. Non-functional changes: * TabRestoreDelegateImplIOS (which is the iOS implementation of the sessions::LiveTabContext API, not "TabRestoreDelegate") was a keyed service. It's renamed to LiveTabContextBrowserAgent and (accordingly) scoped to a Browser (on desktop, Browser directly implements this API. * The associated factory class is removed. * TabRestoreServiceClient is updated to use Browser and BrowserList instead of TabModel and TabModelList. * The RestoreTab() helper function is updated to take a Browser param instead of a BrowserState. FUNCTIONAL CHANGE: Previous to this CL, IOSChromeTabRestoreServiceClient's implementation of CreateLiveTabContext() simply returned the (single) BrowserState- scoped sessions::LiveTabContext implementation. Looking at the desktop implementation of this function, it appears to create a new window: https://cs.chromium.org/chromium/src/chrome/browser/sessions/chrome_tab_restore_service_client.cc?type=cs&g=0&l=35 While that might be a desirable behavior when multi-window is supported, we don't yet have a set of hooks available to do that cleanly; nor do we want to instead return some arbitrary, already-opened window. It looks like the call sites for this (in TabRestoreServiceHelper) are: - When restoring a session by ID with the WINDOW type, and - When restoring a tab without a provided context or with the NEW_WINDOW disposition. ios/ doesn't currently have code paths that do either of these, and this CL adds a check in the RestoreTab helper to guard against them. Then, the implementation of CreateLiveTabContext() now is a NOTREACHED() no-op. crbug.com/1056596 tracks adding support for window restoration with multi-window. Bug: 1056208 Change-Id: Ib51ea7ea6efd3a51e6ec07d031e1a3ae1203579b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078915 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746384}
-
Xi Han authored
CachedFeatureFlag values are set by @Features.EnableFeatures and @Features.DisableFeatures after this CL. Bug: 1056327 Change-Id: Ie4bbc9f21908ef3f7e9336c7d558165a54837381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075972 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746383}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/56364b6b6026..bbbd9a2a1f41 git log 56364b6b6026..bbbd9a2a1f41 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 cepheus@frii.com Fix #1843: Handle built-in function output parameters to a swizzled arg Created with: gclient setdep -r src/third_party/glslang/src@bbbd9a2a1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I79a75d05ef8e8faf7bae1a2584130517ddf9e3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746382}
-
Anna Malova authored
Bug: 1007815 Change-Id: I1cf38ed3882ae5c01690cd18e706deffef7e91c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083485Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746381}
-
Ian Clelland authored
This affects the parsing and serialization of tokens in structured headers draft 15 and above. When operating in Draft 9 mode for backwards compatibility, a character sequence beginning with an asterisk will be parsed as a byte sequence instead. Bug: 1048756 Change-Id: I5b1e2a57501a2e2dedb1183f495f71d75146c46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084711Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#746380}
-
Anna Malova authored
Bug: 1007815 Change-Id: I72241731610b566ca062ff95f8fd94289999b3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083327Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746379}
-