Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jan, 2018 37 commits
  3. 27 Jan, 2018 3 commits
    • Nico Weber's avatar
      Work more on getting things built with -Wimplicit-fallthrough. · 88cb4047
      Nico Weber authored 
      This CL was uploaded by git cl split.

R=eae@chromium.org

Bug: 177475
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I3a861bf5eb39da51b628eafae99d0bff3ebfab39
Reviewed-on: https://chromium-review.googlesource.com/889728Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532255}
      88cb4047
    • Vaclav Brozek's avatar
      [Android password settings] Separate timer for export · 2ed20c91
      Vaclav Brozek authored 
      The user needs to reauthenticate both to view/copy and to export
passwords. Once reauthenticated, the authentication is skipped for the
next 60 seconds.

Through authentication, the user grants an easy access to anybody
holding their device in the next 60 seconds to the passwords on their
device.

The explanation message of the reauth prompt includes the scope of the
approval (e.g., "to view your passwords" or "to export your
passwords") of the _first_ reason to reauthenticate.

To protect the privacy of the user, if they grant the access for a
one-at-a-time access (e.g., viewing passwords) but then a bulk access
(e.g., export of all passwords) is requested within the grace period
of 60 seconds, Chrome ignores the grace period and requests the reauth
again.

Bug: 800686
Change-Id: Icc96bf490b13ba7ba172bc88fdef0ffdefaf97f2
Reviewed-on: https://chromium-review.googlesource.com/883525
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: default avatarBernhard Bauer <bauerb@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532254}
      2ed20c91
    • Scott Violet's avatar
      Changes ordering so that ConfigurationPolicyProviders are set earlier · 615e458c
      Scott Violet authored 
      Specifically this converts back to setting the
ConfigurationPolicyProviders *before* the PolicyService is created.

There is a subtle difference between this code and the way the
code was before my patch. Specifically previously the code did
the following:

1. ChromeBrowserPolicyConnector created, which added a bunch of providers
   from constructor.
2. BrowserPolicyConnectorBase::GetPolicyService is called, which creates
   the service and pushes the providers to the PolicyServiceImpl
3. local state/field-trials created.
4. BrowserPolicyConnector::InitInternal was called, which in turn
   called Init() on the providers.

With this patch, order is now:

1. ChromeBrowserPolicyConnector constructor does very little
2. ChromeBrowserPolicyConnector::InitPolicyProviders is called, which
   creates the providers.
3. BrowserPolicyConnectorBase::SetPolicyProviders is called, which
   creates the PolicyService and calls Init() on all the providers and
   sets is_initialized_.
4. BrowserPolicyConnectorBase::GetPolicyService is called, creating
   the PolicyService.
5. local state/field-trials created.
6. BrowserPolicyConnector::InitInternal is called.

Key differences:
. ConfigurationPolicyProvider::Init() is called earlier.
. Had to remove DCHECK in BrowserPolicyConnector::InitInternal() because
  SetProviders sets is_initialized_.


BUG=806538
TEST=none

Change-Id: I0981419cb1734208789639cc1713e49ac8e901c7
Reviewed-on: https://chromium-review.googlesource.com/889500
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532253}
      615e458c