- 18 Aug, 2018 40 commits
-
-
Alex Clarke authored
This reverts commit 6410ee3d. Reason for revert: This is causing some crashes. Original change's description: > Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue > > Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792 > > Our usage pattern is unfortunate for existing queues such as > base::circular_deque. We tend to fill up an empty queue and then drain all > those tasks until it's empty. This means the queue yo-yos in size which > confuses the memory reclamation schemes of most queues. > > As an optimisation we introduce a deque specialised for TaskQueueManager's > usage patterns. For performance (memory allocation isn't free) we don't > automatically reclaim memory when the queue becomes empty. Instead we rely > on the surrounding code periodically calling MaybeShrinkQueue, ideally when > the queue is empty. > > We keep track of the maximum recent queue size and rate limit > how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary > churn. > > This yields a nice win on our microbenchmark: > > Patch: us/run for 10000 delayed tasks with N queues > 1 queue 4 queues 8 queues 32 queues > 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 > 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 > 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 > 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 > 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 > 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 > 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 > 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 > 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 > 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 > Average 35812.1871 35430.24471 35636.02188 36204.63076 > > ToT: us/run for 10000 delayed tasks with N queues > 1 queue 4 queues 8 queues 32 queues > 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 > 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 > 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 > 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 > 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 > 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 > 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 > 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 > 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 > 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 > Average 37942.951 37481.78685 36983.47337 36634.15632 > > Percentage improvement > 5.61570422 5.473437399 3.643388159 1.172472933 > > NB the reason the improvement goes down with the number of queues is because > we're saving malloc overhead in the queue, but a constant number of tasks are > posted across N queues. This means the more queues we have in this test, the > less loaded the queues are individually. > > Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4 > Reviewed-on: https://chromium-review.googlesource.com/1169043 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582586} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id8290646dba1dcea9fcf92d490b9ce4ac63ae702 Reviewed-on: https://chromium-review.googlesource.com/1177561Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584314}
-
Nico Weber authored
LayerTreeHostBlendingPixelTest.BlendingWith* still timeout on win/asan after the switch to swiftshader, so bump up the timeout even more. Bug: 875223 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I30eb5e3717ed7c5f55a478b8e2e1323c8e59d974 Reviewed-on: https://chromium-review.googlesource.com/1180282Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584313}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d18d79130163..5cc10c8cd6db git log d18d79130163..5cc10c8cd6db --date=short --no-merges --format='%ad %ae %s' 2018-08-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 43a2762db19a..5055fba5692f (3 commits) Created with: gclient setdep -r src/third_party/skia@5cc10c8cd6db The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ibe9b01f470991e072fe9b5bdfe649664483f6e58 Reviewed-on: https://chromium-review.googlesource.com/1180450Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584312}
-
Roger McFarlane authored
The current implementation uses a vector to store all the forms that we parse. The code to find cached forms the searches that vector starting from the back. This CL changes the cache to a map instead, so each form will be saved only once. The key is the FormSignature and the value is a unique ptr to the FormStructure. Notable differences - AutofillHandler now holds a map, by form signature, of FormStructure unique_ptrs instead of a vector. - Parsing/updating FormData associated with a given signature now delete any previously cached FormStructure for that signature. - form_structure_browsertests sorts currently known form structures by their earliest parse time, to preserve the output ordering. - AutofillHandler::FindCachedForm To update an existing form signature, this function is O(lg n). when inserting a new form signaure this function is O(n + log n). Bug: 769617, 864469, 864503, 865640, 866504 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I630336d6672a57acbe0257501c44f540b39341de Reviewed-on: https://chromium-review.googlesource.com/1175456 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584311}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I9e73cac82282e6db8425fea7c990e559d860129a Reviewed-on: https://chromium-review.googlesource.com/1180616Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584310}
-
Zhiqiang Zhang authored
Previously we made CastMessage & CastSessionImpl (now CastSessionController) lifecycle bound to per connection, which makes the session management over-complicated. This CL makes those classes having the same lifecycle as CafBaseMRP/CafMRP, so there's no need to create/set/unset instances any more. These instances will only be active when there's currently an active session. Bug: 711860 Change-Id: I1736bb7085cd1ffbffed8ec40f3410ebe997e64e Reviewed-on: https://chromium-review.googlesource.com/1171582Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584309}
-
Christopher Cameron authored
The methods NativeWidgetMac::GetWindowBoundsInScreen, GetClientAreaBoundsInScreen, and GetWorkAreaBoundsInScreen compute their results by querying the underlying NSWindow. When the NSWindow is a separate process, this won't be an option. Instead, have the BridgedNativeWidget push these properties to the BridgetNativeWidgetHost, from which the NativeWidgetMac may query them. Also have the BridgedNativeWidget (in the app shim process) query the display::Display for its NSWindow and send that to the BridgetNativeWidgetHost (in the browser process). This can then be used to update the device scale factor, vsync, and color space properties of the compositor (at present these properties updated only by attached RenderWidgetHostViewMacs). Rename BridgedNativeWidgetHost::SetSize to SetViewSize, to indicate that it is computed differently. Remove BridgedNativeWidgetHost::SetCompositorSize as its functionality can be rolled into the new function. Bug: 859152 Change-Id: If00184c31f9c493ece4ea08ace11d0be3a866786 Reviewed-on: https://chromium-review.googlesource.com/1175428 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584308}
-
Gang Wu authored
Implement Journal storage API in java Bug:875438 Change-Id: Iaaede743f66182c3bec7ffc945c37fc9204c1475 Reviewed-on: https://chromium-review.googlesource.com/1179252 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#584307}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/11378953830a..d18d79130163 git log 11378953830a..d18d79130163 --date=short --no-merges --format='%ad %ae %s' 2018-08-18 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 80ab360d2622..94d4660dd3f1 (1 commits) 2018-08-18 kjlubick@google.com [PathKit] Add more correctness tests to gold 2018-08-18 mtklein@google.com refactor cpu configs Created with: gclient setdep -r src/third_party/skia@d18d79130163 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I55794e67b77596ea74e79b97dc42cb7af26b59a6 Reviewed-on: https://chromium-review.googlesource.com/1180448Reviewed-by:
-
Michael Giuffrida authored
The Highlights app is part of Chrome OS Demo Mode. It will use chrom.metricsPrivate.getIsCrashReportingEnabled() to enable/disable Google Analytics reporting, similar to other Chrome apps. There are 2 versions of this app, thus 2 entries. Bug: 819404 Change-Id: I023880eac23c332afe1fb80942c7d9f737cb369d Reviewed-on: https://chromium-review.googlesource.com/1179370Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584305}
-
Ben Wells authored
Bookmark apps that are not locally installed will not be treated as installed for the installation banner checks. In the future more changes to their behaviour, in relation to the chrome://apps page will be introduced. Bug: 874841 Change-Id: I48741967a646c6aac95cde3c832b8c8860b4f7b1 Reviewed-on: https://chromium-review.googlesource.com/1177529 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#584304}
-
Siddhartha authored
The startup category in background tracing is not useful to trigger with a histogram since it has to start early at startup for getting useful information. The startup category will set a flag in app preferences and start tracing next time chrome starts and upload a report. We can keep having session consistency for the trials, with startup traces being uploaded one session after the config was seen. BUG=859260 Change-Id: I588cb5ebd21e96abe9230718f69775d271f827f5 Reviewed-on: https://chromium-review.googlesource.com/1155996 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#584303}
-
Jun Choi authored
Currently, FidoBleDiscoveryBase returns when ble adapter is not present. This is problematic as the embedder layer explicitly waits for NotifyDiscoveryStarted() to be invoked prior to launching UI. Make sure to call NotifyDiscoveryStarted(false) when Bluetooth adapter is not present. Bug: 847985 Change-Id: I968e2ff5f1408b7a5a56eb94b25240b8705b1c68 Reviewed-on: https://chromium-review.googlesource.com/1176977Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584302}
-
gogerald authored
Change-Id: Iaea43229f0fc400cc6f4c0f2415e59a60748d224 Reviewed-on: https://chromium-review.googlesource.com/1180606 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584301}
-
chrome://tracingNasko Oskov authored
This CL adds logging to chrome://tracing when a SiteInstance is locked to an origin and increases the details logged at navigation commit time. It should allow us to more easily diagonse issues with origin locks on renderer processes. Change-Id: If0ff66bf8cc8373781b2bf15d11221caae6c5689 Reviewed-on: https://chromium-review.googlesource.com/1179256 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#584300}
-
Alexei Filippov authored
BUG=874116 Change-Id: I8384cebe03348556df733ee8098500eab6352188 Reviewed-on: https://chromium-review.googlesource.com/1180515 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584299}
-
Wez authored
This test base instantiates a content::ChildProcess to provide the expected environment for the code-under-test. ChildProcess expects to either run in the context of ScopedTaskEnvironment, in tests, or to need to initialize the TaskScheduler itself. Add a ScopedTaskEnvironment to the test base, otherwise the ChildProcess TaskScheduler will "leak" and break later tests. Re-enables the RTCVideoDecoderAdapterTest tests, that had been broken by this issue. TBR=hbos Bug: 875278, 875301, 875336 Change-Id: I8a7ee1f42e62241d48720c41897bdcadbcd26bdf Reviewed-on: https://chromium-review.googlesource.com/1180408 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#584298}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I16a59ca14cb06692cf1b0d9ef78aa8c5f314e682 Reviewed-on: https://chromium-review.googlesource.com/1180548Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#584297}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff6a73cc08af..11378953830a git log ff6a73cc08af..11378953830a --date=short --no-merges --format='%ad %ae %s' 2018-08-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@11378953830a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: If4cf9ea9e2f5626090a708eb269acecea72a7113 Reviewed-on: https://chromium-review.googlesource.com/1180446Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/458c654bff0a..5055fba5692f git log 458c654bff0a..5055fba5692f --date=short --no-merges --format='%ad %ae %s' 2018-08-17 jie.a.chen@intel.com Optimize Program::resolveLink Created with: gclient setdep -r src/third_party/angle@5055fba5692f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I9c8cf5bcb14f82705ac2d7158a0dfc7642bb594c Reviewed-on: https://chromium-review.googlesource.com/1180447Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584295}
-
Alexei Filippov authored
BUG=874116 Change-Id: I84a4f31223ee6d365e06c2f14a29dff40583ecd1 Reviewed-on: https://chromium-review.googlesource.com/1180536 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Andrey Lushnikov authored
Scripts added by addScriptToEvaluateOnLoad used to be evaluated in the order of their addition. This was regressed recently with https://crrev.com/578514. R=caseq, pfeldman Change-Id: Ieabd67aca497fab8eaff749fea0877d93c54deae Reviewed-on: https://chromium-review.googlesource.com/1180585Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#584293}
-
rbpotter authored
These two print ticket settings are not included in the histogram currently. Bug: None Change-Id: I5d7400c1b953d62ac52d4714b4f5e322cab09abf Reviewed-on: https://chromium-review.googlesource.com/1180512 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584292}
-
Xida Chen authored
This CL changes the variable name only, should not introduce any behavior change. TBR=alexmos@chromium.org Bug: None Change-Id: I0e249eb585bc8e2953bef51f93995eab18d73937 Reviewed-on: https://chromium-review.googlesource.com/1176272Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584291}
-
yiyix authored
FrameSinkElement implements FrameSinkObserver interface and handles all the events for updating the tree. Bug: 816802 Change-Id: I6552281672cda18f611c65971aa56eea7aa13a00 Reviewed-on: https://chromium-review.googlesource.com/1113018 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#584290}
-
Robbie McElrath authored
This migrates GoogleUrlTracker to use NetworkConnectionTracker instead of NetworkChangeNotifier so it will work with the network service enabled. Bug: 868018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8231dc6df2456ae6a0908b49e4626364158ba81 Reviewed-on: https://chromium-review.googlesource.com/1175486 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#584289}
-
Martin Kreichgauer authored
Currently, |AuthenticatorImpl| is binding |CreatePlatformAuthenticatorIfAvailable| with |base::Unretained| for the |MaybeAddPlatformAuthenticatorCallback| argument to the |FidoRequestHandlerBase| ctor. The callback was originally invoked synchronously from the ctor, but then recently changed to async invocation to account for observer registration (crrev.com/c/1175418). This is a potential callback lifetime issue because the AuthenticatorImpl and its request handler can now theoretically get destroyed before the callback gets invoked. To work around this issue, replace the callback with a method on the request handler invoked by the AuthenticatorImpl. Bug: 875338 Change-Id: I089f0783a46791ae8d9d6bac5f0e663e52075b86 Reviewed-on: https://chromium-review.googlesource.com/1179081 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584288}
-
Shu Chen authored
Bug: 756059 Change-Id: Ieeea588c60e51a95cf89f86ee13cc77b2eba3883 Reviewed-on: https://chromium-review.googlesource.com/1179114 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584287}
-
Eric Karl authored
Currently we limit GPU Image Decode Cache working set by bytes, but this allows the cache to be filled with thousands of working set entries if sufficiently small. This ends up causing negative performance and memory spikes vs flushing more regularly. This change adds a 256 item limit to the GPU IDC working set, avoiding the worst of these issues. Bug: 870455 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0e6f27d3cb070ea3c29940ce9aad61224a3120cf Reviewed-on: https://chromium-review.googlesource.com/1179378 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#584286}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f04be3a84fdd..8859c10c2823 Created with: gclient setdep -r src-internal@8859c10c2823 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/111505878,chromium:875451 TBR=mmoss@chromium.org Change-Id: I93decaefac616f72ed9939b27b5bfc86056001ef Reviewed-on: https://chromium-review.googlesource.com/1180441Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584285}
-
Tom Anderson authored
This reland includes a patch that fixes the AFL build with CFLAGS="-std=c11 -D_GNU_SOURCE". BUG=427584 TBR=thakis,sbc Change-Id: I9c3c52f4898a9ae1efc377802671ac44b79e9381 Reviewed-on: https://chromium-review.googlesource.com/1180170 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584284}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7de5f08c459c..dd765da4dff7 git log 7de5f08c459c..dd765da4dff7 --date=short --no-merges --format='%ad %ae %s' 2018-08-18 bpastene@chromium.org depot_tools: Add header doc w/ a warning to cipd recipe_module. Created with: gclient setdep -r src/third_party/depot_tools@dd765da4dff7 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iad1fe0ce965a4c57363b09c6d5c01c73ccbe3a14 Reviewed-on: https://chromium-review.googlesource.com/1180444Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584283}
-
Sidney San Martín authored
In 3bd1f5ed, I renamed the histograms right before commit, and I forgot to rename them in some places. Whoops. TBR=rkaplow Bug: 871801 Change-Id: Iff576c3d9c06878b4f2f60c6fb6557b16e915d1c Reviewed-on: https://chromium-review.googlesource.com/1180293Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584282}
-
Alexei Filippov authored
Use indexed colors for bar vertices. It makes color arrays 4 times smaller. BUG=874116 Change-Id: Icad75d28357af2a62bd3ff8025a12e6fec82d64a Reviewed-on: https://chromium-review.googlesource.com/1180276 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Katie D authored
Warnings occur when loading the manifest or using a chrome.tts or chrome.ttsEngine Javascript API with VocieGender. Does not actually deprecate gender, but makes sure it is optional. BUG=863999,863998 Change-Id: If850e4374cb871289af0102da18040b49f100ae7 Reviewed-on: https://chromium-review.googlesource.com/1176354 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584280}
-
rajendrant authored
This reverts commit 7c08a1a3. Reason for revert: Formatting issues Original change's description: > Split placeholder image load checks and enables > > Refactor the MaybeAllowImagePlaceholder() and MaybeAllowLazyLoadingImage() > functions to checks and enable the placeholder request bit separately. > > This will help with lazyloading of CSS background images. > > Bug: 846170 > Change-Id: I07dd50db59287c290ff0a7f0cc726dc23ed882e8 > Reviewed-on: https://chromium-review.googlesource.com/1178637 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#584252} TBR=fs@opera.com,japhet@chromium.org,sclittle@chromium.org,rajendrant@chromium.org Change-Id: Ic71a202d73e4cdb4154e55e04e12faca70d19ba7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846170 Reviewed-on: https://chromium-review.googlesource.com/1179354Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#584279}
-
David Black authored
Previously, we failed this DCHECK: https://cs.chromium.org/chromium/src/ui/views/controls/styled_label.cc?dr=CSs&q=styled_label&g=0&l=156 This occurred when we had an empty query string. Bug: b:112773506 Change-Id: I12f2418a7c0a058fe52ffff6c3507c844c607276 Reviewed-on: https://chromium-review.googlesource.com/1180523 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584278}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a9d56105a725..032b3bed2b18 git log a9d56105a725..032b3bed2b18 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 thestig@chromium.org Ger rid of some #defines in Android font code. 2018-08-17 thestig@chromium.org Get rid of CFPF_SkiaFont::InitFont(). 2018-08-17 thestig@chromium.org Encapsulate CFPF_SkiaPathFont members. Created with: gclient setdep -r src/third_party/pdfium@032b3bed2b18 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icd0ab990b04d773b54b37d931ec94321121397dc Reviewed-on: https://chromium-review.googlesource.com/1180445Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584277}
-
Stephan Stross authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I5768d75a7675041750f71cb824c6919c73896d67 Reviewed-on: https://chromium-review.googlesource.com/1180507Reviewed-by:
-
Eliot Courtney authored
didn't get stuck on the edge. Bug: b/112572556 Test: exo_unittests and tried swipe-to-dismiss on a PIP window and it Change-Id: I02626a004c6e2dfc7c64f077d77bea8edaa150c1 Reviewed-on: https://chromium-review.googlesource.com/1175748Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#584275}
-
