GitLab

ATTN Sheriffs: There is good probability that that this patch may have unintended side effects. For example there may be some JS tests that use setTimeout(...0) and hope that layout will occur.  With this patch that's much less likely to be the case and is actually a bug in the test.  I tried to fix some of those here https://codereview.chromium.org/644093003/

Another possibility is that something using setInterval(... 0) may suddenly show a perf regression due to running much more frequently.

BUG=402694

Review URL: https://codereview.chromium.org/467153003

git-svn-id: svn://svn.chromium.org/blink/trunk@185372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is possible now that Service Worker's ExtendableEvent
has been made constructable.

Specification:
  https://notifications.spec.whatwg.org/#service-worker-api


BUG=432527

Review URL: https://codereview.chromium.org/716143003

git-svn-id: svn://svn.chromium.org/blink/trunk@185371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removes functions which take ScriptWrappableBase as an argument
in DOMDataStore, V8Wrapper, and V8Binding.

ScriptWrappableBase is still used as the internal pointer in a
wrapper, and it's used to support NPObject.

BUG=235436

Review URL: https://codereview.chromium.org/721383003

git-svn-id: svn://svn.chromium.org/blink/trunk@185370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to avoid memory bloat due to m_validatedURLs.

BUG=52411

Review URL: https://codereview.chromium.org/723423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/720223002

git-svn-id: svn://svn.chromium.org/blink/trunk@185368 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/r2aARnIHG4k/mGAsu9RGKSMJ

BUG=429536

Review URL: https://codereview.chromium.org/693353002

git-svn-id: svn://svn.chromium.org/blink/trunk@185367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow it to be called with startIndex that is greater than info.Length().
This will happen from the generated code for a method such as

  void f(long x, optional long y = 0, long... rest);

when called with a single argument.

Also a minor improvement: reserve a tighter initial capacity for the
result vector. Capacity used to be reserved for storing all arguments,
disregarding the startIndex value.

Review URL: https://codereview.chromium.org/732483002

git-svn-id: svn://svn.chromium.org/blink/trunk@185366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This brings the events in line with the Service Worker specification.

This allows us to implement events deriving from ExtendableEvent
(most notably Push, NotificationClick and NotificationError) according
to their specifications as well.

BUG=420896

Review URL: https://codereview.chromium.org/715013003

git-svn-id: svn://svn.chromium.org/blink/trunk@185365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

xmlhttprequest-responseXML-nopartial used resources/small-chunks.cgi that takes
5 seconds to complete and it led to flaky timeout. Let's use a usual response.

BUG=432784
R=kouhei

Review URL: https://codereview.chromium.org/731443002

git-svn-id: svn://svn.chromium.org/blink/trunk@185364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=427954
R=yurys, pfeldman

Review URL: https://codereview.chromium.org/693183002

git-svn-id: svn://svn.chromium.org/blink/trunk@185363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On StepInto we should not show "Paused on Event Listener".
The corresponding breakpoint may not even be active, so this status looks quite confusing.

BUG=432468
R=vsevik, yurys

Review URL: https://codereview.chromium.org/723543002

git-svn-id: svn://svn.chromium.org/blink/trunk@185362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/727703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Nobody uses the forConstructor().
- m_interfaceName and m_methodName are passed, but nobody uses them.

BUG=433174

Review URL: https://codereview.chromium.org/724183004

git-svn-id: svn://svn.chromium.org/blink/trunk@185360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If you have a "foo| ", WebLocalFrameImpl::selectWordAroundPosition
 selects space after the caret.
This is from the Selection::expandUsingGranularity behavior.
It is used widely including double-click word selection on desktop.
Thus we can not change the behavior.

I changed the implementation to use VisibleUnit functions directly.
New implementation is that we try to find a word on right side and left side.
In addition, move implement from WebLocalFrameImpl to FrameSelection.

BUG=397696

Review URL: https://codereview.chromium.org/675413003

git-svn-id: svn://svn.chromium.org/blink/trunk@185359 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: Split NetworkPanel.js (patchset #5 id:80001 of https://codereview.chromium.org/722683003/)

Reason for revert:
Don't overwrite files.

Original issue's description:
> DevTools: Split NetworkPanel.js
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185306

TBR=vsevik@chromium.org,apavlov@chromium.org,eustas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/730463002

git-svn-id: svn://svn.chromium.org/blink/trunk@185358 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/51#issuecomment-51172079

BUG=432827

Review URL: https://codereview.chromium.org/731433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432907
TBR=pfeldman

Review URL: https://codereview.chromium.org/723903004

git-svn-id: svn://svn.chromium.org/blink/trunk@185356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we calculate allocationSizeFromSize twice in Heap::allocate()
and Heap::outOfLineAllocate(). This CL removes the redundancy.

BUG=420515

Review URL: https://codereview.chromium.org/730443002

git-svn-id: svn://svn.chromium.org/blink/trunk@185355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow all selectors to update invalidation sets using updateInvalidationSets
and never fall back to a separate wholeSubtree loop in
collectFeaturesFromSelector. The method for finding the InvalidationSetMode
is dropped completely.

With this change we are now at a point were a whole subtree invalidation is
only necessary for these cases:

1. There are no recognized features in the rightmost compound selector

 - A universal selector: ".a *"
 - Only contains pseudo classes or elements that are not considered
   features:

   ".a ::before", ".a :first-child", etc.

2. The invalidation set component is immediately left of an adjacent
   combinator:

   ".a + .b", ".a ~ .b"

3. The selector has a ::first-letter or ::first-line pseudo

   These are currently depending on style recalc or layout below the
   element they are pseudo elements for.

3. There is a :host-context() in the rightmost compound selector

   :host-context sub-selectors match ascendants of the :host element for
   which we are resolving style, so ":host-context(.a)" is effectively the
   same as ".a :host" which falls under no recognized features in the
   rightmost compound in point 1.

Points 1, 3, and 4 are now handled through
InvalidationSetFeatures::forceSubtree set as a result of feature extraction.
Point 2 is handled by updating InvalidationSetFeatures::adjacent as we
progress past selector combinators.

RuleFeaturesSet::collectFeaturesFromSelector is now back to how it was
before we introduced invalidation sets (without the feature hash sets).
Now, it only counts adjacent combinators and sets a flag when finding
::first-line, so it is possible to squash it into the same method as
updateInvalidationSets() to have a single pass over the selector when
finding rule features (if we want to do that).

The lowered expected node count in the :host-context test is due to the
fact that we only fall back to subtree invalidation when present in the
rightmost compound. ::first-letter/::first-line are always in the rightmost
compound, and :host-context() doesn't need subtree invalidation when in
other compounds. ":host-context(.a) .b" is effectively ".a :host .b".

R=chrishtr@chromium.org
BUG=335247

Review URL: https://codereview.chromium.org/726503003

git-svn-id: svn://svn.chromium.org/blink/trunk@185354 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is unused.

BUG=420515

Review URL: https://codereview.chromium.org/728753002

git-svn-id: svn://svn.chromium.org/blink/trunk@185353 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/717393004

git-svn-id: svn://svn.chromium.org/blink/trunk@185352 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to demonstrate the requestor wants to receive the body stream as a
byte stream, this CL adds a flag in WebURLRequest and ResourceRequest.

BUG=418879

Review URL: https://codereview.chromium.org/700663004

git-svn-id: svn://svn.chromium.org/blink/trunk@185351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the current implementation, when Vector::reserveCapacity expands its backing storage,
we always reallocate the backing storage (i.e., allocate a new storage -> memmove the storage
-> deallocate the old storage).

In this CL, we reallocate the backing storage only when necessary. If we can expand the tail
of the backing storage to the new capacity, we just expand the storage instead of reallocating
the storage.

This optimization works well for the following code:

  HeapVector<X> vec;
  for (...) {
    X* x = new X();  // Note that X is allocated in a different heap than the collection backing heap.
    vec.append(x);  // If this calls Vector::reserveCapacity, we can expand the backing storage without reallocation.
  }

but doesn't work for the following code:

  HeapVector<X> vec;
  HeapVector<X> vec2;
  for (...) {
    X* x = new X();
    X* x2 = new X();
    vec.append(x);  // If this calls Vector::reserveCapacity, we have to reallocate the storage.
    vec2.append(x2);  // If this calls Vector::reserveCapacity, we have to reallocate the storage.
  }

This significantly improves a lot of benchmarks:

parser.query-selector-*: 20 - 50%
parser.html-parser: 5%
parser.xml-parser: 11%
shadow_dom.ShadowReprojection: 6%


BUG=420515

Review URL: https://codereview.chromium.org/720163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Split Writer, Reader, Serializer and Deserializer off from SerializedScriptValue.cpp.

The goal is https://codereview.chromium.org/718383003/

BUG=358074

Review URL: https://codereview.chromium.org/721133002

git-svn-id: svn://svn.chromium.org/blink/trunk@185349 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously WTF::bind() returns |Function|, but this causes implicit temporary objects and copies of |Function|, resulting potential thread-safe issues.
This CL changes the return type of WTF::bind() to |OwnPtr<Function>|, thus removing such temporary objects and making the ownership of |Function| explicit.

- Change the return type of WTF::bind().
- Replace |const Function&| in parameter with |PassOwnPtr<Function>|.
- Replace |Function| with |OwnPtr<Function>|.
- Add |.release()| and replace |f()| with |(*f)()|.
- Other types of changes are in |callOnMainThread| and NetworkStateNotifierTest.cpp.
(|Function| appears in typedef'ed names such as Closure.)

Also this CL makes |FunctionBase| non-copyable to prevent unintended copies of |Function|.

BUG=390851

Review URL: https://codereview.chromium.org/705003002

git-svn-id: svn://svn.chromium.org/blink/trunk@185348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix a problem where a control's willValidate change wouldn't trigger the containing form's or fieldset's style change. Cache form validity while at it to avoid style recalculation

BUG=360466
TEST=Added cases to layout tests that toggle controls disabled and readonly in form and fieldset

Review URL: https://codereview.chromium.org/703473003

git-svn-id: svn://svn.chromium.org/blink/trunk@185347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes SVGAnimatedProperty and its subclasses inherit from ScriptWrappable.
This change increases the size of SVGAnimatedProperty and its subclasses
by 8 bytes (on 64-bit env).

BUG=235436

Review URL: https://codereview.chromium.org/720113003

git-svn-id: svn://svn.chromium.org/blink/trunk@185346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=433146
TBR=bokan@chromium.org, senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/723413002

git-svn-id: svn://svn.chromium.org/blink/trunk@185345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have three specialized getWithUndefinedOrNullCheck(), but we don't
need them, as DictionaryHelper::getWithUndefinedOrNullCheck() template
does the job.

Review URL: https://codereview.chromium.org/725023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This unintuitively caused drags to end immediately if a page called
setDragImage with a detached node or one that hadn't been through layout
yet. There's nothing in the spec that says the drags should abort in
this case either, so this makes Blink more spec-conformant.

BUG=413795

Review URL: https://codereview.chromium.org/724663002

git-svn-id: svn://svn.chromium.org/blink/trunk@185343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/719253002, Skia disables LCD text
for non-opaque save-layers automatically.

Also remove a couple of single-use getters.

R=reed@google.com,jbroman@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/724063004

git-svn-id: svn://svn.chromium.org/blink/trunk@185342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates the clip recorder and clip items to track a
RenderLayerModelObject (a subclass of RenderObject) so invalidations
are properly handled in the update algorithm just like regular
DisplayItems. Clipper callsites have been updated accordingly.

With this patch, the ASSERT in ViewDisplayList::findDisplayItem can
now be removed.

TEST=ViewDisplayListTest_UpdateClip

Review URL: https://codereview.chromium.org/719353004

git-svn-id: svn://svn.chromium.org/blink/trunk@185341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The error message should explain what types are expected.

BUG=240176

Review URL: https://codereview.chromium.org/726793002

git-svn-id: svn://svn.chromium.org/blink/trunk@185340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=inspector/layers/layer-canvas-log.html

BUG=430557
TBR=senorblanco@chromium.org, caseq@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/727663002

git-svn-id: svn://svn.chromium.org/blink/trunk@185339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Flakyness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/dom/Geolocation/error-clear-watch.html

BUG=373430
TBR=mvanouwerkerk@chromium.org, senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/722383002

git-svn-id: svn://svn.chromium.org/blink/trunk@185338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EventHandler maintains a ton of state, and making sure everything is in
sync gets rather complicated. m_didStartDrag was only used as by gesture
code, to detect if it should fall back to default handling.

This patch changes handleDrag()'s CheckDragHysteresis parameter to
DragIniator, which more accurately reflects how it's used. The updated
parameter is also used to determine when default handling is needed,
eliminating the need for the m_didStartDrag bool. Yay!

BUG=none

Review URL: https://codereview.chromium.org/720693003

git-svn-id: svn://svn.chromium.org/blink/trunk@185337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402536

Review URL: https://codereview.chromium.org/723943002

git-svn-id: svn://svn.chromium.org/blink/trunk@185336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because this build time flag is only used for debugging purpose,
rename it to DEBUG_TEXT_AUTOSIZING_ON_DESKTOP.

Review URL: https://codereview.chromium.org/720203002

git-svn-id: svn://svn.chromium.org/blink/trunk@185335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing
Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions

================

Originally this was a 3-way patch since it involves API change in WebFrameClient.h. After the chrome side impl was committed (step 1), we found that it is better to pass struct instead of long list of params. So this turns out to be a 5-way patch.

Here are the 5 steps:
1. Chrome side - save the data (https://codereview.chromium.org/652283002/).
2. Blink side - getting the data and introduce struct WebTransitionElementData, but still using long list of params (https://codereview.chromium.org/654953002/).
3. Chrome side - implement the API with WebTransitionElementData (https://codereview.chromium.org/679813003/).
4. Blink side - remove old APIs that use long list of params and start to use new API with WebTransitionElementData (this CL).
5. Chrome side - remove redundent implmentations of the old APIs (https://codereview.chromium.org/728653003/).

BUG=370696

Review URL: https://codereview.chromium.org/721973002

git-svn-id: svn://svn.chromium.org/blink/trunk@185334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Animations are shown for the selected element making it difficult to
find and navigate between animations. This change introduces a persisted
checkbox setting to show all animations for the selected node's DOM tree.
When hovering on an animation section title the animating element on the
page is now highlighted. Clicking on the title to expand/collapse an
animation section is also enabled. The subtree setting is turned on by
default. This change is behind the Animation Inspection experiment.

BUG=419269

Review URL: https://codereview.chromium.org/682423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185333 bbb929c8-8fbe-4397-9dbb-9b2b20218538