- 27 Mar, 2019 40 commits
-
-
Yashar Dabiran authored
This CL is part of the changes needed for this design doc: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q This CL provides a way to define feature policy features in a declarative way inside "feature_policy_features.json5" which generates the required code needed by the parser. The parser does not use the generated functions yet (it will be done in an upcoming CL). A few features are added to "feature_policy_features.json5" to manually test the generated code. Once all features are defined in the .json5 file and the parser uses the helper functions, the code will be tested against all existing tests for feature policy features. Bug: 934491 Change-Id: I44e5a919f1dbc0d6a5abae327f68ba3c90abb5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534290 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#644818}
-
Nektarios Paisios authored
This currently doesn't work. Any help appreciated. 1. Modifying the selection by moving forward to the end of the current line works. I verified by using the same HTML in Chrome. 2. The affinity of the DOM selection is not set to upstream as it should have been. 3. As expected, the affinity of the AXSelection is also not set to upstream. 4. The width of the first line is not 15 characters, even though the width in the style rule is set to "15ch" and the font is a monospace one. R=dmazzoni@chromium.org, yosin@chromium.org Bug: 639340 Change-Id: I6b7254107c5f7ca96bf6bd38fe55e6824d05e614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536752 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644817}
-
Tien Mai authored
Bug: 942539 Change-Id: I3b7226c5193a47664683b630300ac917df81d07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525989Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#644816}
-
Moe Ahmadi authored
This is a reland of e09772fe The original CL was reverted because testInfobarAutoNeverTranslateMaxTries was timing out. That test is disabled in this reland. Original change's description: > [iOS][Translate] Adds EarlGrey tests for the new translate infobar (part 2) > > Adds tests for: > > 1. Auto Always translate (incl. max tries) > 2. Never translate language > 3. Auto Never translate (incl. max tries) > 4. Never translate site > > > Bug: 910994 > Change-Id: Ice90d639afd1f48dbdace62f6da8932f7b78d185 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521592 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642911} Bug: 910994 Change-Id: I06bbc66da0066690884706787b8fad1a543c455e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538708Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644815}
-
Marc Treib authored
Previously, SupervisedUserService explicitly called SetEncryptEverythingAllowed, requiring a dependency to SyncService. Now, the "EncryptEverythingAllowed" bit is instead propagated via SyncTypePreferenceProvider, which SupervisedUserService already implements. After this, there is only one remaining dependency from SupervisedUserService to SyncService, namely adding/removing itself as a PreferenceProvider. That will be cleaned up in a followup by wiring it through the factories instead. Bug: 946473 Change-Id: I797abf14bc03aacf2e130a283f3a12c88a2cd358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541183 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#644814}
-
Moe Ahmadi authored
In some scenarios TranslateInfoBarDelegate gets destructed before the TranslateInfobarController and subsequently its TranslateInfoBarDelegateObserverBridge instance. This results in the delegate reference to be invalid in the observer bridge's destructor. TranslateInfoBarDelegate now notifies its observer before being so that it can stop observing the instance. Bug: 945433 Change-Id: I8b8644c66c84c3a4378f281d2937b931e3bd6f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536799 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644813}
-
Moe Ahmadi authored
Signed-off-by:
Moe Ahmadi <mahmadi@chromium.org> Bug: 944829, 910994 Change-Id: I29d9e74b81cfc0b33397d32f8d9d212e2d736fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538896 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644812}
-
Robert Sesek authored
Bug: 934930 Change-Id: I0c9bae607e06a921c4587fcfb50ebc574c830c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540281Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#644811}
-
Mike Wittman authored
This reverts commit f99a085f. Reason for revert: Broke iOS build Original change's description: > [Sampling profiler] Use cross-platform sampling implementation for Mac > > Refactors the Mac sampling to use the StackSamplerImpl implementation, > with the platform-specific aspects moved into ThreadDelegateMac. > > Bug: 931418 > Change-Id: I8f468fa09b9ddc85921f21563ff41000a5c968f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535178 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644804} TBR=thestig@chromium.org,wittman@chromium.org,lgrey@chromium.org Change-Id: I3f50a2117449abca9c58d89b13febab3889b421b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541586Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644810}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ed4c3763465..576eb87a2d2d git log 0ed4c3763465..576eb87a2d2d --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader df5b28fdb45c..e43cda5f76de (1 commits) 2019-03-27 michaelludwig@google.com Fix paint filter quality in draw_image_set GM 2019-03-27 enne@chromium.org Add a function to compute texture sizes 2019-03-27 mtklein@google.com FM, a dumber new testing tool 2019-03-27 rmistry@google.com Fix RecreateSKPs bot page sets III 2019-03-27 robertphillips@google.com Minor cleanup of GrResourceAllocator Created with: gclient setdep -r src/third_party/skia@576eb87a2d2d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944846 TBR=stani@chromium.org Change-Id: Ie7a8641bc1f8f34f77cb8e2b0964a52d6c414f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644809}
-
Aaron Leventhal authored
Bug: 945366 Change-Id: I35fa5fb658ebbfdf478ad2a59aaffdf44bb7a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538015Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#644808}
-
Michael Ludwig authored
(not batched anymore to support color filters) Change-Id: Ie51bc5de90c5827428a08b26c85a99e18ab93291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518840 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#644807}
-
Aditya Keerthi authored
PlatformNativeWorkerPoolMac is an alternative worker pool backed by libdispatch. We expect libdispatch to perform better than the current implementation, as it is optimized for thread pool parallelism. In order to assess the benefits of using libdispatch, an experiment to to use PlatformNativeWorkerPoolMac in place of SchedulerWorkerPoolImpl will be conducted on macOS and iOS. Bug: 946147 Change-Id: Iebc4386070bad629e01ab05438546be545a4f3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536442Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Cr-Commit-Position: refs/heads/master@{#644806}
-
Nick Diego Yamane authored
Cl adds WaylandShmBuffer class, which basically unifies functions and data regarding wayland shm buffers, currently spread into wayland_util, data device and cursor implementation, thus reducing code redundancy and improving on current awkward CreateSHMBuffer/DrawBitmapIntoSHMB API. This new class is meant to cover both: 1) local buffers created and mapped within local memory address space to draw bitmaps into (as WaylandDataDevice and WaylandCursor do); and 2) buffers created using file descriptor sent by other process throuhg IPC (e.g: ShmBufferManager and buffers requested by GPU process/thread). This change covers case 1, and a followup CL will add support for case 2. Bug: 578890 Change-Id: I4ab853166a6fed4e16d85988495313ed84575990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535493 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#644805}
-
Mike Wittman authored
Refactors the Mac sampling to use the StackSamplerImpl implementation, with the platform-specific aspects moved into ThreadDelegateMac. Bug: 931418 Change-Id: I8f468fa09b9ddc85921f21563ff41000a5c968f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535178Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644804}
-
James Cook authored
This avoids creating a bunch of <option> elements if the timezone select isn't shown. Follow-up from this review: https://chromium-review.googlesource.com/c/chromium/src/+/1536544 Bug: 927732 Test: browser_tests Change-Id: I330256a57ebd0082b7755af1441c89d1cb83623d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539268Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#644803}
-
Liquan(Max) Gu authored
This CL is to fix a bug in FCP++. FCP++ is currently using a set for ranking the nodes' size. When two node sizes are the same, the set will ignore one of them. This bug will manifest in the following scenario: * A and B element have the same size, which is the largest on the page. * When the set adds A and B, it ignores B implicitly. * A is detached from the DOM. * LCP reports a candidate. At this time, LCP should have reported B, but as B is not in the ranking set, it's ignored by LCP as well. Bug: 944248 Change-Id: I55d6856ff93191494a0bd46f7043b76c2f674b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534303Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#644802}
-
Becca Hughes authored
Add field trial testing config for preseed stable exp. BUG=931791 Change-Id: I5db4299e1a347cb52565d862a60f1b0ff3c12783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540458 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644801}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58cb9bcb7e0a..f27b5ca150c5 Created with: gclient setdep -r src-internal@f27b5ca150c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: If17d627742106624408f11b9259b2e35fdea476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541503Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644800}
-
Nico Weber authored
- Move global win-only flags from //build/config/compiler to //build/config/win:compiler which the former already references if is_win - Move /FC from the toolchain to //build/config/win:compiler too: The toolchain isn't where random compiler flags should be added. - This allows moving msvc_use_absolute_paths from a gni file to a gn file, so do that as well. No intended behavior change. Bug: none Change-Id: I1b35a4242649105e005b94df911849ebf44d7c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541636 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#644799}
-
Dominik Röttsches authored
Change-Id: I58eacb74a1cd2335119ba508b27656088285dc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541776 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644798}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c020057. With Chromium commits locally applied on WPT: 685a1df9 "Extend canvas getContextAttributes WPTest" 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." 1bf12f7c "Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"" efbe41b8 "Change unoptimized-images feature policy to unoptimized-lossy-images." 34ea864a "Revert "Change unoptimized-images feature policy to unoptimized-lossy-images."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I8300b9b3c3096f7c63a3d10a7fcb1f2c1a4ce04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541496Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644797}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/df5b28fdb45c..e43cda5f76de git log df5b28fdb45c..e43cda5f76de --date=short --no-merges --format='%ad %ae %s' 2019-03-27 capn@google.com Add GLES unit tests to Kokoro Windows CI Created with: gclient setdep -r src/third_party/swiftshader@e43cda5f76de The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ifa2b18d9d9722e231c59c61ff1b760bfe8f29104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541499Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644796}
-
Ehsan Karamad authored
This reverts commit 8fce3374. Reason for revert: This is causing test failures. I will wait for crrev.com/c/1535965 to land and then try this again in case the failures are due to non NetworkService code path. Original change's description: > [ MimeHandlerView ] (frame-based MHV) postMessage > > This CL hooks up post messaging API for frame-based MimeHandlerView. A > current post message test which runs only for BrowserPlugin version is > now modified to run for frame-based MimeHandlerView as well. > > Bug: 659750 > Change-Id: Ie58fa733f463e697e38a100f78e0e50e7431b983 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539869 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644640} TBR=ekaramad@chromium.org,wjmaclean@chromium.org Change-Id: I9b14956a23b601c35e626c8a691ea000160823dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 659750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541583Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#644795}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I196dc9dd1a90f5c9dc69a2905c374ddbee691631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541498Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644794}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bc2a48ba8635..2d11abbb30a0 git log bc2a48ba8635..2d11abbb30a0 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 perezju@chromium.org [systrace] Replace generate_random_filename_for_test with tempfile_ext Created with: gclient setdep -r src/third_party/catapult@2d11abbb30a0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945342 TBR=sadrul@chromium.org Change-Id: I9aebb0e02870c29783b01dbb863e55d462efcd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541502Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644793}
-
Zhang Xiangze authored
Usage of compositor_task_runner has been moved to CreateSubmitter() Change-Id: Iedd9eb118f0308ceb97a2857f32b6fed5b5b378c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537568Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#644792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a9ce6e0..4a2582bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I57e28ce8cc308d0a499cf69331665ed3cc73cd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541424Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644791}
-
Dominik Röttsches authored
Fixes fuzzer issues listed in Bugs line. Remove behdad@google.com from OWNERS. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/bcb4e505d6ff..ec2a5dc859b0 $ git log bcb4e505d..ec2a5dc85 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 behdad Use class templates for Null objects 2019-03-26 behdad [aat] Add missing check to ankr table 2019-03-25 behdad [docs] Update 2019-03-25 behdad Update ChangeLog generation 2019-03-26 qxliu completely remove lines that are commented out 2019-03-26 qxliu update arguments in_populate_gids_to_retain() and _create_old_gid_to_new_gid_map() so they don't use deprecated variable 2019-03-25 qxliu try to remove deprecated variable from struct definition Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,behdad@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org,bungeman@chromium.org Bug: 945855, 944346 Change-Id: I632436a98f9d3fd5de96d71a326c3ec4922af758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540002 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#644790}
-
Stefan Zager authored
Because PageWidgetDelegate::Animate can run arbitrary script, it's possible that a LocalFrameView could call Dispose() -- and delete its LocalFrameUkmAggregator -- while there is a UKM measurement in progress. By making LocalFrameUkmAggregator ref-counted, instances of ScopedUkmHierarchicalTimer can keep it alive while a measurement is in progress. BUG=943500 R=schenney@chromium.org Change-Id: Icc1346db664583a4e5686c2f15a9f261305fb5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539182Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#644789}
-
Yuwei Huang authored
This CL renames a few files in grpc_support. This makes it easier to track changes in cl 1540360. Bug: 927962 Change-Id: I492926e8fd92310b8b7fdf671457f001a1585556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539631 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#644788}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8f22a28e30b0..afa61c94e50e git log 8f22a28e30b0..afa61c94e50e --date=short --no-merges --format='%ad %ae %s' 2019-03-27 crodbro@webrtc.org Avoid calling OnRoundTripTimeUpdate with invalid RTTs. Created with: gclient setdep -r src/third_party/webrtc@afa61c94e50e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I25e7f82a149720c4b15a46c09e34430199e88704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644787}
-
Thomas Tangl authored
|prefs::kContextualSearchEnabled| is added to the list of synced prefs that are observed during settings opt-in. Bug: 933647 Change-Id: I3db775f98127286971cd5a1e3b2d5ddeee583959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538530Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#644786}
-
Chris Cunningham authored
Meant to do this earlier in: https://chromium-review.googlesource.com/c/chromium/src/+/1534711 With this final step we can get the pieces we need to pass from WMPI to the VideoDecodeStatsReporter. Bug: 907909 Change-Id: Ic0c4055071435b273e80aba9bf4bdde03c139d7d TBR: sandersd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539904 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#644785}
-
Brian White authored
This reverts commit b1ef7206. Reason for revert: The is causing crashes on Linux CFI bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/13126 Original change's description: > Enable DownloadDBForNewDownloads by default > > BUG=842245 > > Change-Id: Ieea0d3bcaef8f8f47a32c74845c056c452ca7f8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532922 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644406} TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org Change-Id: I8a9550ab957e439b3a40b9caf38205d902354075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541660Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#644784}
-
Christian Fremerey authored
When starting video capture with a device that is rotated, e.g. a convertible in portrait orientation, the rotation of the captured video intermittently (most of the time) comes out wrong. The root cause is that rotation events are ignored before capturing is started but may end up arriving before. This CL fixes this by storing the rotation in case rotation events are received while capturing is not started. Bug: 944215 Change-Id: I1346772341044c92be754d11d17a519397598df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540459Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#644783}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c476e5da4fef..0ed4c3763465 git log c476e5da4fef..0ed4c3763465 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 fmalita@chromium.org [skottie] Fix handling of hidden shapes and layers Created with: gclient setdep -r src/third_party/skia@0ed4c3763465 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I5928d58cc2a57a414b3982385c000653ab3b117c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644782}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5a48042d7f2..5c4690c2f4e8 git log b5a48042d7f2..5c4690c2f4e8 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 lannm@chromium.org Filter out Legacy-Code-Review=-1 Gerrit changes from CQ 2019-03-27 evanhernandez@chromium.org chromeos_config: Do not run BranchUtilTestStage. Created with: gclient setdep -r src/third_party/chromite@5c4690c2f4e8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I0c9a691458a85ffc341d058d89c6e889323a13b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541596Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644781}
-
chrome://flagsJonathan Backer authored
Change-Id: I7da6fbcf9e935c88057e71190089883a4cb18fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539875 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#644780}
-
Olivier Robin authored
These methods can be calle asynchronously. It is necessary to check that the web_frame was not destroyed before processing it. Bug: 942427 Change-Id: Icc46dae9193c4fd9ef9612ce47239bd50eef33d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538194 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644779}
-