- 31 Mar, 2020 40 commits
-
-
Bryce Thomas authored
One instance of this was already fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1874486. This CL simply covers the other. Bug: NONE Change-Id: Ic0dc4ce2fdc1ca0daa414b50d2f9cf5a59f676ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130667Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#755064}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dbb23ec3589f..06f4f3e13c49 git log dbb23ec3589f..06f4f3e13c49 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 cnorthrop@google.com Capture/Replay: Disable binary formats when FrameCapture is enabled 2020-03-31 jmadill@chromium.org Vulkan: Observe staging buffer changes in TextureVk. Created with: gclient setdep -r src/third_party/angle@06f4f3e13c49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Id3e72ad7c72d56af16dd39730352071e8c4ba7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755063}
-
Henry Jian authored
Support for report_java_assert is no longer needed. This CL removes it. In addition, this CL removes BuildHooks.java as report_java_assert is the only thing BuildHooks.java is used for. Bug: 1024346 Change-Id: I0235718b771d717f258575ab005acdb261612c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123316 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#755062}
-
John Budorick authored
Timing out frequently, possibly due to crrev.com/c/2125464 Change-Id: Iee1d7d9965bdb2858930d40d6f9d0fb56f99aabc Bug: 1066570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129999Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#755061}
-
Wez authored
Chromium targets now depend directly on the Fuchsia SDK's own GN rules for FIDL, prebuilt, and C++ libraries, so remove the Chromium-generated rules for those. Bug: 1050703 Change-Id: I96300722aa0973d72161f143c9ddf3979f70fd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061756 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755060}
-
Tarun Bansal authored
Pass the next likely navigations from external Android apps to observers of navigation predictor keyed service. For current two observers (isolated prerender and optimization hints manager), this CL adds logic to return early if the prediction source is an external Android app. Bug: 1014210 Change-Id: Ie6db1927fb76d8d4e651e7d7680031d2eb8c641d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125693Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#755059}
-
Dave Tapuska authored
These tests seem to be failing. Create a specific bug for them and assign to CSS team. BUG=626703,1066577 Change-Id: I99d66e54382c44ced9a1f59e82e4c89e9ff18420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130686Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755058}
-
Bo Liu authored
The cause of flake is reverted, so enable them to resume test coverage: https://chromium-review.googlesource.com/c/chromium/src/+/2122818 Tbr: ntfschr@chromium.org Bug: 1065173 Change-Id: I2b7e13541de564e6bf92831115199329b14355a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124076Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755057}
-
Devlin Cronin authored
The Chrome UI Overrides allowed extensions to override the bookmarks UI, but never shipped. This CL removes most of the remaining core bits. Specifically, - The _manifest_features.json entry - The manifest_types.json entry - The associated ManifestHandler (UIOverrides) - The associated FeatureSwitch (enable_override_bookmarks_ui) - The associated constants - The associated commandline switches ("enable-override-bookmarks-ui") Bug: 894447 Change-Id: I673485dcb5f5e414c449476cd6169f862c48aa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129282Reviewed-by:Mike Wittman <wittman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755056}
-
Jochen Eisinger authored
I accidentally deleted the else which led to always using the search icon. Bug: 1066568 Change-Id: I872989d4f0ecb66be1b1f967a092caa58c44ed7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130250 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#755055}
-
Toby Huang authored
Extensions lite was an emergency feature, launched in response to the COVID-19 crisis, to enable supervised users to temporarily install extensions, such as Zoom, from the ExtensionInstallWhitelist policy. While all extensions are currently blocked for supervised users, themes are not. The current implementation of extensions lite will block all themes for supervised users, since not every theme is included in the policy whitelist. This CL checks for and excludes themes from StandardManagementPolicyProvider::UserMayLoad(), to restore supervised users' ability to install themes. Bug: 1066244 Change-Id: I9a90d2408545de6d28ec38c90627f1037cf143d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128374Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755054}
-
Nate Fischer authored
No change to logic, only docs. This adds general documentation for how to launch Dev UI, and provides information for how Dev UI interacts with Finch. Fixed: 1058571 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Icc7234807935d764886a66305ff8cd5653701f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123334Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755053}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba238d8eed6d..af705142bcc4 Created with: gclient setdep -r src-internal@af705142bcc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I80dd5a0b9a44f8342d808afca8233db0db58588b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130286Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755052}
-
Ted Choc authored
Bug: 985905 Change-Id: I65cb5cc35a8f4f61322e14cda76e63ee34ed7a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128932 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Update PageInfo to get SecurityLevel and VisibleSecurityState from the delegate, which moves a lot of duplicated logic from wherever PageInfo is constructed into the delegate, and will also make componentizing ConnectionInfoPopup and PageInfoController easier, because the dependency on SecurityStateTabHelper won't be necessary. UpdateSecurityState and ComputeUIInputs don't need SecurityLevel and VisibleSecurityState, and have been updated to get them directly from the delegate instead. PageInfoTest was setting custom values for these, and so a test-only method to set security state has been added. Bug: 1052375 Change-Id: Icf09eba58654d46ca9f9bf075364c1f00793db91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128107 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#755050}
-
Ehimare Okoyomon authored
Add check to shouldCaptureThumbnail that informs the ntp if the cookie controls state is incorrect. Bug: 1065391 Change-Id: I6b7fb5e5ce88975e1ebb844f5c402a8540176858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128311 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#755049}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06101933267d..17ffd9875c34 git log 06101933267d..17ffd9875c34 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 ehmaldonado@google.com git-cl: Fix git-cl split. Created with: gclient setdep -r src/third_party/depot_tools@17ffd9875c34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3fcb7f664f576bf644da5d75645a5792f812abd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130185Reviewed-by:
-
Sean Harrison authored
Also, reorder two strings in the list for readability. Bug: 1032584 Change-Id: I2dcf03bb795a3f920d4d0a9be0a9db3e21dc5c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107629 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755047}
-
Etienne Pierre-doray authored
Add Unwinder as optional param in StackSampler that's used if present. This is necessary for follow up NativeUnwinderAndroid that doesn't have a default constructor. Late creation of StackSampler in StackSamplingProfiler is also removed because this won't be possible with NativeUnwinderAndroid. Instead, StackSampler is always created in constructor or injected. Bug: 989102 Change-Id: Ib90416659f28d7139baed8d7adba62836337b13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095372 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/143da7b3..3acfab72 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I419e9583a897af3566ea8893924f844c5bb54626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130067Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755045}
-
Anastasiia Nikolaienko authored
Use crosAddAccountEdu flow name for Child users. Bug: 1043108 Change-Id: I5598f05105cd3817e544d82a74d7b6aaebea5f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120361 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755044}
-
Raul Tambre authored
has_key() has been removed in Python 3. Use the 'in' operator which works in both Python 2 and 3. Traceback (most recent call last): File "../../gpu/config/process_json.py", line 961, in <module> sys.exit(main(sys.argv[1:])) File "../../gpu/config/process_json.py", line 935, in main process_software_rendering_list( File "../../gpu/config/process_json.py", line 810, in process_software_rendering_list process_json_file( File "../../gpu/config/process_json.py", line 771, in process_json_file write_entry(entry, total_features, feature_tag, unique_symbol_id, File "../../gpu/config/process_json.py", line 677, in write_entry write_conditions(entry_id, False, -1, entry, unique_symbol_id, File "../../gpu/config/process_json.py", line 525, in write_conditions if driver_version.has_key('value2'): AttributeError: 'dict' object has no attribute 'has_key' Bug: 941669 Change-Id: Ib0f629fdcd7d1a72c4b1dd5f846a33007154e46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130267Reviewed-by:Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#755043}
-
Dana Fried authored
Thanks to corising@chromium.org we have previously made special cases for a number of bubbles of this type to prefer offsetting rather than mirroring, as mirroring can't fix certain cases where the anchor is off-screen (e.g. in immersive mode, or when the browser window is partially off-screen). This makes the fix universal for almost all bubbles anchored to the toolbar and location bar. Bug: 1065327 Change-Id: I62e7b060ed20fb6bfa49ec38a2f4b2b1803bedd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125468 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#755042}
-
Martin Šrámek authored
See the linked bug for the explanation of the approach. Bug: 1064722 Change-Id: I8e2343f7be297acc212985ad079a79a374d1ef9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120722Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#755041}
-
Arthur Hemery authored
This CL introduces basic use counters for the following cases: Assert COOP: same-origin Assert COOP: same-origin-allow-popups Assert COEP: require-corp Assert both COOP: same-origin and COEP: require-corp Doc: https://docs.google.com/document/d/11wdUazTT3lRTW3udzhAjrlwnTBdKrnnubZQAcCXraJY/edit# Bug: 1064951 Change-Id: I05c6d44b61edcd6345e1fe1a09c88bf3c5fb9b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122140 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#755040}
-
Kai Ninomiya authored
This will be used by the WebGPU CTS to compile GLSL shaders at runtime: https://chromium-review.googlesource.com/c/chromium/src/+/2100018 The compiler is around 1MB, and is rebuilt with some frequency, so we avoid checking it into WPT or Chromium. And since WebGPU has decided not to use SPIR-V, this solution is temporary until we have an implementation and testing of WGSL shaders. glslang.js is a WASM build of glslang, which currently also exists in src/third_party/glslang. Bug: 1060911 Change-Id: I7665b9d7137549466ac9409852e4dd32cc678663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100016 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL moves multiline-column-overflow.html from css3/flexbox to external/wpt/css/css-flexbox/, and renames it to multiline-column-max-height.html. <link rel> tags are added, as well as <meta name=assert> and title. BUG=1063749 R=cbiesinger@chromium.org Change-Id: Ie22e6abd0d3fc677853fd2b3d0ea8507d257aa62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127549Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#755038}
-
Sinan Sahin authored
With this CL, the status indicator will show and hide on the Start surface without any animations, like the tab switcher. Bug: 1059438 Change-Id: Ib5bdd16721f43f2a132e25034fcc30bbda4991fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119610Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
This regressed in r753679. Bug: 1066387, 1025603 Change-Id: I77702548bbf7d7606f4f4a9a3f5007e9773f193a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130347 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#755036}
-
dpapad authored
Bug: 1026426 Change-Id: Ife93a1eceedd067cbb6fbfd8fd08197f0ef54ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128926Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755035}
-
Gurchetan Singh authored
This is reduce minigbm technical debt. BUG=b:145747350 TEST=CQ will test Change-Id: Ib9956bc4720b5c09d531f3774d90a189dc5ec4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129991Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org> Auto-Submit: Gurchetan Singh <gurchetansingh@chromium.org> Cr-Commit-Position: refs/heads/master@{#755034}
-
David Van Cleve authored
The experimental Trust Token API (https://github.com/wicg/trust-token-api) takes in parameters specifying a Trust Tokens protocol operation, annotates outgoing requests with request headers corresponding to protocol state, and processes corresponding response headers. For the MVP of the API, we're making the functionality available via Fetch, iframe, and XHR. To implement the iframe surface, this CL adds a new iframe attribute, "trusttoken," that accepts as input a syntactically identical struct to the corresponding Fetch parameter; the CL also adds code for parsing the parameter. The attribute is gated by the TrustTokens runtime-enabled feature. A subsequent CL will add the results of the parse to the frame's load request in order for the downstream request handling logic to be able to access the parameters. Bug: 1062396 Change-Id: I8f0d00e17e06f5f4bbf780db5a77a71ea4d64db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116014 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#755033}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/937cfa8b7e10..b6fd42ad9ae2 git log 937cfa8b7e10..b6fd42ad9ae2 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 lalitm@google.com tp: improve diff testing script when tp returns error retcode 2020-03-31 treehugger-gerrit@google.com Merge "tp: fix memory leak of table objects" Created with: gclient setdep -r src/third_party/perfetto@b6fd42ad9ae2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I55b06592a8aa44dd4f3181e54b6961f736984f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129863Reviewed-by:
-
Ken MacKay authored
* Don't allow pending reads to complete within a write call. * Signal EOS when the other end of the socket disconnects. Merge-With: eureka-internal/381432 Change-Id: Ia091361fc0c72da52c76c9fcf98b7c24a04d9f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129996Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#755031}
-
Daniel Rubery authored
Feedback from translators indicated 'extra features' was a confusing phrase. (b/151968849) We can be more clear using the phrase 'extra protections' instead. Change-Id: Ia4b251d95103b38f43d7b9f035a3b5c89ebb6c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127897Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#755030}
-
zhaoyangli authored
These two eg2 tests are disabled because they broke 15% of recent ios-simulator-noncq builds and will block iOS code submission after EG2 tests run in CQ. The failure happens mostly on iOS 12.4 but also sometimes on 13.3 so the test method is just disabled. Bug: 1046369 Change-Id: I4b30abcea7be5aef995f24e0ce407f2df92e3514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129108Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#755029}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/469046c09657..8cbedf985570 git log 469046c09657..8cbedf985570 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 brianosman@google.com Improve SkVerticesPriv ergonomics 2020-03-31 robertphillips@google.com Reduce GrGlyph's functionality Created with: gclient setdep -r src/third_party/skia@8cbedf985570 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: michaelludwig@google.com Change-Id: I2e0457de93a8a63ad86faa6014015165ea7791ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129859Reviewed-by:
-
Robert Ogden authored
This ensures that AMP pages (often same-doc navigations) get the same treatment. Bug: 1023485 Change-Id: Id300abd499696e87cc2261c205f9e7ea9c3a8d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129015 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Trevor Perrier authored
This xtb file was added in https://crrev.com/c/1821528. It is not currently used. Change-Id: If2c19a1495b1af5db89cc3e0fad7c5e79b4d30ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124540Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#755026}
-
Trevor Perrier authored
The string that was breaking this has been updated in the TC. This suppression is no longer needed. Bug: 1033288 Change-Id: I83d753a030505db2b2ed15f7978fb14887881206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128590Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
-
