Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 19 Nov, 2017 2 commits
    • John Budorick's avatar
      Revert "Add Android OOP HP end-to-end tests." · c94d1275
      John Budorick authored 
      This reverts commit e0b4355f.

Reason for revert: Breaks chrome_public_test_apk in debug builds. Will explain more in crbug.com/786743.

Original change's description:
> Add Android OOP HP end-to-end tests.
> 
> This CL has three components:
>   1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver.
>   2) Adds a java instrumentation test, along with a JNI shim that forwards into
>   ProfilingTestDriver.
>   3) Creates a new apk: chrome_public_apk_for_test that contains the same
>   content as chrome_public_apk, as well as native files needed for (2).
>   chrome_public_apk_test now targets chrome_public_apk_for_test instead of
>   chrome_public_apk.
> 
> Other ideas, discarded:
>   * Originally, I attempted to make the browser_tests target runnable on
>   Android. The primary problem is that native test harness cannot fork
>   or spawn processes. This is difficult to solve.
> 
> More details on each of the components:
> (1) ProfilingTestDriver
>   * The TracingController test was migrated to use ProfilingTestDriver, but the
>   write-to-file test was left as-is. The latter behavior will likely be phased
>   out, but I'll clean that up in a future CL.
>   * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver
>   has a single function RunTest that returns a 'bool' indicating success. On
>   failure, the class uses LOG(ERROR) to print the nature of the error. This will
>   cause the error to be printed out on browser_test error. On instrumentation
>   test failure, the error will be forwarded to logcat, which is available on all
>   infra bot test runs.
> (2) Instrumentation test
>   * For now, I only added a single test for the "browser" mode. Furthermore, I'm
>   only testing the start with command-line path.
> (3) New apk
>   * libchromefortest is a new shared library that contains all content from
>   libchrome, but also contains native sources for the JNI shim.
>   * chrome_public_apk_for_test is a new apk that contains all content from
>   chrome_public_apk, but uses a single shared library libchromefortest rather
>   than libchrome. This also contains java sources for the JNI shim.
>   * There is no way to just add a second shared library to chrome_public_apk
>   that just contains the native sources from the JNI shim without causing ODR
>   issues.
>   * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test.
>   * There is no way to add native JNI sources as a shared library to
>   chrome_public_test_apk without causing ODR issues.
> 
> Finally, this CL drastically increases the timeout to wait for native
> initialization. The previous timeout was 2 *
> CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test.
> This suggests that this step/timeout is generally flaky. I increased the timeout
> to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL.
> 
> Bug: 753218
> Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55
> Reviewed-on: https://chromium-review.googlesource.com/770148
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517541}

TBR=brettw@chromium.org,erikchen@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 753218
Change-Id: I0ce13ddac560fc685bce8798a59d2e1c784e08af
Reviewed-on: https://chromium-review.googlesource.com/778339Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517726}
      c94d1275
    • Aleks Totic's avatar
      Revert "[layout test results.html] Small UI tweaks and tiny bug fixes" · 3bb869bf
      Aleks Totic authored 
      This reverts commit 4e68cd40.

Reason for revert: Couple of outstanding bugs. Sorry I did not get
to code review this before landing.

Original change's description:
> [layout test results.html] Small UI tweaks and tiny bug fixes
> 
> - When click the toolbar to select a view during animation, show the
>   view for 1 second. This is convenient to briefly view a specific view
>   without stopping the animation. Previously the time showing the clicked
>   view was random.
> 
> - Let GUI.getExpectation(el) handle cases that the el is under
>   result-frame, so that keyboard navigation still works when the focus
>   is under result-frame (e.g. after the toolbar or the image result is
>   clicked).
> 
> - Let GUI.activeExpectation() return the open expectation if no
>   expectation line can be found from the focused element, so that keyboard
>   navigation can be based on the open expectation if the focus is neither
>   under the expectation line nor result-frame.
> 
> - Correct total count. Previously the total count didn't include expected
>   failures, skipped and wontfix tests, etc.
> 
> Change-Id: Ibc4b697c52a7b5d37f0ebbfb5c925cc478f15f06
> Reviewed-on: https://chromium-review.googlesource.com/777469
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517674}

TBR=wangxianzhu@chromium.org,qyearsley@chromium.org,atotic@chromium.org

Change-Id: I214a79799ab0c5744c00c0cbd85f1ecd7978159f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/777808Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517725}
      3bb869bf
  3. 18 Nov, 2017 38 commits