GitLab

Bug: 767192
Change-Id: Ibea39c5a94c36d8c7c67672ee7fc380f50fa7acb
Reviewed-on: https://chromium-review.googlesource.com/676193Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505253}

Additionally all services that are launched run using the utility
process.

BUG=763529
TEST=none

Change-Id: I82ca2cef75335de7a85c7c7d3cb7362530a9ad56
Reviewed-on: https://chromium-review.googlesource.com/685979
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505252}

Also creates cleaner way to add additional compile targets to builders.

NOTRY=true # win chromium rel ng seems flaky

Bug: 758630
Change-Id: I03f2b599d8f953f21d3a6d0e57d8db90d8d13999
Reviewed-on: https://chromium-review.googlesource.com/691065
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#505251}

ChromeOS has switched over to ozone.

Bug: 750642
Test: Build passes.
Change-Id: Iffaf5f2b6d18fc05a6fa29fa22c7d16f2132497d
Reviewed-on: https://chromium-review.googlesource.com/689874Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505250}

Change-Id: I8013c0c149548069e91df8e3b47228f3b2f0646b
Reviewed-on: https://chromium-review.googlesource.com/691099Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505249}

This patch logs the time a particular WebContents spends in the
foreground, after a navigation which:
 - Is started in the background
 - Commits to a cross-origin site
 - Has no user gesture
 - Is not the first navigation in the WebContents

This metric will serve as a basis for determining how much user
benefit comes from the (imo) harmful practice of navigating a site
without user action or direct consent.

In the near future, this metric will be broken up to also include
breakouts for if the WebContents opened a popup before performing
this kind of navigation.

Bug: 661629
Change-Id: Ib6b59792b193bd447fd59939e06ed94d25c1be6b
Reviewed-on: https://chromium-review.googlesource.com/685559Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505248}

If user see modal warning, ignore it, then restart browser, change
password card should still be showing on chrome://settings page.

Bug: 765807
Change-Id: Iaeedcc4e68f865b0fc263e0b4f7cc460df43302f
Reviewed-on: https://chromium-review.googlesource.com/683461Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505247}

Adds initial support to views::Link as well, by allowing it to pass
TextContext to its parent views::Label constructor.

The entire StyledLabel has a single TextContext. A default TextStyle
can be optionally overridden on a RangeStyleInfo.

Audited the StyledLabel consumers: One consumer (EchoDialogView)
uses underlined text outside of a Link. The dialog is under review
(http://crbug.com/768663), so don't add a style for it.

The PageInfoBubble was the only consumer that wanted an underline on
its links. Remove underlines from all links in the page info bubble for
consistency with the rest of Chrome's UI.

All the (slow) FontList::Derive(..) calls disappear from StyledLabel.
Most fonts just come from the ResourceBundle cache now, unless they
need a custom_font (which is currently just EchoDialogView).

Bug: 691891
Change-Id: I6cca4480d366d2578ac01da4d604a414415ffbc4
Reviewed-on: https://chromium-review.googlesource.com/649930
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505246}

Logs either "ChunkDemuxer: buffering by PTS" or ... "by DTS" to
chrome://media-internals on MSE demuxer construction. This assists in
manual verification and debugging.

Tested with/without --enable-features=MseBufferByPts in cmdline

BUG=718641

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I418fb8e9d89bbfc98c343b2db6effc8a03201794
Reviewed-on: https://chromium-review.googlesource.com/689865
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505245}

Fix tests that break with --ash-enable-shelf-model-synchronization.
(I'm hoping to imminently enable that functionality by default)

Perform some extra cleanup in chrome_launcher_controller_browsertest.cc
(Fix ShelfModel use, avoid Shelf, nix redundant fixture, add another)

Bug: 557406
Test: Automated
Change-Id: If93c8d0c3ec70f4aa427b5eab2b2c43ffc571158
Reviewed-on: https://chromium-review.googlesource.com/691104
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505244}

Bug: 751950
Change-Id: I5e8f66fd2fc8b89cffcabd4d3827c72f333fd118
Reviewed-on: https://chromium-review.googlesource.com/687094
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505243}

Mus WindowTree::SetFocus fails to activate minimized windows.
(The failing condition is that window->IsDrawn() is false)

Add and call ::wm::ActivationChangeObserver::OnWindowActivating.
Use that to unminimize before activating in WorkspaceLayoutManager.
(otherwise, Ash was unminimizing after attempting activation)

Bug: 769520
Test: See bug.
Change-Id: Id181e463b6f574657e8ccb162ab8a6dfc9b3652c
Reviewed-on: https://chromium-review.googlesource.com/688166
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505242}

Bug: 724381
Change-Id: I38ef54257142367075157c6436f9a773620535ac
Reviewed-on: https://chromium-review.googlesource.com/690755Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505241}

This patch wilk add CORE_EXPORT to convertToSelectionInDOMTree() and
ConvertToSelectionInFlatTree() in SelectionTemplate.h, to utilize these
methods for selection conversion between a flat tree and a dom tree.
This patch is for the SelectionModifier on flat tree changes.

Change-Id: Id847872a6699448e4db3b852c96ae2edb7a68306
Reviewed-on: https://chromium-review.googlesource.com/690134Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Akari Asai <akariasai@google.com>
Cr-Commit-Position: refs/heads/master@{#505240}

Added status for every spec error code we currently use

spec: https://w3c.github.io/webdriver/webdriver-spec.html#dfn-error-code

Bug: chromedriver:2046
Change-Id: I36d7ee12859643b76133d342021015e7353f28cc
Reviewed-on: https://chromium-review.googlesource.com/687808Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505239}

Bug: 734095
Change-Id: I49b37f0b36c657e28dd85c6f29bb291c083c7467
Reviewed-on: https://chromium-review.googlesource.com/685834
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505238}

This patch removes the forced paint invalidation when scroll offset
changes with slimming paint v2 (SPV2).

This required adding four new invalidations for scroll offset changes:
1) background attachment local because we do not have compositor support.
2) A TODO has been added for background attachment fixed.
3) Overflow:hidden scroll offset changes. A scroll offset node can be
gained or lost when scroll offset crosses zero due to an IsZero check
in PropertyTreeBuilder. This IsZero check is important for reducing the
number of transform nodes in the common case that overflow:hidden has
no scroll offset.
4) The paint layer interest rect may change. This is tested by
PaintControllerPaintTestForSlimmingPaintV2.BlockScrollingNonLayeredContents
but was masked by over-invalidation in InvalidatePaintOfScrollControlIfNeeded.

Bug: 667946
Change-Id: Ic591684923ea5352706a91e65160310b81ba220a
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/644556
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505237}

Bug: 726520
Change-Id: I7ad9c513033eb1a22543336f477d71adf0a90189
Reviewed-on: https://chromium-review.googlesource.com/686035
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505236}

Bug: 743001
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id07bbc5a0afe968ca448a0b32855d104b7322211
Reviewed-on: https://chromium-review.googlesource.com/688818Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505235}

SimpleFeature has a collection of criteria to determine if a context or
extension has access to the feature, but frequently only a few are used.
Use base::Optional<> for these rather than a std::unique_ptr<> (which
requires heap allocation) or defaults (which require reserving an
"invalid" value).

This also lets us remove the SimpleFeature::UNSPECIFIED_LOCATION enum.

Bug: None
Change-Id: If3f417be60aca2a974abd0273e3fd339004db5ff
Reviewed-on: https://chromium-review.googlesource.com/685285
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505234}

This reverts commit 27c33249.

Reason for revert: Need to revert https://chromium-review.googlesource.com/c/chromium/src/+/656597 and https://chromium-review.googlesource.com/673093 which this patch depends on.

Original change's description:
> Fix ozone Linux build
> 
> This CL fixes the ozone Linux build after r504590.
> 
> TBR=tommi@chromium.org
> CC=​mfoltz@chromium.org
> 
> Change-Id: Ice6b7e1f5858c43bd1d9388ef84ee179e2268a32
> Reviewed-on: https://chromium-review.googlesource.com/688155
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504738}

TBR=tommi@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I89257302c00b903a61bfd8e483dcff61b3256113
Reviewed-on: https://chromium-review.googlesource.com/691310Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505233}

Check whether the user is primary when setup the search page in CrOS
settings. Remove the voice interaction entry and change the title if the
user is not primary.

BUG=b/66919596

Change-Id: I1b38de178830862ebca9c56160ddab595640c844
Reviewed-on: https://chromium-review.googlesource.com/689965Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505232}

IsGenerated and Get both do lookups in the same map. We can just
Get the result and see if it's empty. The result is a StringPiece,
so examining it isn't expensive in the absent case.

Change-Id: If42d6dc7c384a64e7716fe771d1cc5758dd18cfc
Reviewed-on: https://chromium-review.googlesource.com/678183Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505231}

Creates a new download::Client, BackgroundFetchDownloadClient, which
forwards calls to the BackgroundFetchDelegateImpl.

Bug: 758562
Change-Id: I8fa30334b41713b1e1d9952448c521ae547bfc2d
Reviewed-on: https://chromium-review.googlesource.com/663718
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Mellor <johnme@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505230}

TextPrompt and its subclasses are all single-line prompts.  Since none
require multiline, we can preventDefault on Enter at the base and remove
several preventDefault calls.

Bug: none
Change-Id: I42c08c10052746954c4698975ca72383f3fc25ec
Reviewed-on: https://chromium-review.googlesource.com/683436Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505229}

R=ekaramad@chromium.org,lfg@chromium.org
BUG=628704

Change-Id: I88b95a335e8f97ef5076329a49b52d482fe297f4
Reviewed-on: https://chromium-review.googlesource.com/690348Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505228}

Refreshes the IDB tree and table data if IDB is modified.

Bug: 729793
Change-Id: I806e44ea6b5db884a2ab8ce9279745e023ac2732
Reviewed-on: https://chromium-review.googlesource.com/658486
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505227}

Bug: 711253
Change-Id: I21b7af034c8284a9b752b06e7784ea653351f27b
Reviewed-on: https://chromium-review.googlesource.com/691218Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505226}

When pak.info files are concatenated whenever pak files are merged, they
need to have a consistent format so that the concatenated file does not
have merged lines.

BUG=723672

Change-Id: Ic45f62d0320fe9b167793694fc13feec76e336ec
Reviewed-on: https://chromium-review.googlesource.com/690317
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505225}

wayland_client_perftests doens't build for cros without explicitly
including 'memory' header for unique_ptr.

Bug: 
Change-Id: I74b8bbe07e2fd8b0b52bee2bacb49e445d9a46a9
Reviewed-on: https://chromium-review.googlesource.com/691334
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505224}

Introduce a NativeRendererMessagingService to handle extension message
passing with native bindings enabled. Add tests for the same.

To start, only handle port-based messages (i.e., runtime.connect);
subsequent patches will address runtime.sendMessage et al.

The new service is not yet being used, since it is not fully functional
and would break bindings tests.

Bug: 653596
Change-Id: Ibcf1b06552e6097d2494ad3704b8a15bc3c32b7e
Reviewed-on: https://chromium-review.googlesource.com/669862Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505223}

Add a feature flag for the redesigned modern
media controls and reshuffle the existing
resources.

BUG=757768

Change-Id: If4626b285f15ab30168eeb54a4a83e9c1fc08708
Reviewed-on: https://chromium-review.googlesource.com/625937
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505222}

This is a precursor for enabling a load of new compile-time warnings for sandbox/win.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ia25413826c1a186cd6b680522ac93409fb01ddea
Reviewed-on: https://chromium-review.googlesource.com/683240
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505221}

net::android::GetIsCaptivePortal API returns the captive portal status
on Android. Use this API to determine whether to show a captive portal
interstitial in addition to the captive portal certificate list.

Bug: 642993
Change-Id: I8cdeaed47ea7e198a7589a3573f96b2093cd4fad
Reviewed-on: https://chromium-review.googlesource.com/664342Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505220}

Applies mojom bindings-generation-time message ID
scrambling to all mojom targets by default. Changes the
generator's salt flag to take a filename, and uses some
GN and LASTCHANGE magic to ensure that the salt file is
updated on each build revision.

This behavior can be disabled in specific mojom GN targets
by setting |scramble_message_ids| to |false|, which is done
here for ARC mojoms to avoid compatibility issues between
Chrome and the ARC container.

BUG=673417

Change-Id: I4263a4b90400a09fed8286b362108f13376b88c5
Reviewed-on: https://chromium-review.googlesource.com/685457
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505219}

Bug: None
Change-Id: I5e6f56c34f41cabedade893ccff46d3ed1deda7b
Reviewed-on: https://chromium-review.googlesource.com/691146Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505218}

This test is also flaky on Linux (dbg):
virtual/threaded/transitions/transition-end-event-transform.html

TBR=kbr@chromium.org

Bug: 757955
Change-Id: Iceed2eb7ec013dc396314b754ec4b0885f03876d
Reviewed-on: https://chromium-review.googlesource.com/691061Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505217}

This change removes the png asset for the Chrome Home promo and
replaces it with a vector asset.

BUG=767738

Change-Id: I1b0d07427e2b73e3a4609df27ae3c1083221c198
Reviewed-on: https://chromium-review.googlesource.com/691215Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505216}

This CL removes all the old DNS.Resolve* and AsyncDNS.Resolve*
histograms and replaces them with a new set. The new Net.DNS.Resolve*
histograms measure timing and success/failure at the Job layer, and each
type of Task gets its own set to measure Task layer timing and
success/failure.

Bug: 769320
Change-Id: I0b0df897310a474fd11022f932724c8d40789090
Reviewed-on: https://chromium-review.googlesource.com/687836
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505215}

Currently the placeholder for obscured text is defaulted to be '*'
except for Mac. However for Chrome OS lock screen we must use bullet as
placeholder. Added a setter to customize the password replacement char.

Bug: 719015
Change-Id: Ic874a29f68d530aa479cf9852265fe8c07d64003
Reviewed-on: https://chromium-review.googlesource.com/683598Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505214}