- 05 Feb, 2019 40 commits
-
-
Fredrik Söderquist authored
The scaling of the various edges/widths would always round down, which meant that edges that were supposed to be abutting were not. Round the scaled width instead, but take care to avoid introducing a new overlap (which we scaled down to avoid). Use LayoutUnits for this since we probably want to just compute the widths to LayoutUnit directly in the future for slightly improved fidelity (TODO added). Also, fix typo in |include_rigt_edge|. Bug: 918994 Change-Id: I359fd54d30ddcfa235217e14f340cd6139e9d040 Reviewed-on: https://chromium-review.googlesource.com/c/1452183 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#629133}
-
Armando Miraglia authored
Lately, fixing some flakyness in the WebRTC Browser tests (crrev.com/c/1445936, crrev.com/c/1447693) I noticed some inconsistency in the way the tests are defined. This CL consolidates where the constraints that are used throughout the tests are defined and should reduce the maintenance burden. BUG=926830 Change-Id: I63f76e6e720f430f7b25a8326fe4dbb225a3a85a Reviewed-on: https://chromium-review.googlesource.com/c/1451830Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#629132}
-
Florent Castelli authored
This reverts commit acdd73ae. Reason for revert: editing/selection/mouse/drag_over_text_transform.html fails on mac Bug: 928739 Original change's description: > [LayoutNG] Work around crash with 'text-transform' > > 'text-transform' may make LayoutText::GetText() longer than the original > DOM text node, and result in out-of-range offsets that are not properly > handled. > > This patch works around that in some crash sites so that it stops > crashing. > > Bug: 899868 > Change-Id: I55645b83b3d2d0aec38cb2c0f97a2b89a4897d3e > Reviewed-on: https://chromium-review.googlesource.com/c/1450745 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628916} TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org Change-Id: I3aa66f79939a3fd32760db28f3832c31b67a24ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899868 Reviewed-on: https://chromium-review.googlesource.com/c/1454581Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629131}
-
Eric Seckler authored
Removes an unnecessary lock and constructs the TraceWriter earlier. I'm not convinced either will actually solve the missing metadata bug, but I'd like to rule these out. Bug: 919187 Change-Id: I8f73c7749cc6d3cb66a23f14308e2a7ab8dc8306 Reviewed-on: https://chromium-review.googlesource.com/c/1454483Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#629130}
-
Henrik Boström authored
They're currently not wired up to be used anywhere, but they are constructable from JavaScript and can be used for real in future CLs. Intent to Implement & Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TsJA1XX7mTE Bug: 821806 Change-Id: I463e3e322908c9b67b7032891193ec77b368aa20 Reviewed-on: https://chromium-review.googlesource.com/c/1424951 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#629129}
-
Stephane Zermatten authored
Before this change, chips were kept in UiControllerAndroid and progress was kept only in the UI model. With this change, both are kept in the controller. Also, the responsibility for making sure the progress does not decrease is moved to the Controller, as progress can decrease when switching controllers. The goal of this change is to make it possible to attach the UI to a new controller. This change also introduce a FakeScriptExecutorDelegate, to make it easier to maintain unit tests that use a ScriptExecutorDelegate. It also refactors some controller test to make use of the fact that the controller is now stateful. This is a pure refactoring. It should not have any visible effect. Bug: 806868 Change-Id: I028437f48d5a86929135167bc1759da9a8b8c036 Reviewed-on: https://chromium-review.googlesource.com/c/1445902 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629128}
-
Clemens Hammacher authored
The raw-pointer API will be deprecated soon. Switch all uses in chrome to the new API expecting a unique_ptr. R=adamk@chromium.org, jochen@chromium.org Bug: v8:8725 Change-Id: If08fc3b655b5bc2c2bf3d81bd5788a98385e3568 Reviewed-on: https://chromium-review.googlesource.com/c/1447652Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#629127}
-
Nico Weber authored
Bug: 928679 Change-Id: If98edba89ada21bb51076173034102e06cdd0345 Reviewed-on: https://chromium-review.googlesource.com/c/1453113Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629126}
-
Florent Castelli authored
This reverts commit 3d50bc41. Reason for revert: Broke win32-rel builds ( https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/10719 ) Bug: 928727 Original change's description: > Roll src/third_party/skia 0783aca7ba31..ad8f25f81346 (1 commits) > > https://skia.googlesource.com/skia.git/+log/0783aca7ba31..ad8f25f81346 > > > git log 0783aca7ba31..ad8f25f81346 --date=short --no-merges --format='%ad %ae %s' > 2019-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 950d2f4a..6c1a9cca (394 commits) > > > Created with: > gclient setdep -r src/third_party/skia@ad8f25f81346 > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=fmalita@chromium.org > > Change-Id: I22968a75e30f8600cb992aece44a4cfd3437e8a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1454420 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#629115} TBR=fmalita@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Iedb0ca00bedf90cbda582403fd520f18971833b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1454364Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/049ff3873334..8f71f7311f29 git log 049ff3873334..8f71f7311f29 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 headlessclayton@gmail.com Fix linux link error when using LLVM reactor backend. Created with: gclient setdep -r src/third_party/swiftshader@8f71f7311f29 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123360006 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0e068cb8a88ac88ca9d27da479f901319bd36d6c Reviewed-on: https://chromium-review.googlesource.com/c/1454424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629124}
-
Jan Krcal authored
This CL removes an undesired early return for empty GetUpdates responses (with no gc directives) for bridges that do not support incremental updates. This early return caused that even the new progress marker was not stored by the bridge. The previous code was based on assumption that the progress marker does not change in such responses but this was proven to be wrong by traffic issues in the recent USSWalletData rollout. Bug: 924447 Change-Id: I891a93d484669f8cb1f195395a9cd0f6ad54ffdf Reviewed-on: https://chromium-review.googlesource.com/c/1451831 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629123}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I9aa7e8eff88248c9f0cc47d98f94bf823be426e5 Reviewed-on: https://chromium-review.googlesource.com/c/1452179Reviewed-by:
-
Dan Elphick authored
Fixes use of deprecated Object::Get/Set V8 functions by instead using the Context version and checking the return values. Bug: v8:7283, v8:8562 Change-Id: Idf2b5b596a431ad249d9bbcbf8f295537b2bab80 Reviewed-on: https://chromium-review.googlesource.com/c/1452177 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Rayan Kanso authored
The tests are consistently failing on Android tablet testers. TBR=reillyg@chromium.org Bug: 928712 Change-Id: I2e4426f922a1966d13ced292f2beaaf2ae4f059e Reviewed-on: https://chromium-review.googlesource.com/c/1454362Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629120}
-
Alexandre Courbot authored
We want to switch V4L2IP to V4L2Queue, but V4L2Queue is more strict about all device access being done from the device thread. Currently buffer allocation and deallocation is being done in the client thread, so move them to be performed by the device thread instead. BUG=792790 TEST=Checked that VDA passed on Hana and VEA on Peach Change-Id: I4b06b3bb10676c3a902e5e91657da2ecca7b737c Reviewed-on: https://chromium-review.googlesource.com/c/1071496 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#629119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f3c96a88. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 14c11107 "Implement `Sec-CH-Lang`" c49d046d "Initial support for WorkletAnimation.playbackRate" 70938d55 "Fix remaining preload tests flaking on wpt.fyi" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I1fdbec3569c7e07c58b3aaf780936f6ea87b3ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1454220Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629118}
-
Vladislav Kuzkokov authored
Bug: 660612 Change-Id: Iff14d75ee912e38c10334fed5b5337de9606610a Reviewed-on: https://chromium-review.googlesource.com/c/1446216Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629117}
-
Michael Lippautz authored
Enabling unfied heap garbage collections per default. Bug: 843903 Change-Id: I473f85bbe2d6b3fc72051549ffd389896cc488c6 Reviewed-on: https://chromium-review.googlesource.com/c/1412026Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629116}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0783aca7ba31..ad8f25f81346 git log 0783aca7ba31..ad8f25f81346 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 950d2f4a..6c1a9cca (394 commits) Created with: gclient setdep -r src/third_party/skia@ad8f25f81346 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I22968a75e30f8600cb992aece44a4cfd3437e8a2 Reviewed-on: https://chromium-review.googlesource.com/c/1454420Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib90cd7eb2b549624b50dc226875733855ea2a22d Reviewed-on: https://chromium-review.googlesource.com/c/1454422Reviewed-by:
-
Mikel Astiz authored
We've observed crash reports that may be related, but nevertheless starting this feature during sync standalone transport is questionable. We achieve so by removing SUPERVISED_USER types from "core" sync types and instead considering them user types that always preferred (as long as sync-the-feature is enabled) and of high priority (to avoid behavioral differences wrt startup latency). Together with ignoring two remaining deprecated types, "core" sync types now become synonym of control types, so we get rid of the concept altogether. Bug: 923826 Change-Id: Ie653f1c43f892307d72655967d4d75f13c338741 Reviewed-on: https://chromium-review.googlesource.com/c/1454519Reviewed-by:
-
Yutaka Hirano authored
... in order to drain a BytesConsumer, and use it for Fetch API in the future. As the BytesConsumer passed to ResponseBodyLoader can be exposed, we need to create ResourceLoader::CancelReportingBytesConsumer, a BytesConsumer that translates a cancelling request to the ResourceLoader. Bug: 894819 Change-Id: I1700635dbb9bed6f2b34a80ed2b4c8532733e4c4 Reviewed-on: https://chromium-review.googlesource.com/c/1442431Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#629112}
-
Boris Sazonov authored
This CL removes the code that used to add _numaccounts, _numgoogleaccountsondevice and _numsignedin attributes to Omaha requests. Bug: 926273 Change-Id: I36edef48dc4d51cbed70ad1a7e14284cfa1c772f Reviewed-on: https://chromium-review.googlesource.com/c/1451925Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
Remove unwanted headers related to SignInManager from unified_consent_service_factory.cc Bug: 927253 Change-Id: I2b18b160d8c16eb309fa1d9592aa0aefcbb892bb Reviewed-on: https://chromium-review.googlesource.com/c/1447993Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#629110}
-
Yoshifumi Inoue authored
This patch chanages |NGPaintFragment::PopulateDescendants()| not to associate paint fragments to layout object for "float" since we don't need to use them. Change-Id: I79278a183d3bef9edac69e37de71a63aaa05ed08 Reviewed-on: https://chromium-review.googlesource.com/c/1454199Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629109}
-
Daniel Vogelheim authored
This customizes the explanation for the actual error encountered. Bug: 751996 Change-Id: Ida921aff4232f675e3a84e5766c562ba5a1f2c0e Reviewed-on: https://chromium-review.googlesource.com/c/1451892 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629108}
-
Alex Clarke authored
base::unique_any is similar to std::any except it doesn't use exceptions or RTTI which are banned in Chromium (std::any sort of works with RTTI disabled but it's crippled because you can't use Any::type to inspect the type). base::unique_any can hold any move or copy constructible type (std::any can only hold copy constructible types). As you might expect base::unique_any doesn't have a copy constructor or a copy assignment operator. I chose not to implement base::any for now since the main motivation for base::unique_any is to allow base::AbstractPromise to be an ordinary type and to reduce promise template bloat. Still it would be easy to implement base::any on top of this patch if we chose to. Small objects are stored inline and larger ones with an auxiliary allocation. Bug: 906125 Change-Id: I16223d27aa46490a1e36266c59264ec24ddc5062 Reviewed-on: https://chromium-review.googlesource.com/c/1340802 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
tzik authored
The TestRunner for web tests used to grant the universal access permission to all origins by default. That is, all origin boundary checks are disabled. However, it's no longer needed, and it's hard to support dynamic configuration of the security check around the origin boundary. This CL drops the permission as a preparation to remove the settings item itself. Change-Id: I22cd23d10fe1f0d10a4a64a3d5404adda129645c Reviewed-on: https://chromium-review.googlesource.com/c/1454163Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#629106}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/30b182aca08a..69b761e52b10 git log 30b182aca08a..69b761e52b10 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 srte@webrtc.org Sets start on activities added after starting scenario test. Created with: gclient setdep -r src/third_party/webrtc@69b761e52b10 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8e9504920934b44e8fd430882c3b1d56de555577 Reviewed-on: https://chromium-review.googlesource.com/c/1454419Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/02bb14c83b69..a308a9443ca9 git log 02bb14c83b69..a308a9443ca9 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 kbr@chromium.org Crash renderer via DevTools if Log.enable raises an exception. Created with: gclient setdep -r src/third_party/catapult@a308a9443ca9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917211 TBR=sullivan@chromium.org Change-Id: I2e4580e3e8f65f33da6baeb8f8705efc9e822bdd Reviewed-on: https://chromium-review.googlesource.com/c/1454423Reviewed-by:
-
Antonio Gomes authored
This is a follow up of [1] and [2], where droger asked to move away from using "unchecked" ObserverLists. [1] https://crrev.com/c/1448473 [2] https://crrev.com/c/1448754 BUG=927341,927343 Change-Id: I5d91a6af2f51af50eb3a803e908c79c8f1789bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1452818 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629103}
-
Mohamed Amir Yosef authored
PasswordSyncBridge assumed that MetadataStore should be always available during construction time. However, this isn't necessarily the case. If LoginDatabase initialization fails, PasswordStoreBridge will be constructed while the MetadataStore is not available. In such case, the bridge should report an error to the change processor. Bug: 928421 Change-Id: Ie2cdd103accbaca27a093a9f9f002fd0d6e88c70 Reviewed-on: https://chromium-review.googlesource.com/c/1454393 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629102}
-
Vadym Doroshenko authored
When the user chooses a password in the save prompt from the combobox, this password has to be saved. The current implementation is the following: 1.When the user chooses another password, UpdatePasswordValue is called 2.UpdatePasswordValue sets password_value to this password. 3.CreatePendingCredentials is called (it detects what case it's - Save, Update etc and creates credentials to write to store). But if there is new_password_value in submitted_form, new_password_value will be chosen to save instead of the user chosen. That's incorrect and this CL fixes that. Namely: it removes new_password_value which makes that user chosen value is saved. Along the way, it was fixed calculating password_element, that fixes sending votes. Bug: 831123, 919487 Change-Id: I3f202224782eb1a1220df3e0ee2076f0ff2da23b Reviewed-on: https://chromium-review.googlesource.com/c/1451982 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#629101}
-
Chris Palmer authored
Bug: 817982 Change-Id: Ice97de84ed3e45ea4c237e953a80a5817c5d53b4 Reviewed-on: https://chromium-review.googlesource.com/c/1372893 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This is a speculative fix for bug http://crbug.com/924449 to avoid using destroyed paint fragment in |NGPaintFragment::LastForSameLayoutObject()| by changing |LayoutObject::InsertedIntoTree()| to reset moved child layout object's assocated paint fragment list. From this patch, we reset associated fragment list for both fast and slow path in |LayoutObjectChildList::InsertChildNode()|. Bug: 924449 Change-Id: Iea1142ba5b91fb43a3c6a06e9bc3f45d03330e57 Reviewed-on: https://chromium-review.googlesource.com/c/1454164 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Certain bucket were overcounting because the directory, if empty, generates a random cache GUID during early initialization (while prefs, best case, would be empty). This means the metric needs to be instrumented closer to directory initialization code, which is now within SyncManagerImpl and requires distinguishing the two scenarios: either a random cache GUID was just generated (i.e. new directory started from scratch) or a previously existing cache GUID was reused (which is expected to match the value in prefs). Bug: 923285 Change-Id: Ibf008676dace251ba1599e08837eeb33b8d9d120 Reviewed-on: https://chromium-review.googlesource.com/c/1451894 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/576d82ee..22770bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie9662062130526125c7c1f903cd660757570316d Reviewed-on: https://chromium-review.googlesource.com/c/1452757 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f9db0f81173..f8840fffa6cc Created with: gclient setdep -r src-internal@f8840fffa6cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:926191 TBR=mmoss@chromium.org Change-Id: Iea14eee364a882cc3e5e1abf3bcb8dc1e3539e2b Reviewed-on: https://chromium-review.googlesource.com/c/1454421Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629096}
-
Stephane Zermatten authored
This change makes the current touchable area available to the UI code, through UIDelegate. It also renames UIController::UpdateTouchableArea to UIController::OnTouchableAreaChanged to be consistent with the other methods on UIController. The goal of this change is to make it possible to attach the UI to a new controller. This is a pure refactoring. It should not have any visible effect. Bug: 806868 Change-Id: Ifa6dca04d45071f73ce431bcadc36e58c37fe582 Reviewed-on: https://chromium-review.googlesource.com/c/1447872Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Sergio Villar authored
This reverts commit a83662e4. Reason for revert: Reverting to land it in two different CLs. The first one will include the migration, and the second one will include an small behavioural change. Original change's description: > Migrate FamilyInfoFetcher to use PrimaryAccountAccessTokenFetcher > > The FamilyInfoFetcher was creating an AccessTokenFetcher to fetch > access tokens for the primary account, and observing IdentityManager > to determine when a refresh token is available for the primary > account. That's exactly the use case PrimaryAccountAccessTokenFetcher > was designed for. > > Bug: 920965 > Change-Id: Iea6f47d64f2d4df170d023708ed7d3c8974caedb > Reviewed-on: https://chromium-review.googlesource.com/c/1421923 > Commit-Queue: Sergio Villar <svillar@igalia.com> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628373} TBR=blundell@chromium.org,svillar@igalia.com,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920965 Change-Id: I82c6f92d27334a84c10ffd2fb4fd8efe6d56414f Reviewed-on: https://chromium-review.googlesource.com/c/1454394 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#629094}
-
