- 12 Dec, 2018 40 commits
-
-
Chase Phillips authored
Bug: 717812 Change-Id: I4d69b9b5093df319f7c47df3c93794108a0bb451 Reviewed-on: https://chromium-review.googlesource.com/c/1364301Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615989}
-
Henrique Nakashima authored
Use COMPONENT_EXPORT instead. Change-Id: I8cebed14c3f4df0596fbc94edd9afd1840cf5603 Reviewed-on: https://chromium-review.googlesource.com/c/1370574Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Orin Jaworski authored
The default search engine (DSE) list is being refreshed from recently collected data. This CL is focusing first on countries for which a DSE list is already in place. Existing engine registrations will be kept intact, and only new engines are being added. The list of engine references for each country is being completely replaced based on new usage statistics, and unreferenced engine registrations are removed. Bug: 783890 Change-Id: Ie13eaa91d4a62eb581375f6dc00c556c7c536885 Reviewed-on: https://chromium-review.googlesource.com/c/1345542Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615987}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I443fe09079186ef8a2e2680efd6346b5f509b61c Reviewed-on: https://chromium-review.googlesource.com/c/1352780Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#615986}
-
Mrunal Kapade authored
Added checks for feature policy attribute. This fixes all feature policy related tests. BUG=862460,257511 Change-Id: I6258c41dcca164f7c6584ba4a387860237ca3ba3 Reviewed-on: https://chromium-review.googlesource.com/c/1343193Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Cr-Commit-Position: refs/heads/master@{#615985}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88faa6967431..64f62f4a179f git log 88faa6967431..64f62f4a179f --date=short --no-merges --format='%ad %ae %s' 2018-12-12 ynovikov@chromium.org Skip external texture ImageTest tests on Ozone Created with: gclient setdep -r src/third_party/angle@64f62f4a179f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:914146 TBR=jmadill@chromium.org Change-Id: I3cc29d028fe0efe458958a23e047d05268e30097 Reviewed-on: https://chromium-review.googlesource.com/c/1374039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615984}
-
Jun Mukai authored
This CL made a short-term fix for crostini app icons when SingleProcessMash is enabled. The observed problems are: - the terminal app icon has the spinner (rotating cycle) on launch, but the spinner doesn't disappear when the terminal is ready - other app icons (like gedit) create two app icons, one is the expected one and the other is the blank icon The terminal app is a chrome app (hosted by browser), however CrostiniAppWindowShelfController observes aura::Env in ash::Shell, thus it will fail to obtain Browser object. It needs to aura::Env in the browser. The blank icon is created by ash::ShelfWindowWatcher; to prevent this, kShelfItemTypeKey property needs to be set as ArcAppWindowLauncherController does. This is kinda hacky and does not work with multi-process Mash. We will eventually need a major refactoring around the shelf and the launcher. Bug: 905802 Test: manually Change-Id: If941bcc100160d3b5ff6e590032153000efc674a Reviewed-on: https://chromium-review.googlesource.com/c/1371144 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615983}
-
Manu Cornet authored
Bug: 882991 Change-Id: I952c5e9ed4d2153b50fb7cfb2bc15b4f7557b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1373809Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#615982}
-
Kim Paulhamus authored
Bug: 913881 Change-Id: I291167a9f707afe19709aabf212e01aed8d4e201 Reviewed-on: https://chromium-review.googlesource.com/c/1372911Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#615981}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/407a081da693..88f396963bc7 git log 407a081da693..88f396963bc7 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 tsepez@chromium.org De-duplicate rows in element-attributes table. Created with: gclient setdep -r src/third_party/pdfium@88f396963bc7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1082ed761f9d8c34ea74894384b62f39aae5afaf Reviewed-on: https://chromium-review.googlesource.com/c/1374137Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I8f6b7e62166de2d025f05cf4239686fed7a1d3ec Reviewed-on: https://chromium-review.googlesource.com/c/1353884Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#615979}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/149e7c6373d2..277cdb9bcc3e git log 149e7c6373d2..277cdb9bcc3e --date=short --no-merges --format='%ad %ae %s' 2018-12-12 yuzhao.zhang@intel.com Tab_Switching results calculation includes unwanted data Created with: gclient setdep -r src/third_party/catapult@277cdb9bcc3e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899174 TBR=sullivan@chromium.org Change-Id: I679895819692b4a5e2575a90527918dd4525c3f9 Reviewed-on: https://chromium-review.googlesource.com/c/1374040Reviewed-by:
-
Yi Su authored
After migrated to ChromeTableView, PasswordsTableViewController (use to be SavePasswordsCollectionViewController) displays less items in one screen, and testSearchPasswords has to scroll down to find all items which will hide the search bar. Then it will fail when trying to tap on search bar. This CL makes it scroll to top first and then tap the search bar. Change-Id: I08327f99043b26b426a0f41fdb32e578e93c3b74 Reviewed-on: https://chromium-review.googlesource.com/c/1373827Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615977}
-
Morten Stenshorne authored
At some point [1] it ceased to be a printing test, so it didn't really test anything useful. Make sure that we enter print mode, and turn it into a PNG test. Reduce the number of lines and use the Ahem font, to keep the PNG file sizes low. Mark the test as failing with LayoutNGBlockFragmentation. It used to pass because there was no block fragmentation involved in the test. [1] df18d7ad Change-Id: I5a17d76b53515975c90020bd37639f0af4563130 Reviewed-on: https://chromium-review.googlesource.com/c/1371868Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#615976}
-
Tom Anderson authored
Adds a fix for components/crash/content/tools/generate_breakpad_symbols.py which saw significant slowdown causing telemetry_unittests and telemetry_perf_unittests to timeout on the Linux Debug bot. On my machine, the time for this script to run is reduced from ~4m30s to ~6s. > Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so: > > $ ldd libfontconfig.so | grep freetype_harfbuzz > libfreetype_harfbuzz.so => not found > $ ls libfreetype_harfbuzz.so > libfreetype_harfbuzz.so TBR=dpranke R=thestig CC=mmoroz BUG=913070,911836,912366 CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_dbg_ng Change-Id: I94faed54a4ea9d50b8db38ca8c41b65d26e2bd5f Reviewed-on: https://chromium-review.googlesource.com/c/1371080Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615975}
-
Max Moroz authored
TBR=bpastene@chromium.org, inferno@chromium.org Bug: 701825, 911856 Change-Id: I205073ad7f85d770556fd570fa558ae52404f0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1374153Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615974}
-
Dominic Mazzoni authored
Bug: 911945 Change-Id: I64af0f02733e46bf1cd6df73d4ed0735d662c1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1364159 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#615973}
-
Jacob Dufault authored
Eliminates a dependency on test bases Bug: 912704 Change-Id: I30807d081cb790ff0f5c4c0873d75d9267c24b47 Reviewed-on: https://chromium-review.googlesource.com/c/1370908Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#615972}
-
Zinovy Nis authored
Minor fixes. Bug: None Change-Id: I2270516c27757bceb0e6b3e838ce2004f1d137eb Reviewed-on: https://chromium-review.googlesource.com/c/1356985Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615971}
-
jdoerrie authored
This change implements a navigation throttle for the Google Password Manager. Users that try but fail to access the Google Password Manager will be redirected to the local Chrome Password Settings page instead. Since this Google Password Manager integration is still experimental, this navigation throttle is guarded by the kGooglePasswordManager feature flag as well. Bug: 904821 Change-Id: If24d9ca04145d0e969bb34cb945a5a0607ec20c8 Reviewed-on: https://chromium-review.googlesource.com/c/1366442 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#615970}
-
Dana Fried authored
When a view changes size, it's important to call PreferredSizeChanged() so that its parent knows it might need to re-layout or repaint. The current code either fails to call PreferredSizeChanged() or instead lays out the current view in a couple of cases relevant to the toolbar, preventing us from using a consistent layout manager. This CL is a prerequisite for actually switching to a layout manager for the toolbar. Bug: 898632 Change-Id: I7154eb6ac58a11eca9069b25655a6c2666a704e0 Reviewed-on: https://chromium-review.googlesource.com/c/1372715 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#615969}
-
Clark DuVall authored
This change makes sure we save the clean exit value if the connection to the child process is lost. Bug: 911716 Change-Id: I9e0ac28e4ed18a3852fa157a4ce1295552d79bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1370644Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615968}
-
Sami Kyostila authored
The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call to Delegate::DoWork in the following scenario: 1. Start a run loop and schedule DoWork. 2. In DoWork, start a second run nested run loop which quits immediately. 3. After the nested run loop quits, schedule another DoWork which quits the original run loop. After step #3, the message pump would call DoWork again because the nested run loop triggered the execution of the nesting deferred work source. This patch fixes the issue by checking whether the further work is allowed before calling DoWork. Note that this check can't be done just for the nested deferred work source, because in the flow above that source is what triggers the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point. The patch also includes a fix to WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the following sequence in it (while a select menu is open): 1. Quit an outer run loop. 2. Post a task onto an inner run loop to continue the test. The assumption here was that a select menu causes an inner run loop to be active while the menu is open. This wasn't strictly correct: the inner run loop is a native (CoreFoundation) run loop as opposed to a base::RunLoop, which can't be explicitly exited with RunLoop::Quit(). This means that the Quit() in step #1 affects the same run loop as the PostTask in step #2, i.e., the task is prevented from running. This patch changes the test to only quit the test run loop after the posted task (which closes the select menu) has run. Bug: 891670 Change-Id: I6fe21289205664c4e1b1469547495667c753f56d Reviewed-on: https://chromium-review.googlesource.com/c/1373754Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615967}
-
Tommy C. Li authored
Previously, the UnapplySteadyStateElisions method had a wrong early exit for when ONLY the path was elided. This CL removes that early exit and replaces it with a more robust check. Bug: 912671 Change-Id: I1046d54c678a560f1562ff375aba134c1ad01627 Reviewed-on: https://chromium-review.googlesource.com/c/1372849Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#615966}
-
Lucas Furukawa Gadani authored
Bug: 908139 Change-Id: Ie328baa725217abe3dbbb144d166671f2933403b Reviewed-on: https://chromium-review.googlesource.com/c/1356004Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615965}
-
Navid Zolghadr authored
Reset last known cursor in RenderWidgetInputHandler upon receiving a mouse leave event so the very next set cursor command in this widget always sets the cursor. This change originally failed CursorUpdateReceivedFromCrossSiteIframe test and fixes were added to EventHandler to stop sending set cursor message when mouse is on a remote embedded iframe by the embedder. Bug: 899525 Change-Id: I0a7114bccc7c3087b4993a212e5d5a8c1b39a03b Reviewed-on: https://chromium-review.googlesource.com/c/1365085 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615964}
-
David Tseng authored
Bug: 622387 Change-Id: Idddd32bf271f28fb5d22cbef54b4250e636e2f6f Reviewed-on: https://chromium-review.googlesource.com/c/1372312 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615963}
-
Matt Wolenetz authored
With https://chromium-review.googlesource.com/c/chromium/src/+/1371020 landed, MSE pipeline_integration_fuzzers no longer appear to emit spurious gtest failure messages. However, the non-MSE (SRC=) media_pipeline_integration_fuzzer still emits such messages. This change narrows the close_fd_mask=1 libfuzzer option to no longer be used for the MSE fuzzers. It remains for the SRC pipeline_integration_fuzzer until the underlying spurious gtest messages are fixed. BUG=894460 TEST=Local build of MSE pipeline integration fuzzers does not produce options files, but SRC fuzzer still does. Change-Id: I1bcd642892fd909dbd1f9c639ae9a58cac4cad0f Reviewed-on: https://chromium-review.googlesource.com/c/1373034Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615962}
-
Michael Thiessen authored
Also handles a possible security exception when trying to grant permissions that chrome probably already has. Change-Id: I6c6ed7e35885ac4784e1f6b13c3bd9b16aaf9571 Reviewed-on: https://chromium-review.googlesource.com/c/1374390 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615961}
-
Eugene But authored
This callback is deprecated. Clients should use |TitleWasSet| to listen for title changes and |DidFinishNavigation| for |window.location.replace|. Bug: 720786, 546218 Change-Id: Ic8e0dbbb773b8943ddca3961440af553901aa799 Reviewed-on: https://chromium-review.googlesource.com/c/1372850Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615960}
-
François Beaufort authored
This is a reland of 28e9c18c Original change's description: > Add replay button to Picture-in-Picture window when video ends > > This CL makes sure there's a new replay button visible in the PiP window > when video ends. This icon comes from Material Icons library at > https://material.io/tools/icons/?icon=replay. > > https://i.imgur.com/I1n90tM.png > > Bug: 911620 > > Change-Id: Ibfcb96b9c69228ad74afe96ec00eb0e28d335ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/1360852 > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615846} Bug: 911620 Change-Id: I8d994d2feb32dd6b83185d9ec3fb44af0be5f977 Reviewed-on: https://chromium-review.googlesource.com/c/1374229Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#615959}
-
David Tseng authored
region: - make it read similarly to other containers cell: - include the name in the output format. Note we prioritize the cell index, so users would hear/in braille c1 cellname Test: manually (including in Docs with braille mode off). Change-Id: I93503f1d523a9aac09ac92298c38669fc8a3c222 Reviewed-on: https://chromium-review.googlesource.com/c/1372424 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Wez authored
Bug: 910670 Change-Id: Ieac8ffe1ebaf49c4faad10fc83791d384231ac32 Reviewed-on: https://chromium-review.googlesource.com/c/1372910 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615957}
-
Steven Bingler authored
OnDidLoadResourceFromMemoryCache calls new NotifyExternalCacheHit when network service is active as to properly update the cache with an external hit. Bug: 893323 Change-Id: Ia21b3441122a55d8eb5a8c7e508b4243ab500cda Reviewed-on: https://chromium-review.googlesource.com/c/1366435 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615956}
-
Takuto Ikuta authored
This is to pick up https://chromium.googlesource.com/infra/infra/+/25958d48e89e980e2a97daeddc977fb5e2e1fb8c Change-Id: I71d7e1ca56cf575cc37db4a3e2bdf5b1e02da0a7 Reviewed-on: https://chromium-review.googlesource.com/c/1374050 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f7831a8afd6..dfed8e9b27e3 Created with: gclient setdep -r src-internal@dfed8e9b27e3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I80d9a53db7027ae86eee734dde3cc506c53d159a Reviewed-on: https://chromium-review.googlesource.com/c/1374134Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615954}
-
Junbo Ke authored
Bug: None Test: CQ Change-Id: I41f3989df237c8ecce55c1d2ac503402c5f95dca Reviewed-on: https://chromium-review.googlesource.com/c/1355435Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615953}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff2d54966a03..38b36666a125 git log ff2d54966a03..38b36666a125 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 hjd@google.com Merge "trace_processor: Regression test for counter is null" 2018-12-12 fmayer@google.com Merge "fuzzing: Fix buffered_frame_deserializer_fuzzer for too large sizes." 2018-12-12 fmayer@google.com Merge "profiling: Add persist.heapprofd.enable." Created with: gclient setdep -r src/third_party/perfetto@38b36666a125 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaa1bb3c08beb55f35747383eb94fe12e711fadec Reviewed-on: https://chromium-review.googlesource.com/c/1374133Reviewed-by:
-
David 'Digit' Turner authored
See related bug entry for details. BUG=912117 R=nyquist@chromium.org, thildebr@chromium.org Change-Id: I7d1a46f84fe58c4b93a03b9445ae6902831d0538 Reviewed-on: https://chromium-review.googlesource.com/c/1373847Reviewed-by:
-
Wez authored
This is a reland of 0ed2b6ca Original change's description: > [Fuchsia] Generate more complete GN target names for FIDL packages. > > FIDL package names consist of multiple dot-delimited segments, to allow > scoping of packages to avoid clashes. Our GN generator script was using > only the final segment of each package's name, resulting in clashes, > e.g. between fuchsia.auth and fuchsia.modular.auth, if both were > present in the SDK. > > We continue to generate targets under the //third_party/fuchsia-sdk/sdk > namespace, but use the full name rather than only the final segment, > e.g. custom.modular.auth would become custom_modular_auth. > > We also special-case the top-level "fuchsia" namespace to be ignored, > e.g. fuchsia.modular_auth becomes just modular_auth. > > Bug: 910670 > Change-Id: I675d894c72b5d43b6d8b20fb026075573a5a3380 > Reviewed-on: https://chromium-review.googlesource.com/c/1372892 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615763} Bug: 910670 Change-Id: I2b7c5d766f5ee7cfe2d31b10f8410075efd52288 Reviewed-on: https://chromium-review.googlesource.com/c/1373276Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615950}
-
