GitLab

This CL removes the DCHECK in the popupMenuCoordinator in the callback
at the end of the presentation of the popup menu.
The DCHECK can be triggered by dismissing the popup menu before the end
of the animation.

Bug: 834957
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic507735290e56ab80b3ae7b9e9f74abf0ae35722
Reviewed-on: https://chromium-review.googlesource.com/1025096Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553095}

Supervised users are deprecated, and the corresponding SyncableService
implementations are already gone.
This CL adds a DEPRECATED_ prefix to the enum entries, and removes some usages
that aren't needed anymore. However, some uses are still required, e.g. the
pref mappings. I hope to fully remove the enum entries in a followup.

Skipping presubmit because of pre-existing failure (SU model type enum
entries not matching the model type name strings).
NOPRESUBMIT=true

Bug: 824756
Change-Id: Ic6ffd500e656719424f74fb92889270d1385301e
Reviewed-on: https://chromium-review.googlesource.com/1019404
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553094}

We shouldn't require clients to explicitly set that they can be
minimized. The default behavior for toplevel XDG surfaces is that
they can be minimized.

Note: The previous behavior was motivated by the lack of shelf icon
integration, and that making it less obvious how to restore the
window after minimizing it. This is not an issue anymore, with
shelf integration having been added.

Bug: 821498
Test: Caption for xterm in crostini has minimize button by default
Change-Id: I8a730d8e64dc104f990d70b0e147f182cc06e54d
Reviewed-on: https://chromium-review.googlesource.com/1024818
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553093}

Two functions do not call the assoicated Cocoa suffix properly.
It causes an infinity loop in the end.

Here is the original CL:
https://chromium.googlesource.com/chromium/src/+/007bca68b8905abeac9519c0809d039fc47f73a8

Please note that the CL above has been checked into M66. It was not caught by the QA
team as the code was disabled by the feature switcher.

Bug: 835758
Change-Id: I60f38199049fcf07f1767680f4287349152f1360
Reviewed-on: https://chromium-review.googlesource.com/1025047Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553092}

https://skia.googlesource.com/skia.git/+log/78fb04e69eae..af88ec371248

$ git log 78fb04e69..af88ec371 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 mtklein Revert "Add arcs as a specialized geometry to GrShape."
2018-04-24 csmartdalton Revert "ccpr: Don't preempt the convex path renderer"
2018-04-24 skcms-skia-autoroll Roll skia/third_party/skcms e492929..6a4194e (1 commits)
2018-04-24 mtklein Revert "call skcms_OptimizeForSpeed()"
2018-04-23 mtklein Revert "Reland "Exercise the threaded backend in test bots""
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms e8bc226..e492929 (1 commits)
2018-04-23 bsalomon Add arcs as a specialized geometry to GrShape.
2018-04-23 mtklein call skcms_OptimizeForSpeed()
2018-04-23 angle-skia-autoroll Roll third_party/externals/angle2/ 40786bdfc..b3474d9d7 (6 commits)
2018-04-23 liyuqian Reland "Exercise the threaded backend in test bots"
2018-04-23 liyuqian Fix variable name collision
2018-04-23 halcanary SkBitSet: make movable.
2018-04-23 brianosman Add skcms include directory for Android framework builds
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms fe14a6a..e8bc226 (1 commits)
2018-04-23 robertphillips Suppress BlurMaskBiggerThanDest on NexusPlayer for Vulkan
2018-04-23 jvanverth Revert "Remove ambient clamp hack for analytic shadows."
2018-04-18 csmartdalton ccpr: Don't call calcCubicInverseTransposePowerBasisMatrix
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms f1a2ba9..fe14a6a (1 commits)
2018-04-23 brianosman Enable skcms by default
2018-04-23 halcanary SkPDF: Don't forget to upcast before shift.
2018-04-23 liyuqian Clip the SkAntiRect because of possible tilings
2018-04-23 herb Generalize to SkDescriptorMap
2018-04-23 brianosman Use relative path to skcms GN file
2018-04-23 brianosman Fix deprecated constructor usage
2018-04-23 bungeman Add Transform section to viewer tools window.
2018-04-23 reed use SkRect::outset, as it clamps on overflow
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms 17d4b82..f1a2ba9 (1 commits)
2018-04-23 reed Rewrite CHECK_INTERSECT to perform the !(opposite) predicate, so that we return false if either argument is NaN.
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms 71966da..17d4b82 (1 commits)
2018-04-23 egdaniel Fixes in ReadPixels2 and yuv_texture gm to fix Vulkan validation issues.
2018-04-23 robertphillips Reland "Prevent masked solid-color draws from being turned into clears"
2018-04-23 robertphillips Disable BlurMaskBiggerThanDest unit test on ANGLE
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms c4941e8..71966da (1 commits)
2018-04-20 benjaminwagner Add SwiftShader Test jobs.
2018-04-23 bungeman Backspace opens slide picker (not paint) in viewer.
2018-04-23 brianosman Reject XYZ profiles missing some (or all) TRC tags
2018-04-20 scroggo (Mostly) respect FilterQuality in draw[stretchy]
2018-04-23 borenet [infra] Fast-forward recipes, re-enable roller
2018-04-23 robertphillips Revert "Prevent masked solid-color draws from being turned into clears"
2018-04-23 skcms-skia-autoroll Roll skia/third_party/skcms e658346..c4941e8 (1 commits)
2018-04-23 angle-skia-autoroll Roll third_party/externals/angle2/ 505ea1bb5..40786bdfc (3 commits)
2018-04-23 rmistry Remove Android compile bot from the CQ
2018-04-23 borenet Switch RecreateSKPs and Bookmaker bots to use service accounts
2018-04-23 borenet Remove UpdateMetaConfig bot
2018-04-20 robertphillips Disable threaded SW mask generation on DDL bots
2018-04-23 robertphillips Prevent masked solid-color draws from being turned into clears

Created with:
  roll-dep src/third_party/skia
BUG=chromium:835666,chromium:b/77917978


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I2d3ce75f62d13529ad35a13fa78a62e6da15c08e
Reviewed-on: https://chromium-review.googlesource.com/1025319Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553091}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=eugenebut@chromium.org

Bug: 825327
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibb41d632874e6c54c87755eee78a306f8be1fb0f
Reviewed-on: https://chromium-review.googlesource.com/1024766Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553090}

Also removed outdated FIXME.

Bug: 813068
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I93fbe971f2d3a419b2fdcd15512073d841ea1104
Reviewed-on: https://chromium-review.googlesource.com/1025712
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553089}

Previously, in Mash, Ash used an EmptyDraggableNonClientFrameView and
Chrome drew an AppWindowFrameView on top of that. Events went to the
former, which didn't know about caption buttons, and AppWindowFrameView
draws Windows-style caption buttons, so both appearance and behavior
were broken. (In classic Ash, Chrome uses a CustomFrameViewAsh.)

Now, in Mash, Chrome doesn't have a NonClientFrameView, but tells Ash
about the frame's colors via mus init properties. The Ash-process
CustomFrameViewAsh will be painted correctly and be able to handle
events.

Bug: 766712
Change-Id: Ic272e5755d0ac9af325b512bb0c3ccbe87fcb2c8
Reviewed-on: https://chromium-review.googlesource.com/1023036Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553088}

Support additional placeholders in ONC identity fields such as Identity
or Username:
- CERT_SUBJECT_COMMON_NAME: the ASCII CommonName of the selected client
  certificate (replaced when a CertPattern is used).
- DEVICE_SERIAL_NUMBER: the serial number of the device. Only replaced
  in DeviceOpenNetworkConfiguration.
- DEVICE_ASSET_ID: the Asset ID of the device. Only replaced in
  DeviceOpenNetworkConfiguration.

This CL also changes ONC identity field variable replacement to use
|VariableExpander| instead of custom code.

      chromeos_unittests --gtet_filter=ClientCertResolverTest*

Bug: 833426
Test: unit_tests --gtest_filter=*NetworkConfigurationUpdater* && \
Change-Id: I436792ea0115230554f9726d56288cae09e80d40
Reviewed-on: https://chromium-review.googlesource.com/1016920
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553087}

As stated in message_loop_current.h, |MessageLoopCurrent::IsSet()|
should be preferred to checking the return value of
|MessageLoopCurrent::Get()|.

Bug: 825327
Change-Id: I90bf74dd9929eeb946e8e2e3ee1ac2e9f093a938
Reviewed-on: https://chromium-review.googlesource.com/1025770Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553086}

TBR=tandrii@chromium.org

Bug: 731978
Change-Id: Idbd56255a33cd7fa2d14d27c4ba0847893c94257
Reviewed-on: https://chromium-review.googlesource.com/1025326Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553085}

This is flaky on all platform

TBR=clamy@chromium.org
NOTRY=true

Bug: 836220
Change-Id: I13265c5d90e7297a004ccb75607419d60b4dd10e
Reviewed-on: https://chromium-review.googlesource.com/1025128Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553084}

This change has some pros and some cons:

Pros:
- Human readable ExecType in patch/hex dumps as the ASCII is meaningful.
- Can be done at next to no cost at compile time.
- Assigning new values regardless of order of appearance in the enum is
  more flexible. No more concern over invalidating old patches as values
  will be more or less permanent once this change goes in.

Cons:
- Checking if an ExecutableType is valid requires O(n) time where n
  is the number of supported Exec types using a cast.
  Alternatively, we could maintain a sorted list of these types in
  memory to check against in O(log(n)) or could use a set
  but this is more memory. Overall not a huge deal since we only support
  ~9 types but it is worth understanding the tradeoffs.
- Enums don't enforce value reuse so it is possible although highly
  unlikely we introduce a repeated value. However, given the use of the
  switch case casting requiring unique values this is very unlikely.

Bug: 834932
Change-Id: I7bc14ea7b4434e60bb0dafa47178fb2c2c12dc7f
Reviewed-on: https://chromium-review.googlesource.com/1020446
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553083}

I applied modernize-use-override in blink/renderer/core
http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html

Bug: 428099
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3ce2ca968d5f8beee68620d3e9f4421e99008807
Reviewed-on: https://chromium-review.googlesource.com/1025494
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553082}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 825327
Change-Id: I0da1a35816b422a01b88ae1dac4b2f4c400e8aee
Reviewed-on: https://chromium-review.googlesource.com/1024285Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553081}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=kpschoedel@chromium.org

Bug: 825327
Change-Id: Ie381e306bf1ea665a24180ac51c881a220875f3b
Reviewed-on: https://chromium-review.googlesource.com/1024471Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553080}

NewPasswordFormManager (details go/new-cpm-design-refactoring) needs
to find best matches. This CL implements new best matches finding
algorithm, that will be used for now by both PasswordFormManager
and NewPasswordFormManager.

Scoring algorithm is greatly simplified. All that we need to compare
matches is PSL/non-PSL match, preferred/non-preferred.

Since now algorithm of finding best matches is in separate function,
we can test it. So tests were written.

Bug: 831123
Change-Id: I543aa185e489777007c0c19bcc5924f9964696b6
Reviewed-on: https://chromium-review.googlesource.com/1023936
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553079}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 825327
Change-Id: I1b445eb50f48bfd9e52cc13458f936b251fdd47f
Reviewed-on: https://chromium-review.googlesource.com/1024373Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553078}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug: 825327
Change-Id: I0c0e770c71f5b7082cb5aa15fe12108f1fea861f
Reviewed-on: https://chromium-review.googlesource.com/1024441Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553077}

Bug: 817377
Change-Id: I50b7cebc5e9fa32bec2a48c343731bc133261c47
Reviewed-on: https://chromium-review.googlesource.com/1015502Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553076}

TBR=clamy@chromium.org
NOTRY=true

Bug: 836215
Change-Id: I43d5372cead82d285da6089dc5adbfaaa2857d80
Reviewed-on: https://chromium-review.googlesource.com/1025324
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553075}

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/extensions/api/settings_private

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug: 825327
Change-Id: Ib40cfbf453b9a9f5926ea92e7711b3732b365021
Reviewed-on: https://chromium-review.googlesource.com/1024372Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553074}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=kmackay@chromium.org

Bug: 825327
Change-Id: Ic2d81d1bc53eac58a69f323c8ef4820defc8af93
Reviewed-on: https://chromium-review.googlesource.com/1024473Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553073}

TBR=clamy@chromium.org
NOTRY=true

Bug: 836211
Change-Id: I3049e37717dce84ee9f4692210391c1d3eeb7c74
Reviewed-on: https://chromium-review.googlesource.com/1025323Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553072}

This CL adjusts the navigation menu items to look like the mocks.

Bug: 804778
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3d4b45196207e98187af64cac25a6d7cf7309f90
Reviewed-on: https://chromium-review.googlesource.com/1025752
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553071}

[CallWith=ThisValue] is obsolete from the beginning and only used at
Location's valueOf(), which must be implemented in the way of
https://html.spec.whatwg.org/multipage/history.html#the-location-interface

No need to support it in IDL callback interface, and it's actually not
supported now.

Change-Id: I3546f78a68fb2b335950d3848b6c4b51628cc505
Reviewed-on: https://chromium-review.googlesource.com/1025153Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553070}

Serialize the ServiceWorkerFetchRequests and store them with the metadata.
Store Pending Requests (all requests are pending initially), and add
util functions to query pending/active requests.

Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/

Bug: 826257, 757760
Change-Id: Ic3aa98106583e9273e5f93b53123b2e2f1067cd9
Reviewed-on: https://chromium-review.googlesource.com/1017101
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553069}

TBR=nednguye@google.com
NOTRY=true

Bug: 834905
Change-Id: Ie5a2736ca742071d1338ae1a28c025ef113c9786
Reviewed-on: https://chromium-review.googlesource.com/1025657Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553068}

Server card fetching requires that ChromeAutofillClientIOS returns
a valid sync_service.

Bug: 825319, 535784
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic59cfd5fba28f0fa3721806bcfbfc91829f75445
Reviewed-on: https://chromium-review.googlesource.com/1023930
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553067}

Also rearrange method order a little and rename HandleMetrics to
DispatchMetrics, as there's no need to pass the metrics map to the
method.

R=chrisha@chromium.org

Bug: 755840
Change-Id: If316817f540315bf8c0465d1d32be60734183db6
Reviewed-on: https://chromium-review.googlesource.com/1019563Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553066}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=manzagop@chromium.org

Bug: 825327
Change-Id: I6fb6356e6c0b8dded0c990bca7c15012d757405d
Reviewed-on: https://chromium-review.googlesource.com/1024390
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553065}

This CL disables
SitePerProcessBrowserTest.ScrollBubblingFromOOPIFWithBodyOverflowHidden
which is flaky on linux-chromeos-rel.

TBR=xidachen@chromium.org, nasko@chromium.org
NOTRY=true

Bug: 836200
Change-Id: If6bd9bad4d852eebfe4fe277f420854b228ed5a4
Reviewed-on: https://chromium-review.googlesource.com/1025694Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553064}

Fixed on issue 831074 issue 804413 issue 829310.

Tbr: yamaguchi-san
Bug: 835794,690983
Change-Id: Ia92b6e5a096760c747ebb20802dc59f07f918ea5
Reviewed-on: https://chromium-review.googlesource.com/1025850Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553063}

BUG=605605

Change-Id: I22f0c4a6fe06ec3d76359f2559e532e155c53815
Reviewed-on: https://chromium-review.googlesource.com/1014677
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553062}

This CL disable to extensions browser_tests that are flaky on ChromeOS
MSan bots.

TBR=thestig@chromium.org, xidachen@chromium.org
NOTRY=true

Bug: 836188
Change-Id: I0579a0129291a82a0818b31046cd946a469abd02
Reviewed-on: https://chromium-review.googlesource.com/1025755Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553061}

In QUIC, use bit 0x08 of each packet's first byte to demultiplex Google QUIC and IETF QUIC. Not protected.

Make QUIC_VERSION_99 be able to build/process IETF QUIC packet header format.

Merge internal change: 193045984

R=rch@chromium.org

Change-Id: Icb282bd79239c824ee1f3ad1db5aed90023646df
Reviewed-on: https://chromium-review.googlesource.com/1024772Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553060}

Autofill and password autofill uses IsFocusable to approximate
visibility of form fields, as long as Blink is done rendering the page
and triggering a layout in order to compute visibility is acceptable.

Triggering a layout is not acceptable when Blink is about to render the
page. See https://crbug.com/595078 for past issues with this.

When triggering a layout is not acceptable, the variable
g_prevent_layout is set to true and computing visibility for
(non-password) autofill in WebFormControlElementToFormField is given up,
assuming all fields are potentially visible.

Password autofill used a different path to compute visibility for the
form fields, querying IsWebElementVisible. This has historically used
HasNonEmptyLayout at all times, but then switched to using IsFocusable
when triggering a layout was acceptable (see
https://codereview.chromium.org/2769023003). Calling HasNonEmptyLayout
remained to minimize the change in behaviour, leading to the puzzling
situation when a function clearly triggering a layout was called when
layout should not be triggered.

While the latter never seemed to produce crashes as seen in
https://crbug.com/595078, it is a potential landmine, and likely
unnecessary, given that the data it provided needed improvement in the
form of IsFocusable anyway.

Therefore this CL stops calling HasNonEmptyLayout from
IsWebElementVisible. It also extends a visibility-related test to
check IsWebElementVisible and two scenarios based on prevention of
layout.

Bug: 833838
Change-Id: I6aedca91ff0369c541891c96336125dff9adeac0
Reviewed-on: https://chromium-review.googlesource.com/1021573Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553059}

New profiles' last selected file directory was left uninitialized, and
hence the first file open was done in the last OS selected directory.
This created unpredicted behavior for new profiles, and could cause
leakage of the last folder used in incognito mode.
User's home directory is now set as the default value for it.

Bug: 659632
Change-Id: I91e49e7152bda9abe26ff97ece12f08f9805c8de
Reviewed-on: https://chromium-review.googlesource.com/1023401
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553058}

This test relies on the typing shield tap, but on phones the typing
shield is not available when some suggestions are shown. With
zero suggest, there are some suggestions in the popup.

Use cancel button to close omnibox on phones instead.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie01c78c86cd9a7baa6d25391142bdcdbe89533a1
Reviewed-on: https://chromium-review.googlesource.com/1025095Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553057}

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chrome_browser_main_android.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=bauerb@chromium.org

Bug: 825327
Change-Id: Ia10a44445d3e9b765511fda5e1135afc0d32a338
Reviewed-on: https://chromium-review.googlesource.com/1024710
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553056}