- 26 Nov, 2018 40 commits
-
-
Hiroki Nakagawa authored
As a preparation of PlzDedicatedWorker, this CL makes browser-side loader classes for PlzSharedWorker reusable for PlzDedicatedWorker. Specifically, this CL introduces WorkerScriptFetchInitiator that is a static class to abstract SharedWorkerScriptFetcher and SharedWorkerScriptLoader. This doesn't change functional behavior. WorkerScriptFetchInitiator is now used only by SharedWorkerServiceImpl, but it will also be used by DedicatedWorkerHost in a follow-up CL. Next plan: Rename SharedWorkerScriptFetcher and SharedWorkerScriptLoader to WorkerScriptFetcher and WorkerScriptLoader respectively, and remove shared worker specific code from WorkerScriptFetchInitiator. See the design doc for details: https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing Change-Id: Iae37ebb8fec6f0843df4c11fac8c9d8abe5b6667 Bug: 906991 Reviewed-on: https://chromium-review.googlesource.com/c/1345704 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610790}
-
Rune Lillesveen authored
FindIt analysis says this is because of harfbuzz roll: https://crrev.com/c67f53b0b TBR=drott@chromium.org Bug: 908276 Change-Id: Iebf1efc0f0f462d8d8f5c967b62c8056586835b1 Reviewed-on: https://chromium-review.googlesource.com/c/1350178Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610789}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9103e90f6e6..7284f296f47b Created with: gclient setdep -r src-internal@7284f296f47b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2d4cd933d276f5220e2c3d1eef57bcaf40040341 Reviewed-on: https://chromium-review.googlesource.com/c/1350572Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610788}
-
Matt Falkenhagen authored
Callsites must use UpdateURLs() instead to ensure dependent state is updated. Replace the getter with url(), which makes more sense for all provider types. Bug: 908311 Change-Id: I4741225a0aec82f150d906f0f8f1736ac0097705 Reviewed-on: https://chromium-review.googlesource.com/c/1350021 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610787}
-
Kouhei Ueno authored
Bug: 863305 Change-Id: Id6d4a4fe4fce240972af183b3b5d2921cff4e51b Reviewed-on: https://chromium-review.googlesource.com/c/1350442Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#610786}
-
Kent Tamura authored
Remove 'LayoutTests' in testing code, comments, documents, and OWNERS in files other than third_party/blink/web_tests. This CL doesn't change symbol names in source code. This CL doesn't have any behavior changes Bug: 843412 Change-Id: I6eeda7b12ba3e484dff7559d21a9c13a3214795f Reviewed-on: https://chromium-review.googlesource.com/c/1350372Reviewed-by:
-
Shik Chen authored
BUG=b:118418065,b:118415374,b:64996728,b:77833131 TEST=Check the result of getUserMedia() matches the external camera in settings 100 times when Video Capture Service is not running. Change-Id: If83b5b3070724321b3524903505c98e6391a2dea Reviewed-on: https://chromium-review.googlesource.com/c/1347961Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#610784}
-
Makoto Shimazu authored
Bug: 906542 Change-Id: I1b33376d5e07ed1725e3a5760d32a2837b4b83b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345702Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610783}
-
Kunihiko Sakamoto authored
This patch renames "srcset" and "imgsizes" attributes on link to "imagesrcset" and "imagesizes" respectively, to match the latest spec PR [1]. Note: this feature is behind experimental-web-platform-features flag. [1] https://github.com/whatwg/html/pull/4048 Bug: 813452 Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1 Reviewed-on: https://chromium-review.googlesource.com/c/1350414Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fce137b1e13..c9103e90f6e6 Created with: gclient setdep -r src-internal@c9103e90f6e6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic0e199d7f64daba2fc2c2a4acada35a7d064fe01 Reviewed-on: https://chromium-review.googlesource.com/c/1350571Reviewed-by:
-
Matt Falkenhagen authored
Make callers use UpdateURLs instead. Bug: 908311 Change-Id: I1689c8670dc2c03f325500be24dcdde9a88586a0 Reviewed-on: https://chromium-review.googlesource.com/c/1350419 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Adam Rice authored
Change-Id: Iba151bf31367c06c94311402a9fc550d7bb87a6d Reviewed-on: https://chromium-review.googlesource.com/c/1350550 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Bug: 565837 Change-Id: I392128332981dd9d282648f6d4fa8ab3392188b1 Reviewed-on: https://chromium-review.googlesource.com/c/1347045 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#610778}
-
Alan Cutter authored
This CL makes Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnSync and Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnCreate ignore data: URLs which have no HTTP status code. Bug: 901552 Change-Id: I5a7ec6f9300c0b91668e9994b769073a638aff5b Reviewed-on: https://chromium-review.googlesource.com/c/1317213 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610777}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2871509751ab..bc97432f4f93 git log 2871509751ab..bc97432f4f93 --date=short --no-merges --format='%ad %ae %s' 2018-11-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@bc97432f4f93 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ie065cd646a2323400135b9f54220d1f1eccb0779 Reviewed-on: https://chromium-review.googlesource.com/c/1350570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610776}
-
Matt Falkenhagen authored
This aligns with ResourceRequest's naming, which is where the value comes from anyway. Note that ResourceRequest documentation states site_for_cookies is "usually" the topmost frame URL. This also allows the getter function to be called for service worker execution contexts. This simplifies some code at the callsite. Bug: 908311 Change-Id: Ief92f49d439e1219a6a33a7bafb03371d514b6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1350415Reviewed-by:
-
Tao Bai authored
Only log package name if app is system app or installed from playstore Bug: 902008 Change-Id: I934cd148a074078516ecc8f64a8b57e76e25ef53 Reviewed-on: https://chromium-review.googlesource.com/c/1343515 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610774}
-
Sam McNally authored
Previously, selected files overlapped the files-toast; they have a adjustable splitter between the directory tree and the files list was also in front of the toast with a z-index: 500. The search autocomplete suggestions have z-index: 550 and the toast should not overlap it so pick a number in between: 520. z-index: 2, but files-toast did not set one. Additionally, the Change-Id: I307730c4287472963f0aa249dfce779f5202e4d3 Reviewed-on: https://chromium-review.googlesource.com/c/1350551Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b09b5e19aba..0fce137b1e13 Created with: gclient setdep -r src-internal@0fce137b1e13 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I85b02ff723d3f2605308eeac3c21bd8c535eb154 Reviewed-on: https://chromium-review.googlesource.com/c/1350569Reviewed-by:
-
Luciano Pacheco authored
Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads folder: "" when MyFilesVolume is disabled, which means Downloads is the root; "/Downloads" when MyFilesVolume is enabled, which means that Downloads it's a folder at root. Change tests that uses entry.fullPath to prefix with RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag MyFilesVolume. Enable some tests to run with flag MyFilesVolumeEnabled which were failing before this CL. NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with /Downloads will be in-lined when MyFiles as Volume is fully rolled out. --gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*" --gtest_filter="CreateNewFolder/FilesAppBrowserTest*" Test: browser_tests Bug: 873539 Change-Id: I72f6dc314e50103c3cadf2299f582dcf84f4d9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1350019Reviewed-by:
-
Robert Liao authored
Adding support in ui::Accelerator::GetShortcutText fixes this test. BUG= Change-Id: I93dea9bcf2c662a4d63d3d4afab1f9c43fca039c Reviewed-on: https://chromium-review.googlesource.com/c/1345072Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2738b58bef32..8b09b5e19aba Created with: gclient setdep -r src-internal@8b09b5e19aba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3338acda288240a0ce776fe234a0e02cfe141723 Reviewed-on: https://chromium-review.googlesource.com/c/1350283Reviewed-by:
-
Sam McNally authored
Bug: 896123 Change-Id: I3b1e7e8d9c189f21ec767958a1d8afb609448c00 Reviewed-on: https://chromium-review.googlesource.com/c/1350385Reviewed-by:
-
Kunihiko Sakamoto authored
As per the Loading Signed Exchanges spec [1], this patch makes SignedExchangeEnvelope::Parse() fail if the exchange's request method is not "GET". [1] https://wicg.github.io/webpackage/loading.html#parse-cbor-headers Bug: 803774 Change-Id: I4729403f3dae5038bae702b0359e1b98f9a11233 Reviewed-on: https://chromium-review.googlesource.com/c/1350017Reviewed-by:
-
Sam McNally authored
Bug: 896123 Change-Id: I0bb79920cea7aa6a8223d226efdfda2b3fd903eb Reviewed-on: https://chromium-review.googlesource.com/c/1350437Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "element-attribute-js-null.html" to utilize w3c test harnes for ease of maintenance and avoid timeout for dumping result. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText Change-Id: I4c29ac2de838556b617dddd667a55328bbb6db61 Reviewed-on: https://chromium-review.googlesource.com/c/1345688 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#610765}
-
Dean Liao authored
V4L2ImageProcessor::Create() has input_memory_type and output_memory_type parameters of type v4l2_memory. In order to have a generic ImageProcessor factory method, we use StorageType to replace v4l2_memory. Also, since V4L2ImageProcessor supports both allocate and import output mode, and for a storage type (e.g. STORAGE_OWNED_MEMORY), its v4l2_memory mapping is V4L2_MEMORY_MMAP for allocate mode and V4L2_MEMORY_USERPTR for import mode. We have to pass output_mode to v4l2 IP factory till all its users move to use import mode. BUG=b:73752373, chromium:907767 TEST=TEST=Run VEA VDA unittest on devices (peach_pit and elm) VEA: video_encode_accelerator_unittest \ --test_stream_data=bear-320x180.yuv:320:180:1:bear.mp4:100000:30 \ --disable_flush --single-process-tests -v=0 VDA: video_decode_accelerator_unittest \ --test_stream_data=/usr/local/video/test-25fps.h264:320:240:250:258:\ 35:150:1 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm Change-Id: I60f8eeea937dc6566cf844a8a74069711c29f5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1341739 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#610764}
-
Sam McNally authored
getDriveConnectionState, getPreferences and setPreferences can never fail, yet log when they succeed. This logging is noisy and distracts from logging of other API calls so remove it. Bug: 896123 Change-Id: I75f079a941df47c55bb7cbcbd8292b125f6472e6 Reviewed-on: https://chromium-review.googlesource.com/c/1350016Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I75311504af7074dafacc5a96ad1760ba2597f5e7 Reviewed-on: https://chromium-review.googlesource.com/c/1350205Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#610762}
-
Koji Ishii authored
Following bot results are included. 12040 12044 12046 12048 12049 12052 12056 12060 12061 12063 12066 12070 12077 12083 12085 12088 12090 12091 12092 12098 12099 12100 12101 12103 5 lines were removed and 3 lines were deflaked by consecutive results since 12077. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I3482790673360808065facd36bac13cef49051a7 Reviewed-on: https://chromium-review.googlesource.com/c/1347963 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610761}
-
Noel Gordon authored
It is instantiated in media_import_handler_unittest, but never used. Bug: 908290 Change-Id: Ic3e522ec2a4e14b4fc81a6443d77aa1a7622e70f Reviewed-on: https://chromium-review.googlesource.com/c/1350013 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610760}
-
Keishi Hattori authored
This reverts commit 0a5685cf. Reason for revert: crbug.com/908297 Looks like LSAN spotted a leak around CloudExternalDataManagerBase Original change's description: > Fetch External Policy for Device Settings. > > Add support for External Data referenced by Device Policy. > Use the new support to implement the DeviceNativePrinters policy. > Add browser test verifying external data cache is cleaned up after policy was changed or removed. > > Bug: 807068 > Change-Id: Ib98778a438e929a78214d1d9ab066a41a6bdcf09 > Reviewed-on: https://chromium-review.googlesource.com/c/1335592 > Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610596} TBR=emaxx@chromium.org,skau@chromium.org,poromov@chromium.org,nikitapodguzov@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807068 Change-Id: Id4748ce53ded280f54b02c0dc85c23fe6fd41975 Reviewed-on: https://chromium-review.googlesource.com/c/1350435Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610759}
-
Alan Cutter authored
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368714&signed_aid=jxynzMCcaUtxgGB-6k_3_w==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368715&signed_aid=lXnbrTuQdIjEmsYnpGspxA==&inline=1 Bug: 907339 Change-Id: I8ed455084acc4d85f96ecbd3e124c13773bf3e25 Reviewed-on: https://chromium-review.googlesource.com/c/1349136 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#610758}
-
David Staessens authored
This change splits up the test helpers target in separate encode, decode and other helpers. Tests now only depend on what they actually need. This change doesn't introduce any new code, but some things are moved to avoid weird dependancies (such as encode helpers depending on frame mapper which depends on decode helpers). This change also moves code in the video_accelerator_unittest_helpers.h file from the media to the media/test namespace. TEST=ran video/jpeg encode/decode tests on nocturne CQ-DEPEND=CL:1345670 BUG=879065 Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50 Reviewed-on: https://chromium-review.googlesource.com/c/1345701Reviewed-by:
-
Rob Schonberger authored
Change-Id: I04bbedd2317b7f695fbae52779250d228d9f43b9 Reviewed-on: https://chromium-review.googlesource.com/c/1260805Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610756}
-
Dean Liao authored
BUG=None TEST=pass VEA unittest Change-Id: Ica9a10a81ca584991945dd03ca733e3a399a999a Reviewed-on: https://chromium-review.googlesource.com/c/1348151Reviewed-by:
-
Stuart Langley authored
Tbr: rkc Bug: 902882 Change-Id: Ia4f1b162ddc3118de6c992aabf8278e05be2bf22 Reviewed-on: https://chromium-review.googlesource.com/c/1348882 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
WindowClient.navigate() and Clients.openWindow() were implemented in a way that directly navigated to the URL without going through some checks that the normal navigation path goes through. This CL attempts to fix that: - WindowClient.navigate() now goes through Navigator::RequestOpenURL() instead of directly through WebContents::OpenURL(). - Clients.openWindow() now calls more ContentBrowserClient functions for manipulating the navigation before invoking ContentBrowserClient::OpenURL(). Bug: 904219 Change-Id: Ic38978aee98c09834fdbbc240164068faa3fd4f5 Reviewed-on: https://chromium-review.googlesource.com/c/1345686 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
AMR files begin with "#!", which looks like a shell script, which causes the primary sniffer to think the file is plain text. Re-sniff using the expanded types sniffer to properly detect the file as AMR. BUG=813059 Change-Id: Ic4843ce0773a0cba028dde7f134ad32215cacd5d Reviewed-on: https://chromium-review.googlesource.com/c/1349129 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Use appropriate types where necessary. BUG=879657 Change-Id: Ib20ac7132628cfaac37a57059be3c894f3fc41c2 Reviewed-on: https://chromium-review.googlesource.com/c/1349467Reviewed-by:
-
