- 14 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/703f21e21747..c603339365fb 2021-01-14 tikuta@chromium.org autoninja: use pure python for ninjalog_uploader_wrapper.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I270831aeeaaa375d1fceca847ff249ff22ef70ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a42f3312f5e..c0dfd5b48e14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: Ieed082557dda81b75a0ae1b31649540b6ed30382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625943Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843468}
-
Daniel Hosseinian authored
Document properties isn't ready to ship since some property values are still missing. Placing behind a feature flag for now that can be enabled on chrome://flags. Bug: 93619 Change-Id: I064ac07972d58d244a84905bf4a21896978c7f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628038 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843467}
-
Anton Bikineev authored
In case giga-cage is enabled, for 64bit we can use a bitmap of super-pages to quickly validate during scanning if a super-page is valid. The bitmap must consist of only super-pages that correspond to the roots that have PCScan enabled. The CL also makes sure that the IsGigaCageEnabled() check is not performed for each word/scan-range/super-page. To achieve that, it templatizes scanning routines based on giga-cage presence. Having the functions parameterized by policies makes sure that there are no hidden performance costs (e.g. indirect calls). This improves scanning time on cnn:2020 by ~20%. Bug: 11297512 Change-Id: I15226e0bfdf3f6d48c39421f4f54cf1aa5bafb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624677 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#843466}
-
Keishi Hattori authored
When we use BackupRefPtr for AudioOutputDevice::callback_, it detects a dangling pointer being assigned to it. This is because, RenderCallback can be destroyed by the time InitializeOnIOThread gets called on the io thread. This CL adds a check for stopping_hack_ so we won't assign, when Stop() has already been called. Bug: 1154812, 1080832 Change-Id: Icb02ed9661ebcd2c0ee8c81888bc68c3d1af83a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575481 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#843465}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I2382ff5f7489346e591e3f5466352ff6190e16c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626445Reviewed-by:
-
Irem Uguz authored
Add Observer to net::CertDatabase in certificate_manager_model CertsSourcePlatformNSS to observe the changes in the CertDatabase and Refresh whenever there is a change in the database to solve the bug. Update the tests accordingly. Bug: 1146607 Change-Id: I3b9ba7f64cf47333cb79430c6a060620290e8f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601748Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#843463}
-
Eric Seckler authored
Change-Id: I4cfb20bd12e93c84bddb0ff7920e718c0fc03fc4 No-Try: True Tbr: wenbinzhang@google.com Bug: 1166558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626299Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#843462}
-
Andy Paicu authored
This reverts commit 6e03dcb5. Reason for revert: crbug.com/1166565 Original change's description: > CCA: Use calculated default window size > > The calculation of default window size is based on fixing width to 764px > in all preview aspect ratio cases(3:4, 4:3, 9:16, 16:9) and deriving > height from that fixed width so that after preserve space for left, > right, bottom icons(--xxx-line*2), the |#preview-box| can fit in preview > aspect ratio as close as possible. After these, the new default window > size under different preview aspect ratio will be: 3:4 -> 764x888; 4:3 > -> 764x552; 9:16 -> 764x1144; 16:9 -> 764x444. Also change the minimal > window width x height to 486 x 444 accordingly. > > Bug: b/175324385 > Test: Manually verify default window size under 3:4, 4:3, 9:16, 16:9 > preview. > > Change-Id: Ic4c569819f29b813029f478e6920f66453ab4792 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615730 > Reviewed-by: Shik Chen <shik@chromium.org> > Commit-Queue: Inker Kuo <inker@chromium.org> > Auto-Submit: Inker Kuo <inker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843399} TBR=shik@chromium.org,inker@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ia46d3467a098d2682113795d5ddde2df1b016722 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/175324385,1166565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626666 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843461}
-
Viktor Semeniuk authored
This change syncs local Compromised credentials. Bug: 1137775 Change-Id: Icb137b171d8caa3e8c2988b60a201b581140e067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593618 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#843460}
-
Dominic Mazzoni authored
Originally landed: crrev.com/c/2602697 Reverted: crrev.com/c/2618674 Reverted due to new test SnapshotAXTreeBrowserTest.Timeout being flaky. Re-landing with the test disabled, then I'll upload a change to try to re-enable and fix the flakiness. WebContents::RequestAXTreeSnapshot is used for several things, including supporting Assistant on Android and Chrome OS, generating tagged PDFs, speaking the text of a page on macOS, and determining the page language for Translate. On Android, requests are timing out on large pages; Assistant wants results in 3 seconds. This change adds additional parameters to RequestAXTreeSnapshot to enable it to run faster, by limiting the number of nodes, excluding offscreen nodes, and returning partial results after a timeout elapses. This change adds test coverage but does not change any code to use these new parameters, so there shouldn't be any side effects of landing this patch. A follow-up will change the Android callers to pass different parameters. Bug: 1161541 Change-Id: Ie8de84d11b05b297b3c8b7869a76dbd0b07ce5f6 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622002Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843459}
-
Gyuyoung Kim authored
As a pre-work to convert the context menu IPC messages, this CL renames context_menu_data.mojom to context_menu.mojom. The converted IPC messages will be added to the renamed Mojo file. Bug: 1093904 Change-Id: Ic5bfbc0a637cd3b01b2e576cfcca9e239d881732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626819Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#843458}
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. This change is split into multiple CLs. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. Bug: b/175786074 Change-Id: I73580416d039a14abe7b91ecad50f4f8cecc8682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596259Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#843457}
-
Andy Paicu authored
This reverts commit 1c92b3fd. Reason for revert: crbug.com/1166551 Original change's description: > Add custom message related fields to content analysis dialog > > Bug: 1166369 > Change-Id: I32459ec22d8a4a6bd57d8ae0a17a3850a365fc57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625914 > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843330} TBR=anthonyvd@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,domfc@chromium.org Change-Id: Ibdb66dfcb4e267c61eefaaa48ac5a2aefdd8ba16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166369,1166551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628949 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Wojciech Bielawski authored
Python3 map, filter returns generator object. In some places generators must be wrapped with list to allow reuse of result. In other to allow concatenation. Bug: 1164344 Change-Id: I00813ff95c73f3e25f18d7bab08e2704af948664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617846Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. This is a follow up CL that allows usage of policy enforced update URL in management_api.cc Bug: b/175768136 Change-Id: Iae334e3a50b9398664c1ac23fb7f65ee1833a289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592803Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#843454}
-
Andy Paicu authored
This reverts commit 50ba4848. Reason for revert: crbug.com/1166548 Original change's description: > [Extensions] Clean up use of kFlagEnableFileAccess. > > Prior to this CL, the default was that test extensions were loaded > with file access enabled. This is not necessary, and doesn't reflect > the real world, where most APIs work without needing file access. > > With this CL, the default is that a test must explicitly request > file access for the extension. To reflect this, some member functions > have been renamed and their behavior modified so that it's clear > that the test is requesting file access. > > This also fixes the PermissionsApiTest.OptionalPermissionsFileAccess > test, which had incorrect embedded extension IDs. > > Bug: 1163548 > Change-Id: Ib0f80b0448f49628488074082bfd54486dde3aef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613306 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: David Bertoni <dbertoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843401} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,dbertoni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I7250d8a4f8903c296d25471e8518b34167d8a192 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163548,1166548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628988 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
David Jean authored
UIApplicationDidChangeStatusBarOrientationNotification is deprecated in iOS 13. Instead the BVC method viewWillTransitionToSize:withTransitionCoordinator: Set the orientation for crash_keys and notifies the CrwWebController of orientation/size change. Bug: 1131852 Change-Id: Ia2b26e8aa9b8e58d0e5a4401f2a4049b221f599b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620263Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#843452}
-
Hassan Talat authored
This CL moves the ShareError enum def to its own file so the macOS impl (upcoming CLs) can import it in components//remote_cocoa without having to import the other definitions Bug: 1144920 Change-Id: I1f60916facdc34ce67aeb7ecec03e3795278d6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626463Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Hassan Talat <hatalat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843451}
-
Antonio Sartori authored
This is a small refactoring of the code in blink::CSPDirectiveList. Instead of storing the source list directives as separate members, we put them in a map. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I5936d73aa0cb83530565c88341395a51a092cfba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593641 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#843450}
-
Jérémie Boulic authored
JS modules generation: `metrics` has been incorrectly imported a few times. Bug: 1133186 Change-Id: Iddb2d02d4e3e1d0a909451a8aa7b328eda50e0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627200 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843449}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0279c680047..e5adc63d7ca2 2021-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5d2f0cf8aa71e882ec606388cfc573834c9e7729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628852Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f435ada424df..15595ea39c44 2021-01-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2ed9671a0ddd to 198dc345383e (13 revisions) 2021-01-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8aca3b4d to 2930e73f (505 revisions) 2021-01-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3549479dc4cc to 5255c465bbba (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Test: Test: Test: Aztec Ruins MECTest: Test: D3DTextureYUVTest* Change-Id: I67919147fc6f5694cd8daca5dbb739abb2a39120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628695Reviewed-by:
-
Stephen Chenney authored
Bug: 910537 Change-Id: I7258deea189b24c3ffded5c2de122848ab1bce2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626001 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#843446}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/712b239b..c80a50a3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic98a29a151b71881d7d6ad26875d46dc5cd9d989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628741Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843445}
-
Andy Paicu authored
TBR=pdr@chromium.org,wangxianzhu@chromium.org Bug: 1166540,1046544 Change-Id: I37ae96bb63da98c90fd85875742b5c76abf34e7b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628948Reviewed-by:
-
Antia Puentes authored
This CL migrates the legacy IPC message out of extension_messages.h to Renderer mojo interface from extensions.mojom. Bug: 1165812 Change-Id: Id53cdd68da19509682067a067ff544ff04128c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627410Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Antia Puentes <apuentes@igalia.com> Cr-Commit-Position: refs/heads/master@{#843443}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610582310-1de40dcfb71a8181da946117c9e834cf9a0c7d77.profdata to chrome-mac-master-1610603782-b98b7b7ae127903b90c7f2c46875a9e8f16b9cec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib28e160c363ea83599ac16897735172b41a6947b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628853Reviewed-by:
-
Colin Blundell authored
This CL separates separates the mechanism via which SafeBrowsingPrimaryAccountTokenFetcher fetches access tokens and the mechanisms via which it tracks and responds to ongoing token fetches, moving the latter into a new SafeBrowsingTokenFetchTracker helper class for reuse by WebLayer. This class includes the following: - Tracking of ongoing access token fetch requests coming from the client of SafeBrowsingTokenFetcher, responding to these requests when notified that a given access token has been fetched, and gating these requests on a given time threshold (responding with an empty access token if a request times out) - Responding to all active token requests with an empty access token on destruction This CL also adds unittests of SafeBrowsingTokenFetchTracker. Via this helper class, WebLayer will be able to share the key functionality of gating safe browsing access token fetches on a timeout rather than duplicating this functionality and risking divergence over time. The only subtlety is the behavior on token fetch timeout: SafeBrowsingPrimaryAccountTokenFetcher needs to be notified in addition to its client so that the former can destroy the corresponding AccessTokenFetcher. To facilitate this, SafeBrowsingTokenFetchTracker::StartTrackingTokenFetch() takes in both the SafeBrowsingTokenFetcher::Callback that the client passed in and a callback to be invoked on timeout, via which its owner can clean up any state associated with the request. Bug: 1080748 Change-Id: I79bb83096cc2094c7cf9916eccf382271a5f46a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624630 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843441}
-
Ulan Degenbaev authored
Intent to ship: http://bit.ly/memory-i2s Bug: 1085129,1048745 Change-Id: I4391fae4374c5bd1b126d996cebd6c63adb30407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624547Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843440}
-
Jordan Demeulenaere authored
This CL fixes the placeholder animation which was not correctly supporting multiple details. Now, all details with placeholders subscribe to the placeholder animation, which is stopped each time we change the details. This CL also fixes the wrong type of ShowDetailsProto.delay_ms, which should be an int32 and not a bool. Bug: b/174652960 Change-Id: Ib37479337bfc732d57c2b60ff168c28444e2575f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625885 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#843439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a9d4fceede9..8a42f3312f5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com Change-Id: I86621c453a15ad169158b32ef0453fd30ab2458d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628693Reviewed-by:
-
Kenichi Ishibashi authored
The method previously used a template function but the template function was used only from the method. Merge them so that stack traces are easy to analyze for crashes which contain the method. Note that this CL doesn't address the crash. Bug: 1161800 Change-Id: I59898a39b880b6c31e84f96878f898c57f9eefdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626992Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843437}
-
rbpotter authored
These are no longer needed since cloud print deprecation is already ocurring on the server side. Handle only privet related deprecation flag in Print Preview. Bug: 1144931 Change-Id: I6ff77f87fda23d33e25f49d6310e41757a3be530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618682 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843436}
-
Abhijeet Kandalkar authored
Send wayland request only if WindowState changes otherwise it 1. triggers IPC between server & client for a state management 2. calls the wl_display_flush. It is observed that during an initial launch of lacros-browser `maximize` request is sent twice from DesktopWindowTreeHostPlatform adding IPC overhead. This change will also handle minimize, fullscreen and restore operations. Bug: 1138978 Change-Id: Ia532c14ec0fa51f2a9e1e4093a0ded17e2610415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626945Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#843435}
-
Daniel Hosseinian authored
The displayed dates and times are localized. Bug: 93619 Change-Id: I116faa499866a828f53142237983bba6645508a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610627 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
This CL implements DeviceInfoClient interface for iOS platform when invalidations are enabled. Bug: 1102314 Change-Id: I19f6afaa256d127e2d8869123b632088f648c32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605557 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843433}
-
Joe Mason authored
Currently all unassociated bytes are lumped together into one counter. There are actually two types of unassociated bytes: - bytes of detached V8 contexts (i.e. contexts not attached to the frame tree. - bytes shared between all V8 contexts. Besides splitting the bytes, this CL also adds the corresponding memory types and reports them in the web memory API. Based on this patch by ulan@chromium.org: https://chromium-review.googlesource.com/c/chromium/src/+/2626662 Bug: 1085129 Change-Id: I0097e3b1728f5cbfe72746f0a1fd804215487237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626978 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843432}
-
rajendrant authored
This is a reland of fd90951e Original change's description: > Move subresource_redirect proto to components > > Moves the robots_rules.proto from chrome/renderer to components/ > > Bug: 1160424 > Change-Id: I0b2af266e3a6de40872bf094195b7f0c21c42096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623647 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842827} TBR: mcrouse@chromium.org Bug: 1160424 Change-Id: I8ec0a859cdfe204c5216ea1ee23c721352919e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628742Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#843431}
-
Kenichi Ishibashi authored
The core thread is always the UI thread now. Bug: 1138155 Change-Id: Iefda8c1a33303f1ce39d1513f91a36b014d40057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628268Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843430}
-
