- 11 Jul, 2020 13 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66ccc2b65ae8..dc805d4963d4 2020-07-10 brgoddar@microsoft.com Elements: Fix bug where first search result does not highlight If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103316 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib7792e95d16c102b54ae19dcfe9f0c73c99515d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787456}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Icf66a0345e92f08423cc603c561a60cd815c7ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293314Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#787455}
-
Collin Baker authored
Bug: 1102655 Change-Id: I1a250eb518a00245fcf648c96895a8beceb3f22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290696 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#787454}
-
Adam Langley authored
I tried this in c6728c24 but forgot that credential information is optional in assertion responses where the allow-list has exactly one entry. It was reverted in 3eae9ec8. Now that we have machinery to fill in the credential ID, use it to solve this problem. Change-Id: I54ec3e740465d08f8a16d83695506338c3310d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293416 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#787453}
-
Mark Mentovai authored
Apple CPUs since A9 use a 16kB physical page size, which is a change for macOS on arm64 relative to the 4kB pages used on x86_64. PartitionAlloc operates on pages directly, and must be aware of the larger pages on the new platform. If this same change were effective for macOS on x86_64, it would allow x86_64 Chrome to run under binary translation (Rosetta) on arm64. Doing so has potential observable impacts, including memory footprint and performance. Run-time page size detection could be used to overcome this, and would also provide insulation against future page size changes, but that’s a larger and more invasive change. It’s likely that we will adopt one of these strategies soon, but for now, this arm64-only change is sufficient to run Chrome on arm64 Macs. Bug: 1098899 Change-Id: I50b48728350b87a319433188306daad747741e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292831 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787452}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 04b9a46c842f793a2baedcad64de35fcbd3e93b7`. TBR=hans Bug: 1101237 Change-Id: I39243368a5c578fb392814e0fbe654faf0615e6a Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291352Reviewed-by:
-
Dmitry Torokhov authored
Even though GenerateGUID() is supposed to return cryptographically strong data, it is better to use a dedicated implementation for the token that is not supposed to be guessed by a 3rd party. Note that we still use strings to exchange tokens, as we are using DBus and not mojo (which would ensure type safety and would not expose implementation details such as the fact that token is 2 64-bit numbers). Bug: 1071872 Change-Id: I3014864201ee0af5e1d402dcf7ecb6c2e360f513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289213Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787450}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ide9f8fb36d50dd224aaed1849d24197f2ecbdca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293059Reviewed-by:
-
Chris Lu authored
This change fixes OverlayPresentationContextImplTest.ContainedOverlayUI since OverlayUIDidFinishDismissal will trigger another stop call synchronously. Since self.started isn't NO yet, then another dismiss is attempted, even though the presentation state has been removed. Bug: 1100811 Change-Id: Idb3443fa1b0b4e49132de801fe5a6aa6b81c361b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285919Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#787448}
-
ssid authored
Change-Id: I305074648b3265c34ec5a52e625e772991363398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293228 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#787447}
-
Adam Langley authored
By inspection, FilterAndBatchCredentialDescriptors always returns a non-empty list of batches, but GetAssertion assumes that the case where all credentials are filtered results in an empty list. When all credentials were filtered, Chromium started sending empty allow-list requests. There was a test for this! But it didn't work: it tried to detect the empty allow-list case by checking that account selection wasn't triggered, but the request handler doesn't accept a response with |num_credentials| > 1 if it wasn't supposed to be an empty allow-list request. Thus the response is rejected which turns into NOT_ALLOWED_ERROR, as the test was expecting. Instead, have the virtual authenticator record the allow-list sizes and check that no empty allow-list requests were sent. Change-Id: I7fa1f8325b8ad06934183436916043926043fa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293415 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
Brandon Wylie authored
When reparenting from theme changes, tabs wil be reparented during the restore phase. In this case, there's no tabs that are waiting and init should continue as normal. Bug: 1101955 Change-Id: I3f62cf7c3dda55384397b0389ab13c8edc30442b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293015Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787445}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I929306a7186d112a28365080dc7a90bb4c76c57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293322Reviewed-by:
-
- 10 Jul, 2020 27 commits
-
-
Alexander Cooper authored
XRInputSourceArray_Iterable was failing on chromium, since as a ".html" and not a ".https.html" file, it was not loaded in a secure context, and thus WebXr wasn't exposed (and the test API doesn't attempt to polyfill itself in if navigator.xr doesn't exist). However, on closer inspection, this is a redundant test case that is already covered by the idlharness. Fixed: 1104347 Change-Id: Ica4d52578571627e18b9a007e5bb461cf3e34ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293227 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#787443}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b54e8352a1d..4a1f5fc94295 2020-07-10 herb@google.com move makeAtlasTextOp to SubRun 2020-07-10 mtklein@google.com remove intermediate lambdas in skvm interpreter 2020-07-10 johnstiles@google.com Convert GLHighContrastFilterEffect to an .fp file. 2020-07-10 herb@google.com move GrAtlasTextOp creation to GrRenderTargetContext 2020-07-10 brianosman@google.com Make GrFP::registerChild just return -1 for null children If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I4149fb92fd5b83f251fe037c9c8e1a3baf3be087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293337Reviewed-by:
-
Adam Langley authored
Authenticators may omit specifying the chosen credential when responding to an assertion if only a single credential was specified in the allow list of the request. However, this logic was being implemented in the request handler, which considers the allow list prior to authenticator-specific filtering. If filtering reduced the allow list from several entries to one, the authenticator could omit the credential in the response, but then the request handler wouldn't know which it picked and would fail the request. Thus this logic must live in the task, which is the level that also handles filtering. By making the virtual authenticator omit the credential in the response whenever possible, plenty of existing tests sudden start failing without this fix. BUG=1102756 Change-Id: Icd1a7dc3ee3d75d118b509d4d0d1807654554f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288189 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieb6e926232b8da3e4f5ef779699d6d3a248fa93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293225Reviewed-by:
-
Jamie Walch authored
Among other things, https://chromiumcodereview.appspot.com/13983010 removed ScreenResolution::IsValid(), but missed a required negation when replacing one caller with IsEmpty(). Since that CL, we have added support for using an empty ScreenResolution to restore the previous desktop size (although it is currently disabled client-side), so the check is no longer required and this CL removes it. It also fixes an out-of-date comment referring to the same API. Change-Id: I12cc223c2b8f9579e50dbcd3dab0c0e0476416eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293420 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#787439}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1097552 Change-Id: I60641142a6c05f3132b037810c7aecd533d779a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293456 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#787438}
-
Andrew Moylan authored
This CL rolls most recent mojom changes (excluding Clone method which I will roll separately). These are all comment changes apart from the addition Model.CreateGraphExectutorWithOptions. Also added a basic fake impl of that method. Bug: chromium:1081597 Change-Id: If2e02fcbde8eae800872d3cbfebf830dcede1be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291794 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#787437}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594382405-1c0e0d15040ecb2cc25de0b60c76871095d44c41.profdata to chrome-win64-master-1594403996-e3eed77ce75692e0c0c19bee2acf225c6e767aa8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7911aec00ae11e5fd32f9c8c133a69a48cc8177f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293045Reviewed-by:
-
Mei Liang authored
crrev.com/c/1464118 affects the TabModelObserver ordering. It adds TabModelFilter as a TabModelObserver to the system, and TabModelFilter becomes the first set of Observers to be notified when TabModel changed. More specifically, the TabModelFilter receives notification before the TabModelObserver in TabModelSelectorBase and eventually causes the CompositorViewHolder#updateContentOverlayVisibility(true) with a stale |mView| and affecting the focus. This CL addresses this issue by: 1. Attaches TabModelSelectorBase#TabModelObserver to TabModelFilter, So it becomes the first Observer to be notified as before. 2. Verifies the |mView| in CompositorViewHolder is the current tab view when show is requested. 3. Removes redundant logic in LayoutManagerChromeTablet. Don't need to call show StaticLayout explicitly, the LayoutManager will handle that automatically when the ToolbarSwipeLayout hides. Change-Id: I4e588194d8866b06dac1255532ec7094d5eabc1d Bug: 944777, 1073535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290772 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#787435}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2a2b4b135a86..73b6b3a8838f 2020-07-10 ianelliott@google.com Vulkan: Fully enable pre-rotation for Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I924e81cab645b495818f93355897f0ff4b147f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293334Reviewed-by:
-
Haiyang Pan authored
android emulator team points out that the exception is related to DMA. Disable GLDMA temporarily to see if it can fix the timeout issue on MM Bug: 1093602 Change-Id: I940b8111db48d8b542b47f350b949dab7448d1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293279 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#787433}
-
Cicy Tan authored
If the method is called a second time, instead make a window priority request. Bug: internal 160358649 Test: on device Change-Id: I6b38cafb3198a607136e54542f65c6f4df8b163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293419Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Cicy Tan <shiyun@google.com> Cr-Commit-Position: refs/heads/master@{#787432}
-
Eugene Zemtsov authored
Bug: 1041930 Change-Id: Id6d90a7863cc27ad9f1e0f489bd78279de052132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291436Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#787431}
-
Jarryd authored
Replace all uses of blacklist with denylist in quota code. Bug: 1103891 Change-Id: Ia2d50a987a3f6d4f835a09ed20f3894186cb0e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286009Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787430}
-
Justin DeWitt authored
Bug: 1104367 Change-Id: Iba8556773dd0b72f1e69de96a05846e6be4d25b6 Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293414Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#787429}
-
Xianzhu Wang authored
The value had only 3 possible values: 0, 0.5, 1.0. Now use 2 bits in DisplayItem, and reduce sizeof(DrawingDisplayItem) by 8 bytes on 64-bit systems. Change-Id: Ifa8660ea86122a863508a4b6fdcddc2908dcc4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213089 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787428}
-
Katie Dillon authored
Breaking up this cl[1] into two portions: before unload and unload metrics. Adding UKMs to help measure unload performance. More details on why we are adding these metrics can be found on the UKM Collection Review doc[2]. TL;DR is that Search is looking to see where they could improve unload and on the web platform side we are looking to run experiments to prioritize unload and these metrics will help measure impact. This CL adds the metrics we want to collect for before unload. For browser-initiated navigations we look at the queuing duration (renderer-initiated navigations run before unload handlers synchronously so we don't record queuing time. However, if the page has OOPIFs whose beforeunloads will be dispatched from the browser, then we will record queueing time for those) and for all navigations we look at the duration of the before unload handlers (if it is a renderer-initiated navigation who dispatches beforeunloads to OOPIFs from the browser process, the duration of those will be summed into the duration of the local beforeunloads). These metrics are recorded for both cross-process and same-process navigations upon a navigation commit and use the frames origin prior to the navigation committing not the destination (ie if we navigate from google.com to cnn.com the unload times are recorded for google.com). Metrics added in this CL are: 1. BeforeUnloadDuration 2. BeforeUnloadQueueingDuration (measuring the time from browser sending the before unload to the unload being run in the renderer). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2191143 [2] https://docs.google.com/document/d/1DECc8eJQluwkV5k64TX7Krl4zAcP7-Qk7pSirmHuCJs/edit?usp=sharing Change-Id: Id6711f65ce3026c298b1b25d1b8a320b70adfdbe Bug: 1081617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234546 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#787427}
-
Jan Wilken Dörrie authored
This change adds a few more utilities for the string16 switch, makes CommandLine::AppendSwitchNative more generic, and removes further string16 usages in base/win. Bug: 911896 Change-Id: Id37a0c2b2c2c0e3eaafe30d4ec035f7d079fcb42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210580Reviewed-by:
-
Antonio Gomes authored
This CL exposes MediaStreamVideoTrack::CreateVideoTrack() through a helper method, to be used from content/renderer/pepper. No functionality change, but it will allow t_p/blink/public/web/modules/mediastream/media_stream_video_track.h to be moved out of the Blink API altogether. BUG=704136, 919293 R=guidou@chromium.org, haraken@chromium.org Change-Id: I284b245bc24e43de4c59c7d0f498472840782d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292777Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#787425}
-
Matt Menke authored
URLFetcher and URLRequestStatus are deprecated and no longer used in production Chrome code, so code shouldn't be including those headers or using their constants. This CL also removes unused includes of url_request_context.h, url_request.h, cookie_manager.h, and a number of other net/ headers that shouldn't be used in the browser process, since the network code now runs out of process. Bug: 651119, 1010491 Change-Id: Id5963fbeb2f9fb4405fbebd6d8d09027b8df2f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289912Reviewed-by:
-
Reilly Grant authored
This change finishes converting callbacks in the platform-specific Linux and Chromecast implementations of BluetoothAdapter and BluetoothDevice. There should be no functional change. Bug: 834319 Change-Id: I3abedefa4df23d79f803bd4cd2cc7252ee193386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293156 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#787423}
-
Julian Pastarmov authored
These two new policies deprecate the old policies with less appropriate names. The old policies will still be used in the absence of the new ones for at least a few releases of Chrome. BUG=1095227,1095230 TBR=rohitrao,eugenebut Change-Id: Id1e5c0be5e5e2ed72547214f0669c0a2ae1440a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283163 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787422}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9af33fa208fb..8e404a7e4992 2020-07-10 kylixrd@chromium.org Added option to keep empty branches in rebase-update. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie375d5a2408edcc8deb0afdbea33b52fe2a04c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293056Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27d352134c59..66ccc2b65ae8 2020-07-10 almuthanna@google.com Use strict equal to assert Console truncation scenario If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9eb0a71c536f31b82b0ebf47ca5581c0305ecfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293335Reviewed-by:
-
Collin Baker authored
FeaturePromoBubbleView requires a ThemeProvider in its parent Widget. So, for TabGroupsIPHControllerTest to instantiate it the anchor view must be inside a Widget with a ThemeProvider. TestWidget used internally to ChromeViewsTestBase serves this purpose. This CL extracts it as ChromeTestWidget to be used elsewhere. TabGroupsIPHControllerTest uses this as the parent Widget. Bug: 1102655 Change-Id: Ib0d8a290789c1af1c08adb9fb6afc816ee2eeb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289922 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#787419}
-
David Tseng authored
Previously, if a test did: this.newCallback(async function() {}); this.newCallback(async function() {}); the first call would immediately pass the test (and not decrement the expected number of callbacks). Correct this. R=anastasi@google.com AX-Relnotes: n/a Test: catches a ChromeVox test that instantiated a new MockFeedback (which creates a callback) that was never called. Change-Id: I158256031eb670b94be2918562d6dfafaa6819eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292854 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#787418}
-
Alexander Alekseev authored
This is first CL in series to make some viz debug flags dynamic. See the design document here: https://docs.google.com/document/d/1lWHJZK0LxLwN6y2YmPZTc0oTA-SXTo5PPM4OpieiI90/edit?usp=sharing Here we move some boolean debug flags from RenderSettings into a separate structure and add renderer API to modify them. Bug: 1085279 Change-Id: I802db6be7c1eb6dfe97dd4026547f7d7bb742eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234122Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#787417}
-
