- 12 Sep, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts WidgetPtr to new Mojo types. It updates CreateNewWidget() and CreateFullscreenWidget() from render_message_filter.mojom and methods and members which implement these interfaces. Bug: 955171 Change-Id: Ibc1a871b182716c216e90d4a9d041917cf35e278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792471 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695903}
-
Rakina Zata Amni authored
Note there are some changes (contain-size* references) and some weird results in get-bounding-client-rect-block-layout.html Bug: 1000702 Change-Id: I028a00de6c9e6700c1ce1a2e3f05c6037958777b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792221Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695902}
-
Alan Cutter authored
HostedApp* View classes are used by web app (PWA) windows. The name hosted app comes from the Extension app backend used to store them. Web apps are being migrated to their own web_app subsystem while hosted apps are being deprecated (and having their UI implemented on top of web apps instead of the other way around). This CL renames a number of UI classes to fit the current state of the world now that the web_app subsystem is more fleshed out than before when web apps were just bookmark apps (a subtype of hosted app). The following renames are done in this CL: IDs: IDC_HOSTED_APP_MENU_APP_INFO -> IDC_WEB_APP_MENU_APP_INFO IDS_HOSTED_APPMENU_TOOLTIP -> IDS_WEB_APP_MENU_BUTTON_TOOLTIP HOSTED_APP_MENU_BUTTON_SIZE -> WEB_APP_MENU_BUTTON_SIZE HOSTED_APP_PAGE_ACTION_ICON_SIZE -> WEB_APP_PAGE_ACTION_ICON_SIZE VIEW_ID_HOSTED_APP_BUTTON_CONTAINER -> VIEW_ID_WEB_APP_FRAME_TOOLBAR View classes: HostedAppButtonContainer -> WebAppFrameToolbarView HostedAppMenuButton -> WebAppMenuButton HostedAppOriginText -> WebAppOriginText HostedAppToolbarActionsBar -> WebAppToolbarActionsBar Methods: BrowserView::IsBrowserTypeHostedApp -> IsBrowserTypeWebApp BrowserNonClientFrameViewAsh::StartHostedAppAnimation -> StartWebAppAnimation BrowserNonClientFrameViewAsh::SetUpForHostedApp -> SetUpForWebApp Tests: HostedAppNonClientFrameViewAshTest -> WebAppNonClientFrameViewAshTest ImmersiveModeControllerAshHostedAppBrowserTest -> ImmersiveModeControllerAshWebAppBrowserTest HostedAppOpaqueBrowserFrameViewTest -> WebAppOpaqueBrowserFrameViewTest HostedAppAshInteractiveUITest -> WebAppAshInteractiveUITest HostedAppGlassBrowserFrameViewTest -> WebAppGlassBrowserFrameViewTest New directory: chrome/browser/ui/views/web_apps/ TBR=jcivelli@chromium.org Bug: 788051 Change-Id: I1a54693bab779a492ee1ebdc04e7ccba343fe9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792035Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695901}
-
John Budorick authored
Bug: 1001171 Change-Id: I19912e1cfcb3e4a97dd485f5b751484b4334f690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786867Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695900}
-
James Cook authored
UX wants the strings to be: "Used by Chrome browser and Chromebook Launcher" (capital L) "Add languages or reorder list. Learn more" (with period) Bug: 997481 Change-Id: I9e43205df301adb202d5eed6886777463fa8f0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799028 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#695899}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e85f633c7c4..0910f787ebc0 git log 0e85f633c7c4..0910f787ebc0 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-12 alancutter@chromium.org Allow TBR for CLs with approved changes to OWNERS files Created with: gclient setdep -r src/third_party/depot_tools@0910f787ebc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:688115 Change-Id: I621aea28c89a69edb9a3647e7a86eb32e576caec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695898}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f74b71eeaa8a..c979465c52c6 git log f74b71eeaa8a..c979465c52c6 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 tsaiyunnnn@google.com Symbolize object type with frame name if enable "--frame-as-object-type" Created with: gclient setdep -r src/third_party/catapult@c979465c52c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1001848 Change-Id: I70e5a075d29bb13a97366d93dd8cf430cf2b9677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799824Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c8c67ec803c..7c47d41067d4 git log 7c8c67ec803c..7c47d41067d4 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7c47d41067d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I7baf27e87e2bc9c7a2150dc492a143c91e5b4f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799744Reviewed-by:
-
Justin Cohen authored
This reverts commit 24ddb486. Reason for revert: broke ios full_configs bot: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/18443 https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/18444 Original change's description: > Add Field Trial Config for translate UI refresh > > Bug: 976352 > Change-Id: I9e125f2a7d2dfe24691e8097623cbc65866fe353 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796002 > Reviewed-by: Alexandre Frechette <frechette@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695796} TBR=jwd@chromium.org,anthonyvd@chromium.org,frechette@chromium.org Change-Id: I5f43ca5c2d623815d45b171efd91b9e70342c38a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799628Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695895}
-
Xinghui Lu authored
To determine if we need to make local allowlist lookup async, we'd like to record the time for a lookup. Bug: 999344 Change-Id: If029d9bc678aaeeb17ca388337d0f1ec2f51dddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797333Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695894}
-
Andrew Xu authored
This CL moves ShelfTooltipManager from ShelfView to Shelf. Bug: 997807 Change-Id: I407d17fabdcbb84957074c88014caa0e3214de7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776938 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#695893}
-
Peter Kotwicz authored
This CL is in preparation to adding logic in WebApkShareTargetUtil which deals with androidx.browser.trusted.sharing.ShareTarget (e.g. computing equality) This CL: 1) Adds tests in WebApkInfoTest for: - invalid JSON in AndroidManifest in org.chromium.webapk.shell_apk.shareParamNames <meta-data> key - building WebApkInfo.ShareData for Intent.EXTRA_STREAM 2) Refactors tests: - Introduces builder for WebApkInfo.ShareTarget This will simplify adding more tests - Replaces explicit references to WebApkShareTargetUtilShadow with WebApkShareTargetUtil. Robolectric magic changes references to WebApkShareTargetUtil to point to WebApkShareTargetUtilShadow - Introduces helper method createMinimalWebApkIntent() in WebApkTests to cut down on amount of boiler plate code. BUG=997771 Change-Id: I47204c2fba3c4884685feb864d3b9da0f3b90664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766432 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695892}
-
Julie Jeongeun Kim authored
This CL converts MemoryPressureControllerPtr and MemoryPressureControllerRequest to new Mojo types. Bug: 955171 Change-Id: I84464e08ac4be2c3051343a65160b4c02062cc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788963 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f27abc1aaeea..46a045eaf1e1 git log f27abc1aaeea..46a045eaf1e1 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 thestig@chromium.org Disable git EOL policy for .in files again. 2019-09-11 thestig@chromium.org Add another pixel test for invalid glyph ID. 2019-09-11 awscreen@chromium.org [FXCRT] Fix checks in FXSYS_round() for float precision 2019-09-11 awscreen@chromium.org [FXCRT] Add unit tests for FXSYS_round() 2019-09-11 thestig@chromium.org Add a pixel test for incorrect line dash pattern drawing. 2019-09-11 thestig@chromium.org Change CFFL_ComboBox to do early returns. Created with: gclient setdep -r src/third_party/pdfium@46a045eaf1e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:611744,chromium:611744,chromium:660850 Change-Id: I3a678a8cc047b7abc5c219e188c1a7167343f083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799271Reviewed-by:
-
Nico Weber authored
We only use prebuilt instrumented libraries with msan, so use the right default for that, and asser that it's not used in any other build configs. Bug: 1002971 Change-Id: I23c8099394af711a9e28027f9c3093f9f6fd18b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797468 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Evgenii Stepanov <eugenis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695889}
-
Brandon Wylie authored
Accessibility text should provide the user with a description of what interaction with the given UI element will involve. The dse icon is purely cosmetric so it doesn't need an accessibility desicrption unless the underlying button actually does something. This change turns off the important for accessibility flag when there's no description of the button available. There will be no description available when no interaction with the button is possible. Bug: 995059 Change-Id: Ifed72d4f63d8ad58a615a583221d1a63940b72e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799683 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#695888}
-
Kevin Marshall authored
* Moves logging initialization function to a common location. * Adds initializers to Context Provider, Cast Runner, Web Runner. * Migrates WebEngineMainDelegate to use common function. Bug: 951143 Change-Id: I031f2279a7bfdae81be3256ee40f7e73113fce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785012 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#695887}
-
Reilly Grant authored
In r695573 a find-and-replace error changed the parent of the NavigatorGeolocation class from GarbageCollected<NavigatorGeolocation> to GarbageCollected<Geolocation>. This causes a bad cast during sweeping. Bug: 1003140 Change-Id: Ie2398fe2ce3ce501c69b277938bc101c211c5963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799698Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695886}
-
Mike Jackson authored
This change updates the version of axe-core to the latest released version. As part of picking up the latest version, the following additional changes were made: 1) axe-core removed the 'href-no-hash' rule, so that been removed from the test list. 2) Several 'link-in-text-block' tests started failing with axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but are disabled as part of this change. - CrManagementA11yTest.SimpleTest_link_in_text_block - CrManagementA11yTestWithExtension. ExtensionSection_link_in_text_block - CrostiniAccessibilityTest.CROSTINI_link_in_text_block - CrExtensionsA11yTest.NoExtensions_link_in_text_block - MultideviceA11yTest.MULTIDEVICE_link_in_text_block - MultideviceFeaturesA11yTest. MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block 3) One 'heading-order' test started failing in v3.0.0 (and later). This tests does pass in V2.4.2, but is disabled as part of this change. - CrExtensionsA11yTestWithMultipleExensions. WithExtensions_heading_order I spent some time investigating the test failures, and it looks like axe-core is highlighting legitimate product issues. Change-Id: I99c1f85087aea873e29b413dca967864fc93c786 Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790125Reviewed-by:Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695885}
-
Miyoung Shin authored
This CL fixes build failure in system_provider_impl_unittest on internal trybots. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:chromeos-betty-chrome;luci.chrome.try:chromeos-kevin-chrome TBR=blundell@chromium.org, wutao@chromium.org, kinuko@chromium.org Bug: 1003054 Change-Id: I400607d194ce68982d70540ad88514df80d9b36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799642Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Matt Falkenhagen authored
For increased test coverage. I plan to start enabling it on Dev/Canary soon once existing bugs are addressed, and eventually launch to Stable. Bug: 824858 Change-Id: I71374bdc94b32ba24fcbbd8ab86df90c735dd637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786881 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#695883}
-
Jeremy Roman authored
A portal contents briefly has some work to do after the activate() operation is called, but from a spec perspective this operation detaches from the <portal> element and should be largely independent of it from that point onward. To express this separation between the element which hosts the WebContents and the management of the WebContents itself (in the renderer process), this breaks HTMLPortalElement into two classes, one for each. DocumentPortals then needs only to track the existing contents, and HTMLPortalElement doesn't need to keep around an is_activating_ boolean, as it no longer has guest contents the moment activation begins. For convenience, PortalContents is directly aware of whether it is in an element, since communication back to the element is still required and implementing a PortalContentsClient interface seems like overkill at this point. Bug: 964481 Change-Id: I9b394e34f64b891fe013f7ae48a8aaf00ed06d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789466 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695882}
-
Miyoung Shin authored
This CL converts GeolocationContextPtr and GeolocationContextRequest in services, content and components to the new Mojo type. Bug: 955171 Change-Id: Ie076d6ee60cf9e8288f07177510edf7ec85868ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792397 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jeremie Boulic authored
Before this change, after deleting multiple files, one of the remaining files was sometimes left in check-select mode. In file_list_selection_model.js, adjustToReordering is triggered when adding or deleting items in the file list. Having oldLeadIndex != -1 as a condition to leave the check-select mode doesn't seem to be necessary. Verified with manual tests. Removing this condition fixed the unnecessary selection issue. Test: browser_tests --gtest_filter="*fileListDeleteMultipleFiles" Bug: 992341 Change-Id: I3b4cb08ec4568a7f945f3cf8cc4ae089e7a282f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797518Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695880}
-
nancy authored
AppServiceProxy.CreateForTesting and AppServiceAppModelBuilder.SetAppServiceProxyForTesting can be removed, as proxy can use ReInitializeForTesting to reset the connector for test cases. So those two functions are no longer used. BUG=998004 Change-Id: I98b190e294493461b5af0d0aa0f3b64bc25c2e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797830 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Manas Verma authored
Adding an authorization token in the GetRealPan response and the OptChange request in order to allow new cards to be authorized for unmasking through WebAuthn. GetRealPan and OptChange response will also include |request_options| for authorization and opt-in scenarios. Bug: 949269 Change-Id: I3e35afa4dc39e9222e0f49368df231b73f6a88de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761655 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#695878}
-
Tim Song authored
Currently, the uninstall/app info dialog is not being hidden when overview mode is toggled while in tablet (home launcher) mode. TEST=manual + unit test BUG=991140 Change-Id: I7fd95a14e1b74f244f57834cbffd145e59624c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775384Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#695877}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d70a348f..4189eaea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f672eb4b3ca27fa4e6fa2a7d86aa140215b2b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799105Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695876}
-
Gyuyoung Kim authored
This CL applies a new Mojo type to RemotingDataStreamSender and RemotingDataStreamSender in Remote::startDataStreams. As this CL applies pending_receiver, related classes are also changed by the change. Bug: 955171 Change-Id: Ifda0d06183d1beec155a4b82c1b57c22599898d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778108Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts XmlParserPtr and XmlParserRequest in services to the new Mojo type, and remove unused XmlParserPtr in chrome. Bug: 955171 Change-Id: Ifde5cea32a811c597ad902500e3357df2e41255d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792515 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695874}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1727db1acca..9805913bb537 git log a1727db1acca..9805913bb537 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 58a2bab7..fe8ed20c (695605:695755) Created with: gclient setdep -r src/third_party/webrtc@9805913bb537 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I15db6feccddcaa5a7245739eab0b9dabf2cdddf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799427Reviewed-by:
-
Matt Simmons authored
Change-Id: I70b1e659e36eb0df83e699b08181218e0f9a1e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764516 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#695872}
-
rajendrant authored
This reverts commit d479c672. Reason for revert: Reenable perf test since the offending CL is reverted Original change's description: > Disable system_health.common_mobile/background:news:nytimes > > Perf test system_health.common_mobile/background:news:nytimes is failing > on all Android devices. Disabling it. > > TBR=crouleau@chromium.org > NOTRY=true > > Bug: 1002546 > Change-Id: If54c8c34edace7711c12fbe809044158ea6708b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795753 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695195} TBR=crouleau@chromium.org,johnchen@chromium.org Bug: 1002546 Change-Id: Iadeeb83a42ae553910454f91413f8acd4b88b3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799689Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#695871}
-
Ryan Hansberry authored
Chrome OS does not support any Bluetooth profile that phones provide; pairing to them provides nothing to the user, and therefore are just unnecessary noise. Filter them out of the BT discovery UI in Settings and System Tray. See bug for in-depth conversation. Bug: 888785 Change-Id: Ia55aa227a79a1749cd7cab6f288fd31d4c3b4cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799268 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#695870}
-
rbpotter authored
Welcome tests pass when the OutOfBlinkCors flag is enabled. Since the flag is planned to ship in M79, always enable the flag for these tests. Bug: 1002037 Change-Id: I320e89343ce79f4e678731518ad21a3a52e76108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799319Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695869}
-
Min Qin authored
Creating DownloadManagerImpl on startup is very costly as it loads a lot of downloads. So BrowserContext::GetDownloadManager() should not be called in classes like AndroidTelemetryService, which is created in browser startup. This CL fixes the behavior by making AndroidTelemetryService observe SimpleDownloadManagerCoordinator. The coordinator class is a wrapper of the DownloadManagerImpl and will not load any history downloads on startup. BUG=1003160 Change-Id: Iab9a42071821e01d4f70c779113cf23a2fb534f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799684Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695868}
-
Brandon Wylie authored
Adds support for the dse icon in the un/focus animations. * For the NTP, * animations have been added between the fakebox/locationbar * the locationbar --> fakebox has a special animation which slides the url text over the status icon while the status icon is fading. * For non-NTP pages, * the dse icon experiments introduces an icon for every page. * as a result of above, no special animations have been added for non-NTP pages. Bug: 988883 Change-Id: I5a8b02ef0d763797194d7e18b42494cec9b57001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783557Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d195c8eb28db..f74b71eeaa8a git log d195c8eb28db..f74b71eeaa8a --date=short --no-merges --format='%ad %ae %s' 2019-09-11 bpastene@chromium.org telemetry: Ignore CHROMIUM_OUTPUT_DIR when running testFindAllWithCheckout. Created with: gclient setdep -r src/third_party/catapult@f74b71eeaa8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:993606 Change-Id: Ieeceb82935a7cbd7c8d7a916866e0ccf51f5d3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799430Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ae039a065a6..0e85f633c7c4 git log 2ae039a065a6..0e85f633c7c4 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 ehmaldonado@chromium.org Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" Created with: gclient setdep -r src/third_party/depot_tools@0e85f633c7c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I57001f8bec766a0793035951bf4d1e255640859a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799429Reviewed-by:
-
Daniele Castagna authored
We added a panel orientation property to DisplaySnapshot that can be used to determine the natural orientation of the device. This CL adds the property to ManagedDisplayInfo and propagates it from DisplaySnapshot. Bug: 1001369, b/139500237, b/133207693 Change-Id: I7c5d37b6c88e72cdf19a96e03d1c88027fa72805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758430 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#695864}
-
