- 08 Nov, 2019 40 commits
-
-
Sadrul Habib Chowdhury authored
Add some DCHECK-only code to validate that a CompositorFrame is always submitted only between calls to WillBeginImplFrame() and DidFinishImplFrame() (i.e. when a valid BeginFrameArgs is being tracked by the LayerTreeHostImpl). Change-Id: I9f344135163d8fabf15c7b670a4a80eb25079e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894912 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713722}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52591f688023..76eaab6b8cef git log 52591f688023..76eaab6b8cef --date=short --no-merges --format='%ad %ae %s' 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-08 csmartdalton@google.com Implement multisample "disable" in Vulkan Created with: gclient setdep -r src/third_party/skia@76eaab6b8cef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I593777cbc50f9e415b5e9aa8444bbdea945bca3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713721}
-
Julie Jeongeun Kim authored
This CL is a part of effort for converting mojom::URLLoaderClient to new Mojo types. It converts mojo::Binding<network::mojom::URLLoaderClient> to mojo::Receiver<network::mojom::URLLoaderClient>. On a follow-up CL, URLLoaderClientPtr will be handled with new Mojo types. Bug: 955171 Change-Id: Id297a6c86ea7b113d333d0ccb2a41611328c0aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895107Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#713720}
-
John Palmer authored
The new metric will capture more detail at the tail of the distribution than the existing metrics do. Internal CL adding the metric: http://cl/278538382 Change-Id: I4be1eb48fa97f847b0ee8f70f128bbb5e26bfc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900511 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#713719}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a14152fd51b9..1917f7a09940 git log a14152fd51b9..1917f7a09940 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 martiniss@chromium.org Revert "Fetch the input commit ref when both ref and id are specified." Created with: gclient setdep -r src/third_party/depot_tools@1917f7a09940 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:922150,chromium:1022617 Change-Id: I0104ad01275923ee4ff662b1dc6fb2902861f9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904339Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit c9ea6cb3. Reason for revert: Caused flaky compile failure. BUG=1022637 Original change's description: > [IntentHandling] Connect App Service with Pref Service. > > This CL connects the App Service with the Pref Service. This is to > allow the App Service store and retrieve preferred apps from the > preferences file. > > BUG=853604 > > Change-Id: I2802173d80126595966626af5d1ff1f42761c49f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892475 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713174} TBR=gab@chromium.org,dominickn@chromium.org,mxcai@chromium.org,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 853604 Change-Id: Ie0adee8d67e28801eb1e92cc47f13d15276ed1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904564Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713717}
-
rbpotter authored
Run clang-format on chrome/browser/resources/extensions and chrome/test/data/webui/extensions These directories were left unformatted when converting to Polymer 3 in order to reduce the diff created when migrating and make it easier to see the changes required for migration. Bug: 1004967 Change-Id: Ic1eb0ee43eccd56c340d0cf3956e29136b96d10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904488Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#713716}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/275467d3f177..c2eeedf46266 Created with: gclient setdep -r src-internal@c2eeedf46266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iada7593f3ed1758ee6387029c1a9bf84b47cb7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904820Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713715}
-
Sophie Chang authored
I left the SRP check there since that contains more hosts and doing the HasHint check for every host is probably not worth it. Bug: 1022624 Change-Id: I1b4c782df2c9fb76e08e09d3674178420a5a3728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904822Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713714}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/26c5a8d1e381..8095ffd42db6 git log 26c5a8d1e381..8095ffd42db6 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 stevenjb@chromium.org Only copy resources/chromeos/ to the image, not all of resources/ 2019-11-08 stevenjb@chromium.org deploy_chrome: Copy compressed files in locales/ 2019-11-07 achuith@chromium.org xbuddy: Remove subprocess from xbuddy. Created with: gclient setdep -r src/third_party/chromite@8095ffd42db6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I919809a6f5c6a3232c39836a434f62fdbceea2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904819Reviewed-by:
-
sczs authored
- Creates ConfirmInfobarTypeBlockPopups Suffix for InfobarConfirm metrics. - Records the new Histogram on blocked_popup_tab_helper Bug: 1020280 Change-Id: I78422370a2f9658bd98b02ed45445bb7adbe9b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899557 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#713712}
-
Klaus Weidner authored
Ensure that the anchors_data in a frame is populated after processing anchors creation for that frame. This fixes an issue where a new anchor was reported as created in the promise, but only started appearing in the frame's list of anchors with a one-frame delay, resulting in losing custom data that the application may have stored on the anchor object. Also update the example to fix a couple of misused fields for non-reticle mode. This should fix the issue where the sunflowers weren't appearing at the touched point. Change-Id: I042f2e88f1fa4f0e09bacfcd4b93c89abe501bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903822 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713711}
-
Austin Eng authored
This CL exposes WebGPU in Worker contexts behind a runtime enabled flag. It also removes the usage of blink::Platform::GraphicsInfo which was copied from WebGL context creation. It's completely unused right now and WebGPU should collect context creation errors differently. Platform::GraphicsInfo is not safe for cross-thread usage. Bug: chromium:852089 Change-Id: I9447b73f2bf45b32895f6d38818a8e7339de5efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809755Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#713710}
-
Yoichi Osato authored
That's because we've decided not to unify op code and data on a datapipe. Change-Id: I1d9d83d10108552c6ba04b240ee71c2298d7663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903226Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713709}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::ChromeRenderFrame using PendingAssociatedReceiver and AssociatedReceiver. Bug: 955171 Change-Id: I895ad427e08292c8f671fef3965eddbabd9f0003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902184Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Rakib M. Hasan authored
These tags will be used to find active expectations for a test run on a certain system. Bug: chromium:986447 Change-Id: Iaa2cea234b80ff010581cd3991dbb015cb8995e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904270Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#713707}
-
Miguel Casas authored
This CL continues substituting LOG_ASSERT()s with ASSERT_TRUE()s, where the function has void(...) signature, or with ADD_FAILURE() otherwise. This avoids crashing the test binary in Tast test runs. Bug: 1020776 Change-Id: I228dc570d5b1c19fdc766313d194f637f8418f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904848Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#713706}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81a8d282d356..52591f688023 git log 81a8d282d356..52591f688023 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@52591f688023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I667cc2d8bcaeac9bf7cc092c52e3a7a8b6a1ba79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903933Reviewed-by:
-
Anastasia Helfinstein authored
Switch Access has been occasionally getting console errors because a node's location is undefined. This CL adds checks to avoid that. Bug: None Change-Id: Id7ea375fd82b2100cafc4d3d4bb0d9226d183b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904542Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#713704}
-
Kevin Bailey authored
After a previous change, it was apparent that OmniboxEditModel was exposing more members than it needed to, and that the code was a little more complicated than necessary. This CL encapsulates the call, so that no data needs to be public, and the code is simpler. Change-Id: Ibb3dcc23148d1e2568f54a9645de4c4267e3d2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903619Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713703}
-
Eric Roman authored
Bug: 1021236 Change-Id: I8e9f75916d13a388d2074811c8b09fe9eda3229f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898775 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713702}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72a245e4c678..a14152fd51b9 git log 72a245e4c678..a14152fd51b9 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a14152fd51b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ib472fd469cba6ab06605c1d2f83b4008ed5ad39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904807Reviewed-by:
-
Joel Hockey authored
In order to save space on rootfs, we will store crosh and terminal assets gzipped. This CL allows the data source to serve non-compressed or gzipped files. E.g. on a request for chrome://terminal/js/terminal.js, we first search for /usr/share/chromeos-assets/crosh_builtin/js/terminal.js, and serve it if it exists, else we search for /usr/share/chromeos-assets/crosh_builtin/js/terminal.js.gz and serve the uncompressed contents. Bug: 1022250 Change-Id: I3060d86d64b43673ad7c75606083fad2dc3b33fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903170Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#713700}
-
Sophie Chang authored
Bug: 969558 Change-Id: I12fb95184b6d663a424bafe97cc2e6d640cdddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902112 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Clark DuVall authored
Adds EmbeddedTestServerRule to InstrumentationActivityTestRule so all tests have access to the test server without needing to start/stop it themselves. This is similar to what ChromeActivityTestRule does. Change-Id: I17820927c9bd9d8ac2d36fecb794f611de697975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904689 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713698}
-
Darren Shen authored
In https://codereview.chromium.org/2035753003, we started switching the user account as soon as the user focused on a user pod in the lock screen. This was to update parts of the "shelf user icon" based on the focused user pod. However, this has unintended consequences. When the screen is locked, the system is in a special "locked" state. Switching the active user assumes we're in interactive user session state, so it breaks this assumption system wide. One unintended consequence is on IMEs: The lock screen code assumes that active user can only change after auth success, and uses this assumption for managing the user's IME state. This causes the IME state to be incorrectly restored in some cases, which breaks keyboard typing for some users, breaks the virtual keyboard, and shows an incorrect list of IMEs in the shelf. We revert this change as it may have consequences for not just IMEs. We need to implement this feature in a different way (without switching the active user). Bug: 911699, 942392, 980792, b:143235444, b:143906227, 614926 Change-Id: I0691256ecad20c683003004d99469692b4e4ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904558 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#713697}
-
Kouhei Ueno authored
Bug: 981740 Change-Id: Iade267628067ecc39dcc84be6b721b59eddb9db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903241Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#713696}
-
Dana Fried authored
We'll need these when we do our "webby UI" exploration, which has been put on hold temporarily but will resume in a month or so. Bug: 1021148 Change-Id: I3e4bb2244ad2fee46f698520ed7827e7f0259991 Fixes: 1021148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900133 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#713695}
-
Tim Song authored
The CollapseState indicates whether the tray is collapsed or expanded or not collapsable (default behaviour) at all. Currently, the status area will only be collapsable in tablet mode and in-app. The visibility logic for individual tray items is also being cleaned up in this CL, as this logic is fairly complex. We rename SetVisible() to SetVisiblePreferred() because the effective visibility also depends on factors such as the virtual keyboard and status area collapse state. Future CLs will properly update the CollapseState as well as calculate which tray items should be visible when collapsed. TEST=unit tests BUG=982511 Change-Id: I6f6fed7836d0b1dc4991319fb4ec8e58a522da37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903399 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#713694}
-
Alex Cooper authored
This change removes the infrastructure around the WebVr displayactivate events, including XRRuntimeEventListener methods and XRRuntime's SetListeningForActivate for notifications to the browser process. This also remvoes the VRDisplayClient, and some compatibility methods on the VRService. Future work will remove GetImmersiveVRDisplayInfo, which should be the last remaining WebVr-only method in the mojom files. Bug: 1017872 Change-Id: Ic149384917a25d6db4fceef35091f28350025f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898506Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
This reverts commit ddbd49f9. Reason for revert: CL:1879255 is causing the flakiness and is reverted (CL:1904504). Revert this CL to re-enable the tests. Original change's description: > Disable flaky TaskManagerBrowserTest.NoticeHostedAppTab*Reload on Linux. > > TBR=afakhry@chromium.org > > Bug: 1021553 > Change-Id: I6d6170beb77d08da192d24e7ebb7246a83926a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899334 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712622} TBR=waffles@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1021553 Change-Id: I1fe435871e401d46cff04c1e16604214e3d2ea43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904215Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713692}
-
Anand K. Mistry authored
Also convert usages of Bind -> Bind{Once,Repeating}. Bug: 1007814 Change-Id: I205f9a8ff20900eb42e8b2225a1ca3fb49a4a989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902178 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a942a9f9a235..26c5a8d1e381 git log a942a9f9a235..26c5a8d1e381 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 achuith@chromium.org OWNERS: Add chromeos ui folks to chrome_ files. Created with: gclient setdep -r src/third_party/chromite@26c5a8d1e381 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6352481284ca566c618426b0b6e2d5b24013cf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904806Reviewed-by:
-
Adam Langley authored
After doing real-world testing against SIKE[1], re-add the feature flag purely to enable CECPQ2, in the hopes of reaching Stable with it. [1] https://www.imperialviolet.org/2019/10/30/pqsivssl.html Bug: 930812 Change-Id: I4b05b5b1eff7288269640496735ae81168920f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904754 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#713689}
-
Wez authored
https://chromium-review.googlesource.com/c/chromium/src/+/1895745 migrated the GPU process' surface to be embedded as a child View, setting ViewProperties on it to prevent it receiving focus. Because the ViewProperties had no bounding_box set this prevented the GPU surface View from actually being displayed. Bug: fuchsia:29945, 974826, 1022586 Change-Id: Iba93746719751911d645f067ad52e7b9bb8b661d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904557 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#713688}
-
Kenneth Russell authored
In certain situations upon switching between the integrated and discrete GPUs on dual-GPU MacBook Pros, the WebGL context has to be lost and restored because its contents can not be preserved: - If the user allocated multisampled renderbuffers using the WebGL 2.0 API. - If preserveDrawingBuffer:true and antialias:true are both specified. To implement this, notify client code which GPU is active after the switch, by sending the existing gl::GpuPreference enum via both GPU IPC and Mojo. Fix several bugs in dispatch of the GPU switched notifications, and handling of context loss and restoration. Fix an existing race condition where the antialias:true but preserveDrawingBuffer:false case would reallocate the back buffer unnecessarily. Add tests for these code paths, including covering previous CLs' work. Some of the new tests are being skipped while landing this CL to avoid having this CL reverted if flakiness in them is discovered. They will be enabled in a subsequent CL. Bug: 681341 Change-Id: I5f7aa6b24fd54ba6cf77403c33367956ff00bd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885636Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/76ee91e12642..f7e05c734266 git log 76ee91e12642..f7e05c734266 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 rharrison@google.com Remove deprecated API elements (#870) 2019-11-07 9856269+sarahM0@users.noreply.github.com Add support and unit test for OpTypeInt, OpTypePointer and OpConstant (#872) Created with: gclient setdep -r src/third_party/shaderc/src@f7e05c734266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I62d60c539c538455fa4da9731d33c16ab9c171ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904625Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 1016870, 860467 Change-Id: I185dc9f2eb07b0471ddf3eb8ceafdd3768c02af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897700 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713685}
-
Scott Violet authored
These come from running the android linter. BUG=1020414 TEST=none Change-Id: I02069762e3cbadf595884ddaa607c810a30fc45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904763 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713684}
-
John Budorick authored
Bug: 984162, 1004848 Change-Id: Ibb7c47f0188de8e077cd30aa8d68ca61133d2037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904549 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713683}
-
