GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4b7de4a5..573561bf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iece2651aa1d1ff01e4a211dc5477445ae0b5a007
Reviewed-on: https://chromium-review.googlesource.com/1256602Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595743}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: If9c1c2e59ed0f603be7a84a508bebd7d12566f8b
Reviewed-on: https://chromium-review.googlesource.com/1256075Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595742}

This reverts commit 941c32aa.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> PaymentRequest: Fix a memory leak in retry()
> 
> In the current implementation, memory leaks occur becuase the internal
> view_stack_ for payment sheet grows incrementally whenver calling
> retry(). So, this patch uses GoBackToPaymentSheet() instead of
> ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to
> reduce stack's size internally.
> 
> Bug: 861704
> Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc
> Reviewed-on: https://chromium-review.googlesource.com/1255082
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
> Cr-Commit-Position: refs/heads/master@{#595644}

TBR=rouslan@chromium.org,jinho.bang@samsung.com

Change-Id: Ibf67fa672afee9b3da73b6fb22f325641b011186
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 861704
Reviewed-on: https://chromium-review.googlesource.com/1256394Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#595741}

We add integration test coverage for PREFERENCES under pseudo-USS, and
factor out some duplicated code to a newly introduced FeatureToggler, a
helper class to run tests with a feature switch enabled and disabled.

Bug: 870624
Change-Id: I6b1b446439969d5c6e948e21ca160876e14c5cdb
Reviewed-on: https://chromium-review.googlesource.com/1253762
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595740}

Bug: 851163
Change-Id: Ie02bf11865d1f84254d14723dfd55e26c1987609
Reviewed-on: https://chromium-review.googlesource.com/1256012
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595739}

In CL:1195175 we change the formula for Vaapi VEA. However, the
formula still failed at small resolution. According to the
investigation at crbug.com/889739 comment 1 and 2, using the fixed
buffer size might be the choice before we can update the buffer size
when the bitrate and framerate are changed.

Also, Because this function is general for Vaapi VEA and V4L2 VEA, we
move it to gpu_video_accelerator_util.

BUG=b:113309237
BUG=chromium:889739
TEST=pass VideoEncoderTest CTS on eve and scarlet device
TEST=pass RTC lookback on eve at H264 HD
TEST=pass VEA unittest on eve

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0aa6fd8b67c19ad93bae6e62430105dc9ccf6a80
Reviewed-on: https://chromium-review.googlesource.com/1253315
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595738}

This reverts commit a9d61b8e.

Reason for revert: flaky test

Original change's description:
> Implement RTCIceTransport.onselectedcandidatepairchange
> 
> Bug: 864871
> Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286
> Reviewed-on: https://chromium-review.googlesource.com/1208961
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Commit-Queue: Steve Anton <steveanton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595700}

TBR=dcheng@chromium.org,hta@chromium.org,haraken@chromium.org,hbos@chromium.org,steveanton@chromium.org

Change-Id: I946ade2587e49b3273d9dd303a3e383e8f5f16a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864871
Reviewed-on: https://chromium-review.googlesource.com/1256622Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595737}

https://webrtc.googlesource.com/src.git/+log/40b52f789661..ee216640ddcc


git log 40b52f789661..ee216640ddcc --date=short --no-merges --format='%ad %ae %s'
2018-10-02 buildbot@webrtc.org Roll chromium_revision 7d2cf7c4..81efb6d0 (595610:595716)


Created with:
  gclient setdep -r src/third_party/webrtc@ee216640ddcc

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7f6f9edbe610f5d0f71de33a62a81695ed8a7a7e
Reviewed-on: https://chromium-review.googlesource.com/1256227Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595736}

We leverage the recently introduced layer that allows integrating
legacy SyncableService implementations within the newest architecture,
USS. This requires forking the custom controller, because a different
class hierarchy is used.

The new codepath is behind feature toggle
kSyncPseudoUSSHistoryDeleteDirectives.

Bug: 870624
Change-Id: Ief8fb0d5f5d0472aeea1e0edf42e905632bc33fb
Reviewed-on: https://chromium-review.googlesource.com/1251262Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595735}

The crash stack shows OnGridEmpty being called because of WindowDestroyed
while overview is shutting down because of leaving tablet mode.

The feedbacks report say this is play store related, but i have been
unable to reproduce.

This cl introduces a early exit in OnGridEmpty if overview is currently
shutting down. The cause seems like play store is getting destroyed while
in overview tablet and perhaps causing a race condition, but we should
prevent overview from crashing if play store closes its window
unexpectedly.

Test: none
Bug: 881089
Change-Id: I8e8daceb53d2ac56f92662b14d33fd86979dff25
Reviewed-on: https://chromium-review.googlesource.com/1256168Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595734}

Add sendBrowserTestCommand that expects a 'string' result: this helper
retries until a 'string' result is received, and logs errors.

Update sendTestMessage docs (change message -> command) and update the
test extension harness to use sendBrowserTestCommand.

Bug: 891148
Change-Id: I5840668919672e68787eccd8dece3eae5f2d8c45
Reviewed-on: https://chromium-review.googlesource.com/1256482Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595733}

FileApp QuickView has an [open] attribute, present when it (QuickView)
is open, and removed when it's not open. Verify the attribute appears,
and disappears, for all quick_view.js tests.

No change in behavior, no new tests.

Bug: 891150
Change-Id: If90ae81cd60cd350497dece3896173f432571ccc
Reviewed-on: https://chromium-review.googlesource.com/1256465Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595732}

https://chromium.googlesource.com/catapult.git/+log/2ba11d1c2b02..95ed233ed1a3


git log 2ba11d1c2b02..95ed233ed1a3 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 sadrul@chromium.org tracing: Avoid rAF callbacks when hidden.


Created with:
  gclient setdep -r src/third_party/catapult@95ed233ed1a3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I7076194fb63ea4c393a28649f4c43d23bcd2c1ab
Reviewed-on: https://chromium-review.googlesource.com/1256025Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595731}

Previously, the snapshot was displayed during disappearing animation.

We thought we were showing the recreated layer during the animation (see
L819). But that code didn't work for some reason and, actually the
shapshot was visible instead.

And after that, I added the code to hide snapshot correctly
(crrev.com/a128a1b9) and the issue became obvious.

This CL reverts the CL to hide snapshot (crrev.com/a128a1b9) for
temporary solution, and removes the unworking code (L819). I will
consider another solution later.

Bug: 890701
Change-Id: Ia5f1565408c2d13ceae6e9886a9cc1088bfed40b
Reviewed-on: https://chromium-review.googlesource.com/1256385Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595730}

Add a tall html document for scrolling tests. No change in behavior so
no new tests, just adding a resource.

Bug: 891150
Change-Id: I8069e481c098aae21564e5e3ba43e52b12372a04
Reviewed-on: https://chromium-review.googlesource.com/1256463Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595729}

Before this patch the DevToolsAgentHost was left with a pointer to
deleted client when Autofill Assistant finished, causing a crash when
the tab was destroyed.

This patch fixes that issue by having the client detach itself when it
is deleted.

Bug: 806868
Change-Id: Id10f0ba7fdaa0216d7b3053c25d965c7ce02bcc7
Reviewed-on: https://chromium-review.googlesource.com/1253106
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595728}

https://webrtc.googlesource.com/src.git/+log/957c62e0d63e..40b52f789661


git log 957c62e0d63e..40b52f789661 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 buildbot@webrtc.org Roll chromium_revision 1190491c..7d2cf7c4 (595509:595610)
2018-10-01 orphis@webrtc.org Add support for send_encodings parameters in addTransceiver
2018-10-01 buildbot@webrtc.org Roll chromium_revision 148156b3..1190491c (595385:595509)
2018-10-01 ssilkin@webrtc.org Configure frame references in VP9 encoder wrapper.


Created with:
  gclient setdep -r src/third_party/webrtc@40b52f789661

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iafd0fc7e1e8f62417ce4d6d63d0b187b616af91e
Reviewed-on: https://chromium-review.googlesource.com/1256224Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595727}

With the advent of HTTPS Server Previews, we need to remove the "not
HTTPS" verbage from these strings. See the bug for more info and where
I got the strings.

Bug: 889684
Change-Id: I6d3669f30415396a68b81e316a9cc3435fc33f37
Reviewed-on: https://chromium-review.googlesource.com/1255682Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595726}

LazyThreadControllerForTest makes it hard to write tests related to task
runners. We aim to remove this class, and this CL is one of the steps.

In media unittests, LazyThreadControllerForTest is not necessary. Use
WebThreadScheduler::CreateMainThreadScheduler instead.

Bug: 870606
Change-Id: I0976c4db02e466f06247bf5a82654734f6c7d7bd
Reviewed-on: https://chromium-review.googlesource.com/1250684Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595725}

There is no need to use SingleThreadTaskRunnerForTesting here.

Bug: 870606
Change-Id: I2219ece19db82e1636f2cb83eb4570dd1d09b08f
Reviewed-on: https://chromium-review.googlesource.com/1253524Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595724}

Methods called in DestroyTask() assume that the input and output queues
have been acquired. However this is only true if Initialize() has been
successfully invoked, which only happens if a V4L2 codec device has been
found. Consequently, the V4L2VDA crashes on every non-V4L2 platform.

Fix this by explicitly checking that the queues have been acquired in
the relevant methods. Also add a few DCHECK() that check our assumptions
about the presence of input and output queues to make the code sturdier.

BUG=890952
TEST=Checked that VDA unittest was passing on Eve and Hana.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibfa39a85486330c4daa1c0d16c0051796c0011c2
Reviewed-on: https://chromium-review.googlesource.com/1256387
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595723}

Bug: 887888
Change-Id: I51557e114a1385e75476bae20dd8843c383c1b26
Reviewed-on: https://chromium-review.googlesource.com/1253103
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595722}

The logic changes depending on this histogram have not landed,
so let us keep it around for a bit longer.

BUG=884869

Change-Id: Idad11e54709533ce11e5b154aa06b16c003ced71
Reviewed-on: https://chromium-review.googlesource.com/1256203Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595721}

Bug: 884961
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I4c0bbf99bf369e53f19b0566a8eac68636c69153
Reviewed-on: https://chromium-review.googlesource.com/1256009
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595720}

Having a large amount of <script> tags on a page with an invalid type
for execution (e.g. text/html) triggers the same path for event loop
yielding as JavaScript tags, causing slowness due to parser yields and
unnecessarily aggressive chunking. Avoid performing this logic if the
ScriptLoader can't recognize the script type.

This reduces the amount of time it takes for DOMContentLoaded in the script
attachment for issue 873648 from 367ms to 208ms, similar to the div attachment's
209ms.

R=kouhei@chromium.org

Bug: 873648
Change-Id: I4c7ea76feb2034f5ff97fe08b481c790b9a35122
Reviewed-on: https://chromium-review.googlesource.com/1247230Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595719}

Nothing inherits from the Mac MenuController, except its own tests.
It also sends out some notifications that were once used by a test,
which was recently deleted.

Bug: 832676
Change-Id: Ie95206a3a17461c41683422d61f5a18e4ae5c95a
Reviewed-on: https://chromium-review.googlesource.com/1250466Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595718}

https://skia.googlesource.com/skia.git/+log/083bc1576a0e..16c9216905c1


git log 083bc1576a0e..16c9216905c1 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 reed@google.com remove LEGACY_SVG code, as no one defines that flag anymore.


Created with:
  gclient setdep -r src/third_party/skia@16c9216905c1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: Ib325eecbe8973bf4cde4907cc49a749aed4fe0d4
Reviewed-on: https://chromium-review.googlesource.com/1256225Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595717}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/399029db4a18..421d954080fe


Created with:
  gclient setdep -r src-internal@421d954080fe

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I92cdfc345b8ca07ece9eb5248ca4d7f3c5d24c7d
Reviewed-on: https://chromium-review.googlesource.com/1256226Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595716}

I'll be leaving the team soon, you'll still have good reviewer coverage
across timezones.

BUG=b:116761000
TEST=None

Change-Id: Id323102da135ad095b408bbbb5102ce469b8321f
Reviewed-on: https://chromium-review.googlesource.com/1252323
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595715}

Do not attempt to comment on CLs in dry run mode.

Change-Id: I141d143674b22d47021ea425259491d3698ebf2d
Reviewed-on: https://chromium-review.googlesource.com/1255964Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595714}

Atomics.notify is the new alias for Atomics.wake. This use counter
lets us figure out if Atomics.wake can be deprecated without
breakage.

V8 use counters were added here:
https://chromium-review.googlesource.com/c/v8/v8/+/1234581

Bug: v8:7883
Change-Id: I8eb7f32535aa3d913362aae1544e1dc2f595d38e
Reviewed-on: https://chromium-review.googlesource.com/1255587Reviewed-by: Ben Smith <binji@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595713}

This CL applies same anchor insets to both UnifiedSystemTray bubble
and volume slider bubble. It gives 8dip padding between the shelf and
the volume slider (see the screenshot in the bug).

TEST=manual
BUG=888182

Change-Id: Idd455bb272cf58fb023a69359cd6ec68755a2b59
Reviewed-on: https://chromium-review.googlesource.com/1250461
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595712}

Bug: 872462
Change-Id: I0f20f1c71d3d9aee53a2f875198e1e4b3461d90c
Reviewed-on: https://chromium-review.googlesource.com/1232397Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595711}

BUG=762641
TBR=sammiequon@google.com

Change-Id: I68b6fabc93058316d96f0508c3b8ead15a4bd25e
Reviewed-on: https://chromium-review.googlesource.com/1256070Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595710}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I328e26bb479248995ced0d1a7dcc2867c6247f78
Reviewed-on: https://chromium-review.googlesource.com/1256443Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595709}

Add a test that verifies that runtime.onStartup fires on Service
Worker based extension upon chrome start.

This CL also expands "runtime" feature to "extension_service_worker"
context type.

Bug: 891016
Change-Id: I4a11f6da2f5311d7901ad8bb05c348b9343fe701
Reviewed-on: https://chromium-review.googlesource.com/1255588
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595708}

This CL preemptively fixes closure annotations for all NUX-related JS
files, there will be a follow-up CL to actually enable closure compiling
on these files.

Bug: 874151
Change-Id: I67d56d7b0cffc2c8fa8134c03bf748eaaf79c376
Reviewed-on: https://chromium-review.googlesource.com/1256362
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595707}

This CL hooks the video thumbnail backend to the UI layer of new
download home.

Bug: 826021
Change-Id: I190ad09e8231d94d7546128bd1d22dc39f4d5f35
Reviewed-on: https://chromium-review.googlesource.com/1247529
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595706}

Bug: 864900
Change-Id: I9228f1d475e19786ce675da93210c08b54bc3988
Reviewed-on: https://chromium-review.googlesource.com/1250523
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595705}

Add a new mixin for the new input container, which is needed by the
PDF viewer.

Also move background-color styling to the existing
--cr-input-background-color so it is applied to both the container and
the input.

Bug: 888985
Change-Id: I60e1dfe6828ba2d198984ed9ca33d0753aaa1308
Reviewed-on: https://chromium-review.googlesource.com/1244831Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595704}