- 24 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c86d8fb76ac3..1c96e6739bbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6adb005b3025b63999dedaf9e8a86564bcfde700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801036}
-
Tommy Steimel authored
This CL is a followup of crrev.com/c/2365314 which removes the code that is deprecated by that CL. There is a chrome-internal CL that must land after that CL and before this CL in order to avoid a broken state. Bug: b:154517281 Change-Id: I21e0363a0744600b8d91857d53d435841b17145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367934 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801035}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/09b5e6b1950b..7ce9947d8103 2020-08-24 lehoangq@gmail.com Metal: autogen for 3D texture's mipmap generating shader. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I4fd85ab07f6b6827425f89dbcf045a3e74fcd454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801034}
-
Matthew Wolenetz authored
This reverts commit 71256e1f. Reason for revert: Either this or the next devtools roll (already reverted) are suspected in closing tree crbug 1121242 Original change's description: > Roll DevTools Frontend from 5a8fc1fe06a2 to 01f7fadf76bf (3 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..01f7fadf76bf > > 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md > 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag > 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I3de852373f7bc1b728fa28cdc53965ad9d15fd73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372006 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800966} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iefb5604454d6a9ccb1b832535a708cdc680510dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372892Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801033}
-
Matthew Wolenetz authored
This reverts commit 8c45be6d. Reason for revert: Either this or the previous devtools roll are suspected in closing tree crbug 1121242 Original change's description: > Roll DevTools Frontend from 01f7fadf76bf to ecc4ecb65cd8 (1 revision) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01f7fadf76bf..ecc4ecb65cd8 > > 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Ieb099222e319b09a3c54525341520a9f8e1322d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370523 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800979} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3930a85f217d2cb99fefae80b25754820310cdbf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372891Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801032}
-
Matthew Wolenetz authored
This reverts commit 1bc8019f. Reason for revert: One or both of the two previous devtools rolls are suspected in tree closure - crbug 1121242 Original change's description: > Roll DevTools Frontend from ecc4ecb65cd8 to 6702add20dd3 (2 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ecc4ecb65cd8..6702add20dd3 > > 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. > 2020-08-24 tvanderlippe@chromium.org Fix contextmenu for console view messages > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I7d06cf9b8d0a1c1d72d1dbac6ba2c466d04ae487 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371337 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#800995} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I95e0189bf83a3b2fc65905c8f9cdacfa6cd44880 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372730 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801031}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I36e17af8164e44b0f7e81c6513ce044370bc424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801030}
-
Omer Katz authored
This reverts commit 0a610db7. Reason for revert: The same stack trace still appears on new crashes. Original change's description: > Speculative CHECK to pinpoint crash. > > The issue below correlates to element_under_pointer_.at returning a > nullptr. All calls to element_under_pointer_.at but one are prefaced > with an if(element_under_pointer_.Contains(...)) check. > That one call is prefaced with a DCHECK. Most likely culprit is that > there is a real-world case in which the DCHECK doesn't hold and is > not covered by our tests. > Making the DCHECK a CHECK should confirm that. We'd still get the > same number of crashes overall, but with a different stacktrace. > > Bug: 1114579 > Change-Id: Ie28c971ed2114cf4a780f9eb5366c60d7669315c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359081 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798657} TBR=haraken@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114579 Change-Id: I9ff7e81bbe50484718ced3fd1cc97f900427be07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372366Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801029}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f9f6adb625c4..cdc009c24afa 2020-08-22 wl@gnu.org * src/truetype/ttgload.c (TT_Get_VMetrics): Add tracing message. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ibb8813accd8e8efcbddbe46ac6ec4722f4014dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370213 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#801028}
-
Philipp Hancke authored
Adds usage counters for the promise versions of - setLocalDescription - setRemoteDescription - createOffer - createAnswer as well as now counters for the total of each. The usage counters for these have only been applied to the non-promise versions so far. BUG=None Change-Id: I50757cc66821cde7f46b3a864d33965f7543ed70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361686Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#801027}
-
Liquan (Max) Gu authored
Context: Organize the logic of parseAndValidateDetailsOrDisconnectFromClient to prepare for splitting it into business logic and UI logic. The change of this CL is done based on the discussion[1]. Change: * Rename setShippingOption into setShippingOptionIfValid so as to be explicit about the validation purpose. * Close client before SkipToGPay error out. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1787117/5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#1243 Change-Id: I918fb133444d32797b7a71d3aede4586c3c0cb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372802 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801026}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/216b984d3946..87d42e5d12b3 2020-08-24 bsalomon@google.com A new way to specify YUVA planar data from SkCodec to SkImage_Lazy 2020-08-24 johnstiles@google.com Disable ClangTidy namespace comments for short blocks. 2020-08-24 mtklein@google.com style guide tweaks 2020-08-24 tmoniuszko@opera.com Remove duplicated header file from sources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I1b7107dfc7589355de0ae371862d56c274f9e960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801025}
-
Peter Marshall authored
The agent can be disabled when this message arrives, just like the undo() and redo() methods above. Check for this explicitly because it sets history_ back to null which can cause a nullptr dereference. Bug: 1115856 Change-Id: I503a8dffc5abd3b490d6ca21ae22f0edafb8e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367680 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#801024}
-
Becca Hughes authored
The consent covers both background fetching and safe search. BUG=1120621 Change-Id: I32dbec2b9b1644654ca3f465ef4c7986c952e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369296 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#801023}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70b2cf8b368d..d37b0ec2bb0c 2020-08-24 minyue@webrtc.org Passing the estimated capture clock offset to SendVideo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a243a433eb1beb57925f3649c9695900f470073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801022}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /services/device/generic_sensor This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 1110266 Change-Id: I460f572b6271240ae68a867b8059894fac34b583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371299 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#801021}
-
Roberto Moura authored
Replace nested macros with base::ClampToRange<CGFloat>(x, 0, 1). Change-Id: I46a26b3bfe19fffc98b18063890317a93d0baaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372428 Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#801020}
-
Andrew Grieve authored
Not much change in R8 here, but it picks up a fix needed to safely enable class merging in the presence of APK splits. Bug: 1040534 Change-Id: I935bcdd0395a8d3bacc960c04bb779d1f06b11cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368471Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#801019}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/media/media_engagement_browsertest.cc This CL was uploaded by git cl split. R=beccahughes@chromium.org Bug: 1110266 Change-Id: Ic8150752c7c605d957c4516914586543fc310001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371247 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#801018}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /ui/aura This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1110266 Change-Id: I96cd101fb7cc5daf4e2398c9a4b7e80448c623a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371303 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#801017}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c86d8fb76ac3..1c96e6739bbe 2020-08-24 piotr.roguski@mobica.com Added protos/perfetto/trace/ps:zero to public_deps of libperfetto. See crbug.com/1098746 for more details. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I448bb53ed3757c8e385807503534ef41b717923d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801016}
-
Anatoliy Potapchuk authored
This test had the same faliure reason as others KioskUpdateTest.*'s, which after recent reenabling did not exhibit any failures. Bug: 949490 Change-Id: Iead5f727cf87ccba15b99ef6e3991d2eb05297ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372283Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#801015}
-
Nico Weber authored
This will make sure compiler updates don't break the mac-arm64-rel bot. The bot currently only builds and doesn't run tests, but it's a start. Bug: none Change-Id: Ifbd15713c541aa62339a2ef6b72e009527716c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372724Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#801014}
-
Kevin Ellis authored
The flake is caused by limited precision of timeline times. When comparing times with >=, the boundary time needs to factor in error tolerance. The virtual/threaded-no-composited-antialiasing variant of this test had a recent flake score of 954. Bug: 623434 Change-Id: I44b41da1326849da4b3dec30cea76be6673e0b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368500Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801013}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser/font_unique_name_lookup This CL was uploaded by git cl split. R=drott@chromium.org Bug: 1110266 Change-Id: I6e746e1ed90bf2bab026c0c159ebd926d7411979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371289 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#801012}
-
Sorin Jianu authored
Remove the --single-process command line switch. After this CL, Windows is using COM RPC for all client server interactions. Bug: 1060807, 1060800 Change-Id: Ib3582d56ee01724e176ac04f0d6c2600fbf1bb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321330 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#801011}
-
ckitagawa authored
If a launch is backgrounded before TimeToFirstBitmap we shouldn't record it. This CL is a very simple change to enable that and mirror the behavior of FirstContentfulPaint. Bug: 1109991 Change-Id: Ic1624516d55ded2eb74fa140d9f0d57865b11a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372722 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801010}
-
Henrique Nakashima authored
This should fix the failure in the builder and allow the script to be run from any directory. Bug: 1111056 Change-Id: Ibecfbe763a18bf4fcc5f227d23ce42edee3a2ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369011Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#801009}
-
Sébastien Séguin-Gagnon authored
In some cases the model and table were not in sync, which caused a crash when trying to get the visibleCells of the table. The reload should not be too expensive since we only call it when we're on the root bookmark page. Bug: 1116408 Change-Id: I41e3f1c6d09ca5b92f2bbb0494d426e04f2db539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370605Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801008}
-
ckitagawa authored
This CL defers the subframe transform until serializing so as to not affect the position of the sub-picture in the paint preview if embedding into a single SkPicture. Change-Id: I613e713e08ea453dd7999f06810f7481501b0658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364171Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#801007}
-
Etienne Pierre-Doray authored
Jobs API causes longer running concurrent marking task. Since marked bytes is only recorded when the task exists, this causes the mutator thread to underestimate progress and spend more time marking. To avoid such regression, this CL makes concurrently_marked_bytes_ atomic and updates it more frequently. Drive by: Remove unused kConcurrentMarkingStepDuration param that was previously used for yielding. Bug: 1119552 Change-Id: Ia91c994a4ad417456bbe07bd3f4190f69cba5c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368498Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#801006}
-
Sigurd Schneider authored
DevTools change: https://crrev.com/c/2367940 Bug: chromium:1011811 Change-Id: Ib3725b572313baf56bbcde3783c2bc6094c02e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372483Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#801005}
-
Frédéric Wang authored
This is a follow-up of [1] where the validation on the web and browser processes have been unified. Tests for 'web+' have been added to ProtocolHandlerRegistryTest (browser process). This CL adds similar and more complete checks to the existing WPT test (web process). The relevant section from the specification says [2]: * Set scheme to scheme, converted to ASCII lowercase. * If scheme is neither a safelisted scheme nor a string starting with "web+" followed by one or more ASCII lower alphas, then throw a "SecurityError" DOMException. Bug: 971917, 952974, 627682 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2362802 [2] https://html.spec.whatwg.org/multipage/system-state.html#normalize-protocol-handler-parameters Change-Id: I769048bd4db6883a75d4237f20f23aa61452d732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371632Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#801004}
-
Leonard Grey authored
We've had longstanding issues with interrupted tab drags not cancelling the move loop, often causing a crash when the loop is ended belatedly. A recent repro (issue 1119714) theorizes that a NSLeftMouseUp event is not reaching the move loop. Another repro case from a while ago (right clicking the tab while dragging) had a similar proximate cause. This change causes the move loop to also look at mouse moves while it's active. If it receives one (and the left mouse button is not down), it assumes we missed a mouse up and terminates the loop. (As a side note, with this change, I can no longer repro the behavior in 119714 where a single full-screen tab drag can flakily unfullscreen the tab. I'm thinking this behavior itself was due to move loop shenanigans.) Bug: 1119714,1030987 Change-Id: Idd4c765e1abfc87099fa6be82ae2e22f8dc9c55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368172 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801003}
-
Scott Violet authored
The coordinates need to be converted if zoom-for-dsf is enabled. BUG=1119725 TEST=see description in bug. Change-Id: Ic70a77cb726fb1458a1bbb5304d8ec518176901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370654Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#801002}
-
Andy Paicu authored
TBR=raymes@chromium.org Bug: 1016730 Change-Id: I6c00d5179fb1013c3b171281ea82e6baef961385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372563 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801001}
-
Nico Weber authored
Bug: none Change-Id: Idd7520386dbb7965dc357619fc850e6b2949ef19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372723Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#801000}
-
Charlie Hu authored
Bug: 1113375 Change-Id: Ic20b0900ab8ad07792454a1bbc2e2cf5ea1b9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333499Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#800999}
-
Raphael Kubo da Costa authored
Introduce the same changes added to the regular Permissions API implementation in r756753: instead of having a "wake-lock" permission with a |type| field set to either "screen" or "system", the spec now uses two separate permissions with no |type| field, "screen-wake-lock" and "system-wake-lock". Fixed: 1121076 Change-Id: Ib050a1efa82143c177e32bb6a39cad9203198dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372365 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800998}
-
Monica Basta authored
Bug: 1063856 Fixed: 1121142 Change-Id: I8471310b8c0c3e8fb139ba5f48ee6d2f90176a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367834Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#800997}
-