GitLab

This creates the lib build file, adds any missing dependencies, and
moves a crashpad dependency that that was incorrectly placed in the old
lib rule.

Test: gn check out/aw 'android_webview/*'
Bug: 934152
Change-Id: Ic9a03e5a8f105364f9c61e08b35a5889cabfea3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880070Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710053}

When running unit_tests there is no system_network_context_manager
available, so provisioning can't take place. If that is the case then
don't attempt to provision an origin ID.

Tested this with an Android emulator. Without this change 9 of the
OptimizationGuideHintsManagerTest unit_tests failed, and all pass after
this change applied.

Bug: 1018052
Test: see above
Change-Id: Ic3733014c00fc48d1b6860142f08daffcf3d8391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881950Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710052}

Convert the implementation and all users of the
ui::ozone::mojom::DrmDevice interface.

Bug: 955171
Change-Id: I330afef5a15856e9632ee441e95d255bd6d7b502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862455
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710051}

This reverts commit 959cddb1.

Reason for revert: The just enabled testKeyboardHideState test keeps failing:
https://ci.chromium.org/p/chromium/builders/try/ios-simulator/403589
https://ci.chromium.org/p/chromium/builders/try/ios-simulator/403581

Original change's description:
> [iOS][MF][EG2] Migrate keyboard observer test
> 
> Remove deprecate test that would require new code to be migrated.
> Update and enable keyboard disappear test.
> Create app interface to interact with a shared instance of the observer
> in the app.
> Remove OCMock usage in the test.
> 
> TBR=eugenebut@chromium.org
> 
> Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709939}

TBR=eugenebut@chromium.org,stkhapugin@chromium.org,javierrobles@chromium.org

Change-Id: I40a1bfece2a1b3eb03aec11d58c1ab0496b420d9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885252Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710050}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=nharper@chromium.org

Bug: 1018887
Change-Id: Id2d23759b383b43fea02bfba279ec96286da5eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884997
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710049}

This fixes a flaky test crash in PageInfoBubbleViewTest where
content::BrowserSideNavigationSetUp() was called but we weren't calling
the corresponding content::BrowserSideNavigationTearDown(). This can
cause a DCHECK to trigger [1] under certain orderings of test
invocations. The flakiness isn't bad enough to be problematic yet [2]
(especially since it only triggers on Debug bots), but it's better to
preemptively fix it.

[1] https://cs.chromium.org/chromium/src/content/browser/loader/navigation_url_loader.cc?l=55&rcl=42b97a68450fe6fb772120b6767d5687af3a52df
[2] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=PageInfoBubbleViewTest

All other callers of content::BrowserSideNavigationSetUp() correctly
call the TearDown() function during test fixture tear down.

To reproduce the flaky crash, you can run:

unit_tests --gtest_filter="PageInfoBubbleViewTest.*" --gtest_shuffle \
    --gtest_repeat=-1

This can also be used to verify that the crash no longer triggers with
this CL.

Change-Id: I031e3de8a4b46bb58fcb20d752a83289f1372bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885077Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710048}

The two classes have very similar codes, and should be updated together
for many cases moving forward.

Part 1 basically makes a copy of the current CaptionContainerView and
deletes overview specific code from CaptionContainerView and predicted
to be shared code from the new OverviewItemView. To keep the only
deletions in this patch, left some duplicate code.

Test: manual, unit tests
Bug: 1017912
Change-Id: Id1e54b681201a528be69f1f95e2860d1ba02c892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880148
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710047}

Factored out the browser dependency present in browser_view_layout by
moving the required functionality to its delegate, allowing for
simplified testing of the layout component.

Bug: 871419
Change-Id: If4d738677ad1e6666cda245e64aa62a2e2d103ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877613
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710046}

Future OpenXR runtimes are more stringent on validating correct usage
of APIs. The structure type of XrCompositionLayerProjectionViewobjects passed into XrEndFrame
are not currently set. The current version of the WMR OpenXR runtime
from the Windows store does not do this validation, but future versions
will.

Bug: 1015223
Change-Id: I76c02cc5ad9443947f1a5480ebc4a4f5b1e29608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879864
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710045}

Class cannot be used as NSDictionary key.

Bug: 1017213
Change-Id: I1f660792ccf7ab648cf4fcde3be3b5b8a1b8d745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884671
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710044}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/32c0b43e..054ab2be

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I648cd9102c82481f1ac1d3efb0a8994b6aef83f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884476Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710043}

https://android.googlesource.com/platform/external/perfetto.git/+log/a78528cc1f2b..5a19effaca7e

git log a78528cc1f2b..5a19effaca7e --date=short --no-merges --format='%ad %ae %s'
2019-10-28 tneda@google.com Merge "perfetto-ui: Adding symbol names to callsites in flamegraph"
2019-10-28 fmayer@google.com Merge "Disable HeapprofdJavaCtsTest."
2019-10-28 eseckler@google.com processor: Remove unnecessary includes & fix incomplete rename

Created with:
  gclient setdep -r src/third_party/perfetto@5a19effaca7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3f798b19f7873053bbeae3eb3a9d96d5d3765ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884438Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710042}

Change-Id: I46134d1283708ae8dd79c28cc65d4a180e9baef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884970Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710041}

Used the size and weight from:
https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/typography/

Bug: 989761
Change-Id: Ife83bf55ab112ec61fccab329be5c908d83df3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884363Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710040}

Bug: 1018640
Change-Id: Ia71ad149c92d8d125efecc1a285db4548ddf8f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883268Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710039}

They seem to be fixed long time ago according to the comments in the
linked bugs.

Bug: 614418, 627525, 757097
Change-Id: I7ed1734ee895e5594de18a518f4727f47ada00c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878167
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Jiajie Hu <jiajie.hu@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710038}

This CL adds a new placeholder view to contain the dismiss button and
reserve space in the header so that nothing needs to shift when the
dismiss button shows or hides.

Bug: 1016369
Change-Id: Iaeb4f2735df814e5b8e29c79b28434f2aea1bb17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883622Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710037}

SVGAnimateElement::CalculateAnimatedValue already does this reassignment
generally.

Bug: 1017723
Change-Id: I91917719a10f7d0edab9a7396283c86e8fac1a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884551Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#710036}

This is a followup to this patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1830360

There's sort of a mismatch between whether code uses uint8_t or
char for bytes.  I think uint8_t is a little bit better of a
representation and matches what BigBuffer does.  This cleans up
a bit of storage code and apis to use that in more places.

Bug: 1012869

Change-Id: I7b1e8eb7d9b967f451b19f9c1c6d86c0d89d3ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857648
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710035}

Adding role="application" lets us be in control of the mode change on windows for screen readers.
aria-roledescription is necessary now because we don't want to change users' expectations that this is a menu.

Focus target change is necessary because focusing the application causes all its contents to be read as a label.

Bug: 855123
Change-Id: If2428d875f325b55339b6ad3c14874c9e066e584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869483Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710034}

No functional changes; simplify the code by using the function above rather
than manually creating a ScriptPromiseResolver, a ScriptPromise and then
passing a DOMException to the ScriptPromise.

Change-Id: I65a266dfd95f7d03b5b06cd6ca4fdd85aff67df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878069
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710033}

https://chromium.googlesource.com/angle/angle.git/+log/0964988b77ab..2f71802b4404

git log 0964988b77ab..2f71802b4404 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 jmadill@chromium.org GN: Don't expose glslang when unused.
2019-10-28 jmadill@chromium.org Don't cc angle-team on Chromium DEPS rolls.

Created with:
  gclient setdep -r src/third_party/angle@2f71802b4404

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I88404f544da88545e5ed3f2bf90dad752499bf9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710032}

Bug: 1011921
Change-Id: Ieabbb0ba0b1727200d575f23ad9a5c6477b31557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884369Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710031}

Some minor refactorings too keep GOOGLE_CHROME_BRANDING out of .h files.

Bug: 961769
Change-Id: I4fd7463abd37b915586c5f6b98dbeae5e85bc263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884757
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710030}

Add a boolean metric to Blink.UpdateTime to record whether the event
was before or after FCP (First Contentful Paint). Also re-organise the
way we report FCP to LocalFrameView for the purposes of the new metric
and triggering commits. The latter reduces code in PaintTiming.

Bug: 1001199
Change-Id: Ibc18faae13ece92e1270c72548585e1f3c4dcc2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864366Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710029}

It has been moved to chrome/browser/util/BUILD.gn. This was a
remnant not to break downstream.

TBR=yfriedman@chromium.org

Bug: 995916
Change-Id: I52e7096d7ece8562e7e4f2771aca8db4095d3695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879554
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710028}

Bug: 747349, 941561, 998345, 1010973
Change-Id: If0291306adfb499caf66832495ba49fde7423ab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881496Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710027}

Bug: 1006977, 1006982
Change-Id: Iab5d76265dd7bc0fbbe4cd28cecd051ad3d9cd94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880035
Auto-Submit: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710026}

Convert the remaining bits in both the implementation and clients for the
viz::mojom::VSyncParameterObserver interface to the new mojo types.

Bug: 955171
Change-Id: Ief3fac4c149e79c866ef8f8e556396acd006950b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872005Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710025}

For cases which doesn't actually perform any interpolation (non-'angle')
we can just take the "discrete animation" code-path.

Bug: 1017723
Change-Id: I00acc3de71132245b93fe9d6b2a6469492ddf770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884670Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#710024}

Bug: 1018108
Change-Id: If1d40b5545819b01dd95eac7f6bf3edd98726f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881550
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710023}

In addition the CL fixes a small bug in the settings on desktop. Before the
toggle was enabled in the Sync on - temporary signed out state.

Bug: 1014660
Change-Id: I9e0f4b6012118b6a0bb98510d206377be18ef689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882321Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710022}

Change-Id: I35ca4a7fe3a7a446c71be80ca9e029a382036ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867391
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710021}

Refactor existing code for handling share actions (ShareHelper and
ShareMenuActionHandler) to better fit the MVC model. This is a starting
point for work on the Chrome sharing hub/custom share sheet.

go/chrome-sharing-hub-dd

Bug: 1009124
Change-Id: I6f3825fed98d896507f44d033d953b54cd32131f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850367
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710020}

Bug: 825041
Test: CQ, build
Change-Id: Ieeda5d967ed6ba77334b432810f88a6e01a492bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881688
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710019}

After the primary user requested to enable adb sideloading on the
device, reboot will be necessary to enable the decision is made in fully
trusted environment.

This change adds an OOBE screen for this purpuse.  Upon confirmation, a
DBus message is sent to cryptohome (as a proxy) to enable the flag in
boot lockbox.

Note: Strings are not final and images are placeholder.

      /home/chronos/Local\ State; start ui
      => see confirmation dialog
      => `bootlockboxtool --action=read --key=arc_sideloading_allowed` prints 1
      => `bootlockboxtool --action=read --key=arc_sideloading_allowed` prints 0
      => looks correct.  Clicking "OK" brings us to normal login screen.
      dialog
      => Confirm or cancel doesn't really matter as already enabled.

Test: stop ui; add "EnableAdbSideloadingRequested":true to
Test: click "Enable" brings us to login screen (warning will be added later)
Test: click "Cancel" brings us to login screen (warning will be added later)
Test: Force error state by `$('oobe-adb-sideloading-dialog').uiState_ = 'error'`
Test: (edge case) Enable the feature forcely then show the confirmation
Test: browser_tests --gtest_filter=WizardController*.*
Cq-Depend: chromium:1765656
Bug: chromium:893332
Change-Id: I1135d9e89c37215f0f23dbcdf6244a06c9967f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804495Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710018}

Fix crashes when DCHECKs enabled since we are running into this issue.

Bug: b/143316162
Test: None
Change-Id: Ic4f20131281f1cbc0f7f80f5377804fb40731f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884818Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710017}

If reordering bookmark page is closed by clicking 'Close Incognito Tabs' on
notifications, then the runnable posted by recyclerView will be run. But at
that moment, bookmark model has been assigned to null. This CL makes it
only run when view is being attached to window.

Bug: 1017073
Change-Id: I328550a11432a7288b9508227f9634e9719ae357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884350Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#710016}

The attribute value is still parsed for UMA metrics only.

Bug: 953995
Change-Id: If80a818c9722625a07fc25e6f35be6394c587d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883291Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710015}

Disables the profiler to work around a major performance bug in Trend
Micro's software that gets injected into our processes.

Bug: 1018291, 882982
Change-Id: I04b3b762c3b5cd16258ca6cb63a317e0f33d05ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881980Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710014}