- 04 Nov, 2019 40 commits
-
-
Mark Cogan authored
ChromeTestCase exposes an EmbeddedTestServer property for use by tests, and includes the header for that class in its own header. This means that tests can (and do) use symbols from EmbeddedTestServer without explicitly including them. To make this work, //net:test_support is a public dependency of the egtest test_support targets, so the individual egtest targets can link correctly. This is in general not in line with our "include what you use" policy, which would prefer that code which uses symbols from an API directly includes the header for that API, and explicitly declares it as a dep in gn. This CL: - Makes the test_support dependencies on //net:test_support private. - Changes the EmbeddedTestServer header include in chrome_test_case.h to be a forward declaration. - Updates nineteen egtest.mm files to explicitly include the EmbeddedTestServer header. - Updates twenty-seven targets in BUILD.gn files to have add a //net:test_support as a dependency. Change-Id: Iea336c66a1a7423732e3aaedcf865882b7ac3a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892814 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712100}
-
Mugdha Lakhani authored
Stops periodic background sync timers when the scheduler is destroyed. Change-Id: Ic1d2412df473d74206347cfafbd0fb8c0771b846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893882 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#712099}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I0265753725783fb569783ba6006dec01d7793851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893881 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#712098}
-
Andy Paicu authored
First failing build: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/50593 TBR=mmenke@chromium.org Bug: 1021021 Change-Id: Iaa80a2212610d407ed1062b50fb8309dd12dfcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894010Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712097}
-
Andy Paicu authored
This reverts commit d8a95882. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "CrOS Shelf: Start moving some hotseat logic into the hotseat widget" > > This reverts commit d1531b9a. > > Reason for revert: > > Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the > culprit for failures in the build cycles as shown on: > https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM > > Sample Failed Build: https://ci.chromium.org/b/8897957936228871696 > > Sample Failed Step: browser_tests > > Original change's description: > > CrOS Shelf: Start moving some hotseat logic into the hotseat widget > > > > The general idea here is to encapsulate more of the hotseat's behavior > > into its own class rather than have it all over the shelf layout > > manager. Eventually, I hope to get rid of the huge > > "CalculateHotseatState" method by setting the hotseat state to the > > appropriate values from the relevant places. > > > > Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 > > Commit-Queue: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711796} > > TBR=manucornet@chromium.org, xiyuan@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I231b1da00af70f302dee4382dd05948031af4cf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897695 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712092} TBR=andypaicu@chromium.org Change-Id: Ie10e97f8df7b251ff40d2282808d6ae3369abe2d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893884Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1018130 Change-Id: I9414fc7c9f4b577d1e4b308749fed2da9aef24f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893163Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712095}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icd106c73f2dfba2af3a947b0de42de3b93a6595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712094}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=marq@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Ib6832ed38491ccee5452b66cf2ba26f98d530cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895652 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#712093}
-
Andy Paicu authored
This reverts commit d1531b9a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM Sample Failed Build: https://ci.chromium.org/b/8897957936228871696 Sample Failed Step: browser_tests Original change's description: > CrOS Shelf: Start moving some hotseat logic into the hotseat widget > > The general idea here is to encapsulate more of the hotseat's behavior > into its own class rather than have it all over the shelf layout > manager. Eventually, I hope to get rid of the huge > "CalculateHotseatState" method by setting the hotseat state to the > appropriate values from the relevant places. > > Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711796} TBR=manucornet@chromium.org, xiyuan@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I231b1da00af70f302dee4382dd05948031af4cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897695Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a4037d9f325..26280ecc7991 git log 6a4037d9f325..26280ecc7991 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 treehugger-gerrit@google.com Merge "processor: Retain original event ids during export + always export args" 2019-11-04 hjd@google.com Merge "Support UUID" 2019-11-04 treehugger-gerrit@google.com Merge "processor: Don't build VulkanMemoryTracker if graphics module disabled" 2019-11-04 treehugger-gerrit@google.com Merge "processor: Exclude syscalls from build if not needed" Created with: gclient setdep -r src/third_party/perfetto@26280ecc7991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idd82656817c5606e8299bf5c67ffc7edd263251f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897635Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4cc2dc64ff13..feac94f2761d git log 4cc2dc64ff13..feac94f2761d --date=short --no-merges --format='%ad %ae %s' 2019-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e96039218e9d..6c7208f93d6e (8 commits) 2019-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fda994c63075..aaa64b76c0b4 (8 commits) Created with: gclient setdep -r src/third_party/skia@feac94f2761d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None,chromium:None Change-Id: Ibc44e2d17f510eb53b8fca0e663e77b5cf4f8c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896147Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8846c8af8511..cc9bf6398c03 git log 8846c8af8511..cc9bf6398c03 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 peah@webrtc.org Revert "Correct AEC3 multichannel functionality activation" 2019-11-04 nisse@webrtc.org Delete gturn support 2019-11-04 peah@webrtc.org Correct AEC3 multichannel functionality activation Created with: gclient setdep -r src/third_party/webrtc@cc9bf6398c03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I781abb115c3fecb8f204cfe445fbfac9d8806665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897354Reviewed-by:
-
Andy Paicu authored
Failing first build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16066?blamelist=1#blamelist-tab Suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 TBR=manucornet@chromium.org Bug: 1021011 Change-Id: I91acd45ed360f5bf4ea24987025bc173b096acb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895346 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Alex Ilin authored
This CL adds a new test DemoSignInTest::TurnOffSync to the suite of live Signin tests. The test does the following: - Turn on sync for Account A - Sign in Account B from the web - Check that Sync is enabled for Account A - Turn sync off from the settings - Check that both accounts are signed out from Chrome and the web This CL also simplifies JavaScript code used to sign user in. Fixed: 1006263 Change-Id: Idd901e5d2eaf55fe69fcbc41d304e25d9fd87ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893994Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712087}
-
Oleg Davydov authored
ExtensionDownloader now reports to its delegate cache status (hit/miss/outdated version) of the extension. We need it for later to gather statistics and, in turn, to investigate how effectively cache works, for example, for force-installed extensions. Bug: 1015817 Change-Id: I22a0e73d2926f073a231fe13c73879608e2df7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868881Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712086}
-
Olivier Robin authored
Change-Id: I8e294d3c99382336ec425c67bb43a29cabdf89df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889871 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Peter E Conn authored
This means that we can replace Origins that are invalid with null. Bug: 1018672 Change-Id: I6faf89e66ea0085ba35b5bab10c58d2ac25a631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886890 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712084}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/618ee509421f..f1e5cd73f658 git log 618ee509421f..f1e5cd73f658 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 afdx@google.com spirv-fuzz: improvements to representation of data synonym facts (#3006) 2019-11-01 stevenperron@google.com Add iOS as a supported platform (#3001) 2019-11-01 rharrison@google.com Reset pointers before iterating in fuzzer to avoid double free (#3003) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f1e5cd73f658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I781d88b3feeae2f9857a902cfe7fc0e44bdd6099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896152Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f00c5e49. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If294a0c1d3d67d7581769f0f8f93b51f08bf5a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897446Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712082}
-
Michael van Ouwerkerk authored
Bug: 1018133 Change-Id: Ieef750cae110765d8df7333647cf9865f2ac412f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893281Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712081}
-
Antonio Gomes authored
The later is a 1:1 wrapper to the former, and now that the WebRTC feature is Onion soup'ed, the use of third_party/webrtc types is preferred. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I22853ca19e1fe67a95a8508a2bbb7b3ad25ec17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884473 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712080}
-
Andy Paicu authored
Failing first build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35958 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16066 Blamelist does not give any immediate hints as to what might have caused this. TBR=jamescook@chromium.org, oshima@chromium.org, sky@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org Bug: 1021005 Change-Id: I5bb4fa54d4f65637253606ae3d9f14ab3651d979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892959 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
arthursonzogni authored
In the back_forward_cache_browsertest file, a lot test used "const" for declaring GURL or Origin variables. This is unusual for a variable scoped to a test function. "const" should be used for preventing mutation, this is mainly used in class attribute or method return value. In test, this is not really needed. Adding "const" here is not harmful at all, but since things tend to be copy pasted, it is better the cut the trend now, so that it won't spread more. Bug: None. Change-Id: Ia100e61781cdadaa9b420fab75244d44acedf33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892957Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#712078}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/cc75dee3ba..8cfb8ccc1a TBR=aerotwist@chromium.org Change-Id: Id72179b437099edb9cd74ff9aa9db57bce45acfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893056Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712077}
-
Michael Lippautz authored
Weakness in collections should be expressed using WeakMember<>. Before this CL, hash traits could be used to create custom weakness. This creates a lot of semantic problems, e.g.: - Member<> that may be treated weakly through overriding the traits which is not intuitive. - Composite types that contain custom weakness may treat parts of their objects strongly. If such a composite type is used to create an ephemeron, it is unclear how the key/value relationship should be presented. In practice, it should be enough to model weakness through WeakMember<> which allows the following combinations: - Weak/Strong: Ephemeron semantics - Strong/Weak: Reverse ephemeron semantics. (Key is only traced if value is alive.) - Weak/Weak: If either key or value is dead the entry is removed. Then: - As soon as one field is weak a finalization callback is added that gets executed *after* marking. This allows cleaning up cleared entries. - For mixed liveness (e.g. weak/strong) an additional weak tracing callback is added that is executed until a fixed point wrt. liveness is reached. Change-Id: Ibde1d34ce89501f3e625d5acc4bd96147fece74f Bug: 1019191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889874Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This reverts commit c7dc2cd8. Reason for revert: FakeServer now logs more detailed failure logs which could help debug the flakes, which otherwise don't repro locally. Original change's description: > Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest. > > This TwoClientPreferencesSyncTestWithSelfNotifications test case is > flaky. > > TBR=mastiz@chromium.org > > Bug: 1012688 > Change-Id: I33f1956523be55f3f77db0560aac4c3de6721341 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859635 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705625} TBR=thestig@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012688 Change-Id: Ib12a81eb25ba2a335ead7a1b1316dfa7c2db2db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893199Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=droger@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I563267ff70c01c99f28da788a361b678a60caa8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893539 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Migrate off BrowserThread::DeleteSoon in /chrome/browser/renderer_host/chrome_extension_message_filter.cc Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=finnur@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I826eae60256fc7c8ac5152afc9bfac6a963c7974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894888 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This is a reland of 38ebe59c The patch was reverted because of test flakiness, issue that introduced flakiness fixed now. Original change's description: > Rewrite sync tests to use custom passphrase logic > > SingleClientUserEventsSyncTest.Encryption and > TwoClientSessionsSyncTest.NoHistoryIfEncryptionEnabled used > EnableEncryption(), which only works with Directory implementation of > Nigori and outdated. They were rewritten to enable custom passphrase > instead. > > Bug: 922900 > Change-Id: Ia5fedeae5b7c7071c1ecc82063e5742934caf2e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890316 > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710839} Bug: 922900, 1020070 Change-Id: I7bd06fc272a615eebe0be60b93c7825e3cd13e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895344 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Roman Sorokin authored
* Remove oobe-dialog-host-{height,width} vars. We don't actually use the vars. This would reduce dependency on OOBE * Make discover app occupy 100% of the dialog Bug: 1019857 Change-Id: I58bba1ff78cfa7fe4494f317590aac2d635c3f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893267Reviewed-by:Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712071}
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: I9fb57baca2e4c117723cc00530d0f017c402f16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884732 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#712070}
-
Oriol Brufau authored
Change-Id: Ieb86ea3598107a2417979773f1c90beca19042d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894004Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#712069}
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: I08fc6b7bb5247fdc0cf2eb36abc88867c1b564c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883510 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
nancy authored
kAppServiceAsh is the flag to integrate AppService in UI app_list. Since it has been enabled for a few months for M78, M79 release, it should not be disabled, so the flag kAppServiceAsh can be removed. BUG=1016159 Change-Id: I5ebab190007370286738308e80d8354ea651493f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892978 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Marc Treib authored
Before this CL: In case of network errors, PerUserTopicRegistrationRequest would most likely record an *HTTP* response code of 0 in UMA histograms. This CL fixes this by treating network errors before HTTP errors. Bug: 1020145 Change-Id: Id54cad7a5e01a65fdd5c3cd5877679789af54a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893157Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712066}
-
Carlos IL authored
Bug: 893647 Change-Id: I43169d912f124514b7e12fb56f5c09586f95c8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879659 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#712065}
-
Sigurd Schneider authored
The pending CL crrev.com/c/1891417 adds a new user metric, hence this test needs to be disabled before landing+rolling. Afterwards, the test will be re-enabled with updated expectations. Bug: chromium:1020096 Change-Id: I409feaea758444a4f23d01386d554d46be5a0bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893197Reviewed-by:
-
Jochen Eisinger authored
Bug: 1018108 Change-Id: Ia0db93c0a48324bd5059f77bd9107f2832bb5d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883508Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712063}
-
Giovanni Ortuño Urquidi authored
Similar WebUI tests are scattered throughout chrome/ and content/. This Cl aims to slightly improve things by consolidating tests under content/browser/webui. Now we have: content/browser/webui/web_ui_browsertest.cc content/browser/webui/web_ui_mojo_browsertest.cc content/browser/webui/web_ui_navigation_browsertest.cc content/browser/webui/web_ui_security_browsertest.cc Change-Id: I6f869df20743872c8b84a3458bc096b80bc8773e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875900 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#712062}
-
Dominik Röttsches authored
external/wpt/webstorage/storage_setitem.html does not time-out locally and original flakiness analysis culprit identification seems to have identified an unrelated CL. Local testing with 20 repeats on Mac 10.13 does not result in any timeouts. Bug: 908276 Change-Id: I81179b39c222f8bce954eda6280491515036d6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893263Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#712061}
-
