- 09 Mar, 2020 40 commits
-
-
Ben Joyce authored
Now that Recyclerview has migrated to Androidx, can remove gridlayout. Bug: 1052460 Change-Id: I844e8cd1480b8eb648d0a9104266103e0051c1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094543 Commit-Queue: benjamin joyce <bjoyce@google.com> Auto-Submit: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748384}
-
Annie Liu authored
In blink we use -1 to represent infinite iterations for historical reasons. Rather, we should use std::numeric_limits<double>::infinity() to be more specification-complaint. CL based on crrev.com/c/1373409. Bug: 913662 Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Annie Liu <t-hunliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748383}
-
Markus Handell authored
WebmMuxer feeds signed timestamps into a mkvmuxer method taking only unsigned timestamps. This turned into problems muxing data for the case the MediaRecorder was immediately paused on startup, and WebmMuxer would try to feed negative timestamps to mkvmuxer. The change makes sure we do not insert negative timestamps. Bug: 1045381, 1057810 Change-Id: I3ea00bb3f4d372e9f6ad4eeba484b0cb8a9582fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095071Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#748382}
-
Robbie McElrath authored
This CL reduces the minimum amount of time between seed downloads from 24 to 12 hours. This should reduce the time taken for variations seeds to be distributed on WebView. 12 hours was chosen as a compromise between our need for quick seed distribution and resource usage on device. We may revisit this number based on the results of this change. Test: Manually verified with logs that 12h is used for timestamp check. Bug: 979075 Change-Id: I5b183f9970662468be1b214cf7d8cb6d4665041d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086263Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#748381}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/1901591 made the test useless by changing the initialization order it was meant to test. That change is no longer necessary as scheme registration happens at JNI_Onload, so it can be reverted. Bug: 783819 Change-Id: I7543eee8e42c13cf2b675d97e29ef3cd14669e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095558Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#748380}
-
Ryan Hansberry authored
Change-Id: I25d3bcf5cb68bc6c5a61f8a9fcb946924deef84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092711Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#748379}
-
Scott Violet authored
This reverts commit 1dd4504b. Reason for revert: this test is still flaky. It failed twice in a row here: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44908 and https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44907 . I am also able to reproduce the flake locally. Original change's description: > Regression test for null pointer deref. > > Bug: 1050801 > Change-Id: I67a09733abcc07e83031e05541b945ccdd56eece > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073158 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746908} TBR=pkasting@chromium.org,msramek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1050801 Change-Id: Ic1e632a5e00a97e4d297217619194a0c3631d6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095404Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748378}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I049a1e16fcd8ad7e3e85343cc01ba028f201c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095197 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748377}
-
Hongchan Choi authored
In favor of the self-referencing patch, this mutex can be safely removed. Test: Ran the patch on a repro case from crbug.com/1029462 and saw no crash after 20 min. Bug: 1058555 Change-Id: I0335fa6c878f4ca7e52a03ed7eb6fc0891dfa3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088491Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748376}
-
Samuel Huang authored
To aid in porting SuperSize to Python 3, this CL does the following: * Sort out int vs. float divisions. * Add "'from __future__ import division" to each python file (except mock files for testing). * For int division: Use "//" (was "/") * For float division: Ensure this can be inferred, by using float(), or float constants (e.g., 1024.0). * Change "except" variable assignment style. * Use "except Exception as e" (was "except Exception, e"). Bug: 1054018 Change-Id: I25925196fe33fc7f4ca28f126f180eb4060fa2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094544 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#748375}
-
Henrique Nakashima authored
This reverts commit 4d4e25dd. Reason for revert: Causes crbug.com/1057586 because ChromeFeatureList is accessed before native loads. Original change's description: > [Prefetch notification service]: Java side and glue setup, feature flag. > > - Added a feature flag for the migration. > > - Added and hid new code path in OfflineNotificationBackgroundTask. > > - Created JNI bridge for gluing prefetch notification service in native. > > Bug: 1047037 > Change-Id: If7b728609f86665cfe6b4c61f521f7362000b292 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082087 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747323} TBR=dtrainor@chromium.org,sclittle@chromium.org,xingliu@chromium.org,hesen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047037 Change-Id: Ieefecde67de7d51dd12ae298debdc5a940c0d0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095208Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748374}
-
Fredrik Söderquist authored
We already have a "type tag" as part of the LayoutSVGResourceContainer handling, and can use that instead. Change-Id: I668a95abf214c744fe76a9377ab6db5ed71f249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095068 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748373}
-
Sophie Chang authored
Diff is to use DISABLED instead of DISABLE This is a reland of 564fad0b TBR=tbansal@chromium.org Original change's description: > Add feature flag for disabling local predictions > > This allows us to run the Client-Side Reactive Preconnect in the below > configs: > 1) Default - Local predictions only > 2) Local predictions with optimization guide filling in > 3) Optimization guide only > 4) No predictions > > Bug: 1050101 > Change-Id: I9eb87170aa0079f3384f1797b03cd3d850b1228e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094246 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748290} Bug: 1050101 Change-Id: I7f7fc036b313c3d8931754383cc1d17431b9cb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095210Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748372}
-
Alain Michaud authored
Reason for revert: The flag has never been used and the underlying fix is being replaced by an upstream bluez fix which does not rely on this interface. Bug:None Test:Built Cq-Depend: chromium:1948095 Change-Id: Ieb8eec8b15b4931c49cddc3f288ed7d1723b437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949152 Commit-Queue: Alain Michaud <alainm@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#748371}
-
Greg Thompson authored
BUG=1043624 Change-Id: I4941a0457a6cad84fe694c2fdd26ee3d3adfcdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095062 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748370}
-
Sean Gilhuly authored
These tests are enabled using the GN arg "skia_use_dawn = true". Bug: 1021566 Change-Id: Ifeaa6c3bb0ab9fbfa74fb4946ef61227f6bfacd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037346Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#748369}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5f5b9e95179..abdb603cd140 git log c5f5b9e95179..abdb603cd140 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 bpastene@chromium.org Add betty-pi-arc to telemetry's list of test condition tags. Created with: gclient setdep -r src/third_party/catapult@abdb603cd140 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: Id73c48dfdb581b4af0e29fe4b972f077befa934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748368}
-
Ehimare Okoyomon authored
Replaced string with the same one used on desktop. This string is clearer for toasts, preferences, and accessibility (TalkBack). Example: https://screenshot.googleplex.com/gZCvZkipoi3.png Bug: 1059718 Change-Id: I8860a37b23f879a22d4dedf1148647199b785ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091725Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#748367}
-
Kelvin Jiang authored
This CL makes the "text" param in chrome.browserAction.setBadgeText optional. Setting text to be null (or not specifying it) removes the explicitly set badge text for a given tab. The tab's badge text will then be removed, or will show the default non-tab-specific badge text if set. Bug: 1002961 Change-Id: I7f9f4ef2ac3187fff0b06455fd4abcc1db0a5143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067641 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748366}
-
Benoît Lizé authored
The linker tests don't run on bots (and likely not locally either) and do not support the latest library loading patterns. This is the first step to remove them, as they add non-trivial complexity in the codebase. Bug: 1059707 Change-Id: Ia14693419792f57dc4f65b2fc7f999e833aec42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095059Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748365}
-
W. James MacLean authored
This CL modifies OriginPolicyFetcher to enforce that Origin Policy manifests load with the mimetype application/originpolicy+json If an incorrect mime type is received, loading is aborted, and the OriginPolicy object is returned with an empty policy and status kNoPolicyApplies. Since this same pathway is hit if the manifest load returns 404, we can also set kNoPolicyApplies in that case as well, and a test is included for that. The test includes a valid CSP which, if applied, would lead the test to fail as eval() would not succeed. If the manifest is rejected due to its incorrect mimetype, then the test passes. Bug: 1051169 Change-Id: I59e5bde20c8a21a4fae8dbc3c6f58f34cb292195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080696Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#748364}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f87536c9de24..4e1d6ce38422 git log f87536c9de24..4e1d6ce38422 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 danilchap@webrtc.org Rename java VideoCodecType to VideoCodecMimeType 2020-03-09 phoglund@webrtc.org Purge phoglund from most OWNERS files. 2020-03-09 brandtr@webrtc.org Add |rids| and |mid| printout to RtpConfig::ToString(). 2020-03-09 ilnik@webrtc.org Wire up internal libvpx VP9 scaler to statistics proxy Created with: gclient setdep -r src/third_party/webrtc@4e1d6ce38422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2aa7a3f27f170784408bfc6e03015d4961d31d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748363}
-
Daniele Castagna authored
Unfortunately David left the team more than a years ago. Having his username in OWNERS files causes some confusion sometimes (crrev.com/c/2090605). This CL removes David from the OWNERS files. Change-Id: I09de963f21821e60f1ded2aa4a2cc1ddbbdfa4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093020Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#748362}
-
Nicolas Ouellet-Payeur authored
Roll the changes to traffic_annotation_auditor.exe from these CLs: https://chromium-review.googlesource.com/c/chromium/src/+/2070818 https://chromium-review.googlesource.com/c/chromium/src/+/2079202 The auditor now requires chrome_settings_full_runtime.proto to be generated from policy_templates.json. Also update BUILD files to so that it's generated when building Chrome (for developers who run the auditor locally) Bug: 1046869, 1048178 Change-Id: I4dcddd031b3d242c2326fea50eaf548603b5f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079648 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#748361}
-
Bettina authored
Bug: 1026006 Change-Id: I4f1329df285d044263d52c32447fdab730810cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092181Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#748360}
-
Anqing Zhao authored
On CrOS, the crash reports submission records are stored in a local file: /var/spool/crash/uploads.log. These related infos are uploaded to the crash server periodically. Although our users cannot access to the crash details directly, they still have the requirement to aggregate the crash numbers and causes. This change is to collect required data from local logging file and submit them to the DMServer by using CrashReportInfo proto. Bug: 1040078 Change-Id: I2733364dcbc681af3cdd90ef6d9ef165b991c0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011852 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#748359}
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Note: deps->public_deps needed in order to appease GN's "do you depend on the targets that produce your inputs" check (you can directly depend on them, or indirectly when listed as public_deps). Bug: 1054892 Change-Id: I25ee07e95cf7744428c95cc19141b3ab4c0d5bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090030Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#748358}
-
Sam Bowen authored
* Add a validator that removes properties that are not the right type. * Add double, time, and timedelta types in the document metadata mojo structure. * Use the new mojo types in document metadata extractor. Downstream clank will not be able to read fields parsed into the new type, but will just skip over them. We should consider updating support there. http://cs/clank/java/src/com/google/android/apps/chrome/icing/AppIndexingReporterInternal.java?l=133 Bug: 1044250 Change-Id: Icfd7f0db74abf7bd1261b30dc416c94a7a23b4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062907Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#748357}
-
edchin authored
This CL adds iOS where pertinent to the chrome flag ownership doc. Bug: 1058614 Change-Id: I6d6af5afb2b3948c59524bde180a9b1a12ac6fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095144Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748356}
-
Nasko Oskov authored
This API is no longer used and the bug it references is closed. Bug: 768526 Change-Id: I6570ce4531c7cccd47ab21e26ad7d570d10e6c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091939 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748355}
-
Owen Min authored
Request extension is a multi-steps process. The policy may be updated during the requests. If policy is updated to whitelist or blacklist an extension right before a user confirms the request dialog, we will show the request approved/rejected notification immediately. Bug: 1006899 Change-Id: I0f41774b8c1a89dd9b34465f8237320bdddc6dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089996 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748354}
-
Evan Stade authored
The beforeunload timer in RenderFrameHostImpl may take a long time to actually run if there are other tasks queued before it in the ui thread task runner. This change allows sudden termination in the case where the user tries to close a tab, the timeout fails to fire quickly, and the user tries to close the tab again. This also skips the close event if beforeunload has already timed out (not allowing the renderer another chance to time out). This allows the user to close, in relatively short order, tabs that run the following: while (true) console.log("bar"); Whether that's in a general context, in the beforeunload handler, or both. Bug: 1056257 Change-Id: Idf1242dab5f06e347cf5fc2ca1019255f0da774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092123Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#748353}
-
Marijn Kruisselbrink authored
The ChooseFileSystemEntriesType enum values were changed from camel-case to dashDelimited in M81. In M82 we only want the new dash-delimeted version available, so remove the legacy ones. Bug: 1020715 Change-Id: Id36e8d1009a53039404859c26c8508a5843c7624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095138 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#748352}
-
Clark DuVall authored
Moves over the tests and puts everything in the permissions namespace. ChooserContextBase was originally moved to //components/permissions in http://crrev.com/c/2083454. Bug: 1052375, 1025609 Change-Id: Id44a8f9468a9db6ec3fdd04896f3c97f960d112f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092156Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#748351}
-
Saurabh Nijhara authored
Screen This CL makes the the update required screen use the checking- downloading-update polymer element so that the UI for this process remains in sync with the Update Screen which also uses the same element. A new property for controlling the download message in the dialog is added in the element as it is different for the UpdateRequiredScreen as per the UI mocks. Bug: 1048607 Change-Id: I9a9c26f10eff2b64602ffb59b1da1f61d4278b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078575 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748350}
-
Adrienne Walker authored
This function collides with the quota StatusCallback, so rename it to avoid any issues and to make the move cl easier to read. Bug: 1015214 Change-Id: I4f82b843ccd27561ed1fb27e76a38b72cf0d2d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092931 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#748349}
-
Raymond Toy authored
This replaces PipelineStatusCB with PipelineStatusCallback in the last places except for error_cb_, which seems like it can be called more than once in a test. Bug: 1007799 Change-Id: Ib60a01634267ea4f5313b8ac8f495925a6f3d989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993423Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748348}
-
Friedrich Horschig authored
With this CL, the leak icon will change between four states that depend on the leak check status: * a checkmark if the check was completed without finding leaks * a triangle if the check was completed but leaks were found * a loading spinner while the leak check is running * an exclamation if the check can't be completed because of an error Screenshots at the linked https://crbug.com/1047726#c31 Bug: 1047726 Change-Id: I27a9ed3f3df18ce2fe8f32de2a7c16bf4cd07f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087342 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748347}
-
Nate Chapin authored
Bug: 979017 Change-Id: I5011e209ed57110a33ae7a49b2dc083815abc8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091637 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#748346}
-
Jonathan Ross authored
This reverts commit 00861a81. Reason for revert: Speculating that this is causing continuous GPU crashes on Vulkan: Android: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/8818 Windows: https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20dEQP%20Release%20%28NVIDIA%29/6153 Original change's description: > VulkanSwapChain: Use VK_KHR_incremental_present for better performance. > > Bug: 1059598 > Change-Id: I4ec9ae96b97606d4e64d6ce8874471b00586def8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094235 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748280} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: I40c693b901282f3e7ed300f6e55249906e8a8559 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094547Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748345}
-