- 31 Jan, 2020 40 commits
-
-
Colin Blundell authored
Follows the componentization of the production class. One note is that there are multiple independent test classes in the unittest file that all construct TestSSLErrorHandler instances. As the manual construction of a CaptivePortalService instance is somewhat cumbersome, we did it only in the tests that actually need it; in the other tests we simply pass nullptr. This is analogous to the how the tests are handling the NetworkTimeTracker parameter of TestSSLErrorHandler. Finally, the test is augmented to account for the fact that on Chromecast, where the test now runs as part of components_unittests, captive portal detection is not enabled. Bug: 1030692 Change-Id: If9292ebbf26437ef85f42f248468325f6d1795f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030524 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#737293}
-
Rayan Kanso authored
This information is needed to figure out whether an WebAPK update is required. Bug: 1045588 Change-Id: I42485a8490b5ee639a433c5466ce54380270421a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030971Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#737292}
-
Friedrich Horschig authored
Currently, the member password_feature_manager_ is marked const in the ChromePasswordManagerClient but only ever accessed in a non-const context. This is possible since PasswordManagerClient::GetPasswordFeatureManager casts the const away. This CL removes the misleading const qualifier and the unused accessor to the const method as well. This clean-up is a precondition for the linked bug which needs non-const access to the feature manager in ChromePasswordManagerClient to call SetAccountStorageOptIn. Bug: 1047202 Change-Id: Ib1383043e25843052815999e00cd163453442d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030866 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#737291}
-
Leon Han authored
Some notable points: 1) Local type in WebNFC APIs is always prefixed by ':', but, the ':' will be omitted when it's actually written into the nfc tag. ":act" --> "act" to be written as the TYPE field into the nfc tag. ":text" --> "text" The reading direction is vice versa. "act" --> ":act" to be exposed as NDEFRecord#recordType. "text" --> ":text" 2) Only "smart-poster", external, and local type records are supposed to be able to carry a ndef message as payload. 3) Local type is only expected to exist inside a ndef message that is another ndef record's payload. Top level ndef message is not allowed to have a local type record. The spec changes: https://github.com/w3c/web-nfc/pull/491 https://github.com/w3c/web-nfc/pull/493 https://github.com/w3c/web-nfc/pull/495 https://github.com/w3c/web-nfc/pull/502 https://github.com/w3c/web-nfc/pull/506 BUG=520391 Change-Id: Ic2890c031109aa583437ac93a8901ff71992af78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996946Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#737290}
-
Nicolás Peña Moreno authored
Currently, we use exclusively the size of the LayoutObject to compute the background image sizes. This is incorrect, for instance when looking at CSS styles like ::first-letter. This CL fixes this by passing the image border to ImagePaintTimingDetector and ImageElementTiming. Bug: 996921 Change-Id: I94e4a2f3c8873be765b144179f7729430c885dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023523 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737289}
-
sandromaggi authored
Add error statements for all "false" returns in CreateOptionsFromProto to enable easier debugging when the action fails. Bug: none Change-Id: I3dfd353706ab7da0b4ad956fb57b86d62ba263ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029512 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737288}
-
Reilly Grant authored
This change updates all base::Callbacks and calls to base::Bind() so that they explicitly choose between call-once and call-repeatedly semantics. Bug: 1007692 Change-Id: Ic570899bccfafe707d6ed8a723b49cc34e6a0339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941272 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#737287}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43b52c20d3b5428f49c44fc07094531b928e807d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737286}
-
Ioana Pandele authored
This reverts commit 36911404. Reason for revert: Multiple test targets are failing on Win7 Tests with: 3724:4788:0131/021830.830:FATAL:dwrite_font_lookup_table_builder_win.cc(335)] Check failed: callbacks_access_task_runner_. Bug: 1047647 Original change's description: > Sequentialise access to callbacks in DWriteFontLookupTableBuilder > > Since there may be multiple instance of DWriteFontProxyImpl instantiated > for multiple RenderProcessHosts, and > DWriteFontProxyImpl::GetUniqueNameLookupTable may access > DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from > separate threads, there may be race conditions around the > pending_callbacks_ member of DWriteFontLookupTableBuilder. > > Sequentialise and guard access to pending_callbacks_ with a separate > sequenced task runner. > > Fixed: 1047054 > Change-Id: Ib7d7a385273bd82eb4d1acf720dac5d688a3435e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030864 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Auto-Submit: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737252} TBR=drott@chromium.org,mpdenton@chromium.org Change-Id: I23ae8f14e6f82171d6b6950a937b51faa00b3a63 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031043Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#737285}
-
Ioana Pandele authored
TBR=thakis@chromium.org Bug: 1047205 Change-Id: I275cf85f2e24031a79af78d1e6d37605a1e78af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032110Reviewed-by:
-
Nohemi Fernandez authored
Previously the test case testSignOutAndClearDataFromNonManagedAccountClearsData() was disabled due to a misuse of the ScopedFeatureList flag, which should only be used for unit tests. This meant that the flag was not set correctly in the tests. The change uses the AppLaunchManager to enable the experimental flag on Earl Grey 2 and the flag within the Earl Grey 1 JSON setup. Bug: 1045981 Change-Id: I3160477a5230d24617168800a5cabacb4b8fd672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023835Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#737283}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae510e8f08e8..ae2b962ce583 git log ae510e8f08e8..ae2b962ce583 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sdefresne@chromium.org Tentative fix for roll-dep.py failing in generate commit message Created with: gclient setdep -r src/third_party/depot_tools@ae2b962ce583 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ia0a39f6094fddcf58373730e05c6253eccce49ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032861Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a66ca23b9f26..09b742896513 git log a66ca23b9f26..09b742896513 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 fancl@chromium.org Fix sheriff-config return 500 without login Created with: gclient setdep -r src/third_party/catapult@09b742896513 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: Ic978d764b39ac17d3a916d4977d667872c25ae88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032862Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/659962bc1b4c..10a83fb9a9da git log 659962bc1b4c..10a83fb9a9da --date=short --first-parent --format='%ad %ae %s' 2020-01-31 szuend@chromium.org Revert "Update DevTools DEPS." Created with: gclient setdep -r src/third_party/devtools-frontend/src@10a83fb9a9da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02564020d6adf46bf03acfe02c480f2b1b0a8a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032858Reviewed-by:
-
Matthew Denton authored
...instead of CertNetFetcherURLLoader, which fails when the URLLoaderFactory is reset. Bug: 1046326 Change-Id: Id9cfc0fbcb3f15776be1399902ad9ee00132c436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032412Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#737279}
-
Clemens Arbesser authored
This CL enables logging of non-sensitive information in release builds. It should allow us to debug some/many issues directly in release builds. Bug: b/147645162 Change-Id: I7388a07ab67ba28883ca51d235fa322f552501ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000818 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit 88fbf344. Reason for revert: Breaks parsing of test expectations on the DevTools waterfall - https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/355 Original change's description: > [blinkpy] Integrate Typ's expectations_parser module into blinkpy > > This CL will replace blinkpy's test expectations logic with typ's > expectations_parser module. This change will significantly reduce the > amount the code used for parsing and maintaining test expectations. > Typ's expectations_parser module also parses the new expectations > format. > > Bug: 986447 > Change-Id: I16842bb2fcbc8a75221f3f208ed1550523470716 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918294 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Luke Z <lpz@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#737159} TBR=lpz@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com Change-Id: Id3b9bab45cae06dc21173d7d5fb99f294ec4e95f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030956Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737277}
-
Etienne Pierre-doray authored
GlobalSize will be used as a hint to schedule marking work in https://chromium-review.googlesource.com/c/chromium/src/+/2029609 This is implemented as an atomic variable that's updated when adding/removing segments. Bug: 1046343 Change-Id: Ia3f3be0539ad925b95a57d3480d064e37ccb6141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030644 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737276}
-
Yuki Shiino authored
- Makes V8SetReturnValue accept const value - Catches up BLINK_BINDINGS_TRACE_EVENT (https://crrev.com/c/2006149) - Minor fixes Bug: 839389 Change-Id: Ic6e63f8f72b78e2ac38d01f369d6c3e367f1ec46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030352 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#737275}
-
Ioana Pandele authored
This reverts commit 50f1686c. Reason for revert: Failure on Linux ChromiumOS MSan Tests Bug:1047641 Original change's description: > Create ResolveContext > > This object stores per-context state for use in host resolution. In > subsequent CLs, it will be passed through the stack instead of how raw > URLRequestContext* is passed today. > > Will soon be responsible for some data currently stored per-session in > DnsSession (in this CL, implementing the DoH probe results, but not yet > using the moved results). Because that data will be both per-context > and per-session, but because we really only care about it in the most > recent "active" session, ResolveContext keeps track of the "current" > session and compares session on manipulation or retrieval of the > per-session data. > > Bug: 1022059 > Change-Id: Iad75fd590c929357415cce1aee2984355a7df251 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003256 > Commit-Queue: Eric Orth <ericorth@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737109} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: I2b48afc66abd59eff8a3bec653013c6e3a6f9738 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031040Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd3f8d4922eb..7a2d408dea60 git log dd3f8d4922eb..7a2d408dea60 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 afdx@google.com Fix typo in comment. (#3163) 2020-01-30 afdx@google.com spirv-fuzz: Arbitrary variable facts (#3165) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7a2d408dea60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I6b0e0d31f8cf2e66ab342c555525e506e506d08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032851Reviewed-by:
-
Matt Menke authored
I'm investigating a failing test, and one possible reason it could be failing is an unexpectedly crashing network process. It also seems like this is a significant enough event to be worth unconditionally logging, as it could cause other unexpected behaviors as well. Bug: 1042354 Change-Id: I2fb2ea8e7c96c0b96b1925cc39f7b02a9a4e3bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031545Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fa7c321f46b..b2cf1247bee6 Created with: gclient setdep -r src-internal@b2cf1247bee6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I90908d7d92a388ca40a341c9a0adaae0a684635e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737271}
-
sandromaggi authored
Fill _ with actual values for RequiredFieldsFallbackHandlerTest. Bug: b/128592689 Change-Id: Iaed9fce18958394c865c46791f4c4afe8f7bc715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030868 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Findit authored
This reverts commit bf17bc25. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 737034 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYmYxN2JjMjUzMzY1NDYzMGQ2MDIxNGI5OGM5NTFjNjY1N2U0NjExMQw Sample Failed Build: https://ci.chromium.org/b/8889761931214094608 Sample Failed Step: browser_tests Sample Flaky Test: ExtensionPolicyTest.CorruptedNonWebstoreExtensionWithoutHashesRemained Original change's description: > [Extensions] Enable content verification for new policy non-webstore installs > > After this commit: > * For non-webstore policy force-installed extensions, write > computed_hashes.json on installation. > * If (according to computed_hashes.json) extension's resource is > detected corrupted, this extension will be disabled and reinstalled. > This applies only for policy force-installed extensions, and for > webstore extensions it worked before this commit. > > This commit will NOT change behavior for already-installed extension. > So, if some (non-webstore) extension was already corrupted, it will not > be detected. The reason for this is that there is no source of truth for > resources of already-installed non-webstore extension. It's possible to > reinstall all previously-installed non-webstore extensions, but it's out > of scope of this commit. See the bug for more details. > > Bug: 958794 > Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964 > Commit-Queue: Oleg Davydov <burunduk@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737034} Change-Id: I3fe8bafddb7154c54c699f3020d25f791650d83d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032998 Cr-Commit-Position: refs/heads/master@{#737269}
-
Mathias Carlen authored
This patch splits the fakes and mocks into another test target in preparation to use that target for the extension API tests. Bug: b/143736397 Change-Id: Idea76fe4e69c90916e4a664d04ad4fd9e9b7f6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032107Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec47b57f1440..8ad9e74d62bf git log ec47b57f1440..8ad9e74d62bf --date=short --first-parent --format='%ad %ae %s' 2020-01-31 peah@webrtc.org Removing deprecated legacy noise suppressor Created with: gclient setdep -r src/third_party/webrtc@8ad9e74d62bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I788490beada8e28d9c07d7f75d45f5a7338cfa4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032855Reviewed-by:
-
Jan Krcal authored
This CL re-enables a previously flaky test. If still flaky, the goal is to gather failure logs to understand the root cause (logging has improved substantially since this test got disabled). Bug: 1006155 Change-Id: I384bbb3cf83068a6d1297592b9400a8ffe23ff73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031035 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/088b1baa948a..689295e34071 git log 088b1baa948a..689295e34071 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 9a80305c0897..5e86b28ffb81 (1 commits) Created with: gclient setdep -r src/third_party/angle@689295e34071 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I8be4a3bfbc30872aca5dd27829e5f05ebec1f37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032854Reviewed-by:
-
Jan Krcal authored
This CL adds a few debug lines to investigate flakiness. There's no behavioral change and the commit will get reverted once the investigation is over. Bug: 997629 Change-Id: I55a19c467affdaed1ed62ea8fb2545dc570b2877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026734 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737264}
-
Frédéric Wang authored
The MathML CG decided that unknown elements in the MathML namespace with a math display should behave like an <mrow> element [1] [2]. This CL ensures that a MathMLRowElement is created for unknown MathML elements in order to make that possible. It does not seem necessary to create a specific MathMLUnknownElement C++ class at that point. Whether a specific MathMLUnknownElement IDL is needed is still open [1][3]. [1] https://github.com/mathml-refresh/mathml/issues/139 [2] https://mathml-refresh.github.io/mathml-core/#new-display-math-value [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1021837 Bug: 6606 Change-Id: Ia493392ee8bfe9a7073e2ea6f1ce65927ec7fcae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007738 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#737263}
-
Ioana Pandele authored
This reverts commit 9b92a6a2. Reason for revert: Multiple ExtensionsMenuViewBrowserTest cases failing on Linux bots. Bug:1047630 Original change's description: > Hide extensions container when none are installed > > This change makes ExtensionsToolbarContainer invisible by default. It > turns visible when any extension is added and goes invisible if the last > extension is removed. > > Bug: chromium:943702 > Change-Id: Ia64d8db55d3cd53beff450941d1b7d2cba282ca0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956186 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Caroline Rising <corising@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737171} TBR=rdevlin.cronin@chromium.org,pbos@chromium.org,corising@chromium.org Change-Id: I012b5f1137c5af73af2cbe1ac2e4b0a123cd2759 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:943702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032108Reviewed-by:
-
Renato Silva authored
Changes the name of a variable used in the enterprise enrollment screen in OOBE. 'last_auth_' was replaced with 'next_auth_'. The author intention with 'last_auth_' was probably 'last_auth_to_try_'. 'next_auth_' makes it easier to understand the code's logic. Change-Id: If1b8ffbfc17767b5a4a4f725856522338231f32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939805 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737261}
-
Fredrik Söderquist authored
If the time container is seeked to a large enough value, we will end up truncating it to SMILTime::Latest(), which is the largest value that isn't one of the two special values ("indefinite" and "unresolved"). When trying to derive other values from this value - like if we have an interval begin at it - we can end up in a loop since any the result of any additions will yield the same value, leading to the element being rescheduled at the same point in time, hanging UpdateIntervals(). This mechanism can also be used to implement the "once" animation-policy in a slightly nicer way. This will be done as a follow-up. Bug: 1039886 Change-Id: If13d7d7d3c44c4f586d15852eb05105879f44918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030885Reviewed-by:Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#737260}
-
Morten Stenshorne authored
This introduces a feature LayoutNGFragmentTraversal, which will make us perform layout read operations (painting, hit-testing) by traversing the NG physical fragment tree instead of the LayoutObject tree. This CL only adds basic support for painting, and only for nodes that generate just one fragment. Painting is still driven from PaintLayer (which is LayoutObject-centric -- we probably want to fix that in the future), and the near-term plan there is to collect each physical fragment and pass to NGBoxFragmentPainter. For now we just pick the one and only fragment, and enter fragment traversal for painting, where possible. Note that this feature is still actively disabled inside multicol. We need to get rid of the "artificial" paint layers for the flow thread and multicol container (and still calculate FragmentData correctly) before we can turn it on. Added a virtual testsuite. The tests in fast/block/ will mainly verify that the new code works, and the ones in fast/table/ will mainly verify that we fall back to legacy painting correctly. What remains (roughly) after this CL: Hit-testing, support for multiple fragments, overflow calculation for fragments, and actual support for block fragmentation (multicol). Bug: 1043787 Change-Id: I1f61bb15458e7162ad61960c317e50891bd13e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002879 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
https://chromium.googlesource.com/infra/infra/+log/37a855b64d59b7f079c9a0e5368f2757099d14d3..8c17d4a7b01d6257e927c629cc623ebc6a6b3711 This is to take crrev.com/f4a945468e0c8498fdf7ea9fdffb2a152e1b2ef6 Bug: 984869 Change-Id: I7ba172d97df7be96bf07faeebb3d467506d8cec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032482 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#737258}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 122b074f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I26fea3682c7ff55c16341d492f6e054b60e61289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031908Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737257}
-
Renato Silva authored
Add new graphics for error screen, adapt text so that error screen can be used in conjunction with automated enrollment. Fixed: 987903, 1024844 Change-Id: I44907b7c931f75323b033737003ee1ad11e6ea7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944388 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737256}
-
Etienne Pierre-doray authored
To keep current behavior, max_concurrency <= 1. TestSupportingGC & TimerTest need CompleteSweep to prevent dangling Job across tests. From local benchmarks: blink-gc-complete-sweep: 15-25% improvement blink-gc-sweep-background: 15% regression blink-gc-sweep-foreground: 2-8% improvement Pinpoint: https://pinpoint-dot-chromeperf.appspot.com/job/14b95f88620000 As the first Jobs API use case, we can now lift experimental:: namespace which is done in a follow-up: https://chromium-review.googlesource.com/c/chromium/src/+/2028287 Bug: 1046343 Change-Id: Idb1c6f44ee19e03039f1f7fa6c18e3591a8fbdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935836 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737255}
-
Julie Jeongeun Kim authored
This CL changes FrameHostMsg_UpdateUserActivationState so that it is implemented in the LocalFrameHost interface and removes WebLocalFramClient::UpdateUserActivationState. Bug: 1044304 Change-Id: I046493809ab76acfe97173bec2a13b199c49c6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026841 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#737254}
-
