- 05 Sep, 2019 40 commits
-
-
Jan Scheffler authored
Fixed regression introduced in #1693175 (https://chromium-review.googlesource.com/c/chromium/src/+/1693175/4/third_party/blink/renderer/devtools/front_end/ui/Toolbar.js) which kept toolbar buttons from showing their keyboard shortcuts in the tooltip. Bug: chromium:999195 Change-Id: I0d0259f19a4abc45d3fe57df419319866e311688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782172 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#693823}
-
Maksim Moskvitin authored
BackendMigrator logic requires resetting sync metadata for specific datatype. For regular datatypes, corresponding logic lives inside ModelAssociationManager and DataTypeManager, which don't have access to Nigori's ModelTypeController. For Directory implementation of Nigori this logic implemented through Directory::PurgeEntiesWithTypeIn(). We can detect required migration, because call of Directory::PurgeEntiesWithTypeIn() plumbed through SyncEngineBackend. We just restart ModelTypeController for Nigori and this triggers call of NigoriSyncBridge::ApplyDisableSyncChanges(). We keep in-memory state of explicit passphrase key loaded from the prefs, because we need it for future support of BackendMigrator for USS Nigori. It's safe, because if we stop due to disabling sync, we will also clear corresponding pref and we should not worry about in-memory state of the bridge, since we won't continue use the same instance. This is not perfect solution, and we need to try a better one. But for now all alternatives too intrusive (getting rid of ModelTypeController for Nigori or moving it into the UI thread). This CL allows passing Migration*ClientTest with enabled USS implementation of Nigori. Bug: 922900 Change-Id: I9f7b218dec46ebfcc21ad8093b73e3c019fd438f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784606 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#693822}
-
Steve Kobes authored
Bug: 1000716 Change-Id: I25013ba77c03a05357f787c4ecec540d0e54ddd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787348Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#693821}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c3c41d20e9c..b6f7d201f629 Created with: gclient setdep -r src-internal@b6f7d201f629 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1f8f1a69a03552d6b82baff70314479e20ab1dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787350Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693820}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/autofill/core/browser/payments. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jsaul@google.com Bug: 891670 Change-Id: I860dba930b082a4d094da8ad0e7bb00d6a6237d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786828 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#693819}
-
Ioana Pandele authored
In certain variants of the dialog, we make a recommendation to change the leaked password. We want this to be emphasized. Bug: 986317 Change-Id: I369a3b9a1e21acb8e51f43f6f4980d2645bf60f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781583 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693818}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b0e2347fedfc..76500e5d0a62 git log b0e2347fedfc..76500e5d0a62 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 csmartdalton@google.com Clean up GrGLIRect 2019-09-05 bsalomon@google.com Fix profile width check in GrRectBlurEffect. 2019-09-05 jvanverth@google.com Reland "Add launch screen to iOS apps" Created with: gclient setdep -r src/third_party/skia@76500e5d0a62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:995308 Change-Id: I0c05029acb56eb3f10d11d51d6ad4a3f6d0930ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693817}
-
Arthur Hemery authored
This fixes the tests run by the android bfache fyi bot. It currently tries to run browser_tests when it should instead run android_browsertests, content_shell_test_apk and chrome_public_test_apk. Bug: 976218 Change-Id: If0abf33ec48a14c3cb1d3024e43ad2f9a0b18f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787541Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#693816}
-
chrome://dev-ui-loaderSamuel Huang authored
This CL changes the error message shown to the user if the DevUI DFM fails to install. The text is approved by UX. The formatting matches that of chrome://dino (desktop version, instead of the more fancy Android version). Styles are flattened for simplicity. Bug: 927131 Change-Id: I30cd76f27aaadd821655d6a4716f7be2ea2c664c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785081 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#693815}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/components/tether. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 891670 Change-Id: I6f698c1eda62dffb5167e82b122e1c6b18c57bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787215 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693814}
-
Synthia Islam authored
Currently a save dialog will return in a read-only file handle if the site is configured to not be allowed to prompt for write access. Modify the logic before triggering the file chooser to reject this attempt Bug: 990988 Change-Id: I0a63a64ce4605fed6c83c67df60027b09a9b3329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753986 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/services/network_config. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 891670 Change-Id: I344d2168d15d303bab24507d348c85bdda2782ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786851 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2dc5f73698ee..1ed60ee797b6 git log 2dc5f73698ee..1ed60ee797b6 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 treehugger-gerrit@google.com Merge "Never start data-source twice." 2019-09-05 eseckler@google.com Merge "proto: Add Tracks for TrackEvents" 2019-09-05 rsavitski@google.com Merge "protozero packed repeated field encoding/decoding" 2019-09-05 lalitm@google.com Merge "trace_processor: add strongly typed column wrapper classes" 2019-09-05 tneda@google.com Merge "perfetto-ui: Adding triangle pointer to current search result" Created with: gclient setdep -r src/third_party/perfetto@1ed60ee797b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I71525903c9f435789e4e607f6d44eb3d709ca348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787843Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:3042 Change-Id: I8ebec3e58904e63926aa276902c7a92559c8ab66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785681Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#693810}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/network. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 891670 Change-Id: I04efc7575adafc026c094f9e8d255708f4ecb804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786897 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Mingjing Zhang authored
This feature allows tracking frame throughput during video playbacks. This frame sequence tracker is a special case in that its tracking process occurs in video_frame_submitter, unlike most other frame sequence trackers that operate mainly in layer_tree_host_impl. Sample tracing report: https: //drive.google.com/file/d/1B9AZCsbLmOyIzIFxFGzDOgINISx7p3lk/view?usp=sharing Bug: chromium:986300 Change-Id: I9a41861e59bbe16d652b49de6b802ccc89833906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755978 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#693808}
-
Yue Zhang authored
Currently, the ungrouped tab is appended to the end of the entire tab list in grid tab switcher. However, a more ideal setting would be the ungrouped tab show right next to the tab from which it is ungrouped. This CL fixes this issue. Bug: 999396 Change-Id: I19b9ed4cdb029fc71ff175b079745f451657d895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778858Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693807}
-
Toni Barzic authored
Supports different folder images per app list config. The folder items icon sizes and spacing change depending on the app list configuration (i.e. screen size), in a way that simply scaling down the folder icon for kLarge/kShared config down to the desired folder icon size will not produce the correct folder icon layout. To address it, add support for per-config icons to app list item metadata. Also, icon getters in app list item now take the app list config type (by default, they return unscaled kShared config icon), which enables apps grid items to fetch the icon for the correct configuration type. For now, these are only used for folder icons (generated in ash), but eventually they can be used to provide differently sized app list item icons from chrome (so original icon better matches the target size). For now, the icons provided from chrome are resized when needed. (For non kShared configurations, this assumes that folder icon size/layout is the same for all configuration instances with the same type). BUG=998207,996808 Change-Id: I2650c4de25a42f98cfa2f13aa6a1ec1ed580890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777142 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693806}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/renderer/media. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 891670 Change-Id: Id30d6abf1228394025cf994fc3a92a7a31b3ecd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787182 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#693805}
-
Henry Jian authored
Before this CL, we had a non-standard res structure for 1. showing larger splash screen icons, and 2. allowing unsigned WebAPK API to have control over their use of adaptive icons. After this CL, the res folder structure will be changed to integrate adaptive icon. Bug: 977173 Change-Id: Ib3deb834e0118db1d0c7f03428724427bdc058e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715100 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693804}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dc5858f0a40a..df4a44889317 git log dc5858f0a40a..df4a44889317 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 saklein@chromium.org build_target_util: Fix error inheritance, add test. Created with: gclient setdep -r src/third_party/chromite@df4a44889317 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I92c7395ac0a4d6e931d5180364f2d1f9a09ec54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787847Reviewed-by:
-
Wei Li authored
For images without any alternative text, there is no point to add it into the accessibility tree as it will only be recorded as an image. We could safely ignore such image as it doesn't convey any extra information. One such case is the Chrome logo icon on HaTS bubble. We don't need to link it into accessibility tree. BUG=979530 Change-Id: I55d1dceb33f5d55241470a5cbd8ff66be9dca877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783672Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#693802}
-
Bo Liu authored
Change-Id: I1f83bb6b5ff7d4f00bc801e5532c90c9285f5b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786834 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#693801}
-
Chris Lu authored
Now that Badges logic will be used when in Incognito, it should not be tied to the Infobar feature flag, which won't be rolled out to 100% soon. Bug: 976901 Change-Id: I94ece69646370de01672ba10c2ef15aad60e2fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783226 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#693800}
-
Pete Williamson authored
Change-Id: Id7f2bcd69b2343b9bb9b40ad037f7e570aaa71e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783481Reviewed-by:
-
John Rummell authored
In order to help determine why this test occasionally fails, log warnings when the test is calling OnTestComplete(false) with the reason why the test has failed. Bug: 999421 Test: Logs show up when test modified to fail (as locally is passes) Change-Id: Ie1395e5ffef724f367a727cfbe841226d8e2c076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785739Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693798}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/nacl. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dschuff@chromium.org Bug: 891670 Change-Id: I09fc82283cdca72baef38002dfb03aa4a88b2a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786983 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#693797}
-
Henrique Nakashima authored
Change-Id: Ie819f96caf6342403cfcf7fedfcad765795fe53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785638Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#693796}
-
Sahir Vellani authored
There is nothing specific to the mouse in the implementation of HandleMouseUp/Down functions, so giving it a more generic 'Pointer' name Bug: 959430 Change-Id: I477ab7cdd65cc374384cae8361cacdde91fb4de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783668Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693795}
-
David Tseng authored
This forks the ChromeVox Classic codebase out of the main ChromeVox repo. Strategy: - code taken from 6f7d8123 the last major release of ChromeVox Classic. - the compressed injected script matches the current compiled sources published to the webstore chromeVoxChromePageScript.js. Security fixes were manually cherry-picked. - chromeVox2ChromeBackgroundScript.js diverges from the webstore published version - the newly checked in fork will live under ui/accessibility/extensions/chromevoxclassic - this source is based on the uncompressed build of ChromeVox (therefore retaining all comments) This fork has yet to be extensively tested. Change-Id: I52ffd17e8bb7a85cbd7ce3493a2613555b193f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784329 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693794}
-
Jan Scheffler authored
Fixed regression introduced in #152d4e13 (https://chromium-review.googlesource.com/c/chromium/src/+/1566120/5/third_party/blink/renderer/devtools/front_end/resources/ServiceWorkerCacheViews.js) by updating the comparator to use _name instead of _path too Bug: chromium:1000278 Change-Id: I258a3122f880be061b312a3336a47cefa28721eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782563Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@google.com> Cr-Commit-Position: refs/heads/master@{#693793}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/preferences/tracked. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=proberge@chromium.org Bug: 891670 Change-Id: I4cf03bbbf1e2a190655dad4e7143392ad6e20466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786816 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#693792}
-
Andrei Chulkov authored
This CL sets the final version the title, explanation and button strings for the password manager onboarding dialog. Bug: 983445 Change-Id: Ibc265894f04877be5f89676e295fa7a7d6c37cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781638Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Andrei Chulkov <achulkov@google.com> Cr-Commit-Position: refs/heads/master@{#693791}
-
Andrei Chulkov authored
This CL makes the password manager hide the save password infobar before showing any of the leak detection dialogs. The update password infobar is not affected by this. Bug: 1001052 Change-Id: Ic07e5fb9eb5ae081e2bc3c02de4df8971cbd105b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782900Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#693790}
-
Pavol Marko authored
If certificates have been specified in ONC policy to be used by a sign-in screen extension, PolicyCertService now uses them. The mapping between extension id (from policy) and StoragePartition is performed in PolicyCertService (see comments in PolicyCertService::GetPolicyCertificatesForStoragePartition). Extension-specific certificates are only allowed if: (*) The extension has isolated storage, i.e. it has its own StoragePartition and (*) The Profile is using CertVerifierBuiltin (which is unconditionally true for the sign-in screen Profile since CL:1750004). A browsertest has been added to ensure that the other StoragePartitions in the sign-in screen Profile do not respect the additional extension-specific certificate. Bug: 939344 Test: browser_tests --gtest_filter=*PolicyProvidedCertsForSigninExtensionTest* Change-Id: If29413049a46ee4f742718253dbbbc7ecdc31ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702425 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693789}
-
Morten Stenshorne authored
The break-before value should only be propagated if we're not at a valid class A breakpoint. This is only the case at the first in-flow child. Propagating it in other situations could cause spurious forced breaks in the ancestry, as the new test would demonstrate. The actual fix here is to simply check that we're at the first child, but I rearranged the code a little while I was at it, to keep the block fragmentation code more closely together. We'll also no longer update the has_processed_first_child_ member unless we're block-fragmenting. Change-Id: I831e162adae0d4b56231c118274ba1083da1fc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787320Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#693788}
-
Matt Menke authored
Internal requests should not end up in file URLs, and Safari handles other requests, so we shouldn't need it. FileProtocoloHandler is no longer in use on other platforms, so we should be able to delete it. Bug: 934009 Change-Id: I00749a080b8bcda2a3ff4655a40ce9835e42e608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783911Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693787}
-
Danan S authored
Bug: 1000743 Change-Id: I9bc22f6b73c48302415c2a8899e83cf1905372aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784009Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693786}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/base/test. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 891670 Change-Id: I9cd9d893ec5a68f3f25fbab9c8e361de6e8c61bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786825 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693785}
-
Danan S authored
We suppress the dialog in this instance because after an account has been supervised because the user must sign out completely. Bug: 1000904 Change-Id: I2df6f3b03d14516af8d81bdd3580eb5a498496c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786917Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693784}
-
