GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/732bda7..2960bec

TBR=pilgrim@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/1010433005

Cr-Commit-Position: refs/heads/master@{#321377}

This refactor removed a lot of unnecessary repeated code. The other guestview types (that currently do not have attributes modules) will be refactored to use guest_view_attributes as well in a subsequent patch.

BUG=466215

Review URL: https://codereview.chromium.org/1017863007

Cr-Commit-Position: refs/heads/master@{#321376}

This CL enables the WebNavigationApiTest.CrossProcess test, but disables
the crossProcessWithSameSiteCommit subtest, since it is flaky due to
imprecise ordering of navigation events.

BUG=467800

Review URL: https://codereview.chromium.org/1019133002

Cr-Commit-Position: refs/heads/master@{#321375}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/effcba4..647211f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1019243003

Cr-Commit-Position: refs/heads/master@{#321374}

BUG=468270

Review URL: https://codereview.chromium.org/1006173004

Cr-Commit-Position: refs/heads/master@{#321373}

The extra fields in DisplayState were only used internally and we don't
need to keep track of them. We can simply compute them when performing
the display configuration.

This is a refactor, no functional change intended.

BUG=none

Review URL: https://codereview.chromium.org/1019623002

Cr-Commit-Position: refs/heads/master@{#321372}

This variable isn't supported any longer.

BUG=446865

Review URL: https://codereview.chromium.org/1008023002

Cr-Commit-Position: refs/heads/master@{#321371}

BUG=467918

Review URL: https://codereview.chromium.org/1015333002

Cr-Commit-Position: refs/heads/master@{#321370}

R=inferno@chromium.org,tsepez@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/1000373004

Cr-Commit-Position: refs/heads/master@{#321369}

This introduces the MemoryAllocatorDump which defines the ground data
model that every allocator MemoryDumpProvider must comply with in order
to get a coherent snapshot of the various allocators inside the trace.
Furthermore, MemoryDumpProvider(s) can specify further attributes that
will be attached to each dump point using the MemoryAllocatorAttributes
map.

BUG=466141

Review URL: https://codereview.chromium.org/987043003

Cr-Commit-Position: refs/heads/master@{#321368}

Failing on Nexus 4/5/7v2 and MotoE.

TBR=dcastagna
BUG=464373

Review URL: https://codereview.chromium.org/1014573007

Cr-Commit-Position: refs/heads/master@{#321367}

BUG=440843

Review URL: https://codereview.chromium.org/1019033003

Cr-Commit-Position: refs/heads/master@{#321366}

The fake device used to just CHECK when it failed to read the file,
but I noticed those checks don't make it into the logs for official
builds. This makes the --use-file-for-fake-audio-capture flag a bit
user-hostile, which has also shown up in Chrome crash reports. This
way there will be an entry in the log and the device will be silent
instead of crashing.

BUG=466408

Review URL: https://codereview.chromium.org/1018293002

Cr-Commit-Position: refs/heads/master@{#321365}

This reverts commit b55be9ed.

This broke layout of the filter box in the events tab.

Reverted CL description:

The problem:

1. Initially all the tabs are visible
2. A layout happens
3. index.js is run and it sets all the tabs to display: none
This results in the flickering.

By initially giving div main-tab-contents the style display: none and
removing that in initTabs_() we can prevent the flickering.

BUG=466068
Committed: https://crrev.com/b55be9ede35c10a2623c3c348768db92069d7f10
Cr-Commit-Position: refs/heads/master@{#320264}

TBR=eroman@chromium.org, alexclarke1@chromium.org

Review URL: https://codereview.chromium.org/1019303002

Cr-Commit-Position: refs/heads/master@{#321364}

This patch adds a "Second batch JS" benchmark and a code generator for
creating synthetic Javascript content for the different variants of the
benchmark.

The benchmark flow is:

1. Load an initial page quickly. We also start a continuous animation
   which gauges the responsiveness of the main thread.
2. Start loading Javascript asynchronously.
3. When the loading completes, wait 1 second and click on a button
   which causes about 5% of the Javascript to execute.

The aim is to keep the page responsive during loading and minimize the
latency of the click handler. There are three variants with a small (15K),
medium (150K) and large (1.2M) amount of Javascript.

The generated Javascript consists of half top-level closures, half top-level
functions, each of which calls a varying number of inner functions to
perform arithmetic.

Note that currently the benchmark only measures the responsiveness of the
click handler, but eventually it will be able to track this over the entire
interaction flow (crbug.com/460206).

BUG=428350
R=rmcilroy@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/b0a90f4b6c81fc65dd0c57ebc00b0ba6fe784b22

Review URL: https://codereview.chromium.org/1000203002

Cr-Commit-Position: refs/heads/master@{#321363}

The test is flaky.

BUG=468753
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1018343002

Cr-Commit-Position: refs/heads/master@{#321362}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1a5041e..effcba4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1019463004

Cr-Commit-Position: refs/heads/master@{#321361}

This will only land after a corresponding change in CQ will land.

R=phajdan.jr@chromium.org
BUG=408675

Review URL: https://codereview.chromium.org/1007323004

Cr-Commit-Position: refs/heads/master@{#321360}

These browser tests verify that we can load notification icons from
data: URLs and blobs when displaying Web Notifications.

R=johnme@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1019803002

Cr-Commit-Position: refs/heads/master@{#321359}

Redesign of MD introduce strange tabfocus behavior around searchBox. This patch fixes it.

BUG=467872
TEST=browsertets pass

Review URL: https://codereview.chromium.org/1017863005

Cr-Commit-Position: refs/heads/master@{#321358}

It's no longer necessary. And the handler is fired unexpected timing after unminimized and causes the issue (see the issue for detail). This patch removes it.

BUG=462065
TEST=browsertest passes

Review URL: https://codereview.chromium.org/1018953002

Cr-Commit-Position: refs/heads/master@{#321357}

BUG=429399

Review URL: https://codereview.chromium.org/1011143002

Cr-Commit-Position: refs/heads/master@{#321356}

We are not going to use 'EmbeddedSignIn' endpoint for OOBE, so this code
could be safely removed.

BUG=468439
TEST=manually

Review URL: https://codereview.chromium.org/1018133002

Cr-Commit-Position: refs/heads/master@{#321355}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7f2e7cb..732bda7

TBR=pilgrim@chromium.org

Review URL: https://codereview.chromium.org/1021723002

Cr-Commit-Position: refs/heads/master@{#321354}

The underlying reason for not finding the profile is probably crbug.com/464616,
but this should still not crash.

BUG=421215

Review URL: https://codereview.chromium.org/1021613002

Cr-Commit-Position: refs/heads/master@{#321353}

BUG=468679
TBR=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/999103004

Cr-Commit-Position: refs/heads/master@{#321352}

Add "--privileged" and "--privileged=<num>" that works similar to
"--sandboxed" to make it easier to debug the GPU process on Android.

BUG=468697

Review URL: https://codereview.chromium.org/1023703002

Cr-Commit-Position: refs/heads/master@{#321351}

Revert of gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D. (patchset #2 id:80001 of https://codereview.chromium.org/1022603002/)

Reason for revert:
This is causing gpu_perftests to fail on android perfbots. See http://crbug.com/468748

Original issue's description:
> gpu: Measure texture uploads with glTexSubImage2D and glTexImage2D.
>
> glTexImage2D and glTexSubImage2D could have different performance
> properties.
> With this patch we benchmark both of these upload techniques.
>
> When using glTexSubImage2D the texture storage is specified with
> glTexStorage2D when available, or glTexImage2D passing an empty pointer as data.
>
> BUG=423481
>
> Committed: https://crrev.com/1b9c0f6571baefe70dad41d504cbe3136ce41ae4
> Cr-Commit-Position: refs/heads/master@{#321300}

TBR=reveman@chromium.org,dcastagna@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423481

Review URL: https://codereview.chromium.org/1011343005

Cr-Commit-Position: refs/heads/master@{#321350}

BUG=468741
TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/1018323002

Cr-Commit-Position: refs/heads/master@{#321349}

WebRTC 8786:8790
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3b9d0a5..78aaaa6

TBR=tommi,pbos

Review URL: https://codereview.chromium.org/1014323005

Cr-Commit-Position: refs/heads/master@{#321348}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b2ae98a..7f2e7cb

TBR=pilgrim@chromium.org

Review URL: https://codereview.chromium.org/1014093004

Cr-Commit-Position: refs/heads/master@{#321347}

This CL adds a comment on how logging is used to report script and test failures.

R=battre@chromium.org
BUG=468245

Review URL: https://codereview.chromium.org/1015533007

Cr-Commit-Position: refs/heads/master@{#321346}

Cr-Commit-Position: refs/heads/master@{#321345}

(By manual request.)

Cr-Commit-Position: refs/heads/master@{#321344}

Revert of "Log force-alt-protocols command line flag usage" (patchset #2 id:20001 of https://codereview.chromium.org/879863004/).  Created manually by git revert ; git cl upload.

Reason for revert:
Reverting bogus CL.  base::RecordAction cannot be called on the IO thread.  This
CL actually causes debug build Chromium to crash upon startup if invoked with
the --use-spdy=force-alt-protocols command line flag.

Nothing else in io_thread.cc seems to be using "base/metrics/user_metrics.h", so
it seems to be safe to remove.

Original issue's description:
> Log force-alt-protocols command line flag usage.
>
> BUG=452514
>
> Committed: https://crrev.com/493bc568527caeab93a173e4feea85c0c86c439e
> Cr-Commit-Position: refs/heads/master@{#313566}

TBR=rch@chromium.org,asvitkine@chromium.org
BUG=452514

Review URL: https://codereview.chromium.org/1023483002

Cr-Commit-Position: refs/heads/master@{#321343}

Revert of Add second batch JS benchmark and code generator (patchset #5 id:60001 of https://codereview.chromium.org/1000203002/)

Reason for revert:
Breaks check_licenses on linux: https://build.chromium.org/p/chromium/builders/Linux/builds/59754/steps/check_licenses/logs/stdio

Notice: This was also caught by the trybot. Please don't commit manually - use the CQ instead.

Original issue's description:
> Add second batch JS benchmark and code generator
>
> This patch adds a "Second batch JS" benchmark and a code generator for
> creating synthetic Javascript content for the different variants of the
> benchmark.
>
> The benchmark flow is:
>
> 1. Load an initial page quickly. We also start a continuous animation
>    which gauges the responsiveness of the main thread.
> 2. Start loading Javascript asynchronously.
> 3. When the loading completes, wait 1 second and click on a button
>    which causes about 5% of the Javascript to execute.
>
> The aim is to keep the page responsive during loading and minimize the
> latency of the click handler. There are three variants with a small (15K),
> medium (150K) and large (1.2M) amount of Javascript.
>
> The generated Javascript consists of half top-level closures, half top-level
> functions, each of which calls a varying number of inner functions to
> perform arithmetic.
>
> Note that currently the benchmark only measures the responsiveness of the
> click handler, but eventually it will be able to track this over the entire
> interaction flow (crbug.com/460206).
>
> BUG=428350
> R=rmcilroy@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b0a90f4b6c81fc65dd0c57ebc00b0ba6fe784b22

TBR=rmcilroy@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428350

Review URL: https://codereview.chromium.org/1019833002

Cr-Commit-Position: refs/heads/master@{#321342}

This parameter is unused in almost every class derived from WebContentsObserver.
This will make refactoring the OnDid{Start|Stop}Loading IPCs from
WebContentsImpl to RenderFrameHostImpl simpler.

BUG=429399,450799

Review URL: https://codereview.chromium.org/1008913002

Cr-Commit-Position: refs/heads/master@{#321341}

This patch adds a "Second batch JS" benchmark and a code generator for
creating synthetic Javascript content for the different variants of the
benchmark.

The benchmark flow is:

1. Load an initial page quickly. We also start a continuous animation
   which gauges the responsiveness of the main thread.
2. Start loading Javascript asynchronously.
3. When the loading completes, wait 1 second and click on a button
   which causes about 5% of the Javascript to execute.

The aim is to keep the page responsive during loading and minimize the
latency of the click handler. There are three variants with a small (15K),
medium (150K) and large (1.2M) amount of Javascript.

The generated Javascript consists of half top-level closures, half top-level
functions, each of which calls a varying number of inner functions to
perform arithmetic.

Note that currently the benchmark only measures the responsiveness of the
click handler, but eventually it will be able to track this over the entire
interaction flow (crbug.com/460206).

BUG=428350
R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/1000203002

Cr-Commit-Position: refs/heads/master@{#321340}

BUG=467059

Review URL: https://codereview.chromium.org/1014403002

Cr-Commit-Position: refs/heads/master@{#321339}

This CL makes all output of the tests to go through the Python standard logging:
 * script-level debugging messages gets logged on a custom SCRIPT_DEBUG level (9)
 * logs from failed tests get logged at level DEBUG
 * summary of the tests run gets logged at level INFO

This allows to remove the knowledge of how the results are passed on from the test running scripts. In particular, the Google Spreadsheet writing code has been removed. To restore that functionality, the caller of these scripts will need to implement a custom logging handler. That will happen in a separate CL, because the caller is in a separate repository.

BUG=468245

Review URL: https://codereview.chromium.org/1011363003

Cr-Commit-Position: refs/heads/master@{#321338}