- 26 Sep, 2014 40 commits
-
-
nyquist authored
Currently paddles show up when distilling a web page. This CL disables that part of the feature, to ensure no paddles show up. BUG=418240 Review URL: https://codereview.chromium.org/611463004 Cr-Commit-Position: refs/heads/master@{#297049}
-
dalecurtis authored
Use newly allowed features to cleanup some audio code: - auto for iterator based for loop. - nullptr for NULL. Additionally const& cleanup found while cleaning. BUG=none TEST=unittests pass. Review URL: https://codereview.chromium.org/602193003 Cr-Commit-Position: refs/heads/master@{#297048}
-
rsleevi authored
This cleans up the README file to clearly indicate which certificates are real world certificates, which are generated by hand / by other sources, and which are generated via script (and which script). Additionally, several test certificates that were previously generated by hand and several test CRLSets that were hardcoded are now generated automatically by the scripts. BUG=401365 Review URL: https://codereview.chromium.org/515583004 Cr-Commit-Position: refs/heads/master@{#297047}
-
rmcilroy authored
BUG=418039 Review URL: https://codereview.chromium.org/612453002 Cr-Commit-Position: refs/heads/master@{#297046}
-
jianli authored
This is used to find out the GCM usage from non-signed-in users. BUG=384041 TEST=none Review URL: https://codereview.chromium.org/605363002 Cr-Commit-Position: refs/heads/master@{#297045}
-
dzhioev authored
Resources added only for Chrome OS build. This is a temporary place for the definitions. When http://crbug.com/418199 is fixed, I will move them to ui/webui/resources. BUG=375191 Review URL: https://codereview.chromium.org/608863002 Cr-Commit-Position: refs/heads/master@{#297044}
-
dpranke authored
Blink's lint-test-expectations script doesn't actually require any command line args, and we shouldn't generally use them on the bots. TBR=cmp@chromium.org, tfarina@chromium.org BUG=338338, 418017 Review URL: https://codereview.chromium.org/605383002 Cr-Commit-Position: refs/heads/master@{#297043}
-
rsleevi authored
This updates to the following revision: f2c25ddbd1cf 2014-09-02 07:27 +0200 It includes changes from revision aedf1212d667 (2014-08-05 11:00 -0400) to revision f2c25ddbd1cf (2014-09-02 07:27 +0200), listed at http://hg.mozilla.org/mozilla-central/log/f2c25ddbd1cf/netwerk/dns/effective_tld_names.dat R=pkasting@chromium.org BUG=37436 Review URL: https://codereview.chromium.org/611573002 Cr-Commit-Position: refs/heads/master@{#297042}
-
tbarzic authored
This is to force the app's background page to load when the app is loaded next time, in order to ensure recently added event listeners are saved. BUG=401634 NOTRY=true Review URL: https://codereview.chromium.org/613453002 Cr-Commit-Position: refs/heads/master@{#297041}
-
jamesr authored
This puts the gles2 thunks target in a more reasonable location, stops abusing static_library to hide dependency issues, and stop the view manager client side library from pretending to know which sort of gles2 to link against. It uses the gles2 headers but depending on whether the lib is being linked into an application or linked into a target that links in the shell lib (as is done in unit tests) it needs a different implementation. This also deletes the unused //mojo/public/gles2/gles2_interface.h file - if we want this we can pull it back but since nobody is using it now it's kind of a waste of space. If we do want it, it should go in //mojo/public/cpp/gles2 since it's a C++ wrapper. R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/604223002 Cr-Commit-Position: refs/heads/master@{#297040}
-
Brett Wilson authored
These cases were commented out (VPX used to not work). They should now match the GYP build. I think these deps aren't strictly necessary because dependent targets link vpx in, but it's a good idea to match GYP, and I think this will make the header checker happier. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/610703002 Cr-Commit-Position: refs/heads/master@{#297039}
-
tburkard authored
Provide a skeleton of the mojo system API, as well as a skeleton test. R=qsr@chromium.org, brettw@chromium.org, viettrungluu@chromium.org Review URL: https://codereview.chromium.org/556813003 Cr-Commit-Position: refs/heads/master@{#297038}
-
Paweł Hajdan, Jr authored
They don't run on memory main waterfall bots. BUG=387743, 416665 R=jam@chromium.org Review URL: https://codereview.chromium.org/601403004 Cr-Commit-Position: refs/heads/master@{#297037}
-
arnarb authored
BUG=416998 Review URL: https://codereview.chromium.org/607913003 Cr-Commit-Position: refs/heads/master@{#297036}
-
zmo authored
Revert of DevTools: Protocol handler generator for content (patchset #30 id:580001 of https://codereview.chromium.org/508973003/) Reason for revert: This causes a lot of layout tests to timeout on Linux ASAN bot in webkit waterfall. Original issue's description: > DevTools: Protocol handler generator for content > > BUG=405566 > > Committed: https://crrev.com/4b0b62979ddd96b65064364eb669ec9dda7e5e5e > Cr-Commit-Position: refs/heads/master@{#296723} TBR=jochen@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,yurys@chromium.org,vkuzkokov@chromium.org NOTREECHECKS=true NOTRY=true BUG=405566 Review URL: https://codereview.chromium.org/612523004 Cr-Commit-Position: refs/heads/master@{#297035}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/a9158da..889f35a TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/603043003 Cr-Commit-Position: refs/heads/master@{#297034}
-
thestig authored
The default modifier key on Mac is Command, but that conflicts with the forward and backward keys. BUG=111232,417902 Review URL: https://codereview.chromium.org/606933002 Cr-Commit-Position: refs/heads/master@{#297033}
-
asargent authored
On case-insensitive filesystems, extensions can generate requests (script src tags, XHR's, etc.) to their own resources using a relative path with incorrect case and have those requests work (see crbug.com/29941 for some history). However, for extension content verification, we were looking up the expected file content hashes using the relative path given in the request, not the actual filename, which meant that any difference in case would be treated as "no hashes for this file". This patch switches to using case-insensitive lookups, but uses a multimap so that case-sensitive filesystems should not experience problems. BUG=412693 TEST=Install the test extension at http://goo.gl/rOpGDu, and turn on content verification to Enforce mode in about:flags. Without this patch, the extension will get force disabled on windows/mac. With the patch, this should be fixed. Review URL: https://codereview.chromium.org/585583003 Cr-Commit-Position: refs/heads/master@{#297032}
-
xhwang authored
This CL introduces a waiter in ~WebMediaPlayerAndroid() and makes sure objects are destructed after MediaSourceDelegate is completly stopped. BUG=417864 Review URL: https://codereview.chromium.org/605013002 Cr-Commit-Position: refs/heads/master@{#297031}
-
dmichael authored
Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #5 id:80001 of https://codereview.chromium.org/589213003/) Reason for revert: Still causing a crash in Canary Original issue's description: > PPAPI: Never re-enter JavaScript for PostMessage. > > Blocking renderer->plugin messages can be interrupted by any message > from the plugin->renderer (even async ones). So while handline a blocking > message, such as HandleInputEvent or HandleBlockingMessage, it's currently > possible to re-enter JavaScript. This patch makes that impossible by > queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage > while any renderer->plugin sync message is on the stack. > > BUG=384528 > > Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506 > Cr-Commit-Position: refs/heads/master@{#296311} > > Committed: https://crrev.com/3fe4ceee750b2cd130bd402de3d371d8518c3eba > Cr-Commit-Position: refs/heads/master@{#296807} TBR=raymes@chromium.org NOTREECHECKS=true NOTRY=true BUG=384528 Review URL: https://codereview.chromium.org/605393002 Cr-Commit-Position: refs/heads/master@{#297030}
-
alexmos authored
The --site-per-process mode does not allow renderer process reuse, so this test shouldn't run under that flag. BUG=417518 Review URL: https://codereview.chromium.org/600993002 Cr-Commit-Position: refs/heads/master@{#297029}
-
Mitsuru Oshima authored
BUG=418234 TBR=miu@chromium.org Review URL: https://codereview.chromium.org/608063002 Cr-Commit-Position: refs/heads/master@{#297028}
-
oshima authored
Optimized 28/87 files in 00:42:49s Result: 61741 => 48551 bytes (13190 bytes: 21%) BUG=418208 TBR=msw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/605273003 Cr-Commit-Position: refs/heads/master@{#297027}
-
dmichael authored
This adds postMessageAndAwaitResponse() support to Pepper stable. Open issues: 1) This is arguably an expansion on what JavaScript can do today. In particular, it would be possible to make JavaScript block on PNaCl, which blocks on another thread, which blocks on something like synchronous FileIO. 2) Not all types are supported yet; e.g. FileRef and FileSystem. I want to fix that prior to M39. (see https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/pepper/message_channel.cc&l=305) BUG=367896 Review URL: https://codereview.chromium.org/600893002 Cr-Commit-Position: refs/heads/master@{#297026}
-
jochen authored
For foreground tabs the blink scheduler handles idle time. BUG=404850,397026 R=hpayer@chromium.org,sullivan@chromium.org,reveman@chromium.org,ulan@chromium.org,dcheng@chromium.org Review URL: https://codereview.chromium.org/603083002 Cr-Commit-Position: refs/heads/master@{#297025}
-
dmichael authored
Add a test that tries using postMessageAndAwaitResponse in ways that should throw an exception, and makes sure it actually throws. BUG=367896 Review URL: https://codereview.chromium.org/608843002 Cr-Commit-Position: refs/heads/master@{#297024}
-
jamesr authored
Fixes up various dependency bugs that prevent mojo_demo_launcher + mojo_html_viewer from working. Once we are gn check clean this should be easy to enforce with a script, but for now it's manual testing. R=abarth@chromium.org Review URL: https://codereview.chromium.org/608023002 Cr-Commit-Position: refs/heads/master@{#297023}
-
reveman authored
Revert of Pending tasks in a message loop should be deleted before shutting down Blink (patchset #7 id:120001 of https://codereview.chromium.org/583043005/) Reason for revert: Speculative revert. Likely cause of crbug.com/418206 Original issue's description: > Pending tasks in a message loop should be deleted before shutting down Blink > > Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.) > > To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink. > > BUG=411026 > TEST=None. I cannot reproduce the crash. > > Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf > Cr-Commit-Position: refs/heads/master@{#296697} TBR=tkent@chromium.org,jochen@chromium.org,jamesr@chromium.org,ager@chromium.org,jar@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=411026 Review URL: https://codereview.chromium.org/608043002 Cr-Commit-Position: refs/heads/master@{#297022}
-
dpranke authored
In order for us to support OAuth-authenticated access to Rietveld, we need to be able to generate signed authorization requests in the Rietveld upload scripts. That requires us to have either the python OpenSSL wrappers plus OpenSSL itself installed, or to use the python pyCrypto library. Currently the bots use python-openssl, but don't work on Windows as a result. We add the python-openssl wrapper to be consistent, but want to switch to pycrypto, so once we have all the bots using pycrypto, we can drop python-openssl from the list. R=thestig@chromium.org BUG=371620, 375971 NOTRY=true Review URL: https://codereview.chromium.org/287053007 Cr-Commit-Position: refs/heads/master@{#297021}
-
ziran.sun authored
R=isherman@chromium.org BUG=412311 Review URL: https://codereview.chromium.org/605683002 Cr-Commit-Position: refs/heads/master@{#297020}
-
ckehoe authored
Review URL: https://codereview.chromium.org/600843004 Cr-Commit-Position: refs/heads/master@{#297019}
-
vitalyp authored
R=arv@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . third_party/jstemplate/compiled_resources.gyp && ninja -C out/Default Review URL: https://codereview.chromium.org/603693002 Cr-Commit-Position: refs/heads/master@{#297018}
-
jmadill authored
This will allow us to correctly transition to the new angle.gypi from the old build_angle.gypi. BUG=415893 Review URL: https://codereview.chromium.org/604413002 Cr-Commit-Position: refs/heads/master@{#297017}
-
danakj authored
The discussion around Rvalue references has been that we should ban their use for now, but come back to it later. So that is what this does. One exceptional case that was agreed upon without dissent was to allow move semantics in scoped_ptr to allow use of scoped_ptr cleaner throughout the codebase, without leaking the requirement to understand Rvalue references outside of the scoped_ptr implementation. R=jamesr@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/607773002 Cr-Commit-Position: refs/heads/master@{#297016}
-
ziran.sun authored
disabled and readonly fields. Autocheckout is deprecated. R=isherman@chromium.org BUG=231160 Review URL: https://codereview.chromium.org/609733003 Cr-Commit-Position: refs/heads/master@{#297015}
-
mseaborn authored
This pulls in the following Native Client changes: r13786: (mseaborn) Scons: Add a sanity check to ensure that nonsfi_nacl=1 is used with bitcode=1 r13787: (shyamsundarr) fix verify_regular_instructions test. r13788: (mseaborn) untrusted.gypi: Factor out duplicated "-t" option r13789: (mseaborn) Cleanup: Remove src/trusted/gio/, since it is unused r13790: (dyen) Added tests for pthread conditions using irt_ext. r13791: (pkasting) Make native_client BUILD.gn more closely match the main Chromium one. r13792: (mseaborn) Cleanup: Update comment about unnecessary copying during IRT loading r13793: (mseaborn) Cleanup: Remove some unused code from src/shared/gio/ r13794: (mseaborn) Cleanup: Remove src/trusted/generic_container/, which is unused r13795: (yyanagisawa) Won't try to use goma if GOMA_DISABLED=true. r13796: (dyen) Added tests for semaphores using irt_ext. r13797: (uekawa) NonSFI Mode: Make hello_world test run with nonsfi_nacl=1 bitcode=1 pnacl_generate_pexe=0. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg TBR=dschuff@chromium.org Review URL: https://codereview.chromium.org/605133005 Cr-Commit-Position: refs/heads/master@{#297014}
-
reillyg authored
Commit 7fb8b995 attempted to enable an unused thread check in extensions::HidDeviceManager but this was not correct because while this class is normally used from the FILE thread this is not where it is created (issue 417939). This change adopts the pattern used in extensions::ApiResourceManager where the BrowserContextKeyedAPI implements its own thread assertions. BUG= Review URL: https://codereview.chromium.org/604843003 Cr-Commit-Position: refs/heads/master@{#297013}
-
oshima authored
Optimized 12/146 files in 00:23:28s Result: 19576 => 18810 bytes (766 bytes: 3%) BUG=418208 TBR=msw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/607883004 Cr-Commit-Position: refs/heads/master@{#297012}
-
rvargas authored
BUG=387876 R=cpu@chromium.org Review URL: https://codereview.chromium.org/588383003 Cr-Commit-Position: refs/heads/master@{#297011}
-
Dan Beam authored
Revert "Prevent updateOpenCommand() from receiving e.target of type other than BookmarkList|BookmarkTree" This reverts commit 0106c710. BUG=417982 TBR=arv@chromium.org Review URL: https://codereview.chromium.org/608883002 Cr-Commit-Position: refs/heads/master@{#297010}
-