- 07 Aug, 2020 40 commits
-
-
Thomas Lukaszewicz authored
This change adds an experimental entry-point for the tab search feature in the tab strip. Currently this tab search button instance has been implemented as another instance of the NewTabButton class, positioned directly next to the existing new tab button. The addition of this feature is gated by both the ENABLE_TAB_SEARCH build flag and the kTabSearch UI feature flag. Outside of changes gated by the build and feature flags, this CL wraps the existing new tab button in a |new_tab_button_wrapper_|. This wrapper allows the addition of the tab search button without introducing significant changes to existing logic that deals with the new tab button (ie animation, hit testing, padding etc). This wrapper is not expected to change the current behavior of the new tab button. There is follow up work to fix issues such as visual style and creating a base class inherited by both the actual new tab button and tab search button. Bug: 1099917 Change-Id: I63cd0804603a8d25efd4416e4f3ea4307ff6535c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333341 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795969}
-
James Cook authored
I anticipate needing it for notifications for lacros. See go/lacros and go/lacros-notifications. Also, clean up BUILD.gn slightly -- enable_native_notifications is always true on Chrome OS. Bug: 1113889 Change-Id: I6c3bc7f81f81157568f8c1b2969f98a82a037b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339450 Commit-Queue: Jun Mukai <mukai@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#795968}
-
Ken MacKay authored
If the mixer didn't have rendering delay available when the start threshold was exceeded, the "ready to play" signal would never be sent. Fix by ignoring rendering delay status. Bug: internal b/158038278 Change-Id: I196be77210ea879ae673b704499f1c683ade8dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342305Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#795967}
-
Maxim Kolosovskiy authored
This CL changes the API of PasswordScriptsFetcher to fit the current design of Password Check on Android. Bug: 1086114, 1092444 Change-Id: I4f617ec239fea9ef778874c94a2cdb442c242eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343080 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#795966}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/889f00501aaa..fb57bbd19358 2020-08-07 vapier@chromium.org licensing: trim no-source-code exception 2020-08-07 vapier@chromium.org gerrit: deps: hack up --raw output to avoid confusion 2020-08-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-06 denik@google.com chromite: Create chromiumos-sdk-next builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I11ca80d5a8ebc8efaa1992141d96071c9042b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795965}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5184219b6ff4..f7721fb24619 2020-08-07 jonaso@webrtc.org Add interface for os/firmware to affect ICE selection. 2020-08-07 razvans@google.com Added field trials to disable video resizing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9086641eb876fc06bb6bd82b20454d9a7b9aa048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343056Reviewed-by:
-
James Long authored
Two presets have been added, based off some combinations of settings found to be useful. More granular customization has been moved to an expandable "advanced settings" panel. Bug: 1112940 Change-Id: I3aae3635642a8cc74526ec4e1e8c0b6bfc898cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337413Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#795963}
-
Eleonora Rocchi authored
PasswordCheckBridge. This CL adds an empty method to the bridge to retrieve the timestamp of the last completed password check. It also adds the logic to call this method from PasswordCheckMediator. Bug: 1109691, 1092444 Change-Id: Ibaa0993e11271b4ae0ee8287a86a51e7023f3bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343268 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..0c0349252934 2020-08-07 aninditaghosh@google.com Handle multiple batches when converting to pandas. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2f6fe332f0e668c261279f07f8acc805f4420dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343057Reviewed-by:
-
Antonio Gomes authored
Drive by. Include isn't needed anymore. R=thestig@chromium.org Bug: 578890 Change-Id: I10763400301d6058a66bd280f01d4a2df059c6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342571 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#795960}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ife83c4878a62a1ceb78513b65b40f3742e48db14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343062Reviewed-by:
-
Ioana Pandele authored
Bug: 1114136 Change-Id: Ie3f43b835d89908ef35541df879e17e14974ce87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343106 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795958}
-
Vasilii Sukhanov authored
Android. Tbr: aboxhall@chromium.org Bug: 1114193 Change-Id: I657de46a8dc7c240cf97a4ac1fb39f6a1807d637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339973Reviewed-by:
-
Kevin Ellis authored
The updated tests run a fair number of interpolations and push the boundary of what should be characterized as a long test. Flakes are typically clustered and the result of variability in speed of the testing infrastructure and not indicative of true changes in performance. Bug: 1093451, 1092177, 1092141 Change-Id: Ia438ae758470e3e7eb695e59e1698734e6526c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341804Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795956}
-
Vasilii Sukhanov authored
SitePerProcessBrowserTest.ChildFrameCrashMetrics_KilledWhileVisible on Win. Tbr: lukasza@chromium.org Bug: 1097060 Change-Id: Ib7378405b9792f1f92f5f1fe2095d30260cce343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343327Reviewed-by:
-
Sylvain Defresne authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/3028c6a4..e327ffdc e327ffdc [ios] Add example of building swift on iOS 89e6425b Add support for building .swift files 070420db clang: Add support for C++ modulemap files 86666321 Add structure to return classified deps bca06318 [rust project] update path to std lib crates c5f5cb21 [rust project] Add debug printing to test failures ab16bbdf [rust project] Extract compiler target 783cc138 [rust-project] Add "core" and "alloc" as explicit deps for crates 9059b0bb Fix displaying "frameworks" and "framework_dirs" for configs 83e48273 Allow WriteCompilerBuildLine to take multiple source files 56e8159f Fix escaping in compile_commands.json Change-Id: I237c64a97b3751db47a161905add1da4bb6c62a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343082 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#795954}
-
Emily Stark authored
This CL fixes a bug in the code that resets to the on-page-load state for the simplified domain hide-on-interaction field trial. The bug is that this reset code let the omnibox bounds go unchanged if the new text was not eligible for simplified domain eliding. For example, when switching to a new tab (as shown in https://bugs.chromium.org/p/chromium/issues/detail?id=1112577#c4), the placeholder text could get cut off because the omnibox was remaining at the bounds used for the last simplified domain elision. The fix is to restore the omnibox to its local bounds, with ELIDE_TAIL behavior, when the text is not eligible for simplified domain eliding. Bug: 1107912, 1112577 Change-Id: I36c359831fc1f7b18c814d9144b801655bd3b1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342123Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#795953}
-
Thomas Lukaszewicz authored
This CL introduces the following UMA histograms: Tabs.TabSearch.NumTabsClosedPerInstance Tabs.TabSearch.NumTabsOnOpen Tabs.TabSearch.NumWindowsOnOpen These histograms aim to measure the number of windows and tabs sent to the Tab Search WebUI in the initial payload and the number of tabs closed via Tab Search controls in a given instance of the UI. See doc below for details: https://docs.google.com/spreadsheets/d/15ygVicrrbJUJOzTn6IlnogxktExXJQzZ2PCSGMQFpWg Bug: 1099917 Change-Id: Ib558fdfb9dc485e464978ff99c2b6ca7b8f93547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340868 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Kent Tamura authored
Change the runtime flag status to "experimental", and remove virtual/layout_ng_fieldset/. Known issues: * inert-retargetting*.tentative.html: They have CHECK failures in |NGPhysicalBoxFragment:: CheckSameForSimplifiedLayout()| * contain-intrinsic-size-014.html: Fieldset NG doesn't support size containment yet. * fieldset-mask.html: Fieldset NG needs to adjust mask painting area. We'll address them soon. Bug: 375693, 875235 Change-Id: Id051f04c7e0fe862e26305b27c106abdee75ba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340647Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#795951}
-
rbpotter authored
Bug: 940326 Change-Id: If92db06e743921e92cbe4da9965d854c401e1d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342119Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#795950}
-
Xida Chen authored
We are seeing half of FrameSequenceLength.Video reports length 0. What's the problem? It turns out that those half are from the main thread. A video frame is on impl thread only, so main thread gets 0 frames for a video tracker. This CL fixes it. Bug: 1112893 Change-Id: I0f6b41625ac2d781dc9c0599e0e8ad28c06a033d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342247Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795949}
-
Mitsuru Oshima authored
* Add view metadata to HeaderView * WideFrameView's widget should always be opaque because it doesn't have a rounded corners. * fix typo in test name. Bug: None Change-Id: I80d5752cfba74a2cdcdd3a0e8cc197ee8a9f4bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336494Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#795948}
-
Maxime Charland authored
The font was previously changed in all illustrated empty states. The font change was also needed in Recent Tabs > Recently Closed. Because the TableViewDetailTextItem is used in multiple places in Bling, the font had to be changed only in Recent Tabs. Bug: 1098328 Change-Id: I047f7f53ed1d118a1efd7e3bda9671a8e482630b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342313Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#795947}
-
Andrew Grieve authored
And fix a broken link. Change-Id: I96a2e13069e53da5545f3bd042a96057f7ba67e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331274 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Scott Little authored
This CL removes usage of the |new| operator with std::unique_ptr in components/translate, either changing the call site to use std::make_unique, or refactoring the call site to not require a std::unique_ptr at all. Bug: 881807 Change-Id: I7d66f206bc9807e5188f22b58647901d720d3505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341177Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#795945}
-
Friedrich Horschig authored
Even in RTL layouts, origins should remain in LTR layout. Bug: None. Change-Id: I5f928e1b2d0e82e3918c46c02d57361030e56ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339753Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795944}
-
David Bokan authored
DocumentPolicy has been enabled in M86 so we want to ship the ForceLoadAtTop policy soon. This CL adds a web platform test to ensure its correct operation. Bug: 1047900 Change-Id: I127331aece02d5b23b77941f5cc2958c81a63315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342344Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795943}
-
Xianzhu Wang authored
The only purpose of it was to group the overflow control layers. With it removed, we can make all GraphicsLayers collectable as GraphicsLayerDisplayItems. Change-Id: Ic37fa3a3902fa3bb493c2b78b15c1df5bd1f6b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341038Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795942}
-
Andrew Grieve authored
Change-Id: I7376cc126cd0a9cee9953cc48a54df696c02a14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343145 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#795941}
-
Rune Lillesveen authored
See: https://github.com/chrishtr/battery-savings/blob/master/explainer.md Bug: 1114184 Change-Id: I6772febbb0a511f523aab1bc34b2368695d7cad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343105Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795940}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/045adb564e19..3b08f35fd150 2020-08-07 mtklein@google.com deserialize SkFilterQuality safely If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I28dae663e286239da21c2f53284f516aa795fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343055Reviewed-by:
-
Jaeyong Bae authored
The security indicator icon in the payment handler UI should match exactly the icon in the regular URL bar, for any given URL. Only if SSL certificate state is secure, the security indicator icon would be appear. Change-Id: Ic15b0f848ecdf326e5ad63704a28cf8d19416fd2 Bug: 1052493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302970 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#795938}
-
Ulan Degenbaev authored
The move of V8PerFrameMemoryReporterImpl from content to blink introduced a bug where the PerFrameV8MemoryUsageData::associated_memory mojo map started to use WTF::HashMap as the backing, which makes key=0 invalid because the hash traits for int64_t reserve that value for the deleted sentinel. This CL also fixes another bug of dereferencing a non-existent entry in the |frames| HashMap. Additionally this CL adds a test for V8PerFrameMemoryReporterImpl to make sure that the fixes work. Bug: 1085129 Change-Id: I04b0b7230fde191571f407b4931d6dba543bd2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339317 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#795937}
-
clamy authored
This CL adds a WPT test that checks the interaction of COOP same-origin-allow-popups with redirects. Bug: 1108292 Change-Id: I647025e635a7096d5f52d30c42b1dc4e0902535f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312796 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795936}
-
Trent Begin authored
When the Chrome OS browser starts up, pass a bound remote to the platform service cros_healthd. This allows the platform daemon to access the network telemetry information. Bug: chromium:1057739 Change-Id: I6084107e8a5364ed0698f521c5e47dbd26265b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323921 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795935}
-
Jose Dapena Paz authored
GCC fails to compile the Color getter in TextDecorationInfo, as it gets confused by different declarations in different namespaces: ../../third_party/blink/renderer/core/paint/text_decoration_info.h: At global scope: ../../third_party/blink/renderer/core/paint/text_decoration_info.h:76:9: error: declaration of ‘blink::Color blink::TextDecorationInfo::Color() const’ changes meaning of ‘Color’ [-fpermissive] 76 | Color Color() const; | ^~~~~ To avoid that, we rename the getter to be LineColor. Bug: 819294 Change-Id: I5b1a0d8a9c4580029ba8148281f9a3a514a88b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339487 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#795934}
-
Abigail Klein authored
When a user clicks on a character in the braille caption panel, it sends a routing event to the braille command listener and moves the cursor to the designated position. Chromevox. Click on a character in the panel to move the cursor to the desired position. AX-Relnotes: Added cursor routing to the braille caption panel in Change-Id: I28e10e17f81c9b0336842a2756263c9f5acb8df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333752Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#795933}
-
Tanmoy Mollik authored
This cl adds description strings for the sync error cards that will be used in ManageSyncSettings page. Bug: 1107420 Change-Id: I16c68378e6bc2fb4f8f35e4d1bdcaceb38c2f2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332446Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795932}
-
Nohemi Fernandez authored
Currently we add the CHROME_CONNECTED cookie only in the case where the user navigates to a Google domain or subdomain, however if cookies are removed outside of our control (as will be the case for ITP in iOS 14) we should instead make sure this works for all Google-owned domains that support Mirror. Bug: 1102794 Change-Id: I1394f73213b81d0921e75426cd9726c95ce993a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340045 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#795931}
-
rbpotter authored
This selector no longer works and Shadow DOM V0 is no longer supported. Since this has not been working for some time, removing these references should not change any behavior. Bug: 842602 Change-Id: I3f2cb9521a3e7c84238bf50ced9455d5b8606386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342116Reviewed-by:
-
