- 05 Mar, 2020 40 commits
-
-
Ben Pastene authored
This new pool will automatically add default CIPD packages that a variety of different tools currently handle today. Needs crrev.com/i/2679645 before this can land. Bug: 812428 Change-Id: Ib9968ab08752021c7afd8ae741187e8e8bb0a57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088224Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#747378}
-
Nate Fischer authored
This removes an extraneous boolean argument. The function does not accept bools for any of its parameters, so I think this was just a typo. This is to unblock CQ. Bug: 1058637 Test: vpython android_webview/tools/cts_utils.py Change-Id: I6be0bff28e4a4a4e871725ed4c11be5af8c01d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088356 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747377}
-
Miguel Casas authored
This CL fixes a potential Initialize()-after-Initialize() of the said service, as described in the bug, following the suggestion in #c11. Bug: 1056222 Change-Id: Idd951d3f0bee62b94382ffe80e4e6b3cef33e6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090031 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#747376}
-
Yuwei Huang authored
Previously we tried to reuse the FTL auth token for multiple connection attempts, and it will only reset if FTL returns an UNAUTHENTICATED error. This doesn't seem to work since we learnt from the last FTL outage that FTL servers can return NOT_FOUND for registration that has been deleted. So it's safer to just re-sign-in every time the signal strategy is disconnected, which doesn't take too much time. (Note that stream lifetime exceeded and pong timeout are handled inside FTLMessageReceptionChannel, which isn't affected by this change.) Bug: 992722 Change-Id: Iee10f04e4ddeea71317b7859a943098d0f0c38fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088633Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#747375}
-
Anna Malova authored
These are constructions of SendCompleteCallback which is OnceCallback. Bug: 1007815 Change-Id: I2715155e477d5e807bf3ccf256ebf71ed21ce2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089815 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#747374}
-
Anna Malova authored
Bug: 1007815 Change-Id: I4f5e6f19402f058bfe11f33018c2d46d4a457920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089774 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Bo Liu authored
Resizing a Surface is really destroying and reallocating a Surface, and then sending it to the GPU process and have it re-composite and re-raster everything. This is a bit expensive and can cause visual glitches when keyboard gets hidden and the view grows in size instead. So follow chrome's behavior in weblayer and avoid resizing the Surface. Note that resizing the web content may also be expensive and can cause similar glitches. Chrome does not address this, neither does this CL. The main code change is keep calling WebContents.setSize, but no longer resize the SurfaceView or call onPhysicalBackingSizeChanged. Do this by introducing SurfaceParent which is a FrameLayout that sits between ContentViewRenderView and the SurfaceView in the view hierarchy. ContentViewRenderView will keep resizing for soft keyboard, and its size controls WebContents.setSize. The SurfaceParent will attempt to detect cases where it is being resized for soft keyboard, and not resize in that case. SurfaceView inherits the size from SurfaceParent, and thus not recreate the Surface if it's not resized. Conditions for when to apply this heuristic: * Only use this for SurfaceView. TextureView is more likely being used in embedded use cases where this does not apply. * ContentViewRenderView is the full width of the window. Again a heuristic to check for embedded use cases. * Soft keyboard is showing. Bug: 1050415 Change-Id: I9702f9ba06a4ab6c3d72355178bf47abf0d2240b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087972Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747372}
-
Anna Malova authored
Bug: 1007815 Change-Id: I80541af887b21830a703cd7352b4e01590a99d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089817Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#747371}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/daac106699e1..f5b833c6d2ac git log daac106699e1..f5b833c6d2ac --date=short --first-parent --format='%ad %ae %s' 2020-03-05 tvanderlippe@chromium.org Remove useless content read 2020-03-05 tvanderlippe@chromium.org Remove unused methods 2020-03-05 tvanderlippe@chromium.org Concatenate all common ts_library into a single target Created with: gclient setdep -r src/third_party/devtools-frontend/src@f5b833c6d2ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1046596 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I016858562da9c465ec38fb68f5854b159c7e847a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747370}
-
Anna Malova authored
MemoryPressureListener expects MemoryPressureCallback which is RepeatingCallback. Bug: 1007815 Change-Id: Icc64607ac64e55819f14dc9d873c66b5f6c6e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089735 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Anna Malova authored
Bug: 2087406 Change-Id: I621bfd19d6e17bf165b3d2e802b9acb14538922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089893 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: 1049864 Change-Id: I9c77a8bba5251ed167aef22d2ce7ab7227ffd361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064179Reviewed-by:
-
Eugene But authored
Logged when app transitioned from background to foreground. Used for Breadcrumbs to log steps to reproduce for crashlogs. Bug: 1046231 Change-Id: I6cc6b7d22fd19ce71347defbfb9246b3788125db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085598 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#747366}
-
Philip Rogers authored
Based on early results in dev/canary, this feature is looking promising and we would like to continue this experiment in Beta. To unblock that we are enabling this experiment for the perf bots now to get more data on the impact. Bug: 1014273 Change-Id: I0b3c0dbb94075bdb94b3f770bd32f2e761c8f6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089953Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747365}
-
Omer Katz authored
In case marking is in progress, first stop concurrent markers and then cancel compaction. If marking is not in progress, compaction should not have been initialized yet, so it suffices to confirm that compaction is disabled. Bug: 1058777 Change-Id: I8f9c6e2c461a6d933d56a7e39c18cbd09e6a40f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089873 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747364}
-
Tommy Steimel authored
This CL prevents media notifications from unfreezing if they are still waiting on new MediaSessionActions. This prevents an issue where notifications would change sizes briefly because they had no actions to show. Bug: 1055254 Change-Id: I2345188626b332846a7b51c93545a1b40764044e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090291Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747363}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6b2c51ab3f3ac138855695a6b21e6e730a5c3466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089403Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747362}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2f18734aa84..2dbcbe8b12e8 git log d2f18734aa84..2dbcbe8b12e8 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 robertphillips@google.com Loosen up SkSurface_Gpu::onIsCompatible a bit wrt FBO0-ness 2020-03-05 kjlubick@google.com [infra] Update node to 12.16.1 2020-03-05 nifong@google.com Name name changes suggested in API review Created with: gclient setdep -r src/third_party/skia@2dbcbe8b12e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I4bcb0be347043b89cbbcec984f87bbf2752f66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090212Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes BulkLeakCheckData and kBulkLeakCheckDataKey from the BulkLeakCheckAdapter. The attached UserData is not required to mark saved passwords as compromised. Bug: 1047726 Change-Id: I3a5c60da160a7d7f42146abb1d5b5f0cc84e929e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089892Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747360}
-
Bruce Dawson authored
The "Failed to add Windows firewall rules" message shows up when running tests as non-admin. This error is usually benign but looks like a failure so it causes confusion when investigating test failures. The message can be avoided by not trying to add firewall rules when this is guaranteed to fail (when running as non-admin). Change-Id: I0980529d3b289f99444d7b2f7ca99440432cefaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088533 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747359}
-
Haiyang Pan authored
After NSOOP_chrome_public_test_apk is also switched to playstore image, it is more clear to see the failed tests that are common to both test_suites, and android-pie-arm64-rel Bug: 1046059 Change-Id: I605ad36c71b5c08bf13b34a2050b2a28319976d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085848Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#747358}
-
Toshihito Kikuchi authored
When the Windows compatibility mode is turned on, ::GetVersionEx() returns a simulated OS version instead of the real OS version. As a result, InterceptionManager selects a wrong thunk resolver, incorrectly patches ntdll's functions, and thus the process crashes when one of those incorrectly-patched functions are executed. The proposed fix is to use OSInfo::Kernel32Version() which returns the real OS version even with the compat mode to select a thunk resolver. Bug: 1053805 Test: Run 32-bit chrome.exe on 32-bit Windows 10 or 8.1 with the compat mode setting to Windows 7. Please note that the crash does not happen if you run chrome.exe on 64-bit OS. R=wfh@chromium.org Change-Id: Id39a11288cc64ff5552de0a6a273231bdeb2eeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080785Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#747357}
-
Yulun Wu authored
Bug: 1058598 Change-Id: I37c233c9fd0aca75be049a2e9ce21498b7ecb7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088671 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#747356}
-
Khushal authored
This change adds a temporary workaround to effectively revert the following changes. While the long term fix for this bug has landed, it might be too risky to merge to M81. So this change reverts enabling of AImageReader on these GPUs, to restore the behaviour prior to M80. Reverted changes: https://chromium-review.googlesource.com/c/chromium/src/+/2015553 https://chromium-review.googlesource.com/c/chromium/src/+/1873393 TBR=nyquist@chromium.org R=dalecurtis@chromium.org Bug: 1051705 Change-Id: I2f7f0828c8ba4a7279c2f6bb95de449402d88f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087987 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747355}
-
Dominique Fauteux-Chapleau authored
The UI now offers the possibility to bypass DLP warnings via buttons in the dialog. The button interactions are tested via a browser test. This involves a few refactors: - DeepScanUploadStatus becomes DeepScanningFinalResult in order to clearly represent what to show the user. - There is now a 4th DeepScanningDialogStatus to represent bypassable warnings. - The callback to allow/deny a paste/upload/drag is delayed in the warning case. - The "Cancel" override in DeepScanningDialogViews is replaced by using set_cancel_callback instead since the virtual method approach is deprecated. Bug: 1044290 Change-Id: I477db8ba06dec26dc12ebc17fdfce94d019787d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072584 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#747354}
-
Kramer Ge authored
Follow-up CL to crrev.com/c/2083571 to remove confusing flips_vertically. Bug: 1051970 Change-Id: Ic260d7b48747d70f41937cba4fec38c8bb943a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087417Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#747353}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..51b2800bb317 git log a095711c5d77..51b2800bb317 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader Created with: gclient setdep -r src/third_party/swiftshader@51b2800bb317 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie79b6461aa9c2c778cdedb03e51f6d3d7bc8383f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090076Reviewed-by:
-
Raul Tambre authored
Using codecs.open() results in a CR at the end of every product name's string. E.g. static const UsbProduct vendor_0001_products[] = {CRLF {0x7778, "Counterfeit flash drive [Kingston]CR "},CRLF };CRLF Use io.open() instead, which works as expected on both Python 2 and 3. Bug: 1058804 Change-Id: I3d77df0a248ccab57e1980a09977cf87720e5714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089696 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#747351}
-
Mark Cogan authored
(Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1997306) This CL creates AllWebStateListObservationRegistrar, which can be used in any case when an object needs to observe all web state lists for a given BrowserState. This is a generalized version of the snapshot cache tab model observer, which this replaces. For cases where only regular or OTR browsers' WebStateLists should be observed, AllWebStateListObservationRegistrar has an optional param that can be set at creation time. To avoid circular dependencies, one target in web_state_list/ had to be split from the main target (hence the scattershot BUILD.gn updates). Bug: 1050148 Change-Id: I3940e2ddf5829e3f70fbc759c7c57220aaadfaef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087620 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#747350}
-
Jeroen Dhollander authored
Previously the Assistant was enabled but failed to start because they are not linked with Gaia. Bug: 1056717 Change-Id: I922822ed16bd8c33b88f85061c09859c564f5737 Tests: Manual and new unittest. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088534Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#747349}
-
Timothy Gu authored
This reverts commit e8d50869. It is not a complete revert, but only removes the skipping bit in TestExpectations. The previously failing test (external/wpt/html/webappapis/scripting/ processing-model-2/integration-with-the-javascript-job-queue/promise-job- entry-different-function-realm) now always passes after a recent V8 roll, so an -expected.txt is no longer needed. Reason for revert: CL 2071624 has been relanded in V8 as 92a2f0c703a6dbbffc2dc83a92c26c24f78c9ec2 and rolled into Chromium. Original change's description: > Temporarily disable promise entry realm test > > This is necessary to land CL 2071624 in V8. > > Bug: v8:10200 > Change-Id: I48c7ad881c060ad161417cd78fdbac8aba8a77ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082112 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Auto-Submit: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745789} CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel Bug: v8:10200 Change-Id: Id041c97d5d0286e190b508e39a14f36459963835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087697 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#747348}
-
Denis Kuznetsov authored
Also reland "Restore End-To-End test on ChromeOS" initially reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2074882 reverted on https://chromium-review.googlesource.com/c/chromium/src/+/2074882 Bug: 1058022 Change-Id: I6766dd944a5807a77087fed240e18766af60e880 Fixed: 1054935, 1058081, 1058582, 1057814, 1057777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087821Reviewed-by:
-
Nina Satragno authored
crrev.com/c/2084725 moved the timeout adjustment logic to the browser side while keeping the old behaviour to make internal android source happy. This removes the old behaviour. Fixed: 976428 Change-Id: I2c6acb06f3efc6c4efbfc917b06a06603b81e7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090091 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Peter Kasting authored
* Simplify AshTestHelper::SetUp() API use by making InitParams arg optional * Rename AshTest*::CurrentContext() to GetContext() to match Views helper class API names * Minor cleanups to ChromeViewsTestBase * NULL -> nullptr to silence presubmit Bug: none Change-Id: If55b08d31a3d244852d3e7aab73e4270e94cde5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088734Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Travis Skare authored
BUG: 1046814 Change-Id: I704099fce2d703f964d16be46f8a7c4c0be07e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954671Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#747344}
-
Ben Joyce authored
Change-Id: Ib82dc3a17382d8f20d0ccf0d840ff7f6bc4b606c Bug: 1052460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088404 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747343}
-
Wez authored
Bug: 1050703 Change-Id: I09b9c20f631a6dda0a424790ac7f55ada0f144d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056947 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747342}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c0409aa3814..f365c53a18b1 git log 7c0409aa3814..f365c53a18b1 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 taylori@google.com Merge "perfetto-ui: Fix counter quantization" Created with: gclient setdep -r src/third_party/perfetto@f365c53a18b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9f1496de8f76cf68115b362d70f759719d2ea452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090074Reviewed-by:
-
Mark Cogan authored
Plumbs a Browser into BookmarkHomeViewController and BookmarkInteractionController. This removes explicit passing of BrowserState, WebStateList and Dispatcher into these classes. Unit tests are also updated, including fixing incorrectly named members in the Bookmarks test superclass. Bug: 1057116, 1057121 Change-Id: Ifdf674c76dc3d449f49ef22d48a4bdc4c8ffceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087921 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747340}
-
Maksim Ivanov authored
This moves the error label a bit down in the SAML smart card PIN dialog, in conformance to the UI feedback. As was clarified by the designers, the padding should be 4px to the upper bound of the text box, not to the upmost pixel of the font. Conceptually, the error message should look centered between the input field and the keypad below. This CL moves the error label by 3 pixels downwards, in accordance to this corrected understanding of the requirements. Bug: 1024251 Test: start SAML login via a smart card, proceed to PIN dialog, take a screenshot, verify the distance Change-Id: I3e2aa96151254595424010e4db33673f5ddd0d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089757Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#747339}
-
