- 01 Feb, 2018 40 commits
-
-
Zhiheng Vincent Li authored
Bug: b/72722832 Test: cast_shell_junit_tests Change-Id: Ie1f26c346f7b5c0b95771c091f429b63bc6a49e2 Reviewed-on: https://chromium-review.googlesource.com/896374Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533550}
-
Yoshifumi Inoue authored
This patch changes "skip-over-contenteditable.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: I78798539a928a7319e439b8947bef7fd89fe695a Reviewed-on: https://chromium-review.googlesource.com/895342Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533549}
-
Koji Ishii authored
Following bot results are included. 3420 3423 3424 3426 3428 3434 3438 5 lines were removed and 29 lines were deflaked by consecutive results since 3372. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5eb50fe97c29ec71ead2860fc3a47e24cb49417e Reviewed-on: https://chromium-review.googlesource.com/895166 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533548}
-
Takuto Ikuta authored
This is mainly for proguard steps which make build slow due to restricted parallelism on android_n5x_swarming_rel builder. Example build traces from slow builds: https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave954-c4/ninja_log.slave954-c4.chrome-bot.20180131-023634.24049.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351638 https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave617-c4/ninja_log.slave617-c4.chrome-bot.20180131-021253.3583.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351634 https://chromium-build-stats.appspot.com/ninja_log/2018/01/31/slave980-c4/ninja_log.slave980-c4.chrome-bot.20180131-021148.4142.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/351629 I investigate peak memory usage of some large/long time targets with args.gn of android_n5x_swarming_rel. |--------------------------------------------------------+-------------| | target | peak memory | |--------------------------------------------------------+-------------| | chrome_public_apk.proguard.jar | 843076 KB | | chrome_public_test_apk__apk.proguard.jar | 995208 KB | | chrome/android/monochrome_public_apk/classes.dex | 1178664 KB | | lib.unstripped/lib_unit_tests__library.so | 3181252 KB | | android_clang_arm/lib.unstripped/libmonochrome.so | 2718856 KB | | android_clang_arm/lib.unstripped/libwebviewchromium.so | 2362328 KB | |--------------------------------------------------------+-------------| So 4GB is sufficient. I tested the builder by modifing base_export.h to run linker for many targets in https://chromium-review.googlesource.com/c/894928/4 Bug: 804251 Change-Id: Ic5f985dba29d063a7541553813561f85c9dd3278 Reviewed-on: https://chromium-review.googlesource.com/894928 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533547}
-
Takuto Ikuta authored
This makes link time faster on the bots. Bug: 807660 Change-Id: Id4ae4a533971e53d5b095cec9bc73a5c273129af Reviewed-on: https://chromium-review.googlesource.com/895426Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Trent Apted authored
This reverts commit cd5b76ea. Reason for revert: Suspected for persistent failures on linux-chromeos-rel. 4 cycles starting: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/4806 PrerenderBrowserTest.PrerenderWindowSize fails with ../../chrome/browser/prerender/prerender_browsertest.cc:1084: Failure Value of: DidDisplayPass(web_contents) Actual: false Expected: true (under NavigateToURLImpl(..)) Original change's description: > Allow navigations to opener's site to go back into opener SiteInstance. > > Previously, when a popup and its opener were cross-site, and neither > site required a dedicated process, navigating the popup back to the > opener's site did not swap processes, so the two ended up in different > processes and couldn't script each other. Even though > DetermineSiteInstanceForURL contains logic to place same-site popups > into their opener's SiteInstance (added as part of the fix for a > similar issue 796912), this logic was never reached because we never > attempted a process transfer in this case, thanks to > IsRendererTransferNeededForNavigation() returning false. > > This CL tweaks IsRendererTransferNeededForNavigation so that a > cross-process transfer is always attempted is such cases. This allows > DetermineSiteInstanceForURL to always place the popup that's going back > to its opener site into the opener's SiteInstance. > > Bug: 807184 > Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec > Reviewed-on: https://chromium-review.googlesource.com/894369 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533410} TBR=creis@chromium.org,alexmos@chromium.org Change-Id: Iabdd81f6a5dc75795985074684e6be77c462a398 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807184 Reviewed-on: https://chromium-review.googlesource.com/896663Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533545}
-
Hayato Ito authored
GetDistributedNodes() doesn't consider Incremental Shadow DOM. Let's replace it with FlattendAssignedNodes, which is aware of Incremental Shadow DOM. BUG: 776656 Change-Id: Ie2730816552e7ea81289a9d44cb8f12f88a8adc9 Reviewed-on: https://chromium-review.googlesource.com/892604 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533544}
-
John Williams authored
This CL adds the media router git repository to the top-level DEPS file and adds supporting files that allow the code to be built as part of the main build process. The version of the media router that can be built from the Chromium tree is crippled because it contains to media route providers. Things coming in future CLs: - Nontrivial media route providers. - Execution of unit tests. - Incorporating the built extension into released build artifacts. - Integration with Chromium waterfall. Bug: 698796 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If5b4a02dfe27f618fd34e586bd8be07833b30d23 Reviewed-on: https://chromium-review.googlesource.com/783555 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533543}
-
liberato@chromium.org authored
Previously, there were many instances of using RequestQuit as a quit closure for ServiceContextRefFactory. However, it's possible for the last ServiceContextRef(Impl) to be destroyed as part of ServiceContext teardown. This causes a closure to call back into a half-destructed ServiceContext. This CL exposes a method to get a weakly-bound RequestQuit closure, and updates all quit closures to use it. Bug: 806632 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7551e74db5d7f1d85d946b611d0bcf6599503673 Reviewed-on: https://chromium-review.googlesource.com/894500Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#533542}
-
chengx authored
Bug: 795672 Change-Id: Icd947146950422f919583b700e6df5660cadc920 Reviewed-on: https://chromium-review.googlesource.com/857260Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#533541}
-
https://skia.googlesource.com/skia.git/+log/4a9ad50646d8..22c528dccef2 $ git log 4a9ad5064..22c528dcc --date=short --no-merges --format='%ad %ae %s' 2018-01-31 fmalita [skottie] Convert SkottieSlide2 to SkSceneGraph animators. 2018-01-31 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 61d5325e6..15443ebad (1 commit) 2018-01-31 fmalita [skottie] Clamp SkCubicMap results to [0,1] 2018-01-31 fmalita [sksg] Initial text support 2018-01-31 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 191a84a83..61d5325e6 (1 commit) 2018-01-31 reed add saturate helper for float2int64 2018-01-31 rmistry Add script that registers an Android compile task and waits for it to complete 2018-01-31 robertphillips Add SkSurface_Gpu::MakeWrappedRenderTarget method 2018-01-31 halcanary SkQP: report, use `image-rendering:pixelated` Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ie9d0144ebed95e32645f0e5658af37204f6c9411 Reviewed-on: https://chromium-review.googlesource.com/896827 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533540}
-
Jaebaek Seo authored
MHTMLGenerationTest.RemovePopupOverlay fails when enabling --use-zoom-for-dsf. It is because |center_point| of MHTMLFrameSerializerDelegate::ShouldIgnorePopupOverlayElement() is in DIPs, while box->FrameRect() (which is compared to |center_point|) is in physical pixels. This CL scales |center_point| by the device scale factor to match those scales. TEST=content_browsertests MHTMLGenerationTest.RemovePopupOverlay on NEXUS 5X Bug: 737777 Change-Id: I8b4a97f546e73759af29e35b8d234ec2dbd937b3 Reviewed-on: https://chromium-review.googlesource.com/895103Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533539}
-
Peter Boström authored
* Removes fixed label width. * Adds context and style to promo label. * Removes content view inside BookmarkBubbleView so that the promo view isn't being enlargened due to the invisible content dimensions. Bug: chromium:766277 Change-Id: Ieadd706373e4b67d0bcf5fb62a1b78fd1ff67703 Reviewed-on: https://chromium-review.googlesource.com/890055 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533538}
-
Eugene But authored
Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. Bug: 695189 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If423f77e077caaf94f619d080b12dbfd6e279fdd Reviewed-on: https://chromium-review.googlesource.com/891655Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533537}
-
Yixin Wang authored
Since google3's implementation will be identical, there's no need for the code to be in quic/platform/impl. This CL along with https://chromium-review.googlesource.com/c/chromium/src/+/893625 together correspond with google3 CL https://critique.corp.google.com/#review/184066984 Change-Id: I335b43b82ae7b53f4de794e0ba465f03165fe4ae Reviewed-on: https://chromium-review.googlesource.com/894178 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#533536}
-
Eve Martin-Jones authored
Mojoms should declare all imported mojoms in their public dependencies. Currently, //ipc/ipc.mojom imports //mojo/public/interfaces/bindings/native_struct.mojom. However, the mojom target (//ipc:mojom) cannot depend on //mojo/public/interfaces/bindings:bindings (the target which defines native_struct) without causing the duplication of symbols defined in that target which are already exported by //mojo/public/cpp/interfaces. This CL duplicates mojo::native::SerializedHandle into //ipc/ipc.mojom from //mojo/public/interfaces/bindings/native_struct.mojom allowing the dependency on native_struct.mojom to be removed. Change-Id: I956ccc5b18c33ee5259a2cedb4c5a96c332aaf6d Reviewed-on: https://chromium-review.googlesource.com/885686 Commit-Queue: Eve Martin-Jones <evem@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533535}
-
Dale Curtis authored
This is a reland of the following with an updated TestExpectations: https://chromium-review.googlesource.com/c/chromium/src/+/882283 For the same reasons as the have metadata test is marked as pass or timeout, so to may the have future data test timeout if timing aligns just right to elide the resume call (not an issue in practice since the real suspend path elides the suspend call in this case).. ----------------------------- Testing is accomplished by a couple new window.internals.* methods which allow modification and inspection of suspend state: - forceStaleStateForMediaElement(element) - isMediaElementSuspended(element) Unfortunately due to the async nature of suspend the method for testing suspend must be polled once a idle suspend is initiated via the forceStaleStateForMediaElement(). Test helper methods have been added to media/suspend-util.js to alleviate test cruft. forceStaleStateForMediaElement() does not actually force a suspend, it simply marks the element as stale. If an element is playing, seeking, or otherwise in a non-suspendable state, no suspend will occur. This is intentional to ensure tests cover our state machine as close to reality as possible. Unfortunately the only way to force given ready states for the media element is through throttled loading; this CL makes extensive use of throttled loading and adds a throttling limit to our layout test loader to avoid timeouts with slow initial rates. These tests were run with a --repeat-each=200 several times without flake, but I'll also watch the flakiness dashboard for these afterward. As a result of the above combined with the fact that we are not yet propagating play state to WMPI, we can reach a timeout state in the 'suspend after metadata' src= test. It's marked as pass and timeout in TestExpectations until the following lands: https://chromium-review.googlesource.com/c/chromium/src/+/876924 This is part 1 of 2, the 2nd part will add MSE based variants of these tests. No new internals methods are expected though, just a appendBuffer() based mechanism for triggering ready states. BUG=694855, 756897 TEST=it's all tests! TBR=mlamouri, peter, foolip Change-Id: Ie8f45d2d9572fd09c1943dc0674b25835527a1ab Reviewed-on: https://chromium-review.googlesource.com/895856Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533534}
-
https://webrtc.googlesource.com/src.git/+log/8fb22e71ee9b..6ade76d69d85 $ git log 8fb22e71e..6ade76d69 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia23bb636e7ca45efe6fb1b154e57913aa31285f2 Reviewed-on: https://chromium-review.googlesource.com/896584Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533533}
-
Evan Stade authored
Bug: 783018 Change-Id: Id77ed586c6db7401688c72deabbdcba4d8d6293d Reviewed-on: https://chromium-review.googlesource.com/892420Reviewed-by:
-
Alan Cutter authored
The method BoundsAnimator::CreateAnimation() is only overridden by a test class that doesn't really need to do so. This CL removes the test subclass and the virtual keyword from CreateAnimation(). This is a code clean up and has no change in behaviour. Change-Id: I633f1163125cca423da4aff54ffafc0922bf0658 Reviewed-on: https://chromium-review.googlesource.com/895207Reviewed-by:
-
Darren Shen authored
This patch implements the new CSSMathValue serialization algorithm [1]. As explained in the bug, this serialization is impossible to do by converting to CSSValues and then serializing them, so we have to implement this from scratch. We tried to make the code follow the spec algorithm as closely as possible for easier understanding/verification. [1] https://drafts.css-houdini.org/css-typed-om-1/#calc-serialization Bug: 803688 Change-Id: I48987d2b76b0bac55389a014588f3fe40aecf10a Reviewed-on: https://chromium-review.googlesource.com/896422Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533530}
-
Yoshifumi Inoue authored
This patch introduces test cases for |StartOfWord()| with |PreviousWordIfOnBoundaryBasic| to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: I5b2452cf45c3063ed67d436def4b05a3a617b424 Reviewed-on: https://chromium-review.googlesource.com/895208Reviewed-by:
-
Reilly Grant authored
This change renames public/interfaces to public/mojom and *_struct_traits_* to *_mojom_traits_* in //device. As a side effect the //device/vr/public/mojom directory was created to hold vr_service.mojom and //device/screen_orientation/public/interfaces was moved to //services/device/public/interfaces as the rest of that directory had already been moved to //services/device. Bug: 806965 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb8cf29107aaae89a9f616a864e079551da63768 Reviewed-on: https://chromium-review.googlesource.com/894142Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533528}
-
Eugene Ostroukhov authored
Bug: 789317 Change-Id: I4ef5f83dc37261b053bf698919aa93ad77375fad Reviewed-on: https://chromium-review.googlesource.com/861199Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533527}
-
Matthew Jones authored
In practice, this means changing the Chrome Home checks to Chrome modern design checks. BUG=803090 Change-Id: Id511842962d72234db4a5c7fb99311f19ed09cda Reviewed-on: https://chromium-review.googlesource.com/896523Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533526}
-
Yoshifumi Inoue authored
This patch changes "skip-over-uneditable-in-contenteditable.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: I9aa13fdf989bddbe578676815072ce3b3207bc7d Reviewed-on: https://chromium-review.googlesource.com/895128Reviewed-by:
-
Devlin Cronin authored
One of the variants of GetPropertyUnsafe() was unused. Remove it. Bug: None Change-Id: I518789c94f00cbd6225159cfcfd6004b94151b64 Reviewed-on: https://chromium-review.googlesource.com/896387Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533524}
-
Yoshifumi Inoue authored
This patch introduces test cases for |EndOfWord()| with |PreviousWordIfOnBoundaryBasic| to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: I598b650c495af5587f6417f04fff4f8236b69903 Reviewed-on: https://chromium-review.googlesource.com/895228Reviewed-by:
-
John Abd-El-Malek authored
Context: https://groups.google.com/a/chromium.org/d/msg/network-service-dev/OtU2gBvN_EE/TUIl4j9cAAAJ Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib40dc4625ead75f0e612bf719e7dba428cbeed35 Reviewed-on: https://chromium-review.googlesource.com/896204 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This CL adds two metrics: (1) Success rate for GATT connection attempts. (2) Effective success rate for one or multiple connection attempts, using retries if a previous connection failed (up to the maximum number of retries). These metrics aid in our ability to analyze what our effective connection stability is. Bug: 805219, 672263 Change-Id: I407c3af03eb86ccc80807395e1f18a5bff2b71a4 Reviewed-on: https://chromium-review.googlesource.com/894445Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#533521}
-
Steven Holte authored
Bug: 793082 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2576f1ae6d40bb20fa641bfaf24089db4dd5e29e Reviewed-on: https://chromium-review.googlesource.com/884941 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#533520}
-
Christopher Lam authored
This CL changes the Cut/Copy/Paste shortcuts to be triggered through the web events so that the browser menu's edit buttons will work in the bookmark manager. Bug: 807104 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I57dfa94825b450de6d69f45f9a36085bd43775c3 Reviewed-on: https://chromium-review.googlesource.com/892549Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#533519}
-
Kevin Bailey authored
OmniboxView::UpdateTextStyle() needs to know if the text is a URL, but so does its caller. Rather than calculate it twice - a non-trivial run through Classify() - pass it. Bug: 669727 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a8be0bfaaf7fd6c2b5ada831de65340e71d47d6 Reviewed-on: https://chromium-review.googlesource.com/890658 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533518}
-
Shubhie Panicker authored
keepalive (renamed to KeepActive) is true if there is a running service worker, or shared worker or unfinished fetch keep-alive. In this case the scheduler should not freeze the renderer. If keepalive state changes then run UpdatePolicy, as a frozen renderer may need to be woken up. For full discussion, see: https://groups.google.com/a/google.com/d/msg/chrome-lifecycle-apis/qjPzJF0quRs/lurC3EWqAAAJ Change-Id: Iafa3e1b745ede38d2dcd6d89b232cc4d12e1e785 Reviewed-on: https://chromium-review.googlesource.com/869172 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533517}
-
Xiaohan Wang authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/3e444ad8860b..f5964c36e1dc $ git log 3e444ad88..f5964c36e --date=short --no-merges --format='%ad %ae %s' 2018-01-31 xhwang Remove carriage return (CR) in Windows CC_IDENT string 2018-01-30 xhwang Updating build configs for M66 roll 2018-01-29 xhwang media: Update build_ffmpeg.py to pull Android API level 2018-01-25 xhwang Merge FFmpeg for M66. 2018-01-19 chcunningham Remove ffmpegsumo.dll cruft. 2018-01-21 sw v4l2_m2m: Fix integer overflow in timestamp handling 2018-01-21 jamrial avcodec/mpeg12dec: fix preprocessor check for mpeg1_nvdec hwaccel 2018-01-21 sw v4l2_m2m: Fix free of the wrong pointer in an error path 2018-01-08 jun.zhao lavfi: add denoise and sharpness VAAPI video filters. (...) Created with: roll-dep src/third_party/ffmpeg BUG=777484 Change-Id: I91e9bea380dc7782c7f7dee751e268a29d270c12 Reviewed-on: https://chromium-review.googlesource.com/896571Reviewed-by:
-
Pavel Feldman authored
DownloadManager has public SetDelegate method and tests and or other subsystems can install their own implementations of the delegate. Bug: 805905 Change-Id: Iecf1e0aceada0e1048bed1e2d2ceb29ca64295b8 TBR: tests updated to follow the API change. Reviewed-on: https://chromium-review.googlesource.com/894702Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533515}
-
yiyix authored
Draw occlusion is introduced to reduce overdraw in chrome between different layers. Before drawing the compositor frame to the screen, Draw Occlusion iterate through every DrawQuad in the CompositorFrame then remove DrawQuads that are not shown on screen. The side effect is that it may take too long to iterate through many small non-overlapping DrawQuad. In this patch, I added a "skip rect", that is if the |visible_rect| of a DrawQuad is smaller than this size, it will be drawn to screen regardless it's shown or not. I did some research on a perfect size for "skip rect": https://docs.google.com/document/d/1N8o7Nvx-qsSGx4aKd-6OwVJHGMsSZZGmlORU7aK6sGs/edit Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I180053a5158832715145391eaaed29a3828834f1 Reviewed-on: https://chromium-review.googlesource.com/867477 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#533514}
-
Nico Weber authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/4a02ec03038d..ac4a549e29fb $ git log 4a02ec030..ac4a549e2 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 lv Extend ifdef to include helper functions 2018-01-31 lv Remove barrier to fix Android build. 2018-01-31 thakis Make breakpad build with -Wimplicit-fallthrough (on linux) 2018-01-17 pcc Do not use non-standard stdext::checked_array_iterator with libc++. 2018-01-08 lv Only restore the signal handler if sigaction has not changed 2017-12-22 nisarul Fixed file extention for minidump_upload in tools_linux.gypi Created with: roll-dep src/third_party/breakpad/breakpad Bug: 801780,177475 Change-Id: Ibab0e22bf2ca8c4f490b48203e182f90c3fba5aa Reviewed-on: https://chromium-review.googlesource.com/895822Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533513}
-
Ahmed Fakhry authored
When the feature is enabled: - Caption buttons will have 8px spacing between one another. - Browser's frame caption buttons will have a bigger height. BUG=805267 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib697ac229e9665377800cc5f58d42341b5ea01b6 Reviewed-on: https://chromium-review.googlesource.com/885508 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#533512}
-
Casey Piper authored
Initial U2F specifications specified a U2F version that was not compatible with ISO 7816-4. As some authenticators require this older GetVersion command, falling back to that initial command upon failure with the current GetVersion command. R=hongjunchoi@chromium.org, jdoerrie@chromium.org Bug: 805778 Change-Id: Id7f8a040aae323ba59c1d3c1418d8b5b8bb8953d Reviewed-on: https://chromium-review.googlesource.com/894894 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Juan Lang <juanlang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533511}
-
