- 18 Sep, 2020 33 commits
-
-
K. Moon authored
Translates between the UrlRequest/UrlResponse (flat string) and blink::WebURLRequest/blink::WebURLResponse (key-value map) header formats, based on the behavior of Pepper's content::CreateWebURLRequest() and content::DataFromWebURLResponse(). The Pepper methods do not distinguish between absent and empty strings, so UrlRequest and UrlResponse now use empty strings as the "absent" value as well, as there's no need to support this state separately. Bug: 1099022 Change-Id: Ia509bea005f356ccbe2bb79aff73a01fd3fd9eed Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415374Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#808171}
-
Ben Pastene authored
The bots moved from builder_group=chrome to internal.chrome.fyi, and I forgot to update their src-side configs. Bug: 1129540 Change-Id: I608e9e1130d720bb54833a33d71f7bdc0d180f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417307 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#808170}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd16cb59745a..ad48610a0129 2020-09-17 herb@google.com use digests internally for SkScalerCache 2020-09-17 reed@google.com Refactor API for mipmap-builder, 2020-09-17 mtklein@google.com Reland "refactor any()/all(), ptest for all()" 2020-09-17 johnstiles@google.com Allow constant propagation of unary negation. 2020-09-17 kjlubick@google.com [canvaskit] Add demo on how to decode images in web worker 2020-09-17 mtklein@google.com Reland "update skvx scalar-fallback strategy" 2020-09-17 brianosman@google.com Disallow narrowing conversions as part of matrix multiply-assignment 2020-09-17 egdaniel@google.com Don't always set vulkan blend constant when not using it. 2020-09-17 herb@google.com rename SkGlyphIndex to SkGlyphDigest 2020-09-17 herb@google.com refactor making a new glyph 2020-09-17 brianosman@google.com SkSL: Only allow bitwise ops on integral types 2020-09-17 johnstiles@google.com Migrate several SkSLFP tests to golden outputs. 2020-09-17 johnstiles@google.com Migrate several GLSL workaround unit tests to golden files. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1129408 Tbr: scroggo@google.com Change-Id: Id66bea3652853af558d3a7fe2d78d6ab8bff61e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808169}
-
My Nguyen authored
Change-Id: I92d80750cae6ba886d38161802d3264b9319fd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416212Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808168}
-
Owen Min authored
Some Java code in policy components are kept due to internal code base references. Those references are removed hence those code can be clean up now. Bug: 1127469 Change-Id: I36021a4e73c988ccc391e89a28815224a98bba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414890 Auto-Submit: Owen Min <zmin@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#808167}
-
Ana Salazar authored
Set a time limit for files restored in the holding space model. Downloads and screenshots older than the time limit, will not be restored on initialization. We fetch the file date from the metadata when checking for file existence, thus we now partition the items by valid and invalid items, checking for both file existence and file age. Bug: 1123739 Change-Id: I35456b9d52d7125f05db686d6855f16e8d8fbe39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415093 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#808166}
-
Xiaocheng Hu authored
As resolved by CSSWG [1], we will add ascent-override, descent-override and line-gap-override, but advance-override remains under discussion. This patch moves advance-override under a different flag, so that it doesn't affect shipping the other three descriptors. [1] https://github.com/w3c/csswg-drafts/issues/4792#issuecomment-693528301 Bug: 1098355 Change-Id: I60ac927efc788b04c11ca2d7160bc724fe3eee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415244Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808165}
-
Nidhi Jaju authored
As EagerCodeCacheStrategy and GetEagerCodeCacheStrategy() are not used anymore, they can be removed. Hence, the service_worker_utils.h header file can also be removed. Bug: N/A Change-Id: I8066861d5e0571a1bb52a07408775ceefd275304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416268Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Cr-Commit-Position: refs/heads/master@{#808164}
-
Kyle Horimoto authored
Change-Id: I9527c9e6bac6f735b56e3a4a4d9905c9b1e93cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417629 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808163}
-
Azeem Arshad authored
This CL adds Barhopper internal repo to DEPS. This library will be used in ChromeOS builds to implement Chrome's ShapeDetection API in ChromeOS. This is being added as part of ChromeOS eSIM project See go/cros-esim-dd-qrcode for details. Approved in ChromeOS Eng Review: go/cros-esim-eng-review Bug: 1093185 Change-Id: Idd0abcfc900a7f30162394c6176caceaa8880f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416746 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#808162}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: If4c41f6ececc2b635da5b9f63c698cad558cb501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411654 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#808161}
-
Gayane Petrosyan authored
Also removing the blue banner. Bug: 1102382 Change-Id: Id94ba797c86dcd18874c7e548797cd087489a851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416810Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#808160}
-
Joel Hockey authored
Unsharing can fail if the VM has a file open within a shared folder. In that case, we show a dialog to notify the user that unsharing failed and allow them to retry. https://storage.cloud.google.com/chromium-translation-screenshots/ec0fdd89ab5d4afc79c7e65d463ecece4925ac68 Bug: 920416 Change-Id: Ib47a7ca6a1d3a8b9501613a36b211fcc5a70d1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413428 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#808159}
-
Michael Checo authored
Description: Currently, when the idle setting is set to "shut_down" or "stop_session", we display "Other." With these changes,we now show either "Shut down" or "Sign out" depending on the policy value. Screenshots: - http://shortn/_VXgsUHKwBd "Shut down" - http://shortn/_p5pE4tCnli "Sign out" Bug: 1091565 Test: gtest_filter=OSSettingsDevicePageTest.PowerTest Change-Id: If599cf3ba6e276d65bec7fee486c7349e487c632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411286 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
Tarun Bansal authored
Also add couple of other histograms to keep track of how frequently the signal strength is queried. Change-Id: Id363c0f0a17803c07e5e5d6424db61f7a95bb470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408276Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808157}
-
Abigail Klein authored
The live caption feature will have a promo underneath of the global media controls in order to inform users of this feature and help them find where to enable it. Bug: 1055150 Change-Id: I00fb0a4a4dfaeba507aac7b3a3d00a93577a731e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406537 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8d7201bc3c3c..fc79097fa2f9 2020-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I64d577a7817bbc0c5fb72b8402e9871adf29b19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417325Reviewed-by:
-
Bo Majewski authored
This is a reland of 6cf11459 //chromeos/components/file_manager:file_manager_ui depends on //chromeos/components/file_manager:file_manager_mojom. That dependency generates (among other) //chromeos/components/file_manager:file_manager_mojom_js. In the failed build, the last library is unconditionally included in //chromeos/resources/BUILD.gn, as, when build, it is needed by the application. Since //chromeos/components/file_manager:file_manager_ui is only included in unofficial builds, all dependencies on generated mojo files must also be done for non-offcial builds only. This has been in the following patches: https://chromium-review.googlesource.com/c/chromium/src/+/2410156/1..12 Original change's description: > Reland "Files SWA: Moving to a new directory." > > This is a reland of 4ccb6508 > > http://crrev.com/c/2367397 and this CL were prepared without > the authors being aware of each other's efforts. > > Timeline for 2367397: > Sep 10, 2020, 6:06:39AM UTC+10 it is submitted to CQ > Sep 10, 2020, 9:01:21AM UTC+10 it is successfully submitted > > Timeline for 2402560 > Sep 10, 2020, 10:46:31AM UTC+10 dry run is successfully completed > Sep 10, 2020, 12:19:23PM UTC+10 it is submitted to CQ > Sep 10, 2020, 12:23:56PM UTC+10 it is successfully submitted > > > Original change's description: > > Files SWA: Moving to a new directory. > > > > Bug: 1111229 > > Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Reviewed-by: Jiewei Qian <qjw@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Bo Majewski <majewski@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805598} > > Bug: 1111229 > Change-Id: I8894da793702136d5e394b9854993026603c311d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402560 > Commit-Queue: Bo Majewski <majewski@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806865} Bug: 1111229 Change-Id: Ia5b27db24b1649589280f09ca41be78f0402bf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410156 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#808154}
-
Tarun Bansal authored
Bug: 1129002 Change-Id: I5edbab61ab01498557ffa030f5bd5fd7a362346a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413548 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#808153}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/37457d086ed3..1c79e9ea29ee 2020-09-17 ianelliott@google.com Vulkan: Delay vkAcquireNextImageKHR till later If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Test: Test: angle_deqp_egl_tests --gtest_filter=dEQP.EGL/functional_query_context_get_current_display_rgba8888_window* --use-angle=vulkanTest: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest*/*Test: Test: angle_perftests --gtest_filter=GenerateMipmapBenchmark.Run/vulkan_webglTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.*Invalidate*/* Change-Id: I297a830e2adf4f0abd70f49f41fc8228ab78d3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417318Reviewed-by:
-
Toshiki Kikuchi authored
This CL changes ScopedOverviewTransformWindow to use ScopedObserver to ensure all observed windows are removed on destruction, instead of relying on GetTransientTreeIterator method to get observed windows. Bug: 1129070 Test: existing tests pass Change-Id: I101ca26ee97c209e7d4623c541c75f57c4cce699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415756Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808151}
-
Kenichi Ishibashi authored
The Storage Service can't depend on //content. We need to remove //content dependencies from ServiceWorkerStorage so that it can be moved to the Storage Service. This CL moves scope matching logic from //content to //blink to remove a //content dependency from ServiceWorkerStorage. The Storage Service can depend on //blink/public. Bug: 1016064 Change-Id: I95dade6bce286f81a030617a44be66211218950f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415711 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808150}
-
Hidehiko Abe authored
This CL cleans up gmock use in keyboard_unittests. - Use MOCK_METHOD, instead of MOCK_METHOD1 etc. - Insert testing::Mock::VerifyAndCleanExpectations in appropriate lines to make sure the callback/delegate invocation timing, otherwise it just checks the number of calls on the destruction of the mock objects. - Move several variable declarations to make closer group. This is the preparation to rework Keyboard more. As its preparation, this CL makes tests more precise. BUG=1123705 TEST=Ran exo_unittests Change-Id: I40675c34e7d239ba970ea11f2c8f4ec53b06618a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416190 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#808149}
-
Hidehiko Abe authored
Currently is_linux is set to true on Chrome OS build, but it is planned to set it to false. This CL is the preparation to keep the behavior even after the switching. Bug: 1110266 Test: Built locally. Change-Id: Ic4fca9914a62080c525baf39ec9e203d8bf95bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413652 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808148}
-
Gyuyoung Kim authored
As ImageAnimationPolicy enum type was moved to Blink, it would be good if we can use it in the whole area without converting. So, this CL replaces the existing enum type and all uses with web_pref::ImageAnimationPolicy after moving image_animation_policy.h from renderer/platform/graphics to public/common/web_preferences. Bug: 919392 Change-Id: I25ddb4aba7f3b7cfc4bc90f0df1e0d1806cedd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413714 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Gavin Williams authored
This change moves the call to NativeLayer.requestPrinterStatusUpdate to inside the Destination object. Shifting responsibility of requesting statuses to Destination helps centralize the managing of the request promises as printer status will be used by multiple UIs in Print Preview. |Destination.printerStatusReason_| changes to null/nullable to make it clear when a destination has never received a status. And since |Destination.printerStatusReason_| will only be populated after a successful printer status request, the tracker |statusRequestedMap_| is no longer needed. Bug: 1123754 Change-Id: I0ade10e7183179e995dda593f3f4f898e708bcfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414771 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808146}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aef8a21a695c..5956a17ed665 2020-09-17 titovartem@webrtc.org Revert "Wires up WebrtcKeyValueBasedConfig in media engines." 2020-09-17 natim@webrtc.org Removing logic forcing AEC within VoIP core 2020-09-17 philipp.hancke@googlemail.com build: document that aaudio was experimental 2020-09-17 sprang@webrtc.org Wires up WebrtcKeyValueBasedConfig in media engines. 2020-09-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d25386e..303ad9b2 (807774:807890) 2020-09-17 nisse@webrtc.org Delete rtc::LeftPad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I032ade000e160649b1b583508a3698fc6a6c3391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417323Reviewed-by:
-
Chih-Yu Huang authored
This CL fixes a wrong DCHECK for checking if a Optional has value before dereferencing it. BUG=b:153608694 TEST=ninja chrome Change-Id: I4b054df94555d828d5523a766484e7fbc64ced09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413680 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808144}
-
David Black authored
New string resources are added for: - "Pin to shelf" - "Unpin from shelf" Bug: 1128731, 1122076 Change-Id: If2952e05fae15cbcf800ff5fa9a051f509e3e141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416817Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#808143}
-
My Nguyen authored
Suggested input methods should not show non-allowed input methods. All input methods shows non-allowed input methods with policy icon. Existing view: http://screen/8xx8PB5jdbEzgpB Spec: http://go/cros-lang-settings-figma View of input page: http://screen/AWbcPaGqZLJ2kY7 View of add input methods dialog: http://screen/3VnQTLXLJD9WEGW Note: - Tooltip text subjected to UX writing review Bug: 1113439 Change-Id: I78afe3e5eedef7c05a43366fabe0f22caa83032a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413710Reviewed-by:
-
Xida Chen authored
As discussed in this doc: https://docs.google.com/document/d/1zCIs8zBE7SPIS_OTvTuLkLbEgSfh-RxF0cYSCNAm-Ko/edit?ts=5f4ea439#heading=h.7o3hpjjptc4v We would apply some heuristic to detect js-driven animation, and canvas invalidation is one of them. This CL detects that, it contains a unit test to verify the correctness. Bug: 1111392 Change-Id: I7f37077b1a0da3c85301bf6034fde96898a84534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393068 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808141}
-
Daniel Classon authored
Adds deep links to the Multidevice page and subpage, as well as the Smart Lock and Nearby Share subpages. Bug: 1084154 Change-Id: I1ea575fa5922e50a7d6defa3c9276a76e66bef11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415091Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
-
Allen Bauer authored
Bug: 938501 Change-Id: Id9b9e82b5b3c50fa8da4fba8c0b1dedcaca470d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416890Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#808139}
-
- 17 Sep, 2020 7 commits
-
-
Jing Wang authored
It is problematic for testing during development if these flags are disabled by default. And it's safe to enable them by default, since the flag AssistPersonalInfo, which is the main switch for these features, are disabled by default. Bug: 1042084 Change-Id: Iad61804c53d306df5378844d8770e98bdbe96f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415751Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808138}
-
Ian Barkley-Yeung authored
Currently, SendJavaScriptErrorReport relies on GetClientCollectStatsConsent which is broken on Windows (specifically, it doesn't thunk over to the correct DLL before accessing globals). Disable SendJavaScriptErrorReport on Windows until that is fixed. Bug: chromium:1129544, chromium:1121816 Change-Id: I949af71855d012547aa2dc91cd87a98fa1de6cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417299 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#808137}
-
Adam Langley authored
This reverts commit dc96d8d4. Reason for revert: Windows is sensitive to export-annotation ordering. TBR=msramek Change-Id: I2ac69570957bf7d4a109d4af92dd537c77d97a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416572 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#808136}
-
Lukasz Anforowicz authored
Bug: 1056949 Change-Id: Ide9a3e5b594580ee8600b0cbe8bf610fc6491bc8 Tbr: alexmos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417005Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#808135}
-
Nina Satragno authored
Implement encrypting and decrypting large blobs, and add a test for updating blobs which exercises the new code path. Bug: 1114875 Change-Id: Ief91f642fa5ccc34f7ef2d00c90467fbcb90bc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415218 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Lijin Shen authored
- Add SingleActionMessage component to build, show and remove a message banner view - A MessageContainer holding messages Bug: 1123947 Change-Id: I6f597bda965cdbd3af0edf9cec47d09fddbcd92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380885Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#808133}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5f863da9c924..11880b30c360 2020-09-17 michael.liao@microsoft.com [Sources]: Bug fix where frontend is imporoperly handling a pausedEvent with empty callframes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129220 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I58e3faae1b221ba07844c4f447312eacd68fc74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417316Reviewed-by:
-
