- 25 Sep, 2019 40 commits
-
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I27f4d213b84a3c7f41ec94759d397bfb694374de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798606 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#699908}
-
Nate Fischer authored
The record_netlog.py previously had a false positive when the package of interest was a substring of a running process (ex. "com.foo" and there's a process named "com.foo.persistent"). Substring matching was not intended, so switch to GetApplicationPids() which does not perform substring matches. Searching for exact package names usually suffices (and this is just a best effort attempt to detect if the app is running), so we should just minimize the false positive rate. Test: Try with "com.google.android.gm" when "com.google.android.gm.persistent" is running Change-Id: I3204131aaaf53df9d7972f8bce37602dfd8324d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820091Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699907}
-
Bailey Berro authored
This fixes a bug where rotation was not persisted properly for displays set to a non-native resolution. ManagedDisplayInfo::native_ represents whether the object comes from DisplayChangeObserver [1]. ManagedDisplayMode::native_ represents whether the display is using a native resolution [2]. Previously, these values were incorrectly used interchangeably in DisplayChangeObserver::CreateManagedDisplayInfo(). This CL introduces ManagedDisplayInfo::from_native_platform_ to track whether the object comes from DisplayChangeObserver. ManagedDisplayInfo::native_ will now be used to track whether the display is using the native resolution. 1- https://cs.chromium.org/chromium/src/ui/display/manager/managed_display_info.h?rcl=661dcc6c712db426e252a8bccecfad50baecdce7&l=334 2- https://cs.chromium.org/chromium/src/ui/display/manager/managed_display_info.h?rcl=189281e03cf1b236600cd5fb6e6bbc049bdb4f60&l=65 Bug: 968224 Change-Id: I0eb4da445682481ced2b55a23e3a0ace6995a8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793745 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699906}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09aa96cf69bd..370924be227a Created with: gclient setdep -r src-internal@370924be227a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9851cb3a54a7b532cfebb3c40f2a1405f139f833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699905}
-
Nate Fischer authored
No change to logic. This reorders Java modifiers to conform to the JLS style guide, which is enforced by a new presubmit check (https://crrev.com/c/1803140). This also adds curly braces to for loops, as this is also a presubmit requirement. Bug: 1003711 Test: git cl presubmit --upload Change-Id: Ice355c6453b4e88c28dacc07d91ade61a1e2d09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823813 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699904}
-
Vikas Soni authored
A DCHECK became invalid after a recent refactoring. Move the DCHECK to more appropriate place. BeginReadAccess() could be called multiple times on a single shared image in which case this DCHECK is valid only for the first call. once |promise_texture_| is created and cached, this DCHECK becomes invalid. Change-Id: Ia77759ca7797675adbcf41a78c1086e3aebba2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822318Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699903}
-
John Budorick authored
Requires crrev.com/c/1809653 Bug: 922145 Change-Id: I3f2f134cd91f4c1ca50cb08348860c058d8dd1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797004 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#699902}
-
Rohit Agarwal authored
Bug: 1004101 Change-Id: I8c8d12cc4faa60b6ead3abf2ed7ca8572fbca6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803921Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699901}
-
Sergey Ulanov authored
Previously SysmemBufferPool wasn't calling Close(), which means that sysmem would fail the collection after SysmemBufferPool is destroyed, which prevent other clients from using that collection. Now the destructor calls Close() to avoid this issue. Change-Id: I0edd5cf9c79d9c0a14048211cebab215d76c953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820102 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699900}
-
Tao Bai authored
This patch added content-capture trace event category, also traced scheduling task and task running event. Bug: 1006418 Change-Id: I2dbe38bbf3e09645abb6185e8efa15587ffb00ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817282Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699899}
-
Kyle Milka authored
If the peek state for a BottomSheet is disabled pressing the back button should return the sheet to the hidden state rather than the peek state. Bug: 1007186 Change-Id: I1d8c3643fffd9eaf34f7b77d4c58470b7a865e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821981 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#699898}
-
Xianzhu Wang authored
This makes std::iterator_traits work for IteratorAdapter, which may be required by some std algorithms. Change-Id: Ib7bf7d8c7f97e6287006314e3b8958ed53bd6b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825467Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699897}
-
jonross authored
There were several redundant test suites being ran on the GPU FYI SkiaRenderer bots. They were originally added to make cross-referencing failures easy. However the SkiaRenderer feature is much more stable now, so these are redundant with coverage on other bots, such as "Linux FYI Release (Intel HD 630)" This change removes all gtests not explicitly about SkiaRenderer + Vulkan from the bots. Bug: 1007087 Change-Id: Id536217e13f2d71c192c5a88adad4366667a4668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824121Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#699896}
-
jonross authored
We have begun field trials of SkiaRenderer on Linux. As such the browser_tests on the CQ are now running with SkiaRenderer enabled. This leaves us without any test configuration for the off state. Here I replace skia_renderer_browser_tests on the FYI bot Linux Viz with non_skia_renderer_browser_tests to ensure we have coverage during the field trials. Also deleting skia_renderer.browser_tests.filter as the final flakes are not SkiaRenderer specific, and are being addressed by those teams. We do not need it for the non_skia_renderer_browser_tests Bug: 967716 Change-Id: I6065d88539829aad49e7a941f2f7fa65977a76ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825098Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#699895}
-
Sinan Sahin authored
Bug: 989148 Change-Id: I889d7c52f4aa241d276e3665475362fa6178b091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809813Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#699894}
-
Reid Kleckner authored
R=thakis@chromium.org Bug: 962988 Change-Id: I8f52fb88cf10d292e414bb2bd5bf4bbf3f7cd392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825119 Commit-Queue: Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#699893}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I5c0efdb274222b1af861acf7cd31dade9a3ab2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822509 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699892}
-
Allen Bauer authored
Bug: 1005568 Change-Id: If12927896ad1daa745517c03a6951ff65b3de2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823257 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#699891}
-
John Chen authored
ChromeDriver was passing --ignore-certificate-errors switch to Chrome, regardless of whether user wants to ignore certificate errors or not. Fixing by stop passing this flag to Chrome, and relying on using Security.setIgnoreCertificateErrors command when user wants to ignore certificate errors. Bug: chromedriver:3148 Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699890}
-
Lei Zhang authored
Add bool ReadAndCheck() as a wrapper around int Read() that returns true if and only if the specified amount of data got read. Similarly, add wrappers for ReadAtCurrentPos(), Write(), and WriteAtCurrentPos(). Make use of these wrapper methods in a few places to show how they can make code more robust or more foolproof. Fix nits and lint errors along the way. Change-Id: I956550708eeecee543b2e9b0948ea20de5308b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775233Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699889}
-
Mark Pearson authored
Correct mis-rendered links and clean up the grammar slightly. Change-Id: I5bbb8af18f40713957625805ae4757a657469d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823800 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699888}
-
Daniel Clark authored
Per https://w3c.github.io/html-aam/#el-mark, update the LocalizedControlType of <mark> from "text" to "highlight". Bug: 996459 Change-Id: I5f435988e16663df295cd195f3de6d97aab0dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762581 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699887}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Moving to use AlertOverlayCoordinator also converts JS dialogs to use child UIViewControllers, fixing some other issues resulting from the asynchronous nature of UIViewController presentation. Bug: 990070, 979030, 999960, 999962 Change-Id: I6c2465e5bc501540d9b16b60add61045e96ed963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809061 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699886}
-
Christopher Cameron authored
Make ExtensionAppShimHandler be an AvatarMenuObserver (making it very similar to the existing ProfileMenuControllerInternal::Observer). Package up the profile list into mojo, and send it to AppShimController, where it is un-packed and displayed. Add a mojo method to communicate menu item selection back to the AppShimHost in the browser process. Note that this implementation is not complete yet. - The UI design is that profiles for which the app is not installed should not be included in the menu (left as a TODO) - Selection reaches ExtensionAppShimHandler::OnShimSelectedProfile, which just opens a new app instance -- it will need to load profiles or focus existing windows (and will need tests) - The app shim will need a dock context menu as well Bug: 982024 Change-Id: Ia72bc46b42b4ee3fa2866235c2e681aa690013a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819853 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699885}
-
Elly Fong-Jones authored
10.15 introduced three new keyboard layouts that this test didn't handle: * Dhivehi-QWERTY, which behaves like DVORAK-QWERTYCMD but with a different base layout * Kyrgyz-Cyrillic, which generates cyrillic characters only and doesn't match any key equivalents * Mongolian-Cyrillic, which is similar This change: 1) Generalizes the DVORAK-QWERTYCMD logic to also handle the new Dhivehi-QWERTY layout (and others if needed later); 2) Skips this test on the two new Cyrillic layouts Bug: 998755 Change-Id: I1527974222b9e962379c70f8a57da5bc9cdba8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825140 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#699884}
-
Adithya Srinivasan authored
This is a reland of a42225db. I've disabled the test on ChromeOS as it fails due to a known bug. We should still run this on other platforms. Original change's description: > Portals: Add chrome/ browser test for activation > > Bug: 927056 > Change-Id: Ief5a22cf86cd6bdeeae4361e616f66487f589c9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809115 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698129} Bug: 927056 Change-Id: I9a05b6086f6d5341a4df30eb2bddf4ea2d07574e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817765Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#699883}
-
Alex Moshchuk authored
This CL will force all future tests that rely on content::NavigateToURL() to check its return value and ensure that the navigation behaves as intended. All existing tests have already been converted to validate the return value. Bug: 425335 Change-Id: I8c7c47a19b9b7beed5546dbe6f38b2dde1aed437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820319Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699882}
-
Vasilii Sukhanov authored
Bug: 936011 Change-Id: I57095b23d0b5540425cac35f929ced8d7a5c5549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824889 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699881}
-
Joshua Peraza authored
Bug: 942279 Change-Id: I221431e352f11b40c3bc39bbcd8297b431dd8f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763346 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699880}
-
Christian Biesinger authored
Tested by running: cups_config_helper.py --libs-for-gn /usr/local/google/home/cbiesinger/chromium/src/build/linux/debian_sid_amd64-sysroot With python2 and python3. Bug: 941669 Change-Id: I88bd4d13039a48b1aafa617e6856b07fdc87ce2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825568Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699879}
-
Scott Violet authored
RemoteFragmentClient -> BrowserFragment BUG=none TEST=none Change-Id: I7560db41694f766b71bf13c9f6f687d587b93b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825569Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#699878}
-
Yue Li authored
In Chromium build the libassistant might be unavailable. In this case we want to hide the Assistant opt-in flow. Bug: b/141330938 Test: Manual Test Change-Id: I6796cab496892938a7c026e1a72d1fc4a4b25296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817319 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699877}
-
Tarun Bansal authored
Effective connection type (ECT) is now available from NetworkStateNotifier on the blink side. The logic to pass the ECT from browser side to renderer per frame is no longer needed. The CL also updates the calls on the Blink side to use GetNetworkStateNotifier instead of the per-frame value. This CL introduces one functional difference: Before: The value of ECT was frozen for the frame and that frozen value was propagated to the child frames as well. With this CL: The value is not tied to a frame and may change dynamically with time during the lifetime of frame. Further, the main frame may see a different value than child frames. Change-Id: Id80629142e17f304f7dd53ac3cd25c9837b99955 Bug: 725680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815602Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699876}
-
Caleb Raitto authored
Create FakeDataSink class to retrieve request body from UploadDataProvider. Add request body byte array as a parameter to ResponseMatcher.getResponse(). Added ResponseMatchers should verify the body of the request if that is necessary for the test before responding. Patched from original CL: crrev.com/c/1742515 (kirchman@'s internship ended). Bug: 669707 Change-Id: I3be8a95e80e82cf74edd7bd5e23e5adf2e5e04cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784978 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699875}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was was destroying decryptor when re-initializing. This approach wasn't working well because the buffer collection shared between decryptor and decoder is being torn down when decryptor is destroyed, which causes the decoder to fail as well. To avoid this issue FuchsiaVideoDecoder now reuses the decryptor after re-initialization. Bug: 1003529 Change-Id: Ie90d4e5f9d4bbe5d96dafcfc69d19f314080c05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819945 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699874}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I65bed07b831dd541dec524562706772f6df33b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824290Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#699873}
-
Fredrik Söderquist authored
This gets rid of the IntervalSelector argument, replacing it with a time which the interval should start after (or at) and end after. With this, ResolveInterval(...) becomes independent of the current interval (previously only used as the internal "begin after"). Fold ResolveNextInterval() into its only user. Bug: 998526 Change-Id: I807327986d5aa7286395ac29019a63d6c8921202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825417Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#699872}
-
Jan Krcal authored
This CL removes and unused notification AutofillMultipleChangedBySync() from the AutofillWebDataServiceObserverOnDBSequence interface. #JointFixit Bug: 900607 Change-Id: I03d32a60f7fbac58a3738767baead7fe61354d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824091 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699871}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/edb189d40cb2..9776ca2c2a0d git log edb189d40cb2..9776ca2c2a0d --date=short --no-merges --format='%ad %ae %s' 2019-09-25 tcwang@google.com afdo: Extend AFDO stalenss check to 42 days. Created with: gclient setdep -r src/third_party/chromite@9776ca2c2a0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6ce60f657fd2f6dd1d5adbaf3fddc805f73d9636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699870}
-
Tibor Goldschwendt authored
Bug: 989646 Change-Id: I979e775039aa59087fa3a50b2ad78e8d692ee634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825297 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699869}
-