- 07 Oct, 2020 40 commits
-
-
Morten Stenshorne authored
It's unused, and its values kAlignLeft and kAlignRight were conflicting with values in the CaretAlignment enum inside LayoutBoxModelObject::LocalCaretRectForEmptyElement() when compiling with -Wshadow Bug: 294205 Change-Id: Iaf89021bbb79aa4e46539284c3db5ba2d2844367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455688Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#814753}
-
Ben Pastene authored
This will display the current gardener on build.chromium.org pages under the "Oncalls" box next to chromium, android, ios, etc sheriffs. Gardeners are responsible for ensuring frequent uprevs of Chrome into Chrome OS. A big part of that is monitoring & resolving Chrome build/test regressions on Chrome OS. Hence why adding them to the list of browser oncalls makes sense. Ideally this will also provide a good point of contact for general CrOS-related tests and build bugs/questions that non-CrOS chromium devs may have. Bug: None Change-Id: I9367acc2871661d2ec69ec9ce2a29d7c758a06d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416944Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#814752}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/972e0ab44119..c90bac4197a4 2020-10-07 saklein@chromium.org cbuildbot/prebuilts: Refactor SplitCPV to parse. 2020-10-07 saklein@chromium.org api/controller: Add require_each validation. 2020-10-07 saklein@chromium.org parser/package_info: Generalize parse. 2020-10-07 saklein@chromium.org service/dependency: Change default targets to their constants. 2020-10-06 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I5348328cc4b70bf19944d5631b200accdd4cd7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814751}
-
Haiyang Pan authored
This reverts commit f1c22acf. Reason for revert: The new FlagsFragmentTest consistently fail on a couple of android builders. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_webview_instrumentation_test_apk&tests=org.chromium.android_webview.test.devui.FlagsFragmentTest%23testToggl* Original change's description: > [AW][Dev-UI] Add some espresso tests for flag UI > > Add tests for toggling flags and the persistent notification. Also > remove test batching for flags fragment tests to so the flags service > is killed when the process is killed leaving a clean state. > > Fixed: 1130599 > Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" > Change-Id: I0cb416471d3b79e98ed9ef8ad5e760b4bfaa1083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438534 > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814362} TBR=changwan@chromium.org,ntfschr@chromium.org,hazems@chromium.org Change-Id: I803750893fa96b624c028905a2c2cd4770ae6d4a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457646Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#814750}
-
Mariam Ali authored
This CL adds new color ids and colors for the avatar header assets for incognito and guest modes using the old method by setting them manually and the new method by extracting the colors from existing core colors. Aligning colors in incognito and guest for both the header asset and the avatar icon. Screenshots: https://screenshot.googleplex.com/BNC82JK2UkZR5eb.png Bug: 1105763 Change-Id: Idcc27c87b081f22429c7342c042d39e721d6ef86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418654 Commit-Queue: Mariam Ali <alimariam@google.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#814749}
-
Nico Weber authored
We no longer use set_sources_assignment_filter() anywhere in the chromium build, so these are no longer needed. Bug: 1018739 Change-Id: I1d4d4d40c479b8a638c962a21f5334d28a3488c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456626 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#814748}
-
Tina Wang authored
Bug: 1131052 Change-Id: I62f8a29ba1fdaefb5912ebad8a9512546f61c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443692Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814747}
-
Avi Drissman authored
This also retires the hang metric. Better metrics are in the works. Fixed: 823087, 1089339 Change-Id: I08a2dd0ec6611e9b301830589b46c8c16935cc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450699 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814746}
-
Akihiro Ota authored
This change adds a test to ensure Switch Access state gets updated when the virtual keyboard is opened and closed. Fixed: 1135248 AX-Relnotes: N/A Change-Id: I1b894bce635f1790cee1111f50992c9136d3ded7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453899 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814745}
-
Aaron Leventhal authored
Was failing on debug builds because now uses NOTREACHED() in debug builds for failure, instead of just returning false. TBR: dmazzoni@chromium.org Bug: 1135795 Change-Id: I107dc265c5861d916179b6a89f4007c0a74cc130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457566Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#814744}
-
Maggie Chen authored
GPU watchdog V2 has been enabled for months. It's time to clean up V1. Merge class GpuWatchdogThreadImplV2 and class GpuWatchdogThread, and use GpuWatchdogThread as default. Bug: 949839 Change-Id: Ic0d784bf4f3bcf79e60b71389c42a824429f83e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455366Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814743}
-
Maksim Sisov authored
This is a reland of a60f7247 Original change's description: > ozone: fix expectations in clipboard test > > In case of Ozone, we support more types. > > Bug: 1134495 > Change-Id: I9712931545c8b70a1a0357d5b119b8c9a7c08c4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443650 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#814303} Bug: 1134495 Change-Id: I5849855e3fd037dc7eb34d0b94bbc08b6246b234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454051Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#814742}
-
Ella Ge authored
This reverts commit ab12c6e3. Reason for revert: Breaks browser_tests: SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9011 Original change's description: > [CCA WebUI] Don't capture navigation other than main page URL for CCA > > We have the following requirements: > 1. We prefer loading CCA UI in the app window rather than browser tab > => Therefore we added "capture_navigation=true" for CCA > 2. We don't want to load resource URLs or invalid URL in the app window > => Short term: Landing this CL to filter out unwanted URLs > > We decide not to support URL filtering feature for capture navigation > since only camera app has such requirement at this moment. > (crbug.com/1132151) > > Bug: 980846 > Test: Type CCA url other than chrome://camera-app/views/main.html and > the page is loaded in browser tab > > Change-Id: I467aa1498aa9fe975d34bdf82adee7f6dff6a14c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440076 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814557} TBR=ortuno@chromium.org,wtlee@chromium.org,qjw@chromium.org Change-Id: I12e4bbd7ee461e7ed0a3d0664e90ca3e4ea435f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 980846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457586Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#814741}
-
Eric Willigers authored
PendingAppManagerImplBrowserTest no longer uses web app ProviderType. Bug: 1065748 Change-Id: I7628ec04f5f990e37b17cdf4a9823a1e16bde8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454962 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#814740}
-
Eric Willigers authored
PendingAppManagerImplTest no longer uses ProviderType and is no longer parameterized. Bug: 1065748 Change-Id: I8841e10b771797238d91441dab623ac3a930aa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454433 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Fixes a regression caused by http://crrev.com/c/2424854 ("Refactor chrome.automation.EventType"), it could have manifested as select-to-speak not updating when the page scrolls. See http://crrev.com/c/2450663 for more context. Bug: 1110367, 1135248 Change-Id: I12e62a18093a0fc2837ec0be312d4f7261c5dc42 AX-Relnotes: none because this just fixes a regression Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454633Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010070700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/EP5Br5PmtIoxqkHULWlMdCAFh4JkRRBcAK3VRUi-3gwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/162270429,b/165769056 Tbr: media-app@grotations.appspotmail.com Change-Id: If38402881b0249caa72c321089afe3ec8104b1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456016Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814737}
-
Roberto Moura authored
Setting the cells' layer zPosition is necessary for lower rows to be superposed during transitions between grid and horizontal layouts. Change-Id: I335aaedf6eee0dca2e15a94558e58d2c2c48974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456346 Commit-Queue: Roberto Moura <mouraroberto@google.com> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814736}
-
Jian Li authored
This is a reland of 325dbbc8 Original change's description: > [Feed v2] Allow setting feed stream data in feed internals page > > Bug: none > Change-Id: Iecc0cb44e239c1b4502e81bc50931230732af61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429930 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814073} Bug: none Change-Id: I580f6bcf05f9876db07a966d4ed9af51f924296b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451921Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814735}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/935a915963e1..b364d20b12d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2b15752d4abda84e8e760f8f4c0aca135c0806c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456149Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 347e8861. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/mediacapture-record NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: If36be818a6c12c6af2779bd823b1af78b5e6a7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456406Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814733}
-
Dominic Mazzoni authored
In http://crrev.com/c/2424854 ("Refactor chrome.automation.EventType"), we simplified the mappings from ax.mojom.Event and EventGenerator events. However, a minor oversight was that the previous code mapped some generated events into automation events with different names. With the new code, they map to an automation event with the same name - but the old names still exist so they didn't generate a compile error. To ensure this was comprehensive, I wrote some code to log all of the event mappings before and after the patch, and did a diff to look for discrepancies. The diff is here - https://paste.googleplex.com/6408048659660800 - but the only relevant ones are: - ariaAttributeChanged - expandedChanged - scrollPositionChanged This patch fixes any instances of those three events in Switch Access in particular. This fixes at regressions with combo boxes and the virtual keyboard. Bug: 1110367, 1135248 AX-Relnotes: none because it just fixes a regression Change-Id: I5e3a3b98edb8d9fcdc3ad55b28ad2ce476da7e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450663 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Also moves the config for this from //base -> //build/config/compiler for symmetry with //build/config/compiler:wexit_time_destructors. Bug: None Change-Id: If117e5963df44fdc2f03e01716e8af16e2c91e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453460Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#814731}
-
Sylvain Defresne authored
With recent change to Multi-Window, the metrics were recorded per window instead of being recorded per BrowserState. Moreover, only the currently displayed window's metrics were sent when the app was backgrounded. To fix this, add a new base::SupportsUserData::Data object that is attached to the ChromeBrowserState. This object, SessionMetrics, stores the session metrics which are updated from events happening in all of the windows. In preparation of adding metrics that are only recorded for the off-the-record ChromeBrowserState, pass a set of flags to the method recording the session metrics to choose exactly which one should be recorded. Add a call to SessionMetrics::RecordAndClearSessionMetrics() for both the main and off-the-record ChromeBrowserState on application background event, and when the off-the-record ChromeBrowserState is destroyed. Bug: none Change-Id: Idee8ef1a1fb0be7153d4ceb78d0a795d589a9848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450052 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814730}
-
Francois Doray authored
Bug: 982143 Change-Id: I3fc1482aad34db3bc6fc1931ea98f8a8bb4dd7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450738 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814729}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/c9110b93cb8a..a388d56d9968 2020-10-07 dsinclair@chromium.org [spirv-writer] Fixup constructor with bitcast parameters. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:263 Tbr: kainino@google.com Change-Id: I0a76f4f7215a7f8eda1a996d79b01f539dbe6510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456015Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I929d7a955c9671748b2e7f7a370a39eecf1dbd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446653 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#814727}
-
Nohemi Fernandez authored
UI change that moves all Google Services and Sync options into their respective categories. Ensures that all Sync status updates are respected. Bug: 1125631 Change-Id: I30cc039ca924a856b555b6215c9a25f6bcf07188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445513 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#814726}
-
Majid Valipour authored
R=goto@chromium.org Change-Id: I2ec08e9a5c7610066d04860555e1d9bf03432c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456147Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814725}
-
Weilun Shi authored
All new chromium metrics OWNERS need to go through a training process prior to being added as formal owners. Bug: 1133371a Change-Id: I9754559357078d74da73924406ede9c7435c06ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453342 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814724}
-
Yunke Zhou authored
Bug: 1135512 Change-Id: I96d28c6817b8661e9a201d759ee6d6ef620cb1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455749Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#814723}
-
Richard Knoll authored
I've been working on notifications for a while now so adding myself as an OWNER to reflect that :-) Bug: None Change-Id: I2f185b5a1d6060717d44e8bb67425832f3d01d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457106 Auto-Submit: Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#814722}
-
Boris Sazonov authored
Disables testReject, testRejectBasicCard and testDetails on tablets. Reason: flaky (builder links: https://crbug.com/1136100#c1). TBR=rouslan@chromium.org Bug: 1136100 Change-Id: I818fe70318c063755a7329b473117bbef779b3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456847Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#814721}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/093cc27604..4b4f9aae75 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/093cc27604..4b4f9aae75 No .def file changes. Bug: None Change-Id: Ie56604087d635647c9d4dff01aaa7ce332299f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456347Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#814720}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be paramaterized. Bug: 1065748 Change-Id: Ie4d7ce9659179e6f925d21533c198f0c0030590d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454595 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#814719}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ifea18890a5bc6144ae6a5581525d1495ff037a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453926Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814718}
-
Weilun Shi authored
Add /tools/metrics/histograms/histograms_xml/*.before.pretty-print.xml to gitignore to ignore generated before.pretty-print files for split histograms as well as histograms_xml/obsolete_histograms.xml and histograms_xml/histogram_suffixes_list.xml Change-Id: I308bdfe8ff205def461418aca7a527c4ca3998a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437729 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7e22b1c44fb0..2ee68783068c 2020-10-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 488d7a9346ff to c9110b93cb8a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I7ad75828c853dd33fd15bd0eb55db1de4ae4a87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456188Reviewed-by:
-
Fabio Tirelo authored
This fixes an issue of UEMs sending empty string for unset policies on Android (issue happening on both GEM and AirWatch). Until all UEMs fix this issue on their side, we should fail gracefully. The proposed approach is simply consider that special case as policy not-set for policies with type list or dictionary. I inspected all list and dict policies, and the only ones for which I expect changes in side-effects are: - DefaultSearchProviderAlternateURLs - DefaultSearchProviderEncodings - ProxySettings The DSP policies are fine, as discussed before. They will in fact prevent other policies from not being set when values are pushed via managed configurations, especially the most basic DefaultSearchProvider ones. The ProxySettings policy should also be OK. When it's unset, values from ProxyMode, ProxyServerMode, ProxyServer, ProxyPacUrl, and ProxyBypassList will be used instead. BUG: 1134739 Change-Id: Ib194b432df0b1f6caba7340bb82496a44ff2c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443669 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#814715}
-
Anne Lim authored
Adds a footer at the bottom of the InfoBar which spans the InfoBar's whole width. Screenshot where a footer is added to SavePasswordInfoBar: https://screenshot.googleplex.com/AVqcryn4jnEcoT9 Bug: 1135847 Change-Id: I8c3cd9968ced6ee4280b3929671e5e61043d4fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454694Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#814714}
-
