GitLab

These tests started failing in try jobs or LED jobs in Xcode 12 GM roll
CL (upstream: crrev/c/2411403, downstream: crrev/i/3274047).

Bug: 1129588, 1129589
Change-Id: Ib18c0cb05c234d2cfb58ad3c59a9af44861dfc40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416754
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808116}

This is a speculative fix. If WebContentsAccessibilityAndroid ever
had a bad pointer to its root BrowserAccessibilityManager, that
could definitely cause the sorts of crashes we've been seeing.
Rather than keeping a copy of a raw pointer, just have
WebContentsAccessibilityAndroid retrieve the root
BrowserAccessibilityManager when needed.

Also ensures that if GetRootBrowserAccessibilityManager is null, any
function called from Java returns an error immediately, as that could
also potentially be a source of bugs.

Bug: 1126657
Change-Id: I52040a71c21ba4a8f5f30b316082c8b1e7efbb66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415928Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808115}

This change adds the ability to forward proto_in_dir to support
downstream use of nested directories for grpc protobufs.

Bug: 1129637
Change-Id: I0221d7b1a28aa578c8f3f33cd93b6d07879c54f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416568
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808114}

Bug: 1129266
Change-Id: Icb27b527607e42b7ec0eb6ea22a093b2a73968a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415808Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808113}

R=akihiroota@chromium.org

Fixed: 1098914
AX-Relnotes: ChromeVox will not move its focus indicator when adjusting the volume using hardware keys.
Change-Id: I6d64fb39dd63bab76630b667ba37ea5d96a02c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416751
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808112}

As the check is no longer needed, it can be removed from the codebase.

Bug: N/A
Change-Id: Ic655e0092bbe34592b2b5179c2debdf80ef590cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414312Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com>
Cr-Commit-Position: refs/heads/master@{#808111}

Adds an override to the focus() function for the multidevice feature
item so that the feature controller is focused when the item is focused.
Helps with adding deep links to the multidevice page.

Bug: 1084154
Change-Id: I9a5c382ccf5b5d6c6f6315bd4da200949e7b2c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417142Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#808110}

This class implements ConnectionAttempt for the Nearby medium in the
initiator role. A follow-up CL will create instances of this class
within PendingConnectionManagerImpl.

Bug: 1106937
Change-Id: I796fb982ad935c36d7cd3e569a0ba7aad407553c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415688
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#808109}

* Remove the two optionals BrowserTabMetadata from BrowserTabsModel.
* Adds sorted vector of BrowserTabMetadata to BrowserTabsModel, from
  most recently visited to least recently visited browser tabs.
* Modifies chrome://multidevice-internals to accommodate.

https://screenshot.googleplex.com/ASLmNrodybKchY6
https://screenshot.googleplex.com/5CyAkSuWD5wXM9g

Bug: 1106937
Change-Id: I5bc898b12db304491cec8091c51a2bf7b1c2ad24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415537
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808108}

Mark key pairs generated in certificate provisioning for Chrome OS as
corporate.

Bug: 1127506
Test: unit_tests, browser_tests
Change-Id: I5379f4b186283d076b2b6f02baf1323f174ea543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404832
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Michael Ershov <miersh@google.com>
Reviewed-by: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#808107}

For authenticated requests, ProtobufHttpClient first invokes
OAuthTokenGetter to get the access token, then enqueue and start the
request and pass in the invalidator. But if the access token fails to
fetch, ProtobufHttpClient will instead just call OnAuthFailed() without
starting the request or passing in the invalidator.

The previous OnAuthFailed() implementation of ProtobufHttpStreamRequest
was broken, since it just called OnStreamClosed(), which assumes the
invalidator_ exists and calls it. ProtobufHttpRequest OTOH seems to be
intact and we have test to guard that.

This CL fixes this issue on ProtobufHttpStreamRequest and add a test
case for it.

Bug: 1129567
Change-Id: I45d295b5a744657673568e937cf638f2013f188e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417143
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@google.com>
Cr-Commit-Position: refs/heads/master@{#808106}

Modify lorgnette_scanner_manager to accept a
base::RepeatingCallback<void(std::string)> which will be called every
time a page has been successfully scanned. The completion callback has
been changed to accept a boolean, indicating whether the overall scan
succeeded or failed.

This doesn't change the internals of lorgnette_manager_client
significantly. It will be migrated to the multi-page scanning API in the
next commit.

Bug: b:161239919
Change-Id: I50d25fe83215cf6861d800123867f52c566bc33b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404402Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808105}

Stops using --replace-system-package for AR/VR tests, instead opting for
a new --remove-system-package + --additional-apk combination. This
avoids some flaky issues associated with attempting to restore the
system app after testing is done and ends up speeding tests up since
fewer reboots are needed during teardown.

Bug: 1120220
Change-Id: I818368114ad7f44fbac282e3b09e2e2494496f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417114
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808104}

This CL is a precursor to https://crrev.com/c/2413407 in preparation
to remove all non-universal planes code paths.

We add a CHECK to verify that universal planes are supported
on all current ChromeOS releases and devices, and that this
upcoming change will not break anything unexpectedly.

Bug: 1129546
Change-Id: I03a1263161c1da4c1489c88af5f345654391c361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416937
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808103}

This patch fixes a bug from https://crrev.com/740787 where
LocalFrameView::ForAllThrottledLocalFrameViews would stop at
non-throttled frames, rather than recursing into them.

Change-Id: Iaaaf129fd693fc0adb546ca09ecd78a6a4002f6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410526
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808102}

OutputPresenterFuchsia was setting image constraints for allocated
buffers. As result the images were always allocated with
pixel_format=R8G8B8A8 without any flags set in format_modifiers. As
result, device-specific optimizations were not enabled for these
buffers, so GPU was using more memory bandwidth than would be possible
otherwise. This change updates OutputPresenterFuchsia to avoid setting
any constraints for the buffer collection. Instead buffer collection
constraints are set only through Vulkan. This ensures that the buffers
are allocated with all possible optimizations supported by the Vulkan
driver.

Bug: 1128740
Change-Id: I7ec8f605ace86a33062d5296a1b6b2e1f647b3c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414757Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808101}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e2e75b23aa67..8d7201bc3c3c

2020-09-17 gavinmak@google.com Modify git map-branches to show the number of commits on a branch

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1128716
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ida9d803154057a9378627cbac4bac8d6be206ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417146Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808100}

This is the ConnectToDeviceOperation implementation for a Nearby
Connections attempt in the initiator role. A follow-up CL creates
instances of this class when performing a connection attempt.

Bug: 1106937
Change-Id: Ie47af35bb23d1d751de1c5833b3acdfb0768824c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415534
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#808099}

This change follows up on feedback in
https://crrev.com/c/2340571
and refactors the way in which the PpdMetadataManager builds PPD
metadata paths into the Chrome OS Printing serving root.

Bug: chromium:888189
Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*'
Change-Id: Ie2619526b596656a3186a708272c9e6da8ad3bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377069
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808098}

Compile targets are copied from the recipe config in
chromium/tools/build in anticipation of removing compile targets from
recipe config.

Bug: 1091004
Change-Id: I024d448e96bbb60d1012f944aa7418d82ed672a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415214
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808097}

Plumb the 'FastAdvertisement' UUID, 0xfef3, into Nearby Connections.
Its presence informs Nearby Connections to register smaller,
non-connectable BLE advertisements.

Manually verified that the correct UUID and advertisement contents are
broadcasting, via my Pixel phone and the nRF Connect app.

Note: Fast Advertisement support for scanning remains unimplemented.
Support cannot be added until b/168659459 is resolved.

Change-Id: Ib9160985cf4c8d1f51dbf6113b9ac376237ed035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410876
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#808096}

Bug: 1122764
Change-Id: I3de9e23f4ac9aad71d6c8b8a52cfac852628c3aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412454
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808095}

This change:
1. Updates the expiry milestone for the annotations feature.
2. Removes the flags to disable the search the menus and language
switching features, since they have been launched now for the past
several milestones.

Bug: N/A
Change-Id: I305dd657b441a8a00402ca9163d3c49ddea691a1
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416398Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808094}

Removes exidx wrapper from arm32 unwinds. The wrapper caused issues
with unwinding crashes in official test bots, crbug/1078588. Since we
are not using libunwind to unwind due to other crashes, this wrapper can
be removed.

BUG=1078588

Change-Id: Ifc6832345a715e75a4344f4dcdd1b570d6f0626b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330743Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808093}

This CL makes the page content scroll with the top controls during
animations if OnlyExpandTopControlsAtPageTop() returns true. Prior to
this change, animations would expand the top controls without moving the
page contents, which would result in them overlapping the page, which
isn't the expected behavior when OnlyExpandTopControlsAtPageTop() is
set.

Bug: 1127076
Change-Id: I4d6f125bae5ac39f27577d3e7aace0c93523e95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404378Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808092}

According to the device capacity http://shortn/_b0QLWXBn0o, there should
be enough devices to support 40% traffic.

Bug: 1111436
Change-Id: I38ceb9b54d151bfddbc83e640c8d0f25d981aa81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417102Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#808091}

Currently we don't do this and it means the user can group tabs,
close one of the tabs in the group and then undo the grouping.
Because one of the tabs is destroyed this leads to a crash when
we try to update its root id.

Bug: 1117396
Change-Id: I0d91d44ce2bf8783531ccb3c959010fdf6905fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414995
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808090}

MathML Core says special properties of operators happen when the
corresponding <mo> elements contain text content only [1]. However,
Blink currently just reads the element's textContent() without checking
whether it contains non-text children. This CL fixes that behavior and
also adds a WPT test to verify correct lspace/rspace (including after
dynamic change of the <mo> content).

[1] https://mathml-refresh.github.io/mathml-core/#dfn-algorithm-for-determining-the-properties-of-an-embellished-operator

Bug: 6606
Change-Id: Iab0e3309bf03167889e4a7161fd053a4a9744908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414282
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808089}

Issue was caused by trying to read a "phoneName" field as part of the
phone status, but that field is part of another API call. This was
mistakenly left in by an earlier CL.

Bug: 1106937
Change-Id: Ia6b2123921955354e96115d8334b915011384ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417291
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808088}

We should check ShouldClipOverflow() instead of IsScrollContainer()
(which was renamed from HasOverflowClip() recently -- this CL shows how
the new name improved code readability) for inclusion of layout overflow
for layout shift tracking.

Bug: 1127474
Change-Id: Id85b292b65dae837d1e366d548939b85c9cd5d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417061Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808087}

This reverts commit 70ab9853.

Reason for revert: crbug.com/1129613

Original change's description:
> [layout] Ensure fragment tree consistency.
> 
> This patch ensures that we always have a "consistent" fragment-tree (or
> rather a portion of a fragment-tree if we have legacy nodes).
> 
> Previously it was possible for a fragment-tree to become inconsistent
> whenever we performed layout from a subtree root. Now when we layout
> from a node like this, we rebuild the "spine" of the tree.
> 
> After this change we'll be able to remove most "PostLayout" calls,
> except where they are used for building this "consistent" tree.
> 
> Bug: 1066616
> Change-Id: I3993fcc5be1cd9043555ecad553fc569fc985314
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407032
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807866}

TBR=cbiesinger@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org

Change-Id: I88e82529f6b11fd07523a46bde6829ca23af77a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417369Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808086}

Using wpt-import in Chromium 2f45c78b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
guidou@chromium.org, armax@chromium.org:
  external/wpt/mediacapture-streams

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: I34d59c3fe542b41bb7304567db7d56ede8055ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417208Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#808085}

Bug: none
Cq-Include-Trybots: luci.chromium.try:mac-arm64-rel
Change-Id: Ibd9b3f1acccce84a4db64a756dd99dcb5f985320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417092
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808084}

This change implements PpdProvider::ResolvePpd() and updates all unit
tests to pass.

Bug: chromium:888189
Test: chromeos_unittests --gtest_filter='PpdProviderTest.*'
Change-Id: I4077a750ab0d3f67bba3be2df010e11c4e6ebf97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363855
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808083}

Bug: 1045980, 1078405, 1090936

Change-Id: I1a004c9fa0cdb5300bb94ce55a80ef3fffaace6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417098
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808082}

This class is responsible for handling connection requests as well as
requests to cancel an ongoing Nearby Connections attempt. This CL
creates the a base class a a fake, as well as a skeleton implementation
class. The implementation will be completed in a follow-up CL.

Bug: 1106937
Change-Id: I45d997192f5a055de1206f283676c7d490cd81b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415224
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#808081}

This reverts commit c50922a2.

Reason for revert: Does not resolve the issue.

Original change's description:
> Revert "USB devices are only shared with one VM at a time"
>
> This reverts commit 4e4ea3fd.
>
> Reason for revert: Speculative revert to fix BrowserTest.CloseWithAppMenuOpen failures on linux-lacros-tester-rel bot.
>
> [ RUN      ] BrowserTest.CloseWithAppMenuOpen
> [27984:27984:0917/013814.891745:WARNING:ozone_platform_wayland.cc(203)] Failed to find drm render node path.
> [27813:28015:0917/013814.933599:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
> [27813:28015:0917/013814.933632:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed.
> [27813:28015:0917/013814.933859:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
> [27813:28015:0917/013814.934033:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
> [destroyed object]: error 1: popup parent not constructed
>
> Original change's description:
> > USB devices are only shared with one VM at a time
> >
> > Remove map of VmSharingInfo from CrosUsbDeviceInfo since device
> > is only shared with one VM at a time.
> >
> > TBR=khorimoto@chromium.org
> >
> > Bug: 1129266
> > Change-Id: I2025091bf63eeed538c62d8b39cfbb744339aa64
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413716
> > Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> > Reviewed-by: Nicholas Verne <nverne@chromium.org>
> > Auto-Submit: Joel Hockey <joelhockey@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#807786}
>
> TBR=joelhockey@chromium.org,nverne@chromium.org
>
> Change-Id: I96cab98518776d10ef10d7c8376eb7379c92d6e3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1129266
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416389
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807879}

TBR=waffles@chromium.org,joelhockey@chromium.org,nverne@chromium.org

# Not skipping CQ checks because this is a reland.

TBR=joelhockey@chromium.org,nverne@chromium.org

Bug: 1129425
Change-Id: I6a251e43676c0b461b49fe681edaee0bb564ea72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416393
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808080}

We enforce that CriticalPersistedTabData observers cannot
be removed after destroy() - this causes the app to crash.
We should check the tab is initialized before doing this.

Bug: 1117396
Change-Id: I38d794536e6571de273bd51d50da3a157e792290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410732Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808079}

Adds the lint test target to android-lollipop-arm-rel.

Bug: 1108309
Change-Id: I827ae0d2bb4746fc7345715ed723d0d56078c208
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414834
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808078}

Bug: 1128583
Change-Id: I31a8b52c89bb411a6dc81f189829adf63907748d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414617Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808077}