GitLab

Previously, tests that involved incognito profiles needed to manually
create them and add them to the parent profile before
GetOffTheRecordProfile was ever called.  However, the documentation for
Profile explicitly states that the incognito profile will be created if
it doesn't already exist when GetOffTheRecordProfile is called. Further,
it was prohibitvely invasive to test code that creates a profile and
expects to be able to do something with its associated incognito
profile.

This commit also updates existing tests to remove unnecessary manual
incognito profile creation.

BUG=318803
R=atwilson@chromium.org, dpolukhin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/181403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255647 0039d316-1c4b-4281-b951-d872f2087c98

Our code has dependencies on the Windows implementation of this API until M33 and a recent unexpected change broke it, we need to make sure to be notified of any other potential changes.

We can remove this after M33 is out of stable.

NOTRY=True
BUG=350028

Review URL: https://codereview.chromium.org/189093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348006

Review URL: https://codereview.chromium.org/189203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255644 0039d316-1c4b-4281-b951-d872f2087c98

There was this TODO(sky): convert this and InitMessagePumpForUIFactory() to return a
scoped_ptr.

This patch is for doing the same.

R=darin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/185413019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332315
TEST=none

Review URL: https://codereview.chromium.org/183923037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255639 0039d316-1c4b-4281-b951-d872f2087c98

These utility functions are now only used in
discardable_memory_allocator_android.cc so they have no reason anymore to live
in discardable_memory_android.cc.

TBR=willchan@chromium.org
BUG=347919

Review URL: https://codereview.chromium.org/189113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255638 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/188723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350016
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/177013006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255636 0039d316-1c4b-4281-b951-d872f2087c98

This cl splits COMMIT_STATE_FRAME_IN_PROGRESS into below two separate
states for more clear.
1) COMMIT_STATE_BEGIN_MAIN_FRAME_SENT
2) COMMIT_STATE_BEGIN_MAIN_FRAME_STARTED

R=brianderson@chromium.org
BUG=347398
TEST=cc_unittests

Review URL: https://codereview.chromium.org/179933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255633 0039d316-1c4b-4281-b951-d872f2087c98

+ Added using statements.
+ Deleted annonmous namespace and include order in congest_control area
  to match internal source code.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/189403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255632 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255631 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 255605 / 475fd16c
Old Skia revision: 13693
New Skia revision: 13700
Control CL: https://codereview.chromium.org/190753002

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true

Review URL: https://codereview.chromium.org/190763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255630 0039d316-1c4b-4281-b951-d872f2087c98

This adds primitive support to the doc server for
API models living in src/extensions/common/api.

BUG=349953

Review URL: https://codereview.chromium.org/176973009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255629 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255627 0039d316-1c4b-4281-b951-d872f2087c98

Make WaitableCallbackResults ref-counted and a member of WebFileSystemImpl to keep it alive longer than before.
Add CallbacksUnregisterMode argument to RunCallbacks() to keep callbacks registered when necessary.
Initialize next_callbacks_id_ with 1 instead 0 to make 0 usable as an invalid ID.
Implement waitForAdditionalResult().
UnregisterCallbacks() is also responsible to unregister WaitableCallbackResults.

Corresponding patch: https://codereview.chromium.org/178333009/

BUG=347900
TEST=run_webkit_tests.sh http/tests/filesystem/\*
TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\*

Review URL: https://codereview.chromium.org/188533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255625 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the flag to enable non-SFI mode is checked just before launching the plugin in the browser process. However, even if the flag is set, we may need to run the plugin in SFI mode.
For example, trivially, if the plugin provides only SFI-mode binary.
To handle such a case, this CL adds entries to NaCl manifest file so that a plugin developer can declare if their plugin provides SFI-mode/non-SFI mode binaries.
In summary, NaCl works in non-SFI mode if;
1) --enable-nacl-nonsfi-mode is set to true, and
2) the plugin provides the binary for non-SFI mode.
So, some checks are moved from the browser to the renderer.

We need similar, but slightly different, a flag for non-SFI mode. Here is the naming rule:
1) enable_nonsfi_mode -> If non-SFI mode is enabled on the browser.
  (In more precise, if it is running on supported platform, and --enable-nacl-nonsfi-mode is set)
2) uses_nonsfi_mode -> If the specified plugin should run on non-SFI mode.
  This happens when the plugin provides the binary for non-SFI mode, and --enable-nacl-nonsfi-mode
  is set.

Note that, in later CLs, we split non-SFI mode nacl_helper from the current nacl_helper with linking it to the newlib.
Then, the uses_nonsfi_mode will become a flag to decide which helper the host should talk to.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Ran trybot.

Review URL: https://codereview.chromium.org/177113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145873, 322664
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/183333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255622 0039d316-1c4b-4281-b951-d872f2087c98

* Add methods EvaluateJavaScriptInContext,
ExecuteJavaScriptInContext.
* Backend classes take an additional context_id argument, which refers to the iframe.
* WebContents has an EnableAllContexts method, to enable access to iframes.
* Add tests testIFrame, and unit test data files host.html, iframe*.html.

BUG=237032
TEST=unittest

Review URL: https://codereview.chromium.org/183863007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255621 0039d316-1c4b-4281-b951-d872f2087c98

Originally these names had been named based on similarly behaving
devices we had in our inventory, change the names of both the variables
and displayed names to be more generic and instead describe their
behavior.

BUG=346367
TEST=device_unittests

Review URL: https://codereview.chromium.org/189753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255620 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/186843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255618 0039d316-1c4b-4281-b951-d872f2087c98

Switch to using the new Link Doctor API.

The new API allows Link Doctor results to be integrated into Chrome's
own error pages.

BUG=64832
R=tsepez@chromium.org, ttuttle@chromium.org
TBR=pkasting@chomium.org, thakis@chromium.org

Originally Landed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254207

Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=254241

Review URL: https://codereview.chromium.org/184973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/184853007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255616 0039d316-1c4b-4281-b951-d872f2087c98

Also avoids unnecessary heap allocations by recycling old state vector.
Result is ~100% performance improvement to ScheduleTasks.

BUG=269841
TEST=cc_perftests --gtest_filter=RasterWorkerPoolPerfTests/RasterWorkerPoolPerfTest.ScheduleTasks/0

Review URL: https://codereview.chromium.org/174453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255615 0039d316-1c4b-4281-b951-d872f2087c98

R=creis@chromium.org

Review URL: https://codereview.chromium.org/189063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255614 0039d316-1c4b-4281-b951-d872f2087c98

We are currently removing trying to remove all references to base::Time (wall
clock time) from Chrome/Blink compositor/graphics stack.

This requires multiple two-sided patches. Following the process found at
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ukaRczAK6t8/0ludyZ1Nu4cJ

The steps are;
 * Adding monotonic only API to Blink's animation delegate interface
   https://codereview.chromium.org/185633002

 * (This Patch) -- Making the delegate adapter use monotonic only API
   https://codereview.chromium.org/185643002

 * Remove the wallClockTime API from Blink/WebKit.
   https://codereview.chromium.org/185393005

BUG=299945

Review URL: https://codereview.chromium.org/185643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255613 0039d316-1c4b-4281-b951-d872f2087c98

This is not needed for renderers, and should be scoped to the right process
type.

BUG=348304,306348
TEST=Flash and renderers do not crash.

Review URL: https://codereview.chromium.org/186803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255612 0039d316-1c4b-4281-b951-d872f2087c98

Broke 
RtcpReceiverReportWithOversizedFrameLog and
RtcpReceiverReportWithTooManyLogFrames tests
> Cast: Cap max receiver log size per rtcp packet to 200 bytes.
> 
> This is a short term fix to hopefully reduce the effects of packets
> queueing up on the receiver side. Previously we try fill up the RTCP
> packet with as many receiver log as possible so we can have redundancy.
> The redundancy that has been observed was more than 30 per message, and
> we don't need this much redundancy. 200 is a good number where each
> log message will be sent with redundancy of around 2-3, without losing
> too many (< 1%) messages, assuming default rtcp interval settings.
> That's fine because we don't need the logs to be completely reliable.
> 
> 
> BUG=349265
> 
> Review URL: https://codereview.chromium.org/189423002

TBR=imcheng@chromium.org

Review URL: https://codereview.chromium.org/190723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255611 0039d316-1c4b-4281-b951-d872f2087c98

After recent refactoring, the volume manager is created for every profile, and listens to cros disks events on each of them. As a result, if a USB is inserted, then it is handled by all of the available profiles. If one of them has the policy disabling removable devices set to false, then all profiles (including those having the policy set to true) will get the device mounted.

To fix this, this CL prevents this situation, by not adding the VolumeInfo and not emiting an event, if the device is not permitted (but got mounted by another profile).

TEST=Tested manually on a enterprise enrolled device.
BUG=349298

Review URL: https://codereview.chromium.org/190153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255610 0039d316-1c4b-4281-b951-d872f2087c98

Modified chrome.bluetooth API code to use the new discovery session API for
device discovery.

This CL is the same as r255262 which was reverted due to a memory leak. The leak
has been addressed in this patch.

BUG=346982,349942
TEST=1. Run unit_tests and browser_tests with LSan.
     2. Use multiple running extension instances with the bluetooth permission
        and check for the following behavior:
        - Only one session per extension. Calling chrome.bluetooth.stopDiscovery
          from one running app should fail if that app never called
          chrome.bluetooth.startDiscovery.
        - An app's discovery sessions should get cleaned up if that app crashes
          or unloads.
        - Use bt_console and run "power off". This should cause all discovery
          sessions that have been assigned to apps to get marked as inactive.
          Verify by requesting a new discovery session from apps, which should
          succeed.

Review URL: https://codereview.chromium.org/189463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=249548

Review URL: https://codereview.chromium.org/183663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255608 0039d316-1c4b-4281-b951-d872f2087c98

This has been approved for launch.

BUG=

Review URL: https://codereview.chromium.org/182313014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255606 0039d316-1c4b-4281-b951-d872f2087c98

Omnibox text can lose text attributes when the origin chip becomes
invisible due to focus loss. This is due to side effects in
EmphasizeURLComponents, which essentially remove all text attributes
from the Omnibox when this routine is called during focus loss.

BUG=347316

Review URL: https://codereview.chromium.org/184783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255605 0039d316-1c4b-4281-b951-d872f2087c98

Also add missing entries for HTMLAppletElement,
HTMLMediaElementSeekToFragmentStart, and
HTMLMediaElementSeekToFragmentEnd.

Corresponds to https://codereview.chromium.org/186673002/.

R=asvitkine@chromium.org
BUG=

Review URL: https://codereview.chromium.org/180743029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255604 0039d316-1c4b-4281-b951-d872f2087c98

The Bluetooth SIG also assigned Vendor IDs used in the Device ID
specification, in fact, Chromebooks use a Bluetooth SIG-assigned
Device ID rather than a USB IF-assigned one.

These take the format bluetooth:vXXXXpYYYYdZZZZ; handle this case
in addition to the usb:vXXXXpYYYYdZZZZ case.

BUG=350159
TEST=device_unittests

Review URL: https://codereview.chromium.org/189663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255603 0039d316-1c4b-4281-b951-d872f2087c98

This is a short term fix to hopefully reduce the effects of packets
queueing up on the receiver side. Previously we try fill up the RTCP
packet with as many receiver log as possible so we can have redundancy.
The redundancy that has been observed was more than 30 per message, and
we don't need this much redundancy. 200 is a good number where each
log message will be sent with redundancy of around 2-3, without losing
too many (< 1%) messages, assuming default rtcp interval settings.
That's fine because we don't need the logs to be completely reliable.


BUG=349265

Review URL: https://codereview.chromium.org/189423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255602 0039d316-1c4b-4281-b951-d872f2087c98

Now that we have a WebGL implementation of MSAA using
EXT_multisampled_render_to_texture, we can reenable MSAA on Mali GPUs.

BUG=322706
TEST=run on daisy, WebGL now uses multisampling and simple demos run at 60 fps.

Review URL: https://codereview.chromium.org/188173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255601 0039d316-1c4b-4281-b951-d872f2087c98

TBR=inferno
BUG=285976

Review URL: https://codereview.chromium.org/184343014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255600 0039d316-1c4b-4281-b951-d872f2087c98

Blink is removing support for the legacy notification API, and there
are a number of Chromium-sided tests depending on it. Remove the
tests if they don't make sense anymore, or change them to use the
Web Notification API instead.

This patch also enables the Notification browser tests for Aura Linux,
part of interactive_ui_tests, since they run just fine. It are the Desktop
Notification tests which have a dependency on Screen.

BUG=348019
R=atwilson@chromium.org, dewittj@chromium.org, kalman@chromium.org, miket@chromium.org

Review URL: https://codereview.chromium.org/187803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255599 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255598 0039d316-1c4b-4281-b951-d872f2087c98