- 30 Aug, 2019 40 commits
-
-
Rika Fujimaki authored
You should be careful not to use a wrong context, which leads to a leak of information. Currently, we can get a context from scattered ScriptValue without consideration, but we would like to prevent it. Instead of from ScriptValue, you can get a context via - ScriptState::GetContext() using ScriptState passed from binding code - ScriptState::GetContext() using ScriptState stored on a C++ object - Isolate::GetCurrentContext() Also, we add GetScriptState() in InternalResolver to get a script_state from instead of from ScriptValue. It is safe because InternalResolver is only used internally. Bug: 998994 Change-Id: Iaa5a936635279566abe4801d4f15774eb628e83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772793Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#692001}
-
Marina Sakai authored
Split |kCrossOriginAttributeTable| into two tables; one is for attributes, which should be accessor properties, and the other is for operations, which are data properties. Currently cross origin attributes are implemented as data properties, but will be converted to accessor properties in following changes. Bug: 809011 Change-Id: If95e6a402c532648ffd406b1ee451df92807375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775689Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Two flags are still needed until at least M-79. I now maintain what they guard. Bug: None Change-Id: If5d7c766b29c3e3ddeeeee31c7b4cb8e25a7c7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776037Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691999}
-
Leszek Swirski authored
Required to land the changes in https://crrev.com/c/1777702 Bug: 999473 Change-Id: I4e2738d76027e6e08d80d39595a3a83e40858eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777721 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691998}
-
Michael Lippautz authored
- Provide BindingTestSupportingGC that can be used to call various types of GC. - Avoiding including v8_binding_for_testing.h in production code. - Fix clients that relied on transitively including V8TestingScope. Change-Id: I64733749389817bbc3eda3cf90003a587e0bf33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776362 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The "doom installing worker" was introduced at a time when we didn't have timeouts for starting a worker or for lifecycle events. The purpose was to prevent the job queue from being stuck forever on a bad worker. Now that we have these timeouts, we can remove the mechanism. This also aligns with the spec, as seen in the passing WPT test. A previous attempt was made at https://chromium-review.googlesource.com/c/chromium/src/+/560633/. That attempt added a timeout timer for the job queue, but was reverted due to crashes with it. I considered adding a timeout timer here too, but it seems to have little utility considering the job should only be stalled by a worker stuck in starting or install. If there is another failure, it's a bug and timing out might not actually help. Bug: 723037, 999027 Change-Id: I0c6248db5a2e834f986218e61cec82e4b8e0f4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776156Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691996}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.CacheStorage interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I194ae2b5dd8d3fc75d6363baf39e46f7b01628a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774925 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691995}
-
Sergio Villar Senin authored
NullValue() is represented as a NaN in a double. We could better return a base::Optional<double> and use the undefined base::Optional as null value. Also there is no need for the IsNull() call as we could just use the returned value as a boolean. Bug: 994811 Change-Id: Ic2a84e8f329c2b790dcd0b996439942974255b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760745Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#691994}
-
Jinsuk Kim authored
ListView is reused for a WebContents NavigationSheet within a page across edge swipe gestures. Populating entries was not properly handled, which caused the reported bug. This CL fixes it. Bug: 998969 Change-Id: Ie0a474e0fb5e0059124ae4ee5ba601f57739e226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772849Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691993}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be613476..71acc9d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I722e891d5dde198d7d832c018dd856006e0bf194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777561Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691992}
-
Jérôme Lebel authored
"Reach bottom" notification from the user consent view should be ignored when the sign-in is started. This can happens when the device is rotated (with the screen height changing). Bug: 995987 Change-Id: Iead0dc2b6a31833ae169a12c30f984a3a6327026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765671Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#691991}
-
Juan Antonio Navarro Perez authored
Add the implementation for the output formatter, as well as: - unit tests for converting intermediate results to the json-test-results currently handled by the waterfall. - an integration test that writes intermediate results to disk and runs the standalone results processor on them. The json-test-results is *not* yet added to the SUPPORTED_FORMATS of results processor. So Telemetry will continue handing this format in perf waterfalls until this is flipped on a follow up CL. Bug: 981349 Change-Id: Ie7b19eb2d8898fdc97b908d6df38712dd7a1f6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776046Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#691990}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12e3f76c1c73..aa94b48e0166 Created with: gclient setdep -r src-internal@aa94b48e0166 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8cfc0fcd6081aac5b2f50f2c80860ff028b5a526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777129Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691989}
-
Leon Han authored
This CL uses AbortController to replace the stop() method of NFCReader interface. The corresponding spec change is from: https://github.com/w3c/web-nfc/pull/300 BUG=520391 Change-Id: Ia28bfb283a7ad66fb9c4cb0fc744582671a62fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769245Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#691988}
-
Mathias Carlen authored
Smoke tests for the ShowDetails action. This patch only tests the structural integrity of setting up the ShowDetails action. The meat of unit testing will be in an upcoming patch around the content of details.{h,cc}. R=arbesser@google.com Bug: 806868 Bug: b/140018932 Change-Id: I7471fe0c54348bb22a5fa4650c1c7f83edd08507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768327 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#691987}
-
Makoto Shimazu authored
This CL modernizes the test by using ES6 styles. Bug: 925740 Change-Id: I3d74a2629d8d6b8d44da06e4ecec60485f909ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775945 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change drops the default launchPasswordCheckup implementation, since it is now implemented downstream. Bug: 986317 Change-Id: I50d5a3d8c346b6f3d288bc167376f861dd460a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777541Reviewed-by:
-
Juan Antonio Navarro Perez authored
Use this early on output_dir and indermediate_dir, so later relative path computations work as expected. Bug: 996105 Bug: 981349 Change-Id: Ic21e43ab03f63cc637f475cfc8f81b230105bb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774634Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/73422a0a5ee1..35d98be3bc87 git log 73422a0a5ee1..35d98be3bc87 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 stevenperron@google.com Amd ext to khr (#2811) 2019-08-29 bclayton@google.com spvtools::Optimizer - don't assume original_binary and optimized_binary are aliased (#2799) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@35d98be3bc87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Bug: None Change-Id: Ie4f32ad58e611b030010a2ac587540b0ebd4cd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691983}
-
Julie Jeongeun Kim authored
This CL converts BytesProviderRequest and BytesProviderPtr to new Mojo types. It updates struct DataElementBytes from data_element.mojom and methods and members to new Mojo types. Bug: 955171, 978694 Change-Id: I4a1f7a2cb73581ec23596178154fc9282c25e6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774424 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#691982}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f018c05e44f0..864bae4cc6a2 git log f018c05e44f0..864bae4cc6a2 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 jiawei.shao@intel.com Enable two BindGroupTests on Metal Created with: gclient setdep -r src/third_party/dawn@864bae4cc6a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Iadaa87365c377db531ccf75f6602d3731c12eee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777127Reviewed-by:
-
Robbie Gibson authored
See https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/3784 for a sample failing run for both tests. Bug: 999079, 999080 Change-Id: I1b7e6ec449828fb971a708d77b5297ff25f9711b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776020Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#691980}
-
Kent Tamura authored
use_counter.h is included from document.h, which is one of the most popular header in Blink, and the pre-processed size of web_feature.mojom-blink.h is very large. This CL updates use_counter.h so that it includes web_feature.mojom-blink-forward.h instead of web_feature.mojom-blink.h. Many files need to include web_feature.h or web_feature.mojom-blink.h explicitly. Change-Id: I1f827fc7f6017dfd8d2345018f019ccb6ce02bd1 Bug: 242216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775679Reviewed-by:
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/378, vertexInput descriptor from GPURenderPipelineDescriptor should not be required anymore. Bug: 877147 Change-Id: Ifdd0ba7ff6af2b8648ad45d029e5ef7b8484f8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776023 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#691978}
-
Michael Lippautz authored
Implement copy of TraceWrapperV8Reference. Note that this will require write barriers during marking. Bug: 998099 Change-Id: Id6921083a6ce29e25386ef7ac159814ec42beb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774624 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Andrei Chulkov authored
Tested on: -- light mode -- dark mode -- KitKat that will later be used for experiments. Eventually we will only use one of them. I have already used avocado. Binary-Size: Adds 3 images as well as their dark mode counterparts Bug: 983445 Change-Id: I077dace271bc85fc626ba3cc57334cdc1d0ee0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773222 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#691976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e12f9bdfbf6a..12e3f76c1c73 Created with: gclient setdep -r src-internal@12e3f76c1c73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I21ee116ad4ef37770b0ad6f0c1e3c8dc70596588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777206Reviewed-by:
-
Jordan Demeulenaere authored
Since http://crrev/c/1743432, the BottomSheet background has rounded corners with a shadow. The shadow has now a height of 16dp (vs 8dp before that CL). This CL introduces a new dimension to store the new height of the shadow. This height is used to compute full/peek ratios of the bottom sheet that are now computed correctly. Before: * https://screenshot.googleplex.com/YZ67ok7O9br.png * https://screenshot.googleplex.com/SOVPh2N9GaA.png After: * https://screenshot.googleplex.com/8HjjkL2Gt62.png * https://screenshot.googleplex.com/C0LTHSnBF1f.png Bug: 985644 Change-Id: Iafbf4cda004bd03a7931a3ef7045bed9d5a05a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776040Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#691974}
-
Rahul Arakeri authored
This CL fixes an issue with scrollbar thumb drags being jittery. The pointermove(s) are not Vsync aligned. When the first GSU is processed, it gets queued in the compositor thread event queue. A second request (to get a GSU for a pointermove) within the same frame will end up calculating an incorrect delta (as ComputeThumbQuadRect would not have accounted for the delta in the first GSU that was not yet dispatched). This leads to generating a GSU with a delta that is larger than what it is supposed to be. When these queued GSUs are finally dispatched, the subsequent pointermove will make the thumb jump backward and this problem continues on leading to a jittery thumb drag experience. To fix this, we process only 1 GSU per frame when thumb drag is in progress. Bug: 986174 Change-Id: Ied8103ffc447966fc15d0052c5295f896dcbcc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770088 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691973}
-
Takashi Sakamoto authored
This reverts commit a1b5aec5. Reason for revert: suspect causing views_unittests failure on Linux MSan Tests: views_unittests failed because of: DesktopDragDropClientAuraX11Test.HighDPI200 DesktopWidgetTest.ValidDuringOnNativeWidgetDestroyingFromClose DesktopDragDropClientAuraX11Test.Basic DesktopDragDropClientAuraX11Test.RejectAfterMouseRelease ...34 more failure(s) (38 total)... Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/18965 Sample log:https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903719865586190112/+/steps/views_unittests/0/logs/Deterministic_failure:_DesktopDragDropClientAuraX11Test.Basic__status_CRASH_/0 [ RUN ] DesktopDragDropClientAuraX11Test.Basic ==26851==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x556c6767c618 in OnXWindowStateChanged ./../../ui/platform_window/x11/x11_window.cc:262:7 #1 0x556c6767c618 in non-virtual thunk to ui::X11Window::OnXWindowStateChanged() ./../../ui/platform_window/x11/x11_window.cc:0:0 Original change's description: > X11 and Ozone: Make DWTHX11 subclass DWTHPlatform and use PWD. > > This CL makes the DWTHX11 subclass the DWTHPlatform and use > the X11Window, which subclasses the XWindow. Also, DWTHX11 > uses PlatformWindowDelegate instead of ui::XWindow::Delegate now. > > That is, to migrate X11 to Ozone, we need to make sure DWTHPlatform > is mature enough. To avoid code duplicate, it was decided to > make DWTHX11 subclass DWTHPlatform and move its code to DWTHPlatform > step by step ensuring nothing is broken. > > However, it was not enough to just make DWTHX11 a subclass of DWTHPlatform. > The way how we communicate with XWindow has had to be changed as well. > > The plan is to move all the code to DWTHPlatform and make the > WTHPlatform create the X11Window. However, there are many intermediate > steps to be done before doing it. As described before, first, DWTHX11 > subclasses the DWTHPlatform and starts to receive messages and > events from the XWindow through the PlatformWindowDelegate. > > It was ensured that the DWTHX11 intercepts all the calls to DWTH, > WTH and PWD and does everything as it was doing previously. In the > follow up CLs, I will start to move the code slowly to DWTHPlatform > and WTHPlatform so that DWTHX11 no longer implements PDW and DWTH > methods and the DWTHPlatform manages everything on its own > for both Ozone and non-Ozone builds. > > Bug: 990756 > Change-Id: If45b05d09609cf8aa826cc4894ec559f210dc0b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771397 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#691944} TBR=sadrul@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I1e967e5b5958307cc6fc60962a45db0016b4f25d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777352Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#691972}
-
Rune Lillesveen authored
Can use equality with kSubtreeStyleChange instead. Change-Id: I50a37545a31de438311e14f4a2020caf69578b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774457Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#691971}
-
Dominic Mazzoni authored
Many Mac accessibility API use an AXTextMarker, which is an opaque application-specific struct representing a position in a document. Chrome implements these using AXPosition (in particular a subclass BrowserAccessibilityPosition). The code used the word "serialized" but it was actually copying the raw bytes from a BrowserAccessibilityPosition and then constructing a new C++ object with these bytes later, which isn't defined behavior and may be causing problems on macOS 10.15. Instead, implement actual Serialize and Unserialize methods on AXPosition and make use of those instead. Tested with a unit test of AXPosition (based on the existing test of Clone) and by manually manipulating some editable text in Chrome with VoiceOver running, to ensure the code is working correctly. Bug: 998896 Change-Id: Ifb64b19ebdc96a8d36522456c77bca23cb58d552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776901 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#691970}
-
Naoki Fukino authored
Now that we have per-device settings to allow Android applications read/write files on it, we don't need to refer the global preference kArcHasAccessToRemovableMedia. kArcHasAccessToRemovableMedia will be completely removed in a follow-up CL as a fix for crbug.com/998512. Bug: 954228 Change-Id: Idd570106f0bdfd031dc00837b5f128b91d2078fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774426Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#691969}
-
Wei Wang authored
This patch replaces the base::RunLoop().RunUntilIde() with base::RunLoop loop, which will reduce the time delay and make those unit tests deterministic. Bug: 973005 Change-Id: I3fa718ef0926b38385c53f0af9d6ce8865a87660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760670 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Marc Treib authored
This reverts commit 7800a3fe. Reason for revert: Suspected culprit (which was reverted) was not the real culprit, so the test is still flaky :( Original change's description: > Revert "Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan" > > This reverts commit 55420155. > > Reason for revert: I have rolled back one suspect change. > Enabling the test again to verify it was indeed the culprit. > > Original change's description: > > Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan > > > > The test is disabled due to high flakiness. > > > > TBR: treib@chromium.org > > Bug: 997912 > > Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974 > > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#690763} > > TBR=treib@chromium.org,jkrcal@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 997912 > Change-Id: I275345a29e2917d5abe5a402fa03cac0d107703c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774630 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691582} TBR=treib@chromium.org,jkrcal@chromium.org,mamir@chromium.org Change-Id: I8bf6cc11e7bcd912cead0e4b4c4d2491cf41d544 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776262Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691967}
-
Rune Lillesveen authored
SubtreeStyleChange on Document has a special meaning that we need to update the viewport style in addition to all elements in the document. This is the start of separating these two concerns. This is in preparation for flat tree style recalc for which the plan is to only mark elements or text nodes as style dirty and use flat tree element traversal for marking ancestors child-dirty. This CL marks the root element instead of document in the cases where we don't need to update the viewport styles. We already did that for layout tree reattach in [1]. [1] https://crrev.com/df2ed4afdfaf3b30adc3d4d80cc7559965eb8519 Bug: 972752 Change-Id: I52a906ed1c30d878cdb34dc004943eadc9448fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774453 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
When custom scrollbar pseudo element style changed on the viewport defining element (root or body), we did not propagate those styles unless something else changed. Bug: 999348, 972752 Change-Id: I52ed46a191d87034bee95bff4d823d92a28031a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774935 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8fe3e6ac1d7a..d10eb04b772a git log 8fe3e6ac1d7a..d10eb04b772a --date=short --no-merges --format='%ad %ae %s' 2019-08-30 dberris@chromium.org Clean up links to waterfalls Created with: gclient setdep -r src/third_party/catapult@d10eb04b772a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:994762 Change-Id: I94a2b4b80680cdb940a9172d95c2135e6b98f263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777213Reviewed-by:
-
Gyuyoung Kim authored
The original CL (crrev.com/c/1763521) didn't remove unnecessary comments. Remove it. Bug: 955171 Change-Id: I66cc285260a196cd29710218eb65ffc8810b7769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777464Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691963}
-
Jinsuk Kim authored
This CL removes |onSheetStateChanged| that updates scrim alpha to the height of the sheet view. Scrim alpha in opened state stays constant. Bug: 993032 Change-Id: Idabf5735e282bbd28e4e290a67ce033c5a9c8f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760834 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
