GitLab

There is a small window where it can be null before the sync service is
done initializing.

Not clearing the data then doesn't matter, since the server db either
points to the local db which is cleaned next, or to an in memory server
db which doesn't exist yet, so there is nothing to clear.

This code is less than ideal and will be refactored along with the
database helper and the personalDataManager in the coming weeks.

Bug: 883713
Change-Id: I9e754985bf5c14750100dee57efe4ed1a3e252d8
Reviewed-on: https://chromium-review.googlesource.com/1231916Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592158}

This moves the logic of handling the Cardboard trigger out of the
scheduler. It also avoids unnecessary operations in Cardboard.

Additionally, we submit vsync to the WebXR session after an input
state has been obtained.

Bug: 875291
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia8723a2fa50dac7ddcca4f6468dadd9c1836f6db
Reviewed-on: https://chromium-review.googlesource.com/1216942
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592157}

This is a reland of 9c5131ad

Cannot reproduce the flake. Relanding for more information.

Original change's description:
> Under refresh, use the same menu options for Windows/Linux as under Mac
>
> Use the BubbleBorder for the menus since the drop-shadow under Windows
> doesn't track the shape of the menu. We also have much more control over
> the shape and depth of the drop-shadow.
>
> Bug: 837782
> Change-Id: I91b9340251c2cd0b60e3b3f66d450a4791113007
> Reviewed-on: https://chromium-review.googlesource.com/1159532
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590731}

TBR=ellyjones@chromium.org
TBR=msw@chromium.org
TBR=estade@chromium.org

Bug: 837782
Change-Id: I80a07fb2d716c9372d18a8d48df3e7e00ff286ab
Reviewed-on: https://chromium-review.googlesource.com/1229173
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592156}

This CL uses ScopedBlockingCall to mark blocking calls in /components/sync.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=tschumann@chromium.org

Bug: 874080
Change-Id: I291ccbeca7b5115053ad57bb3ba072eaad10172f
Reviewed-on: https://chromium-review.googlesource.com/1194103
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592155}

This patch puts isolation nodes for elements with contain: paint.
The nodes act as a boundary where any subtree elements of the
contained element cannot reference elements higher up in the
tree from the isolation nodes. This, in turn, allows us to
put a performance boundary skipping subtree walks for an isolated
subtree when the subtree itself has not changed.

R=chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icd0ff26f7c28d3df226755b7c501e227f532001d
Reviewed-on: https://chromium-review.googlesource.com/1168390Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592154}

- within a single line, delete all words using Ctrl+Backspace
- type until a line wraps. This triggers the inclusion of a new inline text box.
- delete until a wrapped line moves up one line
- delete words until all words on a wrapped line are deleted

In all of these cases and many others, the previous line (surrounding the previous selection) and the current line are *different* lines. In some cases, the previous line is no longer valid because the underlying data is invalid. In all other cases, the lines are both valid, but refer to two different inline text boxes.

In order to get the appropriate context, this change uses the surrounding paragraph to get the right diff of the previous and current value along with the selection.

This fixes:
1. deletions that happen to trigger a line change. The easiest way to reproduce this is via Ctrl+backspace inside of a long paragraph
2. insertions that trigger the addition of a new line. The easiest way to trigger this is to set typing echo to none and start typing without inserting hard line breaks (i.e. pressing enter). When a new line is inserted (soft wrap), ChromeVox used to read the new line's text (the newly wrapped word). This no longer occurs.

Bug: 833252
Test: manual and chromevox_tests.
Change-Id: I5095eb4714932cad050f9fc5162072f918008b20
Reviewed-on: https://chromium-review.googlesource.com/1228790
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592153}

Change-Id: If43a304a2deee1abc05df6c62344f538dd8b1de1
Reviewed-on: https://chromium-review.googlesource.com/1217447Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592152}

The function is only used on Chrome OS and is no longer necessary. Ozone
DRM provides display refresh rates and vsync interval through the
command buffer. The function seems to be leftover from X11 Chrome OS
where Xrandr provided better refresh rate data than the GL context.

GpuProcessTransportFactory::SetAuthoritativeVsyncInterval() is also
broken currently and not setting the interval.

Bug: 885169
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I66ffa73f5b32418cd83553c52ff97293e1b10657
Reviewed-on: https://chromium-review.googlesource.com/1230578Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592151}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/748e4927773d..2426fe64bffb


git log 748e4927773d..2426fe64bffb --date=short --no-merges --format='%ad %ae %s'
2018-09-18 dhanyaganesh@chromium.org failed_stage metric: Add important field
2018-09-18 dhanyaganesh@chromium.org Chromite: Add Common Metric Fields for all metrics


Created with:
  gclient setdep -r src/third_party/chromite@2426fe64bffb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d30a22fbe1cc15e0fca19a22affc1504514b60d
Reviewed-on: https://chromium-review.googlesource.com/1231493Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592150}

I found some test files were added without updating the README file. So
adding this presubmit check to remind people to do so.

Here's an example of the warning when updating test files without updating
the README file:

-----------------------------------------
~/chromium/src$ git cl presubmit --upload
Running presubmit upload checks ...

** Presubmit Warnings **
When updating files in media/test/data, please also update media/test/data/README:
  media/test/data/vorbis-asd \
  media/test/data/vorbis-packet-0 \
  media/test/data/vorbis-packet-0_for_test

Presubmit checks took 1.4s to calculate.
-----------------------------------------

Bug: 818048
Change-Id: Ibc8b5d82aa7b0fd2688a01b736a57d8bf0e11e29
Reviewed-on: https://chromium-review.googlesource.com/1229497Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592149}

BUG=882854
R=pkasting

Change-Id: I8dc419e43882d723a117da19e87abe20505aa01a
Reviewed-on: https://chromium-review.googlesource.com/1228201
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592148}

Ports the changes to memory_monitor_linux.cc in
https://codereview.chromium.org/2321313002/ to Windows.

Bug: 404525
Change-Id: Ibb92bb419292b0dd7298ad8c3ce7ae5268e6000a
Reviewed-on: https://chromium-review.googlesource.com/1231673
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592147}

In the process, this also adapts HostConnectionMetricsLogger to use the MultiDevice APIs
to properly log to the "Background" versions of its metrics.

Bug: 824568, 752273, 854885, 857302
Change-Id: I77fc52b3d07d903fe61ac62de2620216984d28de
Reviewed-on: https://chromium-review.googlesource.com/1117897Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592146}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/804797362e1d..1aa405fd859a


git log 804797362e1d..1aa405fd859a --date=short --no-merges --format='%ad %ae %s'
2018-09-18 sergiyb@chromium.org Add an option to disable adding CC emails automatically
2018-09-18 nodir@google.com [gclient] Fix typo in get_gerrit_patch_root
2018-09-18 nodir@google.com [bot_update] Add gclient.get_gerrit_patch_root
2018-09-18 vadimsh@chromium.org [cipd] Pin hashes of CIPD packages.
2018-09-18 borenet@chromium.org Revert "gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator"


Created with:
  gclient setdep -r src/third_party/depot_tools@1aa405fd859a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:878303,chromium:694348,chromium:694348,chromium:870166
TBR=agable@chromium.org

Change-Id: I439b74e4283ec9962446dd2b14a101175f7fbb4d
Reviewed-on: https://chromium-review.googlesource.com/1231496Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592145}

A few changes were needed to get this to work in BGPT:
- Create a StubChromeClientForSPv2 so that we have a LayerTreeHost,
  without which BGPT does not create composited animations.
- Change StubChromeClientForSPv2 to tell the LayerTreeHostEmbedder to
  use layer lists when running with BGPT
- Check for filter animations as well as current filters when deciding
  if we need a filter on a given object.

Bug: 874253
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7e057d8a225ead67728d68070e62ac62f7a33f19
Reviewed-on: https://chromium-review.googlesource.com/1230438
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592144}

Change-Id: Iaa78ac6b6ad9050479c0e326e36c80cabb9800f3
Reviewed-on: https://chromium-review.googlesource.com/1231386Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592143}

There are instances in which we want links to be able to open new
tabs in the browser. With this change, they will be able to do so by
specifying target="_blank".

Bug: b:115782814
Change-Id: Id4a08c5fbde342c723f47e363c9cf97e76f1578e
Reviewed-on: https://chromium-review.googlesource.com/1227502Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#592142}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/892036cb879f..cb44953479a1


Created with:
  gclient setdep -r src-internal@cb44953479a1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:856278
TBR=mmoss@chromium.org

Change-Id: Ie53026c25d38525322ffee7ac6c19f6f601acf20
Reviewed-on: https://chromium-review.googlesource.com/1231495Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592141}

When there are multiply profiles opened at the same time. The renderer
creation process will be called multiple times which might cause
incorrect behavior. Make sure the renderer created only for the
corresponding profile.

Bug: 847606
Change-Id: I4d47d22220cab2197ad59feedacd3e6a5bc0dabb
Reviewed-on: https://chromium-review.googlesource.com/1229193Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592140}

This patch disambiguates two functions:
- SetDescendantNeedsPaintPropertyUpdate, which is a breadcrumb
- SetSubtreeNeedsPaintPropertyUpdate, which is a dirty bit

By renaming the latter to:
SetSubtreeNeedsForcedPaintPropertyUpdate.

R=chrishtr@chromium.org, pdr@chromium.org

Change-Id: Ia00d845fc114e1eef94987a650b453e363d431cd
Reviewed-on: https://chromium-review.googlesource.com/1231384Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592139}

Cycle time looks good. (Caps out at about 30min for analyze exclusions.)
Flake rate looks like it's pretty much 0.

Though the bot is currently red due to a broken webrtc roll (that this
bot would have caught). Need to wait on reverting that before this can
land.

Bug: 646404
Change-Id: I26ddec32ad1b90165068c0c17946c2ac6cdc330b
Reviewed-on: https://chromium-review.googlesource.com/1229076Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592138}

This CL removes the flag kCheckLayoutTestSysDeps and modifies Content Shell to
run CheckLayoutSystemDeps for layout tests.

Previously, run_web_tests.py would first run Content Shell with
kCheckLayoutTestSysDeps to check system dependencies, and then subsequently run
Content Shell with kRunWebTests to run the actual layout tests. The goal was for
the former step to discover system misconfigurations and early-exit so that
developers would not lose time debugging system configuration failures.

This CL's changes has several benefits:
  * kCheckLayoutTestSysDeps was using a different mechanism for starting and
    stopping the main thread's run loop. This was likely responsible for flaky
    crashes.
  * run_web_tests.py would exit with SYS_DEPS_EXIT_STATUS upon encountering a
    crash in kCheckLayoutTestSysDeps. This failure was not recoverable. Now,
    flaky crashes are caught using the normal layout test runner mechanism, and
    are appropriately retried.
  * It simplifies the logic for both Content Shell [removing a flag] and
    web_test_runner.py [removing yet another mechanism for launching the driver
    and parsing its results].

Bug: 884776
Change-Id: I7472f5e3b90e6d2578d2ed0be906e0e57ae9dbaa
Reviewed-on: https://chromium-review.googlesource.com/1229240
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592137}

Bug: b/80441180
Change-Id: I66bd3265c724229c818d54289479c6262a2e28a9
Test: Ran on device
Reviewed-on: https://chromium-review.googlesource.com/1148803Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Michael Nye <michaelnye@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592136}

Turn on FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans
https://chromium-review.googlesource.com/c/chromium/src/+/1228857

Update IETF QUIC Transport Error codes
The IETF QUIC transport error codes are updated to reflect
version 14 of the QUIC transport IETF draft:
 - SERVER_BUSY is added
 - FRAME_FORMAT_ERROR is changed to FRAME_ENCODING_ERROR
 - UNSOLICITED_PONG is removed
 - INVALID_MIGRATION is added
Merge internal change: 213016352
https://chromium-review.googlesource.com/c/chromium/src/+/1228548

Fix a ACK frame reporting issue caused by unsigned integer wrap around. Protected by flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2.
Flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2 is the v2 of the existing flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames.
Merge internal change: 212991266
https://chromium-review.googlesource.com/c/chromium/src/+/1228894

Implement support for framing QuicCryptoFrames from IETF QUIC.
Merge internal change: 212917548
https://chromium-review.googlesource.com/c/chromium/src/+/1228436

Turn on FLAGS_quic_reloadable_flags_quic_fix_reset_zombie_streams in quartc.
Merge internal change: 212810521
https://chromium-review.googlesource.com/c/chromium/src/+/1228435

In QUIC, fix a bug that zombie streams cannot be closed when gets reset locally. Protected by FLAGS_quic_reloadable_flag_quic_fix_reset_zombie_streams.
Merge internal change: 212676554
https://chromium-review.googlesource.com/c/chromium/src/+/1228434

Split QUIC's FramerVisitor into two methods, OnAckRange and OnAckFrameEnd().  No functional change, not flag protected.
Merge internal change: 212629799
https://chromium-review.googlesource.com/c/chromium/src/+/1228394

Move multiple (repeated) definitions of QuicConnectionArena to a single place in quic_one_block_arena.h. Move only, not protected.
Merge internal change: 212626492
https://chromium-review.googlesource.com/c/chromium/src/+/1228393

Change-Id: I675e3fbaa9c01aa3e5749f44323ddac6eb45a9d8
Reviewed-on: https://chromium-review.googlesource.com/1228858Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592135}

The new benchmark takes all the metrics from the v8.browsing benchmarks and
provides an additional --enable-rcs to switch on the more expensive runtime
call stats metrics.

- Introduce new _LoadingBaseClusterTelemetry base class
- Introduce AugmentOptionsForV8BrowsingMetrics and V8BrowsingShouldAddValue
  helpers to share metrics setup code with v8.browsing benchmarks
- Add new V8LoadingClusterTelemetry benchmark

Bug: chromium:883322
Change-Id: I67287fb046993a4cb687ac57073f81a7c006d361
Reviewed-on: https://chromium-review.googlesource.com/1224448
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592134}

https://pdfium.googlesource.com/pdfium.git/+log/6fc8d877d745..c3099d1c6942


git log 6fc8d877d745..c3099d1c6942 --date=short --no-merges --format='%ad %ae %s'
2018-09-18 hnakashima@chromium.org Change signature of FPDFPageObjMark_Get(Name|ParamKey).
2018-09-18 rharrison@chromium.org Transfer ownership of nodes to top-level XML doc


Created with:
  gclient setdep -r src/third_party/pdfium@c3099d1c6942

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:884664
TBR=dsinclair@chromium.org

Change-Id: Ifcdc87b0ee64b981f34c47a61775113428f8f887
Reviewed-on: https://chromium-review.googlesource.com/1231497Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592133}

This reverts commit 7d96627b.

Reason for revert: Suspect this broke orderfile generation due to conflicting adb binaries.

Original change's description:
> Orderfile: turn on system health order profiling.
> 
> This sets default orderfile generation to use system health profiling.
> 
> Bug: 758566
> Change-Id: Ie87f8b2623373861c7bdc44d5dfd866ce3597cd9
> Reviewed-on: https://chromium-review.googlesource.com/1228074
> Commit-Queue: Matthew Cary <mattcary@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Reviewed-by: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591674}

TBR=pasko@chromium.org,lizeb@chromium.org,mattcary@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 758566
Change-Id: Ia3092b00488f332a5348f9aaae13fdb4691f27de
Reviewed-on: https://chromium-review.googlesource.com/1231919Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592132}

Add method to make buttons observers of any widgets that are anchored to them. Change inkdrop highlight for buttons when anchored widgets are shown or removed. Fix cases where a widget is anchored to the location bar but a different view should be highlighted. Change highlighting to SetBackground when used for extension actions in BrowserActionsContainer to protect inkdrop highlight state during layout calls.

Bug: 863170, 824536
Change-Id: Id6abdfa7a70955b3cb1873b6c8013f0496455f68
Reviewed-on: https://chromium-review.googlesource.com/1165601Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592131}

1. Register Swap promise only when there is no ongoing swap promise.
2. Add tailing underscore to private attributes.
3. Restructure the while loop in FindLargestPaintCandidate and
FindLastPaintCandidate.

Bug: 869924
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaf19947eb3ef098114f2ab2ca7a4d6cdcec42758
Reviewed-on: https://chromium-review.googlesource.com/1229413Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592130}

Bug: 885086
Change-Id: I8046229bdb8ae2ab7dbd36254869320331f1f2e1
Reviewed-on: https://chromium-review.googlesource.com/1230022Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592129}

There are reports from the field that the "maximum" of a histogram
does not match what was configured.  The working theory is that it is
due to rounding errors in the creation of exponential buckets.
Verify this assumption.  If it's behaving wrong, it should crash
during the creation.

Bug: 836238
Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d
Reviewed-on: https://chromium-review.googlesource.com/1228840Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592128}

This is a reland of 32c8ebbe

Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306

Original change's description:
> Enable Perfetto by default for all telemetry tests
>
> This will use Perfetto instead of TraceLog for all
> trace-based Telemetry tests running on Mac/Windows/Android.
>
> R=nednguyen@google.com
>
> Bug: 839084
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> Reviewed-on: https://chromium-review.googlesource.com/1176119
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#585368}

TBR=nednguyen@google.com

Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
Reviewed-on: https://chromium-review.googlesource.com/1208955Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592127}

Since 57a19db6 ("[fuchsia] Whitelist required Fuchsia services in
component manifest.") vulkan fails to initialize. Fix it by adding
the vulkan loader service to the policy.

Bug: 861853
Test: content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu

Change-Id: I38c11f32e0a0dd8b914184a16198c023877a0572
Reviewed-on: https://chromium-review.googlesource.com/1228488Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592126}

Add a BridgeFactoryHost structure, which wraps a
views_bridge_mac::mojom::BridgeFactory interface. This structure has
an BridgeFactoryHost::Observer interface to call back into widgets
when the bridge factory they are using is destroyed (e.g, the app
shim is force-quit).

Bug: 859152
Change-Id: I0c34cf200588ac79d281b31ba85764bca0c02d39
Reviewed-on: https://chromium-review.googlesource.com/1229694
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592125}

When Chrome's fullscreen toolbar style changes, it needs to re-layout to
make sure the UI is updated. This CL fixed a recent regression due to
using |is_exiting_fullscreen| to avoid re-layout. Instead, only when
Chrome exits fullscreen mode to non-fullscreen mode, we should avoid
doing re-layout because exiting tab fullscreen to browser fullscreen
still may requires a re-layout.

BUG=884029

Change-Id: I7392c2cb000b184c0f54b9cb6bb3de2b81a79dcf
Reviewed-on: https://chromium-review.googlesource.com/1226014
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592124}

Use the correct config for the audio decoder, and fix a hang due to AV
sync on desktop machines.

Change-Id: Icb8f1e73d093e58f81a68dd00d8512654c1140d1
Reviewed-on: https://chromium-review.googlesource.com/1229933Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592123}

This CL continues implementation of the Query in Omnibox feature for
Desktop with two main changes:

 1. Shows the Default Search Provider favicon in the Omnibox when we
    are displaying search terms.

 2. Don't (erroneously) try to do unelision for Steady State Elisions
    when we are displaying search terms. Adds a test for that.

This also adds a convenience method to OmniboxEditModel to prevent
repeated code, and adds a bit of testing code for the convenience
method.

Bug: 874592
Change-Id: Iafd791db349df434f616697ecbe6122285b5351b
Reviewed-on: https://chromium-review.googlesource.com/1229493
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592122}

Fixes the crash in ConfirmInfoBarController and potentially other infobar
controllers after the refactoring of infobars in crrev.com/c/1037640.

First attempt at fixing this crash: crrev.com/c/1161324

Bug: 880951
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I14cef2eabf0293221de4ea31ac2ea18d4c1522b0
Reviewed-on: https://chromium-review.googlesource.com/1213546
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592121}

This functionality is used by the FileMetricsProvider, currently based
on a Feature to be enabled.

Bug: 882892
Change-Id: I55262453b58c5ed9473b33e8839bad423ca7ec84
Reviewed-on: https://chromium-review.googlesource.com/1220310
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592120}

Changes:
1. Enable blur for suggestion chip and use a mask layer to clip into
   rounded rect.
2. Enable blur for folder icon and use a mask layer to clip into
   circle.
3. Since anyway we have to use mask layer for the blur, we don't need
   rely on Skia to draw clipped folder icon during the folder icon
   animation. Instead, we use mask layer as well.
4. Opening assistant will recreate layers in app list (bug 879372).
   Since Layer::Clone() does not copy mask layer (not owned), the mask
   layer set before will get lost. So override
   LayerOwner::RecreateLayer() to set mask layer after cloning.

Bug: 873288
Change-Id: I7e7ff23cf38bfaece9799810e398c76bd38f8b68
Reviewed-on: https://chromium-review.googlesource.com/1171546
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592119}