- 16 Jun, 2014 40 commits
-
-
malch@chromium.org authored
Review URL: https://codereview.chromium.org/331143005 Review URL: https://codereview.chromium.org/331143005 git-svn-id: svn://svn.chromium.org/blink/trunk@176229 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
BUG=361045 Review URL: https://codereview.chromium.org/337123002 git-svn-id: svn://svn.chromium.org/blink/trunk@176228 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Url for this event is retrieved from imageURL field later in the same switch. BUG=361045 Review URL: https://codereview.chromium.org/339603002 git-svn-id: svn://svn.chromium.org/blink/trunk@176227 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kozyatinskiy@google.com authored
1. Open page with javascript 2. Add breakpoint 3. Stop on breakpoint 4. Use live edit and save script The test worked for Chromium revision until May 30. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176101 Review URL: https://codereview.chromium.org/329533002 git-svn-id: svn://svn.chromium.org/blink/trunk@176226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philipj@opera.com authored
This is based on Aaron Colwell's patch: https://codereview.chromium.org/170233009/#ps270001 BUG=249427 TEST=LayoutTests/media/avtracklists.html Review URL: https://codereview.chromium.org/284513003 git-svn-id: svn://svn.chromium.org/blink/trunk@176224 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
There use to be isBackground field on Timeline events but it has been removed. BUG=None Review URL: https://codereview.chromium.org/334743008 git-svn-id: svn://svn.chromium.org/blink/trunk@176223 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timvolodine@chromium.org authored
Implement Battery Status API using promises in blink as according to the (modified) spec: https://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html. Using this patch the Battery Status API is accessible using: navigator.getBattery().then(...) syntax. Also added layout tests for the various use-cases. BUG=122593, 360068 Review URL: https://codereview.chromium.org/329723005 git-svn-id: svn://svn.chromium.org/blink/trunk@176222 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aandrey@chromium.org authored
BUG=272416 R=yurys@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/332493002 git-svn-id: svn://svn.chromium.org/blink/trunk@176221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
schenney@chromium.org authored
Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) Reason for revert: This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f2c232cd4a0 \u003Cunknown> #3 0x7f2c2337f313 __poll #4 0x7f2c240b6036 \u003Cunknown> #5 0x7f2c240b6164 g_main_context_iteration #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() #8 0x7f2c2a2f69d8 base::RunLoop::Run() #9 0x00000466bd59 content::RunThisRunLoop() #10 0x00000466c1b8 content::MessageLoopRunner::Run() #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() #12 0x0000011fdf00 MediaBrowserTest::RunTest() #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() ... Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. Original issue's description: > IDL: Support optional argument default value syntax > > Adds support for parsing default values of different types, but > only handles null default values when generating code. > > Replaces existing > > [Default=Null] optional SomeInterface arg > [Default=NullString] optional DOMString arg > > with the now equivalent > > optional SomeInterface arg = null > optional DOMString arg = null > > in IDL files, and drops support for those [Default] attributes. > > No changes to generated code. > > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339683002 git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
clamy@chromium.org authored
This CL removes the setting of the first party for cookies url from FrameFetchContext::addAdditionalRequestHeaders. For request going through the ResourceFetcher, it will be added in content::RenderFrameImpl::willSendRequest (see https://chromiumcodereview.appspot.com/317853002/). Other users of the function (BeaconLoader, PingLoader) can use a new specific function of FetchContext. BUG=376025 Review URL: https://codereview.chromium.org/314093002 git-svn-id: svn://svn.chromium.org/blink/trunk@176219 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sungmann.cho@navercorp.com authored
BUG=none TEST=compile Review URL: https://codereview.chromium.org/331083003 git-svn-id: svn://svn.chromium.org/blink/trunk@176218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Avoids its unnecessary persistents by doing so. R=tkent@chromium.org BUG=357163 Review URL: https://codereview.chromium.org/333313002 git-svn-id: svn://svn.chromium.org/blink/trunk@176217 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
This CL takes care the rest part of html subdirs under core. BUG=381876 Review URL: https://codereview.chromium.org/338123002 git-svn-id: svn://svn.chromium.org/blink/trunk@176216 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
amikhaylova@google.com authored
BUG=376194 Review URL: https://codereview.chromium.org/337753004 git-svn-id: svn://svn.chromium.org/blink/trunk@176215 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
Now that we may fetch a lot of trace (or buffered timeline) events after timeline is stopped, we need a better indication of that. The button remaining red after it's pressed is very annoying. Let's turn it off and disable till we get all the events, and if the progress pane is on, display the appropriate message there. BUG=361045 Review URL: https://codereview.chromium.org/322403004 git-svn-id: svn://svn.chromium.org/blink/trunk@176214 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=354447 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174557 Review URL: https://codereview.chromium.org/267393003 git-svn-id: svn://svn.chromium.org/blink/trunk@176213 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
BUG=245436 Review URL: https://codereview.chromium.org/337973004 git-svn-id: svn://svn.chromium.org/blink/trunk@176211 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kangil.han@samsung.com authored
This CL deletes unneeded mutable keyword by removing const keyword on setter functions. Review URL: https://codereview.chromium.org/337113002 git-svn-id: svn://svn.chromium.org/blink/trunk@176210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
schenney@chromium.org authored
TBR=dpranke BUG=385015 Review URL: https://codereview.chromium.org/338093003 git-svn-id: svn://svn.chromium.org/blink/trunk@176209 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/332203002 git-svn-id: svn://svn.chromium.org/blink/trunk@176208 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dominik.rottsches@intel.com authored
Second blink side change, part 3 of the series in total. BUG=382411 R=eae,behdad,tkent Review URL: https://codereview.chromium.org/323963002 git-svn-id: svn://svn.chromium.org/blink/trunk@176207 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Avoids keeping a bare pointer to the current anchor from the client implementation object. R=ager@chromium.org,zerny@chromium.org,haraken@chromium.org,tkent@chromium.org BUG=340522 Review URL: https://codereview.chromium.org/334153003 git-svn-id: svn://svn.chromium.org/blink/trunk@176206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
TimelinePresentationModel.Record now has three implementations: one for root record, one for coealesced record and one for representing actual TimelineModel.Record. This allows it to work fine with Timeline based on trace events. BUG=361045 R=caseq@chromium.org Review URL: https://codereview.chromium.org/337023004 git-svn-id: svn://svn.chromium.org/blink/trunk@176205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/332173002 git-svn-id: svn://svn.chromium.org/blink/trunk@176204 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mlamouri@chromium.org authored
The mock is currently assuming that the screen orientation is handled by a RendererWebKitPlatformSupportImpl which is no longer the case. It will move to be part of WebFrameTestProxy but that will require a two sided patch so we should first disable the false-negative. BUG=162827 Review URL: https://codereview.chromium.org/339553003 git-svn-id: svn://svn.chromium.org/blink/trunk@176203 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
With GeolocationController (now back) on the heap, maintain a persistent set of them from GeolocationInspectorAgent. R=haraken@chromium.org,ager@chromium.org,zerny@chromium.org BUG=304341 Review URL: https://codereview.chromium.org/332153002 git-svn-id: svn://svn.chromium.org/blink/trunk@176202 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
This is a preparation patch for implementing all shorthand property. This patch adds layout tests, which are currently failing. After implementing all shorthand correctly, the tests will pass. Spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand BUG=172051 TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html Review URL: https://codereview.chromium.org/335733003 git-svn-id: svn://svn.chromium.org/blink/trunk@176201 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jl@opera.com authored
Adds support for parsing default values of different types, but only handles null default values when generating code. Replaces existing [Default=Null] optional SomeInterface arg [Default=NullString] optional DOMString arg with the now equivalent optional SomeInterface arg = null optional DOMString arg = null in IDL files, and drops support for those [Default] attributes. No changes to generated code. BUG=258153 Review URL: https://codereview.chromium.org/312683005 git-svn-id: svn://svn.chromium.org/blink/trunk@176200 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
When a media element is marked with the preload hint 'none', a load is not started until data is explicitly requested. The progress timer is however still started, which means that a 'stalled' event will be fired after ~3s. This is confusing, since loading never actually started in the first place. Fix this by implementing (the "optional") step 3 from the 'resource fetch algorithm'. BUG=382505 BUG=284413 Review URL: https://codereview.chromium.org/327553002 git-svn-id: svn://svn.chromium.org/blink/trunk@176199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
R=haraken@chromium.org BUG=305497 NOTRY=true Review URL: https://codereview.chromium.org/332183002 git-svn-id: svn://svn.chromium.org/blink/trunk@176198 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
falken@chromium.org authored
Before this patch, the ServiceWorker object returned by navigator.serviceWorker.register() could be garbage collected prematurely causing state change event handlers to never be invoked. This patch makes ServiceWorker an ActiveDOMObject and keeps it alive until either stop() is called on it (indicating detach of the parent document) or it reaches the terminal "deactivated" state (soon to be renamed "redundant"). For future work, it may be possible to be more clever and allow the SW to die when it has no event handlers. BUG=383972 Review URL: https://codereview.chromium.org/330173003 git-svn-id: svn://svn.chromium.org/blink/trunk@176197 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
- enable "Capture picture" check-box in Timeline capture filter when Timeline on trace events experiment is enabled; - add disabled-by-default-devtools.timeline.{picture,layers} categories to trace filter when the above is checked; - associate recorded SkPicture with the last paint event of the layer with matching id; - display pictures preview in Timeline's details view, when these are available. BUG= Review URL: https://codereview.chromium.org/328143003 git-svn-id: svn://svn.chromium.org/blink/trunk@176196 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
davve@opera.com authored
Instead add includes to .cpp files that needs things that StyleResolverState.h included for them. This brings down the amount of recompilation drastically (from ~720 to ~20) when touching files like FontBuilder.h or StyleResolverState.h. Review URL: https://codereview.chromium.org/327773004 git-svn-id: svn://svn.chromium.org/blink/trunk@176195 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yhirano@chromium.org authored
ScriptPromise::then should use v8::Promise::Then in order to handle multiply-wrapped Promises correctly. BUG=371288 Review URL: https://codereview.chromium.org/316453002 git-svn-id: svn://svn.chromium.org/blink/trunk@176194 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
Calculating the animated value between two transforms of differing types would give random results (and ASSERT in debug.) Fix by requiring the effective 'from' value to have the same type as the 'to' value. If the types are not the same, then use a "zero transform" as the 'from' value. Also adjust the behavior of animateTransform additive to-animations in this case by clearing the list in these cases too (matching Presto and Gecko in this particular case.) BUG=231409 Review URL: https://codereview.chromium.org/330813002 git-svn-id: svn://svn.chromium.org/blink/trunk@176193 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yoichio@chromium.org authored
Let's use FrameSelection::DirectoinalOption instead of bool. BUG= Review URL: https://codereview.chromium.org/328243004 git-svn-id: svn://svn.chromium.org/blink/trunk@176192 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ziran.sun@samsung.com authored
R=tkent@chromium.org BUG=None Review URL: https://codereview.chromium.org/334793005 git-svn-id: svn://svn.chromium.org/blink/trunk@176191 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pneubeck@chromium.org authored
Will allow reuse of this function in the implementation of the enterprise.platfromKeys Chrome extension API. BUG=364435 Review URL: https://codereview.chromium.org/312393004 git-svn-id: svn://svn.chromium.org/blink/trunk@176190 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yoichio@chromium.org authored
We use VectorComparer to compare WTF::Vector<T>. If T is not primitive type, we use std::equal to compare. By the way, we use the WTF::VectorBufferBase class for a base class of Vector. VectorBufferBase doesn't alloc a array if we init it without a size argument. As a conclusion, we pass NULL object to std::equal when we compare Vectors with the default constructor. It is asserted especially on a Windows debug build. BUG= Review URL: https://codereview.chromium.org/332113002 git-svn-id: svn://svn.chromium.org/blink/trunk@176189 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aandrey@chromium.org authored
Evaluate explicit "delete this[p]" to delete a property. R=vsevik Review URL: https://codereview.chromium.org/323423002 git-svn-id: svn://svn.chromium.org/blink/trunk@176188 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-