- 22 Sep, 2020 21 commits
-
-
Thanh Nguyen authored
1. Adds an icon as the badge icon for the FAR recommendations 2. Make the icon consistent with arc playstore search result. 3. Move EncircledImageSource to ImageSkiaOperations so that it can be reused (no logic changed) Bug: 1028373 Change-Id: Ieabf6f39e63472f6d1b0eee70b6bc9841dbbd13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402472 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809149}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If93f0d4e4e82a93b6405c97f93d8c5993279792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809148}
-
Tommy Li authored
We previously added a top inset to section headers to pad it from the results with no headers. We didn't consider that the section header could be in the top position. This leads to some extra margin for no reason, and also leads to being able to click through the popup onto the bookmark bar on MacOS. This CL fixes that. We should merge this to M86 as it's a trivial fix. Bug: 1130812 Change-Id: Ife0e81c343465e6c8624eeecbea7672e9028be93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422887 Auto-Submit: Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#809147}
-
Lepton Wu authored
This reverts commit d8b85fc3. Reason for revert: The original bug has been fixed. Original change's description: > Disable webgl-compressed-texture-etc.html webgl-conformance test on CrOS > > The test is failing on CrOS and blocking LKGM updates. This disables it > while we figure out what regressed to allow for LKGM updates. > > Bug: 1127052 > Change-Id: Ie44baff4b78e495c1af42b4f01e4b6bb6b16071d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404749 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806261} TBR=oshima@chromium.org,ynovikov@chromium.org,kbr@chromium.org,bsheedy@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1127052 Change-Id: I346f6a9d5f2149c444d955997975a94bc2abe80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421436Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Lepton Wu <lepton@chromium.org> Cr-Commit-Position: refs/heads/master@{#809146}
-
Rune Lillesveen authored
The CSS Color Adjustment specification[1] says we should paint an opaque canvas background for an iframe if the used color-scheme for the iframe element and the root element of the iframe document do not match. This CL propagates the used color-scheme from the embedding document as part of the FrameOwnerProperties mojo API. The embedder and the frame may live in different processes due to OOPIF. [1] https://drafts.csswg.org/css-color-adjust-1/#color-scheme-effect Bug: 1058822 Change-Id: I4db82b774a616b528ab14898755153c624b63adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410223Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#809145}
-
Bo Liu authored
Change-Id: Ib1c8c8f6cb1f74c32c543ae84844e634b26fcb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422428Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809144}
-
Moe Ahmadi authored
This is done in order for Frecency score to be used outside of LocalHistoryZeroSuggestProvider for repeatable quereis. Bug: 1110077 Change-Id: I7c077d7c5215b88cf565c30e84556dffca55182b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422153Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
Change-Id: Ie1a243373fa050b06eb87436e07c21a05948b34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422888 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809142}
-
Eric Lawrence authored
Over the years, the features controlled by some switches were removed but the switches were left behind. Remove the unused switches, and add a comment about how to avoid pitfalls in future cleanups. Bug: 1130298 Change-Id: I7070fe6b8bd8044551e37979f0ebb7bf0e58fc75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421440 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809141}
-
Tomasz Wiszkowski authored
Bug: 1087700 Change-Id: I05d6c896298e2094834f9e14f2e517a3009a7a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419411Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#809140}
-
Andrew Grieve authored
Hoping that this will help multiple trybot runs with the same changes yield the same size result. Bug: 1130754 Change-Id: Ie4376919f7f18e177d5106c86a3f429389333cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422718Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809139}
-
John Chen authored
This reverts commit 7cfb7f2a. Reason for revert: Causing all Windows builds to fail on perf waterfall (crbug.com/1130851) Original change's description: > Update Crashpad to 36d4bb83b3d79dc85c35c258a9364f7d6ec0f6b3 > > 3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls > 76c6de22e1c2 [fuchsia] Enable ConvertInvalidUTF8ToUTF16 > 90344b24ed1c fuchsia: suppress -Wconversion warnings > a98ee20e578f [crashpad] Prepare crashpad for base::string16 switch > 1c77abe90956 fuchsia: Centralize disabling of Wconversion > 36d4bb83b3d7 Remove base dependency from no_cfi_icall > > Change-Id: I5dfe1de33051e0dd5374bf0d5730760651df6b60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422809 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809124} TBR=jperaza@chromium.org,mark@chromium.org Bug: 1130851 Change-Id: Icfc7570ca750bb5baacc61e340e683b5653012e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423103Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809138}
-
Shakti Sahu authored
- Add Keys for preferred language and last updated time. - Register to PrefService. Change-Id: I844b4897ade5478603e386c9b4d615ed53b3c03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394518Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809137}
-
Matthew Denton authored
Currently, BrokerProcess:SIGSYS_Handler dispatches syscall numbers to specific syscall handler, along with a couple sanity checks. When USER_NOTIF support lands, the broker will also need to read the syscall number and dispatch to a syscall handler. So, create an interface that lists the syscall handlers, and deduplicate the dispatching code. The current implementations of the syscall dispatch functions will be specific to BrokerClient, so move them from broker_process.cc to broker_client.cc as they won't be used by USER_NOTIF. This means a lot of changing open_broker.Syscall(...) to open_broker.GetBrokerClientSignalBased()->Syscall(...) in broker_process_unittest.cc. Bug: 1117351 Change-Id: I830fa6d10f973cf90697c7e19b80b596ba0428b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379551 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#809136}
-
Shakti Sahu authored
This CL adds all the required strings for video tutorials, which includes IPH card texts, language names, button names, accessibility texts, tile texts. Bug: 1117145 Change-Id: Ibfded7ab1a24339d867e0f59ae24ce51f321325d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419338 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I7d35f2d96ef4dfb369ebf2062bdbf1ddd00f71bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422418Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#809134}
-
Nico Weber authored
But keep the rpmalloc change, so this builds a new -3 package with the old LLVM rev instead of just pointing us at the old d0abc757-2 (which doesn't have rpmalloc). The roll seems to cause problems in builds that use thinlto (https://crbug.com/1128966, https://crbug.com/1128144). Bug: 1128966,1128144,1126953 Change-Id: I1942eceb86f75d12ec1916cf7831fee221b01f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422159 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#809133}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/616bd4f9aeca..1d32f88ab33e $ git log 616bd4f9a..1d32f88ab --date=short --no-merges --format='%ad %ae %s' 2020-09-18 wtc Cleanup in avifPrepareReformatState() 2020-09-18 wtc Add four more aom-specific options 2020-09-16 wtc Document how to build dav1d with asan or ubsan 2020-09-16 wtc Move AOM-specific option processing to new func 2020-09-11 jdrago Disable receiving one-frame-per-layer when decoding scalable AVIFs with aom and dav1d 2020-09-11 jdrago Actually propagate the commandline codecChoice to the avifDecoder (!) 2020-09-11 jdrago Perform 0.5 UV bias with integers, as 128/512/2048 aren't exactly 0.5, but are expected to behave as such 2020-09-11 jdrago Add BT601 to drift calculations 2020-09-11 jdrago Avoid libpng's complaints about specific ICC profiles, and allow endusers to ignore an AVIF's ICC profile during conversion 2020-09-08 jdrago Store all alpha payloads before color payloads in mdat 2020-09-08 jdrago Fix memory leak in avifenc when encoding image sequences 2020-09-08 jdrago Error out with AVIF_RESULT_REFORMAT_FAILED if request uses an unsupported MC Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1130138 Change-Id: I0f362f84ae6173e6f864aa59aa12b05a4697fd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422434Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#809132}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5674bf247a07..9c00c7f418c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hesen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1102995 Tbr: hesen@google.com Change-Id: If82cd2a89617cdd5d0ddc3557770d1d0c21223fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421433Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809131}
-
Tamir Duberstein authored
This behaviour was fixed upstream. Bug: fuchsia:20603 Fixed: 959314 Change-Id: Ida123b8d8d2ffb32adb56e19432cd64f8bad28d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421766Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#809130}
-
Alexei Svitkine authored
All of these are above the guidance at the top of ukm_features.cc: "e.g. <1% of page views" - verified on Windows and Android stable. The guidance is there because UKM's sampling is on a per event basis, so individual enum entries can't be sampled at different rates. If data in UKM still needs to be collected for these, they can be added as their own dedicated UKM events and thus could be sampled appropriately. Bug: 1129061 Change-Id: Id3087b51eb3af80679026444dc6e4c1aa814d1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414917Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#809129}
-
- 21 Sep, 2020 19 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9f70b6b2054f..1b436e07b1e0 2020-09-21 lexa.knyazev@gmail.com Metal: Implement BPTC support 2020-09-21 ynovikov@chromium.org Skip Texture2DTest.TexStorageWithPBO on Win NVIDIA GL 2020-09-21 jmadill@chromium.org Test Runner: Fix default config grouping. 2020-09-21 jmadill@chromium.org Test Runner: Add more timeout logging. 2020-09-21 lehoangq@gmail.com Metal: Fix wrong FormatID enum order used by PBO autogen shaders. 2020-09-21 jmadill@chromium.org Test Runner: Allow empty sharding parameters. 2020-09-21 jmadill@chromium.org Remove zlib from export_target exceptions. 2020-09-21 jmadill@chromium.org Give trigger.py executable bit. 2020-09-21 jmadill@chromium.org Suppress Linux GL Compute Tests on Intel. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1032721 Tbr: syoussefi@google.com Change-Id: I211379151c9f5bc0f92df1956a2c02d339813b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422310Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9cfae46c7cca8ab4cebf8c12accc63621af6f353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422467Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#809127}
-
Russell Davis authored
This fixes the issue in two ways: * At a high level, we no longer run a new find when nothing has changed. * At a lower level, when both find_match and new_session are false, we no longer end up in an infinite loop of calls to SendFindRequest. Bug: 1129756 Change-Id: Ic2fdad11a83f882dff3dc272a5bd7da24cab8e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418252 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Adrienne Walker authored
This is the last (known) piece for IndexedDB storage service sandboxing. This converts the FileStreamReader for blobs to use FilesystemProxy instead of local files. Bug: 1119547 Change-Id: I00aaec757ffed4bc35ce723eef6171473c8b1f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412834 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
-
Joshua Peraza authored
3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls 76c6de22e1c2 [fuchsia] Enable ConvertInvalidUTF8ToUTF16 90344b24ed1c fuchsia: suppress -Wconversion warnings a98ee20e578f [crashpad] Prepare crashpad for base::string16 switch 1c77abe90956 fuchsia: Centralize disabling of Wconversion 36d4bb83b3d7 Remove base dependency from no_cfi_icall Change-Id: I5dfe1de33051e0dd5374bf0d5730760651df6b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422809 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#809124}
-
Yuly Novikov authored
and use --no-xvfb arg on Linux to connect to X server Bug: chromium:1130483 Change-Id: I3e81fb548e5e15153c009787db467a7d86073899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421510 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#809123}
-
Xing Liu authored
This CL adds an expiration internal to check whether the download can be auto resumed. Download later downloads are not affected. Bug: 1090983 Change-Id: I3bc00e35af6b0e6853465f0ed4e3cc26fc957ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422804Reviewed-by:
-
minch authored
Background blur has been set for power menu and system toast by default, remove flag kEnableBackgroundBlur checking for them. Bug: 1130618 Change-Id: Ibd15ebd10369f605bac4ff123496a3777171ecbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422351Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#809121}
-
Nate Fischer authored
No change to logic. This completely disables testManualInitiationWithBarOpen(). This was previously disabled for M-only, but this is also flaking on P. This removes filters in favor of the @DisabledTest annotation since it appears the test itself is flaky, not just on emulators. Tbr: dtrainor@chromium.org Bug: 1036553, 1130712, 1127786 Test: out/Default/bin/run_chrome_public_test_apk -f TranslateCompactInfoBarTest.* Change-Id: Ic588962d6625a310549d0183754b2d4d612f4643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422706 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#809120}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e0244d9798ab..cc2909804286 2020-09-21 syoussefi@chromium.org Strip trailing empty lines when getting footers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130601 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id4b4ba6aca33b949d481901c0f557f3ff57d8123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422316Reviewed-by:
-
Anastasia Helfinstein authored
Fixes a bug where pressing shift rendered most of the keyboard unreachable by rebuilding all of the keyboard nodes. As a side effect, causes the focus to jump back to the beginning of the keyboard when shift is engaged or disengaged. AX-Relnotes: n/a. Fixed: 1126923 Change-Id: I74cbf35c8e967aed2d7ece19378264aa1b6e9b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419387 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809118}
-
Reilly Grant authored
This change adds a missing check that a new serial port matches the filter specified by the developer when it is detected after the chooser UI is shown. Matching tests are added to exercise this case. Bug: 1130674 Change-Id: I3f7a5086b98971cafd69fe5e630500932944af98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422431 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#809117}
-
Zach Trudo authored
SharedVector protects access to a std::vector and ensures all mutations take place on a SequencedTaskRunner. Bug: chromium:1078512 Change-Id: I9460b6b5f93cfac9455abc9791abe01da053fa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417055 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809116}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I3cccad2231c414a1031475604bd12be70a9bc270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420772 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809115}
-
Angela Yoeurng authored
Currently, there is no voiceover to indicate when we're in keyword mode. This CL expands the existing voiceover for keyword button focus to apply to all of keyword mode. Bug: 785375 Change-Id: I8d284395848e5f092d4ab0a855d23e80bef10c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411230Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#809114}
-
Kartik Hegde authored
Add utility functions that can be shared by routines. This avoids duplicating code per routine. TEST=unit_tests --gtest_filter=NetworkDiagnosticsUtilTest* BUG=chromium:956783 Change-Id: I41cb02956db7b1ee0045c7d7e775ec0a16ee97a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420913Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#809113}
-
Josh Simmons authored
Extend expiry date of NativeSmbFileShare.MountCount and NativeSmbFileShare.MountResult until Chromium M94. Bug: 1088967 Change-Id: Ic6358dcd5ba7789da2ce03fadbd759769ef5b054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418592Reviewed-by:
Anand K Mistry <amistry@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#809112}
-
Nate Fischer authored
This test started failing recently on Android, so this disables it only for that platform. Tbr: tbansal@chromium.org Bug: 1130720 Test: out/Default/bin/run_net_unittests NetworkQualityEstimatorTest.* Change-Id: Ief4644e996b724d862310568aa6007ef3ead2431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422269Reviewed-by:
-
Bo Majewski authored
Bug: 1129607 Change-Id: I32cf4c9f0c19ae310a2de7d449dcbd783651291d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417790 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
-
