- 28 Jul, 2020 40 commits
-
-
Travis Skare authored
Change-Id: Ifdf8969673ad991b8235945c12d7f10a31be31bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320137 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792260}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c11a19145f1f..5b007a519a28 2020-07-28 cwallez@chromium.org dawn_wire: Implement MapRead/WriteAsync on top of MapAsync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I62064e0c7aa84731b1e8078bcb4677ae5d8b398d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792259}
-
Roman Sorokin authored
Was broken by CL:2297621 Fixed: 1109179 Change-Id: Ieeb06baa6b42cbd89df462966bf30977b3fb8fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320574 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792258}
-
Minoru Chikamune authored
This is single call site which uses SequencedTaskRunnerHandle::Get() under third_party/blink. task_runner_ is initialized from ctor of MimeSniffingThrottle. And MimeSniffingThrottle is instantiated from NavigationURLLoaderImpl::MaybeStartLoader(). But NavigationURLLoaderImpl::MaybeStartLoader() uses base::ThreadTaskRunnerHandle::Get() instead of SequencedTaskRunnerHandle::Get(). Bug: 1045925 Change-Id: I66640684214b288bbab477165feec36c53d39335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320712Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#792257}
-
Mark Brand authored
This change simplifies the protobuf representation of Remote/Receiver types, and adjusts the generated code accordingly. It also removes some duplication of code in the Remote/AssociatedRemote cases so that the handling of calls to remotes need only be implemented once for each interface. Bug: 1076336 Change-Id: Ib4cdb0cb6cf700ebb74feb28cd66acb3b49f2d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302609Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#792256}
-
Olivier Robin authored
This fixes non standard startup parameters like - external pdf files - extension search text/images Bug: 1108801 Change-Id: If38c4bb795ec1dfb920a3b5970e4ae6423e4df15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320872Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792255}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I5ec5f9ba5a1af3957bfff1127fb6fac69a9d2623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321062Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792254}
-
Ulan Degenbaev authored
The timer that starts the memory measurement in the Finch experiment can fire for a frame that was detached leading to a nullptr access. Bug: 1105494 Change-Id: I37a2b067acb24303fc5da5a7b7d2855445f28847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320672Reviewed-by:
-
Hitoshi Yoshida authored
The new code generator for IDL dictionaries were run in a different target from other IDL definitions (enumerations and interfaces, atm.) This CL merges them and cleans up related GN targets. Also renames a GN flag to use the new generator for IDL dictionaries to be consistent with interface's one. Bug: 839389 Change-Id: Ic22bd52de7e82ebdb628a78e33d2d4a11fc6707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299681 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Lei Zhang authored
Make sure the call succeeds before continuing, to avoid potentially using uninitialized values. Bug: 1108351 Change-Id: Ife6f8b861a53cad0bbaec8130eef0dd1341ab71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321339Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792251}
-
Luke Zielinski authored
New sha is 22901727d52297378d44b217af0b4c06d5b0a484 Change-Id: Ic1aa7c32de4f2057ce8d7c267774b64fb917a352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320749 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#792250}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I817fa17aa6d19593dd4507962abd57db1ae0a0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319336Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#792249}
-
Solomon Kinard authored
Bug: 179375 Change-Id: I309fa16bc32c5b699dc54da2de2dc64edafff700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300664 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792248}
-
Luke Zielinski authored
This rolls up to sha 40ef02d00e6e4209a8c48d59f56952ad7654731c Main changes are: - set_storage_access testdriver API - hide_test_state member in testharness Change-Id: I98cc4e56379e7d299365dd90684350cf2236c99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320412 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792247}
-
Peter E Conn authored
Change-Id: I66384669d3ef45802ca3ae9468f805ba6fed874f Bug: 1096428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320614 Auto-Submit: Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#792246}
-
Matthias Körber authored
Also removed some duplicated code that slipped through. Change-Id: I15a4a8e7572e8ec07782b818c2eb193afd0baea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300084 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#792245}
-
Mugdha Lakhani authored
So WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: I50d0247ffe8fcba358c7eeaf499ca72cd693279e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312702 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#792244}
-
Anton Ohontsev authored
Back in 2012, we had a problem with the state of the created shortcuts on the desktop: crbug.com/133585 As a fix, we create full-fledged shortcuts and icons only if the profile with which the browser is launched is in the DefaultUserFolder. If the UserDataDir policy is used, a shortcut is created in "%AppData%\Roaming\Microsoft\Internet Explorer\Quick Launch\ User Pinned\ImplicitAppShortcuts" with the path to the icon %ProfilePath%\Default\Yandex Profile.ico, but the icon itself is not created in the profile. To fix this problem, we need to subscribe to create shortcuts and enable the feature of creating shortcuts for a profile from a policy, if such exists. When using --user-data-dir, a different mechanism is used, in this case the shortcut is not created, but the crhome.exe icon is used. BUG=1108485 Change-Id: I21d914d5a4d8b18960bda248a90bf320b649e323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314516Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792243}
-
Michael Thiessen authored
Introduces BlankCTATabInitialState.java, which manages initial state across test suites. No post-batch cleanup is required as the only state carried across test suites is the Activity, which is finished by the test runner. Also batches all device_dialog instrumentation tests together, dramatically speeding them up. Bug: 989569 Change-Id: I66fa56da157491defe1dca9b4ce9464a3d308961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307650Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792242}
-
Avi Drissman authored
In the past, this wasn't done for Canary because the idea was for it to be as identical to the normal Chrome Stable as possible. Now that we're making Chromes to run side-by-side to Chrome Stable, they need their own identity lest visual issues like the one in the linked bug appear. Bug: 1109411 Change-Id: Ie3c75014f5dabfe61d5925383dac5f07b2fce481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318726 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792241}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I8bb93738b8c7c7a726eb257faf2632d351e2d802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321209 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: I4df510cd17acf64bd45fef658da20c0df6e7aae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321770 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#792239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46d04d09. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0e702f34ea4561f034498245d279468e7323b3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322946Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792238}
-
Avi Drissman authored
Files named "*_messages" are used to contain IPC messages and there are special presubmit rules to enforce security team reviews of those files. The "error_messages" files in the chrome/utility/image_writer directory are not IPC messages, so change the filenames so they don't fall under the presubmit check. Bug: none Change-Id: I52025f88ab98c545fc59e6f3ab15ec58f639acc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321525Reviewed-by:
-
Keith Lee authored
Pipe autocorrect character bounds from TextInputClient to getAutocorrectCharacterBounds api surface The CL is dependent on https://chromium-review.googlesource.com/c/chromium/src/+/2251638 Bug: 1108170 Change-Id: Idb651077f9f935b5a9b2a677887b8258eff22310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315658 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#792236}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I692e76739860b75e8cf8de53f3025f581403b1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322178Reviewed-by:
-
Guido Urdaneta authored
This reverts commit e5e98cf1. Reason for revert: Tests have been corrected. New attempt. Original change's description: > Revert "Reland "Do not expose media devices before a successful getUserMedia()"" > > This reverts commit 8b10bc20. > > Reason for revert: camera.CCAUISanity.fake is failing again: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/27932 > > Original change's description: > > Reland "Do not expose media devices before a successful getUserMedia()" > > > > This reverts commit 69a60019. > > > > chrome-prefixed URLs are exempted from the getUserMedia() requirement. > > > > Original change's description: > > > Revert "Do not expose media devices before a successful getUserMedia()" > > > > > > This reverts commit d64e736a. > > > > > > Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680 > > > > > > Original change's description: > > > > Do not expose media devices before a successful getUserMedia() > > > > > > > > This is a spec-compliance change. > > > > > > > > This CL also adds some improvements to the blink MediaDevices unit test. > > > > > > > > Bug: 1101860 > > > > Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808 > > > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#786253} > > > > > > TBR=hta@chromium.org,guidou@chromium.org > > > > > > Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1101860 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282 > > > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > > > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786615} > > > > TBR=mohsen@chromium.org,hta@chromium.org,guidou@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: 1101860 > > Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833 > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#791797} > > TBR=shik@chromium.org,hta@chromium.org,guidou@chromium.org,wtlee@chromium.org > > Change-Id: I6b18c308de10dc5e5251025fd887892ecfef938b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1101860 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320081 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791822} TBR=shik@chromium.org,hta@chromium.org,guidou@chromium.org,adithyas@chromium.org,wtlee@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1101860 Change-Id: I43537e2be617b8d66f40ba1cbd73771a07b79507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320791Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#792234}
-
Marc Treib authored
In some rare cases, clearing of account-scoped passwords can fail (e.g. if there's no network connection). In such cases, we should let the user know that passwords might remain at passwords.google.com. This CL adds an error dialog in chrome://settings/clearBrowserData. Screenshot: https://screenshot.googleplex.com/h9HmAk4sVCq Strings are not final. Bug: 1099260 Change-Id: I252787d9f9d3e8f39f435e6ddb37fb22ea3d7e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#792233}
-
Maksim Ivanov authored
Provide test coverage for the scenario when the PIN dialog, triggered during the challenge-response login (a.k.a. smart card based login), receives a wrong PIN several times until the lockout happens. Bug: 1033936 Change-Id: Ibe90e48fd2a32fb990e22357704afab2bdd6e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317230 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792232}
-
Elly Fong-Jones authored
These tests don't work because the sampler is disabled on Big Sur. Bug: 1101399,1098119 Change-Id: Ibf42402ba0ab2abdcf225cc5de54e5b2939a5572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317806 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#792231}
-
Jonathan Mengedoht authored
The NavigationThrottle validates if a site supports .well-known/change-password urls and redirects to the origin if not to not show the user a 404 page. The NavigationThrottle is guarded by the WellKnownChangePassword feature flag. Bug: 927473 Change-Id: I4c9bf4bc61878096fbfec06cc922d1852a71fb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316164 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792230}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595894324-d422a20c76a9a0bf9c80e2917291820d179a400b.profdata to chrome-mac-master-1595937363-e1ba3bb5d536598606cbf11f12f7443f2b2cf4cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie0fb8aa9f6a9ecf8a1623df25e68c4346ed77a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322597Reviewed-by:
-
Kevin Ellis authored
Initially the table of contents was omitted as it is not populated when viewed in code search; however, it is properly generated if viewed via: chromium.googlesource.com/chromium/src/+/master/<code_path> Use of the [TOC] tag is pretty common in Blink READMEs, and believe it will be quite useful here as well when using a markdown viewer that supports the tag. Change-Id: I354d17ea1a889f91461e5427609a714e8fa24d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320889Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#792228}
-
Leo Zhang authored
When WithSandboxType is deprecated, a wrong Mojo interface was set for ImeService launching, which invalidates the "ime" sandbox. And ImeService's sandbox is set to "utility" by default always. BUG=b:161958233 TEST="--service-sandbox-type=ime" was set for the ime process. Change-Id: I14d0d4141fe8fe684935153ca05dee6cdd86fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320448Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792227}
-
Oleh Lamzin authored
Bug: b:159927590 Change-Id: I732477f033d1afe263203ddf180c61e827f9a3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320277Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#792226}
-
Torne (Richard Coles) authored
Switch to the R SDK and system SDK, and add the WebView code to support WebView R APIs. Bug: 1106471 Change-Id: I4fa349ff6b79983730bca609b95532b019e3e05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310800Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792225}
-
Mathias Bynens authored
CL that temporarily disabled the test: https://chromium-review.googlesource.com/c/chromium/src/+/2320612 Downstream DevTools CL that impacts the expected results: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318257 CL that rolls the updated devtools-frontend into Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/2322214 Bug: chromium:1103854 Change-Id: I4888e1ef9f27839147386596d7ac145046b36b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321310Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#792224}
-
Mason Freed authored
Prior to this CL, there was a magic 166 alpha applied to the system focus ring color (the Accent Color setting). This has now been pulled into native_theme. Along the way, I also added a Color::operator SkColor() to convert blink::Color to SkColor, and used it in gradient.cc, along with here in layout_theme_mac.mm. I'm sure there are other such converters sprinkled around which could be migrated, but this was all I found. Quick note on testing: this change will be best tested by [1] once it lands. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2150765 Fixed: 1108169 Change-Id: I54ac4e60a1df1b39123721adffda9f39aac94fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317294 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#792223}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/df34e3c37407..c6c2cc49fa95 2020-07-28 thestig@chromium.org Remove some OS_ comments on #else lines. 2020-07-28 thestig@chromium.org Use int16_t with CPDF_CIDFont::GetVertOrigin(). 2020-07-28 thestig@chromium.org Make OutputFormat in pdfium_test.cc an enum class. 2020-07-28 vmiklos@collabora.co.uk Add FPDFSignatureObj_GetSubFilter() API 2020-07-28 thestig@chromium.org Rename "render" to "process" in some places in pdfium_test. 2020-07-28 thestig@chromium.org Improve object type checking for /CIDToGIDMap. 2020-07-28 thestig@chromium.org Fix some nits in CPDF_CIDFont. 2020-07-28 thestig@chromium.org Clean up CPDF_TextObject::GetCharInfo(). 2020-07-27 nigi@chromium.org Enable embedder tests RenderWithPause and RenderWithoutPause for Skia/SkiaPaths. 2020-07-27 nigi@chromium.org Consolidate repetitive checksum values for embedder tests. 2020-07-27 nigi@chromium.org Enable FPDFEditEmbedderTest.AddMarkCompressedStream for Skia/SkiaPaths. 2020-07-27 tsepez@chromium.org Remove friendship between CPDFXFA_Context and CPDFXFA_DocEnvironment. 2020-07-27 tsepez@chromium.org Remove CXFA_RenderContext 2020-07-27 tsepez@chromium.org Use uniform snake_case_ member names in CXFA_DocumentBuilder 2020-07-27 tsepez@chromium.org Move ownership of XML document up to CPDFXFA_Context. 2020-07-27 nigi@chromium.org In test suite FPDFAnnotEmbedderTest, enable ExtractInkMultiple and GetSetStringValue for Skia/SkiaPaths. 2020-07-27 nigi@chromium.org Enable FPDFAnnotEmbedderTest.ModifyRectQuadpointsWithAP for SkiaPaths. 2020-07-27 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from a2a7e05eb765 to 0606ae6f9a56 (61 revisions) 2020-07-27 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from a70177d4a2e5 to af90718d311e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6505b1bb2f88329f0c0f26fd946279e80f882c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322207Reviewed-by:
-
Jiewei Qian authored
This CL adds a basic browsertest to verify System Web Apps works after a reinstall. This typically happens on a version upgrade. This CL tests that the installation process completes without crashing, and the installed Apps can be launched (with the exception of Terminal). Terminal requires resources that are only available in Chrome OS images, so we can't launch it from chromium source. Tast tests are needed for this scenario. Bug: 1095524 Change-Id: Ib7053ea56cf0eee8031c66b5d77edcc283236972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316191Reviewed-by:
-
