- 20 Mar, 2019 40 commits
-
-
Vlad Tsyrklevich authored
Previously cfi-icall was disabled because I mistakenly thought is_cfi=true would enable cfi-icall. Enable it explicitly. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng Bug: 942060 Change-Id: I0949e0f547f5ea17c54bb2fb4c99e269daf0f67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529360Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#642364}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2074b14014e..6ce1be5a5a53 git log c2074b14014e..6ce1be5a5a53 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 ynovikov@chromium.org Vulkan: move platform defines to Vulkan Headers build file. Created with: gclient setdep -r src/third_party/angle@6ce1be5a5a53 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I3fe60d1f035486bf1d989bb48891837ba40a3f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642363}
-
Ethan Jimenez authored
1. Adding a method in `AXPlatformNodeDelegate` to provide a localized string for the Landmark Type property of an element. A cross-platform browser test to validate such method is created. 2. Introducing support in `AXPlatformNodeWin::GetPropertyValue` for UIA Landmark Type and Localized Landmark Type properties. 3. Adding unit tests for both properties in `AXPlatformNodeWinTest`. 4. Updating role mapping for Windows and Linux platforms to be more consistent with the CORE-AMM specification. See: https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings https://www.w3.org/TR/core-aam-1.2/#mapping_role_table Bug: 844149 Change-Id: I7a2f47ff6b7b127907b8bfff63ae84852e153f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509907 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#642362}
-
Rakina Zata Amni authored
This CL adds a new function, NearestLockedInclusiveAncestor, to DisplayLockUtilties, so that it can be reused in multiple places (example: https://chromium-review.googlesource.com/c/chromium/src/+/1528123/2/third_party/blink/renderer/core/inspector/inspector_highlight.cc#291) Bug: 882663 Change-Id: Ia7408f10635f7304cebee483c14773c626d6bec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528126Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#642361}
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: browser_tests --gtest_filter=WebViewScrollGuestContentBrowserPluginSpecificTest.OverscrollControllerSeesConsumedScrollsInGuest Bug: 870606 Change-Id: I34d1cb8b94955798a896e741b76135dec6f8c031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530314Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642360}
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: browser_tests --gtest_filter=PrintBrowserTest.SelectionContainsIframe Bug: 870606 Change-Id: If7027d9a104513408f2d14507f6938308273bd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529501Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642359}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7104562e5e4..e065d4ecc451 git log f7104562e5e4..e065d4ecc451 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 eugenis@google.com Annotate UnsafeMemcpy for HWASan. Created with: gclient setdep -r src/third_party/perfetto@e065d4ecc451 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:112438058 TBR=perfetto-bugs@google.com Change-Id: I86803e1238d34fb4d555c30d33dc16f7aee52bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642358}
-
Sam McNally authored
Currently, all DriveFS change notifications are forwarded to the UI. Some parts do their own checks for matching the expected directory, but others do not; one part that does not is DirectoryTree, which triggers a rescan of any changed directories. Filter to just directories with a registered watcher like the old Drive client does. Bug: 943886 Change-Id: If106ef054e5bfbdd16697e41d74b176996c6750f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529896Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#642357}
-
Robert Liao authored
This is a run of run-clang-tidy.py -checks="-*,google-readability-casting" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sadrul@chromium.org Change-Id: I94071fabfa471259ae70acae3ef692f6f588ceef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531712Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642356}
-
Staphany Park authored
Change-Id: Ic1fbc244161497ef64acea02eca5bd795ba693db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529585 Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#642355}
-
Peter Kasting authored
MaterialDesignController requires COM to be initialized. Without this, various views_unittests tests fail when run individually. (This probably means there's a second bug somewhere where something is holding COM initialized that shouldn't be, or the tests would have failed all the time.) It looks like initializing at the test suite level is roughly where other places are doing this (e.g. ContentTestSuite), so hopefully this is the right place. Bug: none Change-Id: I5e6de4d45c6118b6a2bc69ba960904fa0fd8087d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531422 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642354}
-
Peter Kasting authored
BubbleDialogDelegateView observes multiple widgets. It's possible for the anchor widget to be activated after the bubble widget has been created but before it's visible (e.g. for ExtensionPopup). Ensure we're actually observing the right widget. Bug: none Change-Id: If266fb3ed900f1bd345296f1fb1d37ff1c0eee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531720 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642353}
-
Dmitry Gozman authored
This frame type is only used for navigations, so we should plumb it using WebNavigationInfo instead of WebURLRequest. This patch removes SetFrameType, but not GetFrameType and field, which will be done in a follow up. This corresponds to the step 6.h from the doc linked to the bug. Bug: 855189 Change-Id: I8eec45b95884bf8738d35adf3be021e566bc478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512940 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642352}
-
Josh Nohle authored
Note: The C++ style guide states, "Type conversion operators, and constructors that are callable with a single argument, must be marked explicit in the class definition." Bug: 899080 Change-Id: I013f807d451fd540190dbd8f06b1977a83b6b013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521280 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#642351}
-
Kunihiko Sakamoto authored
This is a partial revert of https://crrev.com/c/1526781. Adding back some expectations for tests that still fail on bots. TBR=atotic@chromium.org Bug: 726520 Change-Id: I2c04afe59e72a6dfb700ba41685ce10c6e26d787 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530360Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642350}
-
Lan Wei authored
In order to remove the timer to send the fake mouse move event, we decide the best place to send the fake mouse move event is at the next begin frame right after we have seen a gesture scroll end event. This CL is working on scrolls happening on main thread. Bug: 877132 Change-Id: I4e92650943c4d0a5c9ce290e8100e8e2b52d3385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517168 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#642349}
-
Jay Harris authored
This is a security UX improvement for RTL domains. Before this change http://مثال.com/ would be displayed as com.مثال instead of مثال.com Bug: 943362, 943366 Change-Id: I967216bb402b12dc437e05274ff8ea63e1544f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529975 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#642348}
-
liberato@chromium.org authored
This CL adds unused mojo bindings for LearningTaskController. The service side owns a LearningTaskController to which it forwards calls. It doesn't have to worry about tracking in-flight observations since it just drops the LearningTaskController when the connection to the client is dropped. The client side just forwards requests to the service. Both are more or less just type adapters from ::mojom to the real types. Change-Id: I707987c8ee2c8bff1915e58d0ae60b0752074674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513204Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#642347}
-
Reilly Grant authored
This change migrates the last remaining WebUI pages from mojo_bindings.js to mojo_bindings_lite.js: - chrome://eoc-internals - chrome://reset-password - chrome://snippets-internals Bug: 931798 Change-Id: Iee40c527fd1660453d320e346c4e83c47b482b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480556 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642346}
-
Jinsuk Kim authored
Tab's UserData/TabWebContentsUserData are now created by a helper class that consolidates them all in one place, outside Tab. Also merged Tab.initWebContents/initBrowserComponents. Bug: 925242 Change-Id: I1f47683457382fbcc7934f9fa52430289c0f56e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514010 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#642345}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Icd735f2b17344a4a2f7543783bb1a634bd5fd0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531097Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#642344}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/core/page and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ifa4bd484faa99509dae4bcb0b76e1e6990921d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522513Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#642343}
-
Roberto Carrillo authored
As a starting point, lets mirror the current setting for linux-chromeos-dbg. This may help with the issue of all shards timing out for these targets. TBR=jbudorick,liaoyuke,sajjadm BUG=943175 Change-Id: Ie47a6d934014c758fc9878147130a620c50cc9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531698Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#642342}
-
Peter Kasting authored
* Match Google style guide declaration order * Make override group order match order of superclasses * Make access control match superclass access control * Make constructor private instead of protected since no subclasses exist * Make definition order match declaration order Bug: none TBR: rdevlin.cronin Change-Id: I4d0460247fe262ab1b2a969f2a67c1e8ff904510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531727Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642341}
-
chrome://settings/manageAccessibilityMay Lippert authored
BUG=862957 Change-Id: I3db71eb24637cea5600ce438db400de34ac07a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531472 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#642340}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/501edb72f469..ec795debc5c1 git log 501edb72f469..ec795debc5c1 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 benjhayden@chromium.org Add sparkline-compound for spa 2019-03-19 simonhatch@chromium.org Pinpoint - Fix pinpoint spamming bugs on frozen jobs. 2019-03-19 simonhatch@chromium.org Pinpoint - Cache commit details while job is running 2019-03-19 simonhatch@chromium.org Pinpoint - Add support for recoverable errors Created with: gclient setdep -r src/third_party/catapult@ec795debc5c1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:943054,chromium:942058,chromium:942057 TBR=sullivan@chromium.org Change-Id: I014d89211ce5530fd9ddf64cc5ba68c6a4373107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642339}
-
Scott Violet authored
This makes aura::EventInjector (and by extension ws:mojom::EventInjector) takes dips (vs pixels) that are relative to the location of the supplied host. This also adds a test that exercises content's testing api for event injection, and in the ChromeOS case tests a handful of interesting screen configurations. BUG=936082 TEST=covered by tests Change-Id: Ib6bbcbdc323f42a26107fbb8ede9231b277b71eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526677Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642338}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6893e71405a3..c75272708a80 git log 6893e71405a3..c75272708a80 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-19 nednguyen@google.com cros_extract_deps: improve docstring of cros_extract_deps.ExtractDeps 2019-03-19 gmx@chromium.org Enable the new tcmalloc on ten more boards Created with: gclient setdep -r src/third_party/chromite@c75272708a80 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ie04c12ce71d9204a9b2faa0b8dfec6bbcb72eb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531348Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642337}
-
CJ DiMeglio authored
Bug: 825444 Change-Id: Icfba401d61cdaac52bbe94d9fe89c6afdc6b857d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531694Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#642336}
-
Jinsuk Kim authored
The newly added flags, if turned on, always delegates overscroll swipes to websites. Bug: 865567 Change-Id: I1eb017c89f6519e64d34e097e9a115ea2f19d581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527948 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#642335}
-
Erik Luo authored
This is a reland of df31273e Original change's description: > DevTools: optimize Styles sidebar for reading property values > > SSP UI changes > - Curly brace, Source link color less dark > - Source links are more aggressively truncated > - "Inherited from" separators have less noise > > Screenshot: https://imgur.com/a/SwpWkGs > > Bug: 929536 > Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448 > Commit-Queue: Erik Luo <luoe@chromium.org> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642093} TBR=einbinder@chromium.org Bug: 929536 Change-Id: I1a67b4243cbe0409337faf7a53c620123cb23a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531692Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#642334}
-
Nigel Tao authored
Also add some App Service icon related TODOs. BUG=826982 Change-Id: Ic253de5a6f8a45f667db272833219aee72e51ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524397 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#642333}
-
sczs authored
Bug: 911864 Change-Id: Ia14654e5a2afacbdca48a5c703818d1d5682d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531235 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#642332}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b488d9c8d805..f79e15b85174 git log b488d9c8d805..f79e15b85174 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 thestig@chromium.org Only define UTF16ToWChar() on relevant platforms. 2019-03-19 tsepez@chromium.org CFX_SeekableStreamProxy should not be an IFX_SeekableStream. 2019-03-19 thestig@chromium.org Roll base/trace_event/common/ 211b3ed9d..936ba8a96 (3 commits) 2019-03-19 thestig@chromium.org Roll tools/code_coverage/ 16298755a..0e34d1463 (8 commits) 2019-03-19 tsepez@chromium.org Add unit test for CXF_SeekableStreamProxy. 2019-03-19 thestig@chromium.org Roll build/ a721f3327..e51ca1d98 (227 commits) Created with: gclient setdep -r src/third_party/pdfium@f79e15b85174 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibddaec829683ca6f5f58040addea8a23bbe51cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530464Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642331}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2dc0303903b1..f2564656e7af git log 2dc0303903b1..f2564656e7af --date=short --no-merges --format='%ad %ae %s' 2019-03-19 chrisforbes@google.com Wire up BuiltInWorkgroupId to compute pipeline 2019-03-19 chrisforbes@google.com Carry decorations down type tree in WalkExplicitLayoutAccessChain 2019-03-19 chrisforbes@google.com Add support for push constants Created with: gclient setdep -r src/third_party/swiftshader@f2564656e7af The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126871859,chromium:b/128690261,chromium:b/128872954,chromium:b/128690261,chromium:b/128872954 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic34c84f043c69374fd37adcf019df26294644d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642330}
-
liberato@chromium.org authored
In order to determine which features are most predictive for a learning task, this CL adds the beginnings of a random feature subset selection algorithm. The idea is that clients will select a random subset of features, and the learning results will reflect a model trained on just those features. Currently, since we're reporting results via UMA, we allow only a subset of size one for importance measuring. This makes it easier to report results on a single histogram. Change-Id: I33aa9659c13e07376a9ff801dda030f76567fa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531107Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#642329}
-
Devlin Cronin authored
The ActivityLogPrivate API's test extension had handling for OS-specific tests and disabled tests, but neither of those are used in practice. Remove the unnecessary logic. Bug: None Change-Id: I55b34aacb40cab6a2049af57e91d98d0f363610e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529717Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642328}
-
Philip Rogers authored
This check is wrong because we cannot skip setting the dirty bits. This check dates back to a time when the rects were synchronously calculated which would have required layout information: https://chromium.googlesource.com/chromium/src/+/3ab811935da94c0afc143978a4ca3721788c770f Change-Id: Icc46b97b6fed64972d028676f43022f60935ae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528483Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642327}
-
Kunihiko Sakamoto authored
It lacked expectation for virtual tests. TBR=wangxianzhu@chromium.org Bug: 619103 No-Try: true Change-Id: I33f00c3ba3e0644cbcf06b8e826146d2d39a32d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529897Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642326}
-
Harley Li authored
An object's properties appears to be editable by double-clicking is misleading, because the modified values are not written back to the storage. Change-Id: Idd40bfd4bbbfa3d5528276ff04754e05bb460ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531602 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642325}
-