- 01 Mar, 2019 40 commits
-
-
khachatryan authored
CL https://crrev.com/635738 fixes the bug 2710 so we are removing the workaround for this bug. Bug: chromedriver:2710 Change-Id: Ic6704a7dbca2de13cf49ea12e7e77dae1568d380 Reviewed-on: https://chromium-review.googlesource.com/c/1495222Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636717}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16c76cb9..486980d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1efba1e42158d100193eebad0d3d17174aade339 Reviewed-on: https://chromium-review.googlesource.com/c/1496601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636716}
-
Rob Schonberger authored
For Dinner For One, add a dinguishing piece of text for accessibility. Bug: 914864 Bug: 911427 Change-Id: I39cc682fbb57ae3e7f3e3b26e582ee3ec127ae5e Reviewed-on: https://chromium-review.googlesource.com/c/1496114 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636715}
-
Yoichi Osato authored
This patch is a preparation for Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports removal. Intent to Deprecate and Remove: http://bit.ly/2RGHe3x Though we soon make these APIs only available for test by turning the json5 feature flag from status: "stable" to status: "test", there is browser tests/chrome internal components that use them. FilesApp finished migration but it was only for w/o Polymer2. FilesApp w Polymer1 still needs the APIs for it. Descussion of flagging was done at previous patch among Jochen and Devlin: crrev.com/c/1405955 Bug: 924873, 911943 Change-Id: I0d3038ce5d21c410e1a055b57752d0df62cf62fb Reviewed-on: https://chromium-review.googlesource.com/c/1496259Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#636714}
-
Tom Anderson authored
BUG=919057,916410,934213 R=mohsen Change-Id: If60bc5958d07fec526b04493f80cb47570b9d00a Reviewed-on: https://chromium-review.googlesource.com/c/1432880 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#636713}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4daef0984277..1757d2dc1b48 Created with: gclient setdep -r src-internal@1757d2dc1b48 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: Ia0f250b59c18a2e35937da56e1362edf0f60d966 Reviewed-on: https://chromium-review.googlesource.com/c/1496387Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636712}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14a41b316425..3e8b031e3e8e git log 14a41b316425..3e8b031e3e8e --date=short --no-merges --format='%ad %ae %s' 2019-03-01 kirtika@google.com config: Make octopus run hwtests Created with: gclient setdep -r src/third_party/chromite@3e8b031e3e8e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I43175d62f4b5cbb453dbf5f0c753b8ac8fbcd3fb Reviewed-on: https://chromium-review.googlesource.com/c/1496388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636711}
-
Maajid authored
Bug: 936355 Change-Id: I5d9e685ca063be7af28cf999adf249766209f911 Reviewed-on: https://chromium-review.googlesource.com/c/1491232 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636710}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: If6780cfe101f0783674ce377278c604527757dee Reviewed-on: https://chromium-review.googlesource.com/c/1493627 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#636709}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I702febb1da6e04241b93457e2f1703d0eb986f32 Reviewed-on: https://chromium-review.googlesource.com/c/1496385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636708}
-
Maggie Cai authored
This CL adds histogram metrics recoding for All Sites page. The recording actions includs: load page, clear data, reset permissions, toggle etld+1 and enter site details. BUG=835712 Change-Id: I69ea45541fbb774e07f1b3dd758b3a1bc84650fc Reviewed-on: https://chromium-review.googlesource.com/c/1481284 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#636707}
-
Kenichi Ishibashi authored
When the main script is already installed, ServiceWorkerGlobalScope retrieves the installed script from InstalledScriptsManager and bypass WorkerGlobalScope::DidImportClassicScript(). Since the URL of the global scope is set in DidImportClassicScript(), we need to set the URL when we bypass the method. This CL is a kind of workaround the cause though. Ideally we should fix the issue by refactoring ServiceWorkerGlobalScope::EvaluateClassicScriptInternal() so that we don't use InstalledScriptsManager in it. This CL fixes following NetworkServiceRestartBrowserTests: - FetchFromServiceWorkerControlledPage_RespondWithFetch - ServiceWorkerFetch Bug: 924043 Change-Id: I1189e086ae8d878d32a6a1edd0d7209a1076f526 Reviewed-on: https://chromium-review.googlesource.com/c/1496116 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#636706}
-
Lei Zhang authored
Do the same for WebDialogWebContentsDelegate. Fix lint errors along the way. Change-Id: I729bad2190f98604178ec3b1b20e802fe9ed68e8 Reviewed-on: https://chromium-review.googlesource.com/c/1496277Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636705}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/906430d4b40c..255569187f27 git log 906430d4b40c..255569187f27 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5de69e91bd93..5546fb4fdd85 (4 commits) Created with: gclient setdep -r src/third_party/skia@255569187f27 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ia9e3d26b8d80b2749482029f91a8ec63d74e1a8d Reviewed-on: https://chromium-review.googlesource.com/c/1496383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636704}
-
Ken MacKay authored
Add a volume change source param that is passed through to observers, to make it easier to determine when to display UX feedback. Also, remove weak functions since this API is required now. Bug: internal b/121396128 Change-Id: Ie56168108810467bb3dcb8fb47efd1fc80eaca1f Reviewed-on: https://chromium-review.googlesource.com/c/1493387Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#636703}
-
Luciano Pacheco authored
This CL is a preparation for CL:1493627. Bug: 778674 Change-Id: I08a7f16b8078e51c1020495a28d0c8ac6208e509 Reviewed-on: https://chromium-review.googlesource.com/c/1493636 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#636702}
-
Lei Zhang authored
Add OnInitiatorNavigated() and OnPreviewDialogNavigated() helper methods, then try to simplify them. Change-Id: I5342dbd31366609b59eddfac2ba017375701f5c0 Reviewed-on: https://chromium-review.googlesource.com/c/1496526Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636701}
-
rbpotter authored
SetMediaSize and SetDpi are moved with small modifications to DpiSettingsSectionTest.UpdateFromSetting and MediaSizeSettingsSectionTest.UpdateFromSetting Since setting the setting based on the dropdown is actually the responsibility of the settings-select element, this aspect of the test is covered by a new SettingsSelect.SetSetting test. CustomMediaSize test is moved to: MediaSizeSettingsSectionTest.SettingsSelect Adding new DpiSettingsSectionTest.SettingsSelect (similar to media size test above). Change-Id: I7d6fe6b382b0fb5ac7ddb90c52bc3272425cf380 Reviewed-on: https://chromium-review.googlesource.com/c/1493373 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#636700}
-
Dan Beam authored
Also, make URLs wrap more gracefully. Screenshot: https://imgur.com/a/HUeOBSE R=rdevlin.cronin@chromium.org BUG=937159 Change-Id: Ied0b93cc094c935e45cfad4745007db723e1267e Reviewed-on: https://chromium-review.googlesource.com/c/1496596Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c212bf59cf6..4daef0984277 Created with: gclient setdep -r src-internal@4daef0984277 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I81b156a9eccea994aaebcd95d95cc32680dd549b Reviewed-on: https://chromium-review.googlesource.com/c/1495780Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636698}
-
Xianzhu Wang authored
This avoids unnecessary visual rect recalculation when ancestor clip changes when we called SetSubtreeShouldCheckForPaintInvalidation() in the case. Bug: 927903 Change-Id: Id55440689e9208b2c7b9590a0c2b06e70ae78160 Reviewed-on: https://chromium-review.googlesource.com/c/1484150Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636697}
-
Luciano Pacheco authored
These lines were submitted in CL:1490352. Reported the bug to lebab project: https://github.com/lebab/lebab/issues/287 Bug: 778674 Change-Id: I09b8b6acbde72f4e0af36c5dd4f8084ac3aef27c Reviewed-on: https://chromium-review.googlesource.com/c/1493638 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#636696}
-
Robert Ogden authored
This CL is 1 of 4 to move the DataSaver "Chrome saved you XX data" from a snackbar to an IPH. This CL moves the snackbar controller class to a class in preferences.datareduction and renames everything from "snackbar promo" to a more generic "milestone promo". All of the prefs and variation params were kept to allow the configurations we already have to keep working as is, although this does lead to some stale naming. UMA is removed in this CL, and will be re-added in the final CL. Bug: 878337 Change-Id: Ia7924cd741db2b6b37180d6fb93735636fbaf00d Reviewed-on: https://chromium-review.googlesource.com/c/1487196Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#636695}
-
Hector Carmona authored
Bug: 937030 Change-Id: I44721aafb7e778f8887411b7c46e3d786bccd59d Reviewed-on: https://chromium-review.googlesource.com/c/1496315Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#636694}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9950df105a7c..520d06f4107a git log 9950df105a7c..520d06f4107a --date=short --no-merges --format='%ad %ae %s' 2019-02-28 benjhayden@chromium.org Deserialize a new HistogramSet JSON format. Created with: gclient setdep -r src/third_party/catapult@520d06f4107a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918208 TBR=sullivan@chromium.org Change-Id: I29d237008fffd8ea1706bcd5a80288ec285cbc36 Reviewed-on: https://chromium-review.googlesource.com/c/1496375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636693}
-
Wei-Yin Chen (陳威尹) authored
Add a TabModelSelectorTabObserver for IPH_TabGroupsQuicklyComparePages and plumb SearchableFormURL to Java NavigationHandle. TBR=michaelbai@chromium.org Bug: 930970 Change-Id: I857d0119ebc7ffc0bdcf09373696d8970556815f Reviewed-on: https://chromium-review.googlesource.com/c/1492933 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636692}
-
Dan Beam authored
Screenshots: https://imgur.com/a/qzkvIKH R=rbpotter@chromium.org BUG=923224 Change-Id: I4856655f42a88ccc7bf635b71b931f9a99aaea49 Reviewed-on: https://chromium-review.googlesource.com/c/1496099 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#636691}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5546fb4fdd85..ffa277a12fcd git log 5546fb4fdd85..ffa277a12fcd --date=short --no-merges --format='%ad %ae %s' 2019-03-01 brucedawson@chromium.org Fix logic for warningsAsErrors Created with: gclient setdep -r src/third_party/angle@ffa277a12fcd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920704 TBR=ynovikov@chromium.org Change-Id: Id2eb245e3b146c57194da9415eb4d867682f9a5a Reviewed-on: https://chromium-review.googlesource.com/c/1495779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636690}
-
Victor Costan authored
https://crrev.com/c/1488952 changed the data collection logic for Sqlite.Stats, so it should have renamed the histogram. Bug: 935824 Change-Id: I2ef7cc7409afcdf7033e8f542b0cd57c4a9a8ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1492780 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636689}
-
Julie Jeongeun Kim authored
This CL moves unhandled_tap_notifier.mojom, site_engagement.mojom, ukm.mojom and reporting.mojom in public/platform to public/mojom. Bug: 919393 Change-Id: I430cc84b586bf989ed201cbe78f4b72fd2765cda Reviewed-on: https://chromium-review.googlesource.com/c/1485694 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636688}
-
Chris Hall authored
BUG=889370 R=dmazzoni,aboxhall Change-Id: Icdd7604a497530503864f61a30a85e6f3a3ac75b Reviewed-on: https://chromium-review.googlesource.com/c/1493633 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636687}
-
Sunny Sachanandani authored
Use selenium so that it's easy to run the script on different browsers such as Edge. As a result add support for fullscreen video by double clicking on the video element which works for common sites. Bug: 848093 Change-Id: Iacf0b7bca2c7a162643e2bb08deb8638b297c121 Reviewed-on: https://chromium-review.googlesource.com/c/1487452 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636686}
-
Yusuf Ozuysal authored
This moves away from a constant margin at top to read values from the fullscreen manager. This way we fix Duet+Grid and also leave any other users of TabList on their own to set the margins as needed. (The strip mode for example won't use any margins at all). BUG=934070 Change-Id: I810ced611eb0358757ed0f706f1c67a845b669f2 Reviewed-on: https://chromium-review.googlesource.com/c/1496436Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636685}
-
Nicholas Hollingum authored
Due to the way that the crostini terminal works, the shelf_id was being overwritten because it was: - On a technicality being "DidFinishNavigation"'d when it loads. - Assumed to be a browser window (because we run crosh in a window) - Failed to be associated with an extension (because crostini isn't) - Failed to be associated with an app app_id - Therefore: defaulted to the browser's shelf id. This fix catches the special case for crostini apps, which is to set the app_name of the browser on creation. We also propose a unit test to maintain this behaviour. Note that all of these measures are temporary, pending a better implementation of the crostini terminal. Bug: 839676 Change-Id: I46a43960cbc3820968fbb9872c142923d753039e Reviewed-on: https://chromium-review.googlesource.com/c/1491876Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#636684}
-
Aga Wronska authored
Define two PIN keyboard styles and update view layout accordingly: * Alphanumeric Keys display digit and a part of the alphabet below. This is the exact style of existing LoginPinView. * Numeric Keys only display digit, therefore keys height is different. This is the new style. Use Alphanumeric PIN style for login PIN input and Numeric PIN style for parent access code input. Bug: 911326 Test: LoginPinViewTest Change-Id: Id164d8580cd64db6891348b5de4638be52ab5c0d Reviewed-on: https://chromium-review.googlesource.com/c/1483675Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#636683}
-
chrome://flagsTim Song authored
BUG=921250 Change-Id: I09ebc0d4d3acc931d5d3ad28152f5040c83bfca6 Reviewed-on: https://chromium-review.googlesource.com/c/1492834 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#636682}
-
Rachel Wong authored
This is because we should retrieve the oldest requests from the end of the queue. Bug: 916420 Change-Id: I0232eb73d2c922297833a93adb22da39c91047e2 Reviewed-on: https://chromium-review.googlesource.com/c/1493339Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#636681}
-
Tao Bai authored
- Moves the session related code to TaskSession. - TaskSession categorizes the captured content and the detached nodes into DocumentSession. - ContentCaptureTask uses the DocumentSession to send the data though the LocalFrame's WebContentCaptureClient. Bug: 924681 Change-Id: I8cd5c96c1ab183e7a567a70fef813881c8b2ab4a Reviewed-on: https://chromium-review.googlesource.com/c/1493400Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#636680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe5a160336aa..5c212bf59cf6 Created with: gclient setdep -r src-internal@5c212bf59cf6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I624bcbc47c0c4660f22acf34d45afb1de4f05d6a Reviewed-on: https://chromium-review.googlesource.com/c/1495778Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636679}
-
Keishi Hattori authored
The code calculated the deltas with uint64_t, causing negative values to be reported incorrectly. This CL fixes the subtraction. And also clamps the samples to 1000 buckets (-500MB to 500MB). Bug: 917293 Change-Id: Ie2b48ddbf1a47577692c4c2013c7a9d365c786ea Reviewed-on: https://chromium-review.googlesource.com/c/1488475Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636678}
-