- 14 Sep, 2016 40 commits
-
-
sunyunjia authored
This is a follow-up patch of https://codereview.chromium.org/2332843002/ Import wpt@de70de04726dedd0981c644669911096854929b6 Using update-w3c-deps in Chromium 8e715596. Review-Url: https://codereview.chromium.org/2342603002 Cr-Commit-Position: refs/heads/master@{#418649}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8c5c37517378..8484270f6d2c $ git log 8c5c37517..8484270f6 --date=short --no-merges --format='%ad %ae %s' 2016-09-14 benjhayden [value-set-table] Move Show all to the right. 2016-09-14 petrcermak [tracing] Add step-into event to <tr-ui-b-table> 2016-09-14 nednguyen Fix running statistics's mean implementation TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2340733004 Cr-Commit-Position: refs/heads/master@{#418648}
-
bokan authored
Currently, while the user is hiding the top controls, the compositor expands the main frame's clipping layer so that we reveal more content. This has to happen because we don't actually resize the anything in the Layer/Layout trees in Blink until after the top controls are fully shown or hidden. When an element is set as the root scroller, we want to provide the same effect. However, since there's still masking layers above the root scroller, we can't see the expanded clip. Instead of expanding all the layers above the root scroller, this CL removes the masksToBounds bit on all layers above the root scroller. This means parent boxes with hidden overflow will not clip the root scroller but this is acceptable as a property of the root scroller. Also, GraphicsLayer setMasksToBoundaries kept a bit on GraphicsLayer but this was never read so I removed it. BUG=505516 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2289833002 Cr-Commit-Position: refs/heads/master@{#418647}
-
rajendrant authored
BUG=625270 Review-Url: https://codereview.chromium.org/2278793002 Cr-Commit-Position: refs/heads/master@{#418646}
-
xiaoyinh authored
This CL adds the following metrics: 1. Usage of each pen palette option 2. Usage of each pen palette option on auto-open 3. Length of time spent in each mode 4. count of Mode cancellation BUG=643798 Review-Url: https://codereview.chromium.org/2308823002 Cr-Commit-Position: refs/heads/master@{#418645}
-
jam authored
This regressed in r417444. Previously (https://codereview.chromium.org/2327433002/diff/250001/chrome/browser/certificate_viewer.cc) we would check that the certificate id sent by the renderer was valid (say because renderer died). Races could also happen now, in that the page might navigate right after user presses certificate viewer button and the last committed entry wouldn't have a certificate. BUG=646882 Review-Url: https://codereview.chromium.org/2337783005 Cr-Commit-Position: refs/heads/master@{#418644}
-
rockot authored
Makes Instance ownership and lifetime management easier to follow. Root instances are now explicitly owned by the ServiceManager and non-root instances are explicitly owned by their parent Instance. OnInstanceError always destroys the Instance, either by removing it from the root instance set or delegating to the parent Instance. This avoids the need for children to re-enter their parent on destruction. Notification logic has been extracted from OnInstanceError and moved to a new OnInstanceStopped, which is always called by each Instance's destructor. This allows parents to delete their own children without calling through to OnInstanceError, while still allowing the ServiceManager to know about the destruction and dispatch notifications accordingly. InstanceErrorType is removed: if an Instance becomes unreachable it's simply removed from the identity map via a new OnInstanceUnreachable call. BUG=640488 Review-Url: https://codereview.chromium.org/2341853002 Cr-Commit-Position: refs/heads/master@{#418643}
-
boliu authored
BUG=619055 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2337973005 Cr-Commit-Position: refs/heads/master@{#418642}
-
sdy authored
…and remove the duplicate divider drawing in DownloadShelfView. BUG=589943 Review-Url: https://codereview.chromium.org/2336463002 Cr-Commit-Position: refs/heads/master@{#418641}
-
antz authored
Reason for revert: The original fix is opt-in, which causes unit test binaries to miss symbols. I will reimplement an opt-out for binaries that we do not want to whole-archive libs. Original issue description: >> All chromecast executable include all libstdc++/libgcc symbols by default >> due to b/25566835. Added a config for --whole-archive for only ones that >> depend on shared libs. ~700kb saving per executable. BUG=internal b/31417380 This reverts commit 92947f23. Review-Url: https://codereview.chromium.org/2334163004 Cr-Commit-Position: refs/heads/master@{#418640}
-
maruel authored
This reverts commit a7ce77dd. Monitoring tells us severely regressed isolate performance. TBR=jam@chromium.org BUG=644410 Review-Url: https://codereview.chromium.org/2344563003 Cr-Commit-Position: refs/heads/master@{#418639}
-
hiroshige authored
This is to make EnsurePtrConvertibleArgDecl(T, const T) to fail for https://codereview.chromium.org/2220543002. This CL also adds unit tests for EnsurePtrConvertibleArgDecl. BUG= Review-Url: https://codereview.chromium.org/2220443004 Cr-Commit-Position: refs/heads/master@{#418638}
-
geofflang authored
With this patch, the passthrough command buffer is capable of rendering chrome and basic WebGL content. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2317363005 Cr-Commit-Position: refs/heads/master@{#418637}
-
kmackay authored
BUG= internal b/31488922 Review-Url: https://codereview.chromium.org/2340013002 Cr-Commit-Position: refs/heads/master@{#418636}
-
japhet authored
Can be enabled in about://flags BUG=638198 Review-Url: https://codereview.chromium.org/2323563002 Cr-Commit-Position: refs/heads/master@{#418635}
-
thomasanderson authored
This CL removes all calls to XSelectInput, or XCreateWindow using CWEventMask, from the browser process that uses the main X display (ie, the one returned by gfx::GetXDisplay()). Window event selection will instead by managed by XWindowEventManager. BUG=634084 Review-Url: https://codereview.chromium.org/2319933002 Cr-Commit-Position: refs/heads/master@{#418634}
-
dtrainor authored
- Add a full integration test that spawns both an engine and client in the same process and validates that the rendering pipeline produces the correct thing. - Also add Linux support for BlimpContents and exposed a BlimpContentsView, which is required to gain access to the right classes to validate the rendering path. Marking this as NOPRESUBMIT because there are some ScopedAllowIO calls during test setup and client tear down. Please feel free to revert or ping me on any landing issues. BUG=644262 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2320923002 Cr-Commit-Position: refs/heads/master@{#418633}
-
oysteine authored
TBR=nednguyen@chromium.org BUG=646925 Review-Url: https://codereview.chromium.org/2340033002 Cr-Commit-Position: refs/heads/master@{#418632}
-
timvolodine authored
This patch enables caching of spellcheck results to improve performance and address issues mentioned below. In its current state i.e. without caching spellcheck on Android and Mac has a number of issues e.g.: - selection (click) of words or movement of the caret can result in unnecessary calls to the platform spellchecker. - typing of non-word characters in the end results in unnecessary calls to the platform spellchecker. - modifying text does not always result in invocation of spellchecker, hence not showing the misspelled words. BUG=583616, 629609 Review-Url: https://codereview.chromium.org/2317113004 Cr-Commit-Position: refs/heads/master@{#418631}
-
sdy authored
BUG= Review-Url: https://codereview.chromium.org/2344583002 Cr-Commit-Position: refs/heads/master@{#418630}
-
kenrb authored
As the mouse cursor moves across OOPIF boundaries, elements in other processes that have certain mouse event handlers might require notification in order to fire those handlers. An example is MouseLeave, which is not currently fired when the MouseMove is directed to a parent frame. This CL tracks the last RenderWidgetHostView to receive a mouse event and sends appropriate events to other renderers when that changes. BUG=632035 Review-Url: https://codereview.chromium.org/2229463004 Cr-Commit-Position: refs/heads/master@{#418629}
-
yusukes authored
so that the function takes content::WebContents* instead of content::NavigationHandle*. That allows us to use the bubble view class outside the throttle. BUG=b:29079617, b:31406784 TEST=try Review-Url: https://codereview.chromium.org/2335313003 Cr-Commit-Position: refs/heads/master@{#418628}
-
avi authored
BUG=644268 TEST=none Review-Url: https://codereview.chromium.org/2339813004 Cr-Commit-Position: refs/heads/master@{#418627}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/8b1ed1614492..1f2489023f2b $ git log 8b1ed1614..1f2489023 --date=short --no-merges --format='%ad %ae %s' 2016-09-14 dsinclair Remove FFI_ from CPDFSDK_Environment method names TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2343673002 Cr-Commit-Position: refs/heads/master@{#418626}
-
sfiera authored
Nothing outside of MostVisitedSites needs to use it. Review-Url: https://codereview.chromium.org/2337893003 Cr-Commit-Position: refs/heads/master@{#418625}
-
boliu authored
BUG=619055 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2336803005 Cr-Commit-Position: refs/heads/master@{#418624}
-
pauljensen authored
Cronet API classes must be in org.chromium.net package and Cronet implementation classes must not be in org.chromium.net package. BUG=629299 Review-Url: https://codereview.chromium.org/2320413002 Cr-Commit-Position: refs/heads/master@{#418623}
-
dougarnett authored
[Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end device. Makes unit tests conditional on this check - ran unit tests on both svelte and regular devices locally. BUG=646888 Review-Url: https://codereview.chromium.org/2338313002 Cr-Commit-Position: refs/heads/master@{#418622}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61504ac2..798d1e3c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2340573003 Cr-Commit-Position: refs/heads/master@{#418621}
-
elawrence authored
When a Javascript: url is dropped on a tab, it executes in the security context of the selected tab, representing a script injection attack ("Dropjacking"). We will match other browsers and disallow such drops. BUG=639750 Review-Url: https://codereview.chromium.org/2323273003 Cr-Commit-Position: refs/heads/master@{#418620}
-
sbc authored
This is temporary measure to get the NaCl SDK bots building again. BUG=646666 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk Review-Url: https://codereview.chromium.org/2334303003 Cr-Commit-Position: refs/heads/master@{#418619}
-
dtapuska authored
There was potential that a stream events could enter rAF while it was being processed. This was an initial design consideration but after talking with an external partner it appears that probably we should just process what is queued. This gives the benefit that only one type of a given event will be processed during the callback. BUG=625693 Review-Url: https://codereview.chromium.org/2342603003 Cr-Commit-Position: refs/heads/master@{#418618}
-
megjablon authored
Unit tests for both the PreviewsInfoBarDelegate and PreviewsInfoBarTabHelper. Verfies that the infobar shows with the correct strings and only shows once for a page. BUG=615566 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2266653002 Cr-Commit-Position: refs/heads/master@{#418617}
-
brusi_roy authored
BUG=644626 Review-Url: https://codereview.chromium.org/2330543002 Cr-Commit-Position: refs/heads/master@{#418616}
-
krasin authored
BUG=645295 Review-Url: https://codereview.chromium.org/2338013006 Cr-Commit-Position: refs/heads/master@{#418615}
-
msw authored
Revert of Enforce capability spec renderer <--> browser (patchset #14 id:260001 of https://codereview.chromium.org/2259903002/ ) Reason for revert: Numerous failures; some examples: https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/10021 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/45903 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/36939 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/70401 Potentially related: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/28370 Original issue's description: > Enforce capability spec renderer <--> browser. > > This implements: > > - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer. > - adds such an overlay to chrome/browser > > So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review. > > R=rockot@chromium.org,tsepez@chromium.org > > Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3 > Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba > Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a > Cr-Original-Original-Commit-Position: refs/heads/master@{#418282} > Cr-Original-Commit-Position: refs/heads/master@{#418398} > Cr-Commit-Position: refs/heads/master@{#418582} TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2342523003 Cr-Commit-Position: refs/heads/master@{#418614}
-
rdevlin.cronin authored
SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - feedback_private - file_manager/private_api_drive - file_manager/private_api_misc - file_manager/private_api_strings - file_manager/private_api_tasks - file_system - file_system_provider BUG=634140 Review-Url: https://codereview.chromium.org/2335213004 Cr-Commit-Position: refs/heads/master@{#418613}
-
msw authored
Revert of Fix webkit_tests by adding two more interfaces they expect. (patchset #1 id:1 of https://codereview.chromium.org/2339703003/ ) Reason for revert: Reverting this and https://codereview.chromium.org/2259903002 I'll post more details on the other CL Original issue's description: > Fix webkit_tests by adding two more interfaces they expect. > > TBR=rockot@chromium.org,tsepez@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/5a3bcc8be6b98f0084ad3cbf45045cfa4f848e3c > Cr-Commit-Position: refs/heads/master@{#418600} TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2338163003 Cr-Commit-Position: refs/heads/master@{#418612}
-
joedow authored
This change adds a confirmation dialog for the It2Me Linux host. This dialog will be displayed when an incoming It2Me connection and will wait up to 60 seconds for the user to accept/reject it. If the user accepts the connection then we will complete the conneciton process, otherwise the incoming request will be rejected. BUG=645540 Review-Url: https://codereview.chromium.org/2343443002 Cr-Commit-Position: refs/heads/master@{#418611}
-
hanxi authored
This is caused in WebApkInstaller::OnSucess() which uses a local variable after deleting the "this" pointer. Therefore, a wrong package name is given to the infobar and the infobar believes the WebAPK hasn't been installed yet. BUG=646844 Review-Url: https://codereview.chromium.org/2338253002 Cr-Commit-Position: refs/heads/master@{#418610}
-