- 07 Nov, 2016 40 commits
-
-
martijn authored
BUG= Review-Url: https://codereview.chromium.org/2483733003 Cr-Commit-Position: refs/heads/master@{#430325}
-
ellyjones authored
This was removed some weeks ago in an update to the Harmony spec, but the code was never updated to match. BUG=635176 Review-Url: https://codereview.chromium.org/2477333002 Cr-Commit-Position: refs/heads/master@{#430324}
-
wangxianzhu authored
TBR=pdr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2477413002 Cr-Commit-Position: refs/heads/master@{#430323}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#430322} -
Matt Sarett authored
BUG=642462 R=scroggo@chromium.org Review URL: https://codereview.chromium.org/2482883002 . Cr-Commit-Position: refs/heads/master@{#430321}
-
skyostil authored
BUG=662959 TBR=perezju@chromium.org Review-Url: https://codereview.chromium.org/2484783002 Cr-Commit-Position: refs/heads/master@{#430320}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/470b5fa8f8db..9adabf886724 $ git log 470b5fa8f..9adabf886 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 npm Revert of Compile fuzzer sources in standalone builds. (patchset #3 id:40001 of https://codereview.chromium.org/2480043002/ ) Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2477403002 Cr-Commit-Position: refs/heads/master@{#430319}
-
guidou authored
BUG=648183 Review-Url: https://codereview.chromium.org/2476153002 Cr-Commit-Position: refs/heads/master@{#430318}
-
boliu authored
The flake is probably due to the test server re-using the same url for different test pages. Changed so that each test page gets a new url. Then found out the test is still flaky because apparently onPageFinished doesn't mean blink has committed the new page so it's hit-testable. So also wait for the page commit signal. This replaces polling for title in the test. BUG=662078 Review-Url: https://codereview.chromium.org/2475163003 Cr-Commit-Position: refs/heads/master@{#430317}
-
estade authored
NativeScrollBar used to wrap NativeScrollBarViews, but it was almost entirely a pass-through shim. Thus, now we just have one layer of views scrollbars called ScrollBarViews. BUG=662605 Review-Url: https://codereview.chromium.org/2480763005 Cr-Commit-Position: refs/heads/master@{#430316}
-
sl.ostapenko authored
BUG=662534 Review-Url: https://codereview.chromium.org/2480763003 Cr-Commit-Position: refs/heads/master@{#430315}
-
sky authored
Revert of Don't apply maximized window bounds workaround if bounds aren't changed (patchset #1 id:1 of https://codereview.chromium.org/2454053004/ ) Reason for revert: This resulted in a shortcut to move between monitors not working. See 656001. Original issue's description: > Don't apply maximized window bounds workaround if bounds aren't changed > > In HWNDMessageHandler::OnWindowPosChanging() was added code that > restores correct maximized window's bounds after attaching or detaching > additional display (see crrev.com/6bb7f819). But this workaround also > applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE > flags that leads to bugs such as crbug.com/659525 and crbug.com/655984. > > This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before > applying workaround and fixes this bugs. > > BUG=659525,655984 > > Committed: https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065 > Cr-Commit-Position: refs/heads/master@{#428368} TBR=atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659525,655984 Review-Url: https://codereview.chromium.org/2482933002 Cr-Commit-Position: refs/heads/master@{#430314}
-
rouslan authored
BUG=648051 Review-Url: https://codereview.chromium.org/2473053003 Cr-Commit-Position: refs/heads/master@{#430313}
-
riajiang authored
Reduce similar code in single-display screens. 1. ScreenBase doesn't set itself as the screen instance in display::Screen anymore, rather its subclass needs to decide if it wants to be the screen instance. 2. Moved Displays::iterator FindDisplayById(int64_t id); to private in DisplayList. 3. Fixed BlimpScreenTest since Display::SetScaleAndBounds also updates the work area of a display. 4. Fixed RenderWidgetHostViewAuraTest.PhysicalBackingSizeWithScale since added UpdateDisplay call in aura::TestScreen::SetDeviceScaleFactor. BUG=none, related to https://codereview.chromium.org/2361283002 TEST=covered by blimp_unittests, app_shell_unittests, content_unittests, unit_tests, mash_unittests, extensions_browsertests Review-Url: https://codereview.chromium.org/2431473002 Cr-Commit-Position: refs/heads/master@{#430312}
-
oshima authored
* If the raw device scale factor is lower than 1.0, shrink the font size further. BUG=646254 TEST=manual Review-Url: https://codereview.chromium.org/2441043002 Cr-Commit-Position: refs/heads/master@{#430311}
-
guidou authored
Users of device-change notifications are not yet using this. An upcoming CL will include wiring of the Blink devicechange event and PepperMediaDeviceManager to this and removal of the corresponding code in MediaStreamDispatcher and MediaStreamDispatcherHost. BUG=648183 Review-Url: https://codereview.chromium.org/2471543003 Cr-Commit-Position: refs/heads/master@{#430310}
-
boliu authored
Instead of have the parallel FrameFuture be held in RenderThreadManager and have the logic for waiting on the frame split between different places. BUG=662096 Review-Url: https://codereview.chromium.org/2481573002 Cr-Commit-Position: refs/heads/master@{#430309}
-
slan authored
The Cast Linux build will use this interface to provision devices from the "media" service. Move these classes into general subdirs and update BUILD.gn files so that these build on Linux. The only non-mechanical change in this CL is that content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter* instead of a RenderFrameHost*. This will allow more flexibility for content embedders like Chromecast to use this class. BUG=660736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2469863010 Cr-Commit-Position: refs/heads/master@{#430308}
-
yusukes authored
BUG=None TEST=try Review-Url: https://codereview.chromium.org/2473003005 Cr-Commit-Position: refs/heads/master@{#430307}
-
yusukes authored
BUG=b:31959560 TEST=click a link with a custom scheme, then press ESC Review-Url: https://codereview.chromium.org/2455733004 Cr-Commit-Position: refs/heads/master@{#430306}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/43513543de10..1c2ed9963fb8 $ git log 43513543d..1c2ed9963 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 reed remove xfermode legacy build flag for android 2016-11-07 mtklein update Vulkan docs for GN. 2016-11-07 halcanary fix svg compile 2016-11-07 liyuqian Combine analytic edges with tolerance 2016-11-07 msarett Finish color space support for SkCodec 2016-11-04 robertphillips Add GrTextureRenderTargetProxy and support switching between RT & Tex Proxies 2016-11-07 bsalomon Revert "Revert "Limit GL_TEXTURE_RECTANGLE filtering to bilinear."" 2016-11-07 borenet Fix iOS isolate 2016-11-04 halcanary gm: s/SkAutoTUnref/sk_sp/ 2016-11-04 halcanary bench, samples, etc: s/SkAutoTUnref/sk_sp/ 2016-11-07 brianosman Add/promote gamma helpers to SkColorSpace_Base Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2480313002 Cr-Commit-Position: refs/heads/master@{#430305}
-
stkhapugin authored
Notable changes: * crw_web_controller.mm used to have a dictionary storing selectors just for keeping the KVO code clean. ARC cannot call a selector from a string like this, because it cannot guarantee correct memory management in this case. So it was replaced with an array of observed key paths to keep some of the code cleanness, while the KVO callback has a huge switch. BUG=624365 TEST=None Review-Url: https://codereview.chromium.org/2434853002 Cr-Commit-Position: refs/heads/master@{#430304}
-
debugwang authored
0 and nullptr are both existing in FontCacheSkiaWin.cpp. use only nullptr. BUG=nobug R=pdr@chromium.org Review-Url: https://codereview.chromium.org/2471623005 Cr-Commit-Position: refs/heads/master@{#430303}
-
nasko authored
BUG=575230 Review-Url: https://codereview.chromium.org/2477063003 Cr-Commit-Position: refs/heads/master@{#430302}
-
mmenke authored
This is a relic of a bygone era, when URLRequestJob was refcounted, and could outlive its URLRequest. Now we can just delete the URLRequestJob. Also remove a couple checks in URLRequestHttpJob and ServiceWorkerURLRequestJob that their request is not NULL, as the checks are no longer needed, for the same reason. BUG=NONE Review-Url: https://codereview.chromium.org/2480563002 Cr-Commit-Position: refs/heads/master@{#430301}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2478843003 Cr-Commit-Position: refs/heads/master@{#430300}
-
sprang authored
Second take. Previous attempt (https://codereview.chromium.org/2440143002) caused quality regressions. sSpatialLayers[0].sSliceArgument.uiSliceNum = 1 is the workaround for now. BUG=chromium:614970 Review-Url: https://codereview.chromium.org/2475623002 Cr-Commit-Position: refs/heads/master@{#430299}
-
michaeldo authored
Remove the restriction that only a single state can be active at a time. This is to allow incognito and normal mode WKWebViews live side by side where they can be two active states at any given time. BUG=579264 Review-Url: https://codereview.chromium.org/2251023003 Cr-Commit-Position: refs/heads/master@{#430298}
-
tbansal authored
Separate out observation sources as either HTTP layer or transport layer. Majority of the current observation sources (e.g., cached estimate, external estimate) are not broken down by which networking layer they were computed at. This CL breaks down the observation sources by the layer (either HTTP or transport layer). e.g., this will be useful for observers to distinguish between a cached HTTP RTT estimate vs. a cached transport RTT estimate. when NQE caches both HTTP RTT, and transport RTT. As a side-effect, this CL will prevent the observers from distinguishing between the RTT from a TCP source vs. a QUIC source since both of them will now be bundled into NETWORK_QUALITY_OBSERVATION_SOURCE_TRANSPORT. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=490870 Review-Url: https://codereview.chromium.org/2453653002 Cr-Commit-Position: refs/heads/master@{#430297}
-
fsamuel authored
BUG=none Review-Url: https://codereview.chromium.org/2484483002 Cr-Commit-Position: refs/heads/master@{#430296}
-
mlippautz authored
Untangle TraceWrapperV8Reference from ScopedPersistent. This is required as the combination of vtable and templates makes it impossible to properly cast to the needed type. BUG=chromium:662303 Review-Url: https://codereview.chromium.org/2479133002 Cr-Commit-Position: refs/heads/master@{#430295}
-
kylechar authored
Run the following tests on linux_chromium_chromeos_ozone_rel_ng: 1. mus_demo_unittests 2. views_mus_interactive_ui_tests 3. views_mus_unittests BUG=642433,611473 Review-Url: https://codereview.chromium.org/2478633003 Cr-Commit-Position: refs/heads/master@{#430294}
-
fdoray authored
BrowserThreads are being migrated to TaskScheduler which doesn't support MessageLoop destruction observers. Destruction observers currently serve two purposes in ModelSafeWorker: 1. Set a "stopped" flag to true. When this flag is true, DoWorkAndWaitUntilDone() returns CANNOT_DO_WORK immediately. -> This is useless because all DoWorkAndWaitUntilDoneImpl() implementations already return CANNOT_DO_WORK when they are unable to schedule a task. For example, in BrowserThreadModelWorker::DoWorkAndWaitUntilDoneImpl(): // Note: PostTask returns false once the MessageLoop // running on the BrowserThread is destroyed. if (!runner_->PostTask( FROM_HERE, base::Bind(...))) { DLOG(WARNING) << "Failed to post task to runner " << runner_; error = CANNOT_DO_WORK; return error; } 2. Notify SyncBackendRegistrar that the MessageLoop was destroyed so that it can move the ModelSafeWorker to an inactive list. When all ModelSafeWorkers have been moved to the inactive list, SyncBackendRegistrar deletes itself. -> There is no reason to keep SyncBackendRegistrar alive after both SyncManager and SyncBackendHostImpl have cleared their pointer/unique_ptr to it. With this CL, SyncBackendRegistrar is deleted by a DeleteSoon task posted from SyncBackendHostImpl::Shutdown(). -> Deleting SyncBackendRegistrar causes the ModelSafeWorker references kept in |stopped_workers_| to be released. This is not dangerous since any object that still needs to use a ModelSafeWorker should have its own reference to it. BUG=650723 Review-Url: https://codereview.chromium.org/2471183003 Cr-Commit-Position: refs/heads/master@{#430293} -
lgrey authored
Per offline discussion, leaving "ChromeOS.MemoryPressureLevel" code in place for ChromeOS while history builds up in "Memory.PressureLevel" BUG=655304 Review-Url: https://codereview.chromium.org/2434103003 Cr-Commit-Position: refs/heads/master@{#430292}
-
msarett authored
Revert of Replace flaky smoke test (patchset #1 id:1 of https://codereview.chromium.org/2477013003/ ) Reason for revert: Still breaking the Android bot Original issue's description: > Replace flaky PNG smoke test > > The removed test is a bit slow, which I suspect is > causing flaky behavior on Android. The test that > is replacing it provides coverage of png decoding > and color correction. > > BUG=657839 > BUG=661769 > > Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 > Cr-Commit-Position: refs/heads/master@{#430270} TBR=dpranke@chromium.org,msarett@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657839 Review-Url: https://codereview.chromium.org/2479253002 Cr-Commit-Position: refs/heads/master@{#430291}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/660b1cf4a963..43513543de10 $ git log 660b1cf4a..43513543d --date=short --no-merges --format='%ad %ae %s' 2016-10-14 halcanary SkXPS: handle case where snapSpecial() returns null 2016-11-07 mtklein SkRasterPipelineBlitter: blitAntiH + full coverge --> blitH 2016-11-07 mtklein update ANGLE docs for GN, current test tools 2016-11-07 robertphillips Further centralize computation of GrSurface VRAM consumption - take 2 2016-11-06 mtklein GN: quiet alink spam on Mac 2016-11-06 mtklein GN: quiet link.exe warning spam. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2479223002 Cr-Commit-Position: refs/heads/master@{#430290}
-
lgrey authored
Based on shrike@'s work in https://codereview.chromium.org/989703002 The original change was reverted as a result of https://crbug.com/536170. The underlying issue (backgrounding affecting session restore) was fixed in https://codereview.chromium.org/1769123002, so this change mostly adapts the original code to the current state of the codebase and adds a new feature to gate it. BUG=460102, 536170 Review-Url: https://codereview.chromium.org/2454073003 Cr-Commit-Position: refs/heads/master@{#430289}
-
lizeb authored
Chrome connects to a bound service exposed by GSA, elevating its importance to the system (see the linked bug). This requirement is going away, and this CL is assessing the amount of memory wasted / saved this way. On a Nexus 5X, the cost of gathering this data has been measured (through Trace events) to be ~60ms of wall clock time (on a low-priority background thread), with ~2ms of CPU time on a little core. The data is gathered at most once per startup. BUG=614388 Review-Url: https://codereview.chromium.org/2477513004 Cr-Commit-Position: refs/heads/master@{#430288}
-
debugwang authored
NPAPI is not used in WebPlugin.h, remove it BUG=none R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2481213002 Cr-Commit-Position: refs/heads/master@{#430287}
-
blink-w3c-test-autoroller authored
Using update-w3c-deps in Chromium 89f010d8. TBR=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2476293002 Cr-Commit-Position: refs/heads/master@{#430286}
-