- 03 Oct, 2020 14 commits
-
-
James Vecore authored
We don't support caching share targets so this code removes an attempt to keep cached targets around which causes duplicates to show up in the ui. Fixed: 1133824 Change-Id: I3162cfffae59ca638b2b21e5f9adf6d4a2cc21a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446845 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813447}
-
George Burgess IV authored
These existed in the ebuild before for no particular reason. Having them sitting in Chrome seems more theoretically good, and fixes a small bug with some of our simplechrome builders (they weren't picking up the =20 or =30 limits properly, so they were doing =100...) Bug: 937821 Change-Id: I3f89354d377de2e4db7c1b11b644b07867d3b66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446818 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813446}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/16636f480f81..b3c1e71eb1cb 2020-10-02 nicolascapens@google.com Regres: List regressions before summary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4e28912a9d5510bbc5d35060f7077b3c0d0e38e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813445}
-
Haiyang Pan authored
the device usage looks in a good shape and should be able to run at 100%. See the capacity graph http://shortn/_mMR3m6J0Dr Also have weblayer_instrumentation_test_apk running on sailfish since the grash shows walleye capacity could be tight during peak time, while sailfish still has plenty room to hold more test. Bug: 1111436 Change-Id: I7fb68d6a6710a3d2c68fef3f6e54e23af433d2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446513Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813444}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If2c7e6aa62ced283dc88b1ed79f24d74ea8a8439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813443}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b8970cc0198..3b50b7c41123 2020-10-02 treehugger-gerrit@google.com Merge "Optimize the scroll_jank_cause_queuing_delay metric." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If61bf5f9f0e2c1f5b2c7c4263b730901ec844b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813442}
-
Leonid Baraz authored
Fixes were in https://chromium-review.googlesource.com/c/chromium/src/+/2444409 and https://chromium-review.googlesource.com/c/chromium/src/+/2446451 Bug: 1133962 Bug: b:169427520 Change-Id: I1586c801721a3d8f04035b01ce9ab95000454296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446835 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#813441}
-
Kevin Babbitt authored
This CL uses the parameter introduced in crrev.com/c/2438010 to serialize system colors either as keywords or as rgb values depending on whether computed or used value was requested. Bug: 1112362 Change-Id: I5dfca764f944789930c42c5d80338fca1437ea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436515Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813440}
-
Bettina Dea authored
This CL creates the actual controller for the Enhanced Protection promo on the NTP on Android and hooks it up to the Feed Surface. Also added metrics to track impressions and dismissal of the promo. This also creates a max impressions for SigninPromoController which will be controlled by an experiment. The first part was: https://chromium-review.googlesource.com/c/chromium/src/+/2423165 Bug: 1130739,1130735,1130745 Change-Id: I080e9c93f2f3b9e38dc397d97fee92525c2a0291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430263 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813439}
-
Bruce Dawson authored
The Windows build instructions for Chromium leads many people to assume that the --ide command is required. This change makes it clearer that it is optional, and also expands on how to use the alternatives. This also changes the recommend invocation of "gclient sync" to add "-D". Tested with https://markdownlivepreview.com/ Change-Id: Ia341f3021c320a4cf7a7071fb96f0464078baf3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444450 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813438}
-
Stephen Chenney authored
TBR: ikilpatrick@chromium.org Bug: 1045599 Change-Id: I35c8a5ac4e824816c9c16e252955d106bead5cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446777 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#813437}
-
Peter Kotwicz authored
Rename font-related Chrome resources to avoid resource name clash with internal Chrome library which duplicates the font resources BUG=1129255 Change-Id: I027e2295f5cbc173c9a0de235bcee30cd5b9b8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415533 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813436}
-
Leonid Baraz authored
Bug: 1133962 Bug: b:169427520 Change-Id: I899a35654fbbc91763b46e54350a447d17834581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446451 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#813435}
-
Zentaro Kavanagh authored
- Test each observer firing twice with the second explicitly triggered from the first. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I9c62c05710adb96ac912270bd08265fd9cd8b6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440218 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813434}
-
- 02 Oct, 2020 26 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4b0c039a1f1..e0d95b608dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128599,chromium:1131982 Tbr: kelvinjiang@google.com Change-Id: I327416c0a00424d28afe03633feab3beab5780ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445464Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813433}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2d9abef043b..c488f0c909e2 2020-10-02 jmadill@chromium.org Suppress flaky test on Win/Intel/GL. 2020-10-02 vantablack@google.com First pass at increasing inclusivity 2020-10-02 j.vigil@samsung.com Implement GL_OES_texture_stencil8 2020-10-02 jmadill@chromium.org Disable AMD OpenGL testing on Windows ANGLE tests. 2020-10-02 cclao@google.com Vulkan: Add a test and fix the bug with draw/invalidate/clear 2020-10-02 jmadill@chromium.org Skip ResizeWindowWithDraw test on all Linux. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1097198 Tbr: jonahr@google.com Test: Test: angle_deqp_egl_tests Change-Id: Ifc582e7ac5d4b95be03d4637bac147332970f54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813432}
-
Natalie Chouinard authored
These render tests had breaking UI changes introduced in https://crrev.com/c/2424506 and should have been re-baselined by incrementing the revision number (see https://crbug.com/skia/10795). Bug: 1131073 Change-Id: Idf9df5d43a6da8c80ae0c7ac5d1dcc0e88b59b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443400Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813431}
-
Etienne Bergeron authored
This CL is adding unittests for the Pause(...) and Resume(...) API. Fix potential bugs while calling pause/resume multiple times. The underlying platform implementations may not accept double pause or double resume. The related code pause/resume was not covered by previous unittests. Bug: 1133813 Change-Id: I396bed4e2356a3b4bcb8363f0f82d005436022bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446190 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813430}
-
Peter Kvitek authored
Adding this flag prevents sandbox_type.cc complaining about valid sandbox configuration missing in a command line. Change-Id: I076aaf51411c187e36f3b08f6eb5e50199b2b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446656 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813429}
-
Meilin Wang authored
This CL fixes the issue where the bubble size doesn't get updated after switching to another content view possibly with a different size. Screenshot before this CL: https://screenshot.googleplex.com/4GN26KQ6QC6jyo4.png BUG=1106937,1126208 Change-Id: Ie6dda62d93f4d1e5c09212426e8b55bfc5d30cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446773Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813428}
-
James Hawkins authored
This is necessary because Polymer 3 infra does not support flattenhtml. R=khorimoto@chromium.org Bug: none Test: OS Settings -> Networks -> Add Network -> See add wifi icon Change-Id: I8957b3d60aad33e13a785d2fef15922c10218abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446522Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#813427}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/data_reduction_proxy This CL was uploaded by git cl split. R=tbansal@chromium.org Change-Id: Idf2ab419bf07cd41493076a887390d93c1f8266a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435582 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813426}
-
Aaron Colwell authored
Moving logic from SiteInstanceImpl::ShouldLockProcess() and SiteInstanceImpl::DoesSiteInfoRequireDedicatedProcess() into SiteInfo, because these functions derive most of their behavior from information in the SiteInfo. These functions also represent what the process model should to with specific SiteInfos so it feels like these should be more closely associated with SiteInfo instead of SiteInstanceImpl. This change does not change any behaviour. - Moved SiteInstanceImpl::ShouldLockProcess() to SiteInfo and renamed it to ShouldLockProcessToSite() to make it a little more clear that this method indicates which SiteInfos should cause "is_locked_to_site" ProcessLocks to be used. - Moved SiteInstanceImpl::DoesSiteInfoRequireDedicatedProcess() to SiteInfo and renamed it to RequiresDedicatedProcess(). - Renamed ContentBrowserClient::ShouldLockProcess() to ShouldLockProcessToSite() and updated overrides so that naming is consistent. Bug: 1085275 Change-Id: Iaf9c036c3fe6d274640ee08377ce2e2fcca3d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427864 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#813425}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/77107392837f..8e5f2c0fe3e8 2020-10-02 jophba@chromium.org Speed up YABV tests by using smaller array of sizes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Idf73bbf68a4e8ad48d590c6ea4e00359170537df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813424}
-
Dave Tapuska authored
This moves the creation of the LayerTreeFrameSink into WidgetBase while minimally exposing some APIs on the blink platform. This allows us to move the android synchronous compositor frame sink also to be inside blink. BUG=1097816 TBR=tommycli@chromium.org Change-Id: Ie86b6923cb7cae2505d32ee922c5d03bb8198dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429224 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813423}
-
Siyu An authored
Bug: 1112095 Change-Id: I614ec70d4ba183850cd19412c963bd344b7c318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444800 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#813422}
-
Orin Jaworski authored
This CL includes data fixes for several languages to improve Pedal triggering. Issues resolved include: Stray capitalization, duplicate synonyms, synonyms consisting entirely of a single dash, separators consisting only of a single dash, empty cell gaps, and synonyms consisting entirely of ignore group synonyms. Bug: 11347706 Change-Id: Iabc8099db437e518ef2deea34fd41329985e5b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446823Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813421}
-
Jimmy Gong authored
Fully implements the DoNotDisturbController. This class is responsible sending and receiving states in regards to the DoNotDisturb feature of the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: I6a4fa96de5920711a7534ae7eff8bb33b9bb35b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439777 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813420}
-
Yi Gu authored
Currently when an SmsService has unhandled request upon destruction, e.g navigating away, we record "Timeout" as an outcome. This is misleading because "Timeout" should refer to the user consent prompt being timeout. This patch renames Timeout to UnhandledRequest and the follow up patch crrev.com/c/2427560 records the right Outcome.Timeout. Bug: 1127397 Change-Id: I151d5f087c416136bc042d12086df3185dbf2b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424894Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813419}
-
Hung Vu authored
This CL handles unit test for shouldSuggestDownloadLocation in DownloadDialogUtils. Change-Id: I39442ffe032550631c8f47f6ecc49529b489903c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446518 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813418}
-
Ben Pastene authored
Adds a `mb.py train` command that will dump json files for every builder (one file for each master) to a specified dir. And hook up `mb.py validate` to also validate the expectations. This won't actually generate the expectations. For now it's silently skipped if the expectations dir doesn't exist. Will create it in a follow-up. To see what the expectations would look like, see patchset 5: https://chromium-review.googlesource.com/c/chromium/src/+/2378273/5 Bug: 1117577 Change-Id: Iaa7be9201d26fe331620f0d666a03a6adbaa2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378273 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#813417}
-
Elly Fong-Jones authored
These methods express that the caller is passing in ownership of the delegate, and assert that the delegate believes it is owned by the widget. This change also corrects a flaw in ownership handling in an ash unittest: some of the created delegates were passed around as raw pointers, and one was sort of leaked (not actually leaked, but destroyed in an extremely non-obvious way). Bug: 1075649 Change-Id: I655dfe3e2466032b85247341f43b1b2d75c0b561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446015Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813416}
-
Peter Kasting authored
Also addresses c/b/ui/views/{read_later,web_apps}/. Bug: 772945 Change-Id: I71a0bb167c8eefb19624240536ca1d98dd2bfb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446022 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#813415}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d696086211d..a6ca9757d3a6 2020-10-02 brianosman@google.com Let skslc use more of Skia's core 2020-10-02 johnstiles@google.com Factor out Inliner candidate list assembly into its own function. 2020-10-02 brianosman@google.com Detect non-2D textures in MetalCodeGenerator and fail cleanly 2020-10-02 brianosman@google.com Fixes to array handling and interface blocks 2020-10-02 bsalomon@google.com Remove unused SkImage YUVA factories. 2020-10-02 fmalita@chromium.org [skottie] Auto-resize and VAlign support for point text 2020-10-02 egdaniel@google.com Remove some unneed read access from vk srcAccessMasks. 2020-10-02 ethannicholas@google.com Revert "Revert "moved SkSL FloatLiteral data into IRNode"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I2d8fe59a3c7347c5d1b8b6956f901edfc771c330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b9855ccf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic0381cd6dce3b49b5a10d911030b0c7effdbf94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446819Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813413}
-
Zentaro Kavanagh authored
- One test file was missed from CL [1] that split up tests [1] - https://chromium-review.googlesource.com/c/chromium/src/+/2442502 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5d52dbcc4b6e90fa8b22a059471167f6d10ef0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446389 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813412}
-
Andre Le authored
- Change the status order in the controller. - Use setter function for find my device status. BUG=1106937 Change-Id: I628512f3b13362acc69982a8df48c0e2ada23658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446969Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#813411}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ida267e2a5dfa7b70d0ea25e5a91a4a6cceafe555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446833Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813410}
-
David Bertoni authored
Bug: 1133034 Change-Id: Iec185526bfa222e601252d9a0e1e7cedde2988cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437307Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813409}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4036e35e8d8d8737a327d6133a193c810eb8e929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382595 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#813408}
-