- 27 Nov, 2018 40 commits
-
-
Max Moroz authored
Ran `tools/clang/scripts/upload_revision.py 346388 5`. Bug: 870331 Change-Id: Id09c926a34194487757e641283f63fb63a614436 Reviewed-on: https://chromium-review.googlesource.com/c/1351029 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#611214}
-
Lukasz Suder authored
When default Email is available (defined as email used to start Autofill Assistant) it is used to change the order of Profiles inside Payment Request. The Profiles containing this email will be displayed on top, making them a default choice. Bug: 806868 Change-Id: Iae54abcf009a563a120a6afa09ef02187a82abd8 Reviewed-on: https://chromium-review.googlesource.com/c/1350955 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611213}
-
Wez authored
This reverts commit 912050e1. Reason for revert: Fuchsia SDK believed to be the cause of these failures; speculatively reverting to re-enable the tests to evaluate. Original change's description: > Disable all tests in FrameImplTest. > > Almost all have been reported as flaky. Disable all to avoid having > reports coming in from whichever subtest was not reported yet. Caused a > lot of red jobs on the Fuchsia x64 bot. > > TBR=wez@chromium.org > > Bug: 907804 > Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d > Reviewed-on: https://chromium-review.googlesource.com/c/1349315 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610580} TBR=wez@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907804, 907859, 907717 Change-Id: I72103faff6457a93136925afdab9d7f003061369 Reviewed-on: https://chromium-review.googlesource.com/c/1351100 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611212}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/download. This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 589840 Change-Id: I60b22d3a7b65e614f6109a5d2a79baabe986724f Reviewed-on: https://chromium-review.googlesource.com/c/1351076Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611211}
-
Andrew Grieve authored
Now that r8.jar is checked in, this makes more sense. Bug: 872904 Change-Id: I629c830ec070452688e4eb08dbd02b4190232134 Reviewed-on: https://chromium-review.googlesource.com/c/1349753Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611210}
-
Matthew Mourgos authored
message Bug: 866686 Change-Id: I15d6c4fdb7bd9f609a0573f765393544b56f605b Reviewed-on: https://chromium-review.googlesource.com/c/1347574 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611209}
-
Dmitry Gozman authored
This flag is user-facing, should not have an expiration date. See [1] for an example. [1] https://developers.google.com/web/tools/chrome-devtools/ui#experiments Change-Id: I287a7707d3f896515ea65481e376df5ad16251fb Reviewed-on: https://chromium-review.googlesource.com/c/1351603Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611208}
-
Ken Rockot authored
This is a reland of a7291ad3 Original change's description: > Move audio service to new service APIs > > Migrates audio service and related test code away from using deprecated > service APIs (ServiceContext, ServiceTest, etc) in favor of better ones. > > Bug: 891780,906239 > Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f > Reviewed-on: https://chromium-review.googlesource.com/c/1345548 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610373} TBR=kinuko@chromium.org TBR=olka@chromium.org Bug: 891780, 906239 Change-Id: I300692ee9b4e6b26a9957944b38ddf8f468b165a Reviewed-on: https://chromium-review.googlesource.com/c/1348629 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611207}
-
Ella Ge authored
This CL adds a float value scroll_update_delta_ for GSU deltaY and a time component for last coalesced event to latency_info. And also adds implementation for Event.Latency.Scroll.AverageLag metrics, which measures an average distance represents the lag between finger movement and page scroll. detail of the metric see the design doc: https://docs.google.com/document/d/154jddNiKtxELBvrjLz9v6A7sA1J3iwQQzySHgtY12Oo/edit?pli=1#heading=h.zf3l6o8vecuv Change-Id: I64adef4ebf107185ad4fd1eeec276ea527e1c5ef Reviewed-on: https://chromium-review.googlesource.com/c/1239260 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611206}
-
Vaclav Brozek authored
The test PasswordManagerTest.ReportMissingFormManager executes a number of test-cases, and for each test-case, two runs, one with the old FormData parser, one with the new one. Each test-case can leave the PasswordManager in a state not expected by the next case, so it is good to reset the PasswordManager at the beginning of each run. This happens as part of setting the flags for the new parser automatically, but does not happen when the old parser is used. Thus, the tests failed if for each test-case the old parser was run first. This CL fixes that by ensuring that the PasswordManager is reset before each run. Bug: 907794 Change-Id: Id3ec0acf34d1a9d7b3530edd3eec0d6351fa4e1d Reviewed-on: https://chromium-review.googlesource.com/c/1350899 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#611205}
-
Katie D authored
Bug: 907180 Change-Id: Iad8aafe80e76d7f7ebfafacbccfdda48e1c4bbf5 Reviewed-on: https://chromium-review.googlesource.com/c/1344902 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#611204}
-
Anna Malova authored
Enqueue navigation events and send once a dynamic module is loaded even if there is no active CCT session. Bug: 902298 Bug: 902294 Change-Id: I3ab131b9ab78d4acf48f9959b5232fb6370a9019 Reviewed-on: https://chromium-review.googlesource.com/c/1349694 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611203}
-
Greg Kerr authored
This converts the V1 unit test, checking pasteboard access in sandboxed processes, to the V2 sandbox. Bug: 902597 Change-Id: Id11e2c597a55f9e66f45d1edf6b7c7bcb8396f57 Reviewed-on: https://chromium-review.googlesource.com/c/1327545 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611202}
-
Devlin Cronin authored
Update BaseSetOperators::insert() (and the related method APIpermissionSet::insert()) accept a unique_ptr as a parameter rather than a raw pointer. This makes it significantly more clear that ownership is taken as a result of the method call. Update all call sites appropriately. Bug: 907661 Change-Id: I08568711a01d7a371343dc9137aefedf86d43c7a Reviewed-on: https://chromium-review.googlesource.com/c/1347621 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611201}
-
Patrick Noland authored
Change-Id: Ic9bbedc769612b720ea6667a3736a29bc8b0c7c7 Reviewed-on: https://chromium-review.googlesource.com/c/1345412Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#611200}
-
Shu Chen authored
Bug: 842548 Change-Id: I42a81f539d57ec244f2583bbc8bda9126b11256e Reviewed-on: https://chromium-review.googlesource.com/c/1351197 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611199}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/passwords. This CL was uploaded by git cl split. R=vabr@chromium.org Bug: 589840 Change-Id: I4269a5dcd85ae4e00d275c30fd40b622cc03a1ba Reviewed-on: https://chromium-review.googlesource.com/c/1351951Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611198}
-
David Trainor authored
Somehow Animatable2.AnimationCallback#onAnimationEnd is being called on a background thread. This then tries to hit the compat version of LazyInstanceCompat#AutoRestartCompat to reduce code duplication and restart the animation. In this case we're building the AutoRestartCompat here, which has a local Handler variable that gets created. This causes a crash because Looper#prepare() wasn't called for this thread. I'm not quite sure why this is being called on the background, but we definitely should be creating the Handler for the main looper. Fixing that here. Adding NOTRY due to mac_chromium_rel_ng failure which is delaying this Android/Java only patch that needs to land for 71. All other try bots are passing without issue. BUG=905256 NOTRY=true Change-Id: I523dc9a2cb06a0d26d1acdba3106c93aa272cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/1351894 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611197}
-
Regan Hsu authored
Boolean histograms that capture the success rate for Smart Lock unlock during authentication and connection phase, and enum histograms that breaks down the failure reasons when Smart Lock fails to unlock during authentication and connection phase. Bug: 905438 Change-Id: I4aa35101949931bdd859f886d31e3a78c1412814 Reviewed-on: https://chromium-review.googlesource.com/c/1334227 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#611196}
-
Dmitry Gozman authored
Bug: 906483 Change-Id: I3da2cd45f2ab6e2d88e42c97f0de48208f210ad6 Reviewed-on: https://chromium-review.googlesource.com/c/1350966Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611195}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/b6e9e23e4e79..157bec8a25cc $ git log b6e9e23e4..157bec8a2 --date=short --no-merges --format='%ad %ae %s' 2018-11-26 bradhall Make sure to setup_googletest on all slices 2018-11-26 maruel [client] Add warning about variable flags 2018-11-21 maruel [client] Stop leaking dir 'cache' when running isolateserver_test.py 2018-11-20 maruel [client] internal refactoring adding ServerRef Created with: roll-dep src/tools/swarming_client R=bradhall@google.com Bug: 871453, 908551 Change-Id: Ia0d51cc0584d6df90b71722fbbc9a17bbbceb563 Reviewed-on: https://chromium-review.googlesource.com/c/1351743Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611194}
-
Ken Rockot authored
This fixes potential race conditions in AudioServiceListener resulting from the fact that a service instance can become unreachable (and may therefore be replaced with a new one) before it is officially designated as "stopped" by the Service Manager, even in the case of singleton services. The ServiceManagerListener API is augmented to convey a service instance's current running state via RunningServiceInfo. This is used by AudioServiceListener to more accurately track the running audio service instance. The listener now tracks the Identity of the most recently created audio service instance and responds to events accordingly. This also updates the logic and comments in resource_coordinator's ProcessMap to accurately reflect current guarantees of the ServiceManagerListener API, since these have changed slightly. NOTRY=true Bug: 818593,907898,908319 Change-Id: If3e8a35aa90db72a34c8f5f2d458f0f24c3447eb Reviewed-on: https://chromium-review.googlesource.com/c/1350649 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611193}
-
Hiroki Nakagawa authored
I manually changed only following files: - external/wpt/referrer-policy/generic/common.js - external/wpt/referrer-policy/generic/referrer-policy-test-case.js - external/wpt/referrer-policy/generic/subresource/shared-worker.py - external/wpt/referrer-policy/generic/template/shared-worker.js.template - external/wpt/referrer-policy/spec.src.json - TestExpectations Others were auto-generated. Bug: 835717, 906959 Change-Id: Ib0a84710fe94ba0893d9609bb708a3f5e8fd4091 Reviewed-on: https://chromium-review.googlesource.com/c/1343582 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#611192}
-
Ted Choc authored
This reverts commit 336bb21b. Reason for revert: From the comment on the bug, these failures were a red herring and the underlying issue was an auth one. If you have explicit failure logs that were these tests failing then please add them to the bug. Original change's description: > Sheriff: mark a few omnibox.UrlBarTest as flaky as the test suite flakes a lot. > > Bug: 908542 > Change-Id: Ibf9b8f2ac2c5bcdd14dcf65483d576fe61a3bf8d > TBR: tedchoc@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1351428 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610958} TBR=mlamouri@chromium.org,tedchoc@chromium.org Change-Id: I9df39181033b11a2ac8e3b0e8e395bdb0a626e1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908542 Reviewed-on: https://chromium-review.googlesource.com/c/1352336Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611191}
-
Mario Sanchez Prada authored
As explained in crbug.com/908121, we can't fix SigninManager::Initialize() to require a non-null local_state just yet as that would require manually fixing thousands of tests, so we're adding this transitional function to unblock work on crbug.com/906085 allowing to migrate from SigninManager::IsAllowedUsername right away without depending on those other changes. So, this patch implements a new helper function that will behave more similar to SigninManager::IsAllowedUsername on that it will only check the username against the specified pattern if (1) there's a non-null local state passed and (2) the pattern is registered and a value for it has been set, returning true otherwise. We also include an unit test for this helper function, to help with future refactorings if they happen. Bug: 906085 Change-Id: Idef663d07354fb086a5bc00b1ab447f1811c344d Reviewed-on: https://chromium-review.googlesource.com/c/1350895 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611190}
-
Ruslan Burakov authored
Currently there is only one non-standardized statistics "jitterBufferFlushes which will be exposed under the following origin trial: https://docs.google.com/document/d/1stYIZhEmDZ7NJF9gjjsM66eLFJUdc-14a3QutrFbIwI/edit?ts=5bf5535c# However, note that any other non-standardized statistics added later would be also exposed under this origin trial. Bug: chromium:907113 Change-Id: I4036dd1fceae3b68d33f9ae2666a0e2d942fb345 Reviewed-on: https://chromium-review.googlesource.com/c/1344433 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611189}
-
Matt Falkenhagen authored
Because provider hosts can be for workers as well as documents. Also rename UpdateURLs to UpdateUrls for typing ease and alignment with the style guide (acronyms are treated as a normal word). Bug: 908311 Change-Id: Ie4c7edaed41f8d89315a2ae4514880e8b3fdd2b0 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/c/1350422 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611188}
-
Tien Mai authored
- Implements crashpad support for GCPW installer - Implements crashpad support for the actual credential provider dll and runs the crashpad handler directly in the dll as an entry point Bug: 890348 Change-Id: I5b256b4d6ad8ee7153fd22e4d13f1a1791fa6d65 Reviewed-on: https://chromium-review.googlesource.com/c/1344210 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611187}
-
Dave Tapuska authored
API was using 64 bit integers which caused narrowing to access the arrays. Adjust the paint chunk API to use the correct type. BUG=879657 Change-Id: Ibbe16bd43937788fe3a706773826570e0626eb80 Reviewed-on: https://chromium-review.googlesource.com/c/1348989Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611186}
-
David 'Digit' Turner authored
This is a small cleanup of the TraceEvent class performed which is part of a larget bug allowing cleaning up and reducing the generated machine code for TRACE_EVENTXXX() macro calls (see related bug). A first CL to perform this refactor was submitted as [1], but later reverted because it made some tests fail mysteriously (see http://crbug.com/899813). So the original CL was split into several independent ones. A first CL was submitted as [2], which actually fixed some potential dangling pointer issues that were created from the Initialize() and MoveFrom() methods. This second CL removes this methods by making TraceEvent a proper C++11 movable type, which should prevent (or at least make it more difficult) introducing invalid states for its instances. The goal is to see if this introduces new unexpected test failures (which would indicate that there are still invalid instance states used in the code base). The third CL is [3] and re-introduces the TraceArguments helper class on top of this one. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1340308 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 BUG=898794 R=primiano@chromium.org,oysteine@chromium.org,alexilin@chromium.org,chiniforooshan@chromium.org Change-Id: I2b36885e2485d23cca199c48b2bd07d5745b00c5 Reviewed-on: https://chromium-review.googlesource.com/c/1346305 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611185}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1c194decd51..6b3d18164b4a git log f1c194decd51..6b3d18164b4a --date=short --no-merges --format='%ad %ae %s' 2018-11-27 terelius@webrtc.org Remove unused BWE field trial strings. 2018-11-27 kron@webrtc.org Add setters to ColorSpace class 2018-11-27 crodbro@webrtc.org Specific pacing configuration. 2018-11-27 ilnik@webrtc.org Various VP9 high fps fixes 2018-11-27 danilchap@webrtc.org Populate VideoSendTime extension network2 field when configured 2018-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 208bb982..81c26a09 (610939:611047) 2018-11-27 mbonadei@webrtc.org Fix wrong forward declaration namespace. 2018-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 00f78b5b..208bb982 (610831:610939) 2018-11-26 michel.promonet.1@gmail.com add cstring include need for strncmp 2018-11-26 steveanton@webrtc.org Small cleanup to mediasession_unittest.cc 2018-11-26 ouj@fb.com Rebase std::is_trivially_* with absl::is_trivially_* 2018-11-26 jonasolsson@webrtc.org Bump variable sizes in response to fuzzer bug 2018-11-26 saza@webrtc.org Add AudioProcessingCaptureStats and a level estimator replacement 2018-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7579fcbc..00f78b5b (610728:610831) 2018-11-26 nisse@webrtc.org Delete ChannelSend::RegisterTransport, replacing by construction argument 2018-11-26 phoglund@webrtc.org Add magjed as owner of rtc_tools. 2018-11-26 danilchap@webrtc.org In ReceiveStatistics use monotonic clock instead of ntp clock 2018-11-26 robin@opticaltone.com Add a new Task Queue for WinUWP. 2018-11-26 saza@webrtc.org Delete the WebRTC.Call.TimeSendingAudioRtpPacketsInSeconds metric 2018-11-26 danilchap@webrtc.org In ReceiveStatistic require callbacks during construction 2018-11-26 emircan@webrtc.org Reland Profile 2 to default profiles Created with: gclient setdep -r src/third_party/webrtc@6b3d18164b4a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:904909,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1848d2b4a6fc7fd65655128454244ec7f0916727 Reviewed-on: https://chromium-review.googlesource.com/c/1352235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611184}
-
Clark DuVall authored
These are about to expire, and we will probably want to collect data for a little longer. Bug: 904568 Change-Id: I9ebe814cd5ebe5de3dec10eca3efedb2c7bb94bb Reviewed-on: https://chromium-review.googlesource.com/c/1351586Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611183}
-
Xi Cheng authored
Bug: 903972 Change-Id: Ib70702de4cda80970454fd5d8c296855673698cb Reviewed-on: https://chromium-review.googlesource.com/c/1347145Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#611182}
-
Mike Wittman authored
Reporting has been enabled at 100% server-side for ages. This flips the client default so we can avoid sending the experiment state. Change-Id: I2c88ce73fbf23c83e4572d9db3c72bbda28a8243 Reviewed-on: https://chromium-review.googlesource.com/c/1351379Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611181}
-
Justin Cohen authored
- Work around pushState changes that overwrite the navigation item title on pushState. The root cause of the bug is crbug.com/908173. - Correctly set navigation item titles on restore. Bug: 854174, 872211 Change-Id: Ife407429d7f2723fc9dac6458bf81bdb1ae64ff8 Reviewed-on: https://chromium-review.googlesource.com/c/1349776 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611180}
-
Xi Cheng authored
Change-Id: I58a6a878b511e9ab2c27088ffc0c8069cf39b473 Reviewed-on: https://chromium-review.googlesource.com/c/1347311Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#611179}
-
Wez authored
Enable re-use of these helpers across different test suites, by putting them in their own header & cc. Bug: 893229 Change-Id: I1d239baf708226d08a25a0aa741e8c5f6d0cf1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1334559 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611178}
-
Mihai Sardarescu authored
This CL fixes a condition that triggers clearing the primary account when the SigninManager initializes if there is no primary account set. Bug: 907114 Change-Id: I0f6c515b53cad2e6c12804469fd5b952bd05ca68 Reviewed-on: https://chromium-review.googlesource.com/c/1345079Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#611177}
-
agrieve authored
Based on java@ discussion: https://groups.google.com/a/chromium.org/d/topic/java/9WZLCc14oss/discussion Bug: 149440 Change-Id: Ie36166fe2282af564daafb13fbcb91af1a4ab6c1 Reviewed-on: https://chromium-review.googlesource.com/c/1344889Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611176}
-
Ben Smith authored
All methods that have a parameter with the FlexibleArrayBufferView extended attribute support AllowShared. In other words, it is possible to use them with an ArrayBufferView backed by an ArrayBuffer or a SharedArrayBuffer. This CL makes this an explicit requirement in the IDL file. Currently only WebGL APIs use the FlexibleArrayBufferView extended attribute. Bug: chromium:905449 Change-Id: I52f23d4ee07c169a525243f00dd8a96a58ce7075 Reviewed-on: https://chromium-review.googlesource.com/c/1345125 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611175}
-