- 13 May, 2020 40 commits
-
-
John Delaney authored
Adds about flag entries for enabling the API as well as the debug mode version. Exposed for developer testing. Bug: 1082421 Change-Id: Ib68277248ba35c563932d7d296cce6b74e77ad66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198645 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#768515}
-
Nicolás Peña Moreno authored
This CL addresses a forgotten nit from https://chromium-review.googlesource.com/c/chromium/src/+/2191238/2/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-test-utils.js#125 Change-Id: Ibf5d168d912294b1a5df4099c4d8c269ae505a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199689 Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#768514}
-
Matthew Mourgos authored
Currently the shelf navigation setting is supposed to be hidden on clamshell-only devices. PowerManagerClient is used to detect when tablet mode is unsupported but has not been accurately been detecting when this is the case. After discussion with UX, it has been decided to instead only show the setting when in tablet mode. This will ensure that clamshell-only users are not shown a setting intended for tablet mode users. This change removes usage of PowerManagerClient and instead uses ash::TabletMode::Get()->InTabletMode() to determine when the shelf navigation setting should be shown in a11y settings. ash::TabletModeObserver is also used so that when tablet mode is changed the setting is shown in tablet mode and hidden in clamshell mode. Bug: 1062213 Change-Id: I01a7c3946c557dc65eebd69b52b63240aa39461e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197868Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#768513}
-
danakj authored
This moves the main-frame-specific API off of WebView, and puts it on WebLocalFrame. We go directly there from TestRunnerBindings. To reset the value between tests we add TestRunner::ResetWebFrame() which is called from WebFrameTestProxy. This place can reset all things on the frame that may be modified by TestRunnerBindings during a test. TBR=rdevlin.cronin@chromium.org Bug: 866140, 1069111 Change-Id: I2e49b137bd7c9334972ec6b128921870d1fa5a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198680 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768512}
-
Jae Hoon Kim authored
"GetExistingDlcs" DBus method constant is in system_api now and can be used within dlcservice client files. BUG=none TEST=./unit_tests Change-Id: I347fbabef4691f69ec3482ffbf51cbe7c9b54c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199679 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#768511}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/16d3fc7f371e..c8465a614c30 git log 16d3fc7f371e..c8465a614c30 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 rwkeane@google.com Move Code Coverage to new FYI bot Created with: gclient setdep -r src/third_party/openscreen/src@c8465a614c30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I630b136678922e10ffd260bf6779b7fa990b8dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199427Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768510}
-
Gabriel Charette authored
This was already the intent of the method but it incorrectly returned false if there were sent messages but ProcessMessageHelper(msg) returned false (i.e. |msg| was kMsgHaveWork and there were no others). Extracted from https://chromium-review.googlesource.com/c/chromium/src/+/2185757/2 R=fdoray@chromium.org Bug: 1075960 Change-Id: I3a60b01598b15f3deea5aabd83112cf2ace5cabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185831 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#768509}
-
Tibor Goldschwendt authored
Creates the CSS var --ntp-focus-shadow describing the box shadow we customarily use to create a focus ring. Uses this new var throughout the NTP. Enlarges the focus ring of the voice search button to make it more similar to the local NTP. For promos still uses outline to create the focus ring since we haven't set up keyboard tracking in the promo iframe. However, colors the outline like the box shadow of other elements to make it look similar. Fixed: 1077445 Change-Id: I8cac5a976ee7e5af483f7162e8753584759b57e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195333 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768508}
-
Sinan Sahin authored
Bug: 1068727 Change-Id: I5470452fcdfd5d9b7310e65802ef2867326fb27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191376Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#768507}
-
Elly Fong-Jones authored
This change also adds a unit test to validate this behavior. Bug: 1081393 Change-Id: Ia7354b3cab0adbe0cf83f41084e0402073036446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199398 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#768506}
-
Abhijeet Singh authored
This CL makes quick_answers::UserConsentView share logic with QuickAnswersView via a common pre-target handler. This change also proposes handling context-menu, Quick Answers views are companion-views of which, in a more robust way by dismissing it whenever these views are closed. Corner-case scenario where the menu should not be dismissed (for example, QuickAnswersView should be displayed after acknowledging and dismissing UserConsentView) is handled by the pre-target handler providing a setter. Bug: b:151111996 Test: Tested on Atlas test device. Change-Id: I94fc256ca329787188315df8e71457e4530f4281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195338Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#768505}
-
Sonny Sasaka authored
Bug: None Change-Id: Idd225bb0aef666c2c1918229df84ac742ab033ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196485Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#768504}
-
danakj authored
R=avi@chromium.org Bug: 866140 Change-Id: I3cb68541e43d29205b9de2df8e1f390223143eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199611Reviewed-by:
-
Brian Sheedy authored
Always logs the goldctl output for the Pixel_DirectComposition_Video_VP9_YUY2 test. Gold's inexact matching does not appear to be properly auto-triaging images that pass with inexact matching, but goldctl is (correctly) reporting that the image comparison passes. In order to help debug the triaging issue, we want the goldctl output, which we currently don't log if the comparison was a success. TBR=ynovikov@chromium.org Bug: skia:10245 Change-Id: I11821bfe7c07c1a63573038189f363f22cc0fb5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199686Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#768502}
-
Brian Sheedy authored
Fixes swarming-related mixins not working on CrOS builders due to generate_buildbot_json.py using the wrong dictionary in one spot. Also switches several CrOS builders to use mixins instead of hard-coded swarming dimensions since it now works. Bug: 1080809 Change-Id: Idcde77f97c16a9039d719efd7d2fc750dbede885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200079 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#768501}
-
Joel Hockey authored
Crosh is now served as chrome-untrusted://crosh rather than as a componenet extension. This was partially in order to be able to gzip resources. The previous component extension will no longer work since resources at /usr/share/chromeos-assets/crosh_builtin are gzipped. TBR=calamity@chromium.org Change-Id: I839052f6b0a684593e647dd2abd246d19e8b00ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196626 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#768500}
-
Gayane Petrosyan authored
Bug: 993920 Change-Id: I76db89808d4b3e2868f5fa169032eec37626967d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199684Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#768499}
-
Abhishek Pandit-Subedi authored
This reverts commit 621cd9d9. Reason for revert: Removing chrome://flag for Bluetooth suspend (now default) BUG=b:149795111 TEST=Built Change-Id: I1b826ab8d8bacf04c5093afe7e2fcc28314acc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179769Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Alexandre Frechette authored
Bug: 1044196 Change-Id: I234d75dc1de8f7d4ccb964435442db567d0df93a TBR: twellington@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199479 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#768497}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib72b38b54bb068e2bffad9a42e5a0ef63fa14fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199814Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ca8802d27b8c..4a0e92ae5d49 git log ca8802d27b8c..4a0e92ae5d49 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 mthiesse@chromium.org Reland "Fix file list script listing '*' for empty directories" 2020-05-13 jbudorick@chromium.org devil: add pkill output to forwarder exception. Created with: gclient setdep -r src/third_party/catapult@4a0e92ae5d49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789,chromium:1076580 Tbr: nuskos@google.com Change-Id: If7eec20291dd0618b0ba254b2fa5df86a70072ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199719Reviewed-by:
-
Yichen Zhou authored
When window bounds changes (e.g. toggle between fullscreen mode and windowed mode), the content underneath the cursor changes. We found that the cursor didn't change correctly because this situation failed to trigger SynthesizeMouseMoveEvent(). We changed the condition of triggering PostSynthesizeMouseMove() and reset |synthesize_mouse_move_| when |move_hold_count| going to 0. We also found that the tooltip was wrong when toggling back to windowed mode. We updated tooltip not only when it's visible but also scheduled to show. Bug: 1041396 Change-Id: I1a51c0b658e97b2b67079f7be80afb4dc393efb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186362 Commit-Queue: Yichen Zhou <yichenz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Adam Langley authored
RSA keys could always pass through generically, but this change adds support to the virtual authenticator and for parsing them so that they can be exposed via getPublicKey[1] in the future. [1] https://github.com/w3c/webauthn/pull/1395 Change-Id: If927385dccd8c9bea9f1cc27f015c9cb3da2d8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197668 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#768493}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db76048acef1..fcbb1943453f Created with: gclient setdep -r src-internal@fcbb1943453f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1081356 Tbr: rogerta@google.com,dfried@google.com Change-Id: Ib57a591804bd92c91f752d18d3c10d90fbb188f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199425Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768492}
-
Clark DuVall authored
This runs the WebView compatibility tests in the bundle test suite in addition to the standard instrumentation test suite. I was worried bundles may mess something up here so want to make sure we have test coverage for both WebLayer and WebView loading in bundles. Bug: 1033098 Change-Id: I4a4bf3187d7328a7ba0481b20d80ca5d73966b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199685 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768491}
-
Nathan Zabriskie authored
Recent patches have added YUV to RGB conversion to RasterInterface to prepare for OOPR Canvas. This patch updates yuv_util to use this new capability and changes several call sites to match. Also consolidates PaintCanvasVideoRenderer::UpdateLastImage to create the result image in one location. Eventually the result image will conditionally be an SkImage based on the presence of GrContext. Bug: 1058992 Change-Id: Ibb24eb0518ffd440cf59c146cc928b3cca7077fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195002Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768490}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a3deb22..07d68fbc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6dc58624b0846df2312d669075334c462a093f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199543Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768489}
-
Manas Verma authored
If AutofillClient returns a nullptr for InternalAuthenticator, then treat that as IsUVPAA() == false, and avoid further calls to InternalAuthenticator. Bug: 949269 Change-Id: I2c9246844d1629426d5c89d81933e8e0253a248e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198646Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#768488}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c66681be4bc9..d748e1651af8 git log c66681be4bc9..d748e1651af8 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 sugoi@google.com Fix missing border update after Image blit Created with: gclient setdep -r src/third_party/swiftshader@d748e1651af8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I47b356bb56e339b8bc7e3ddbe6b711a956e3471e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199426Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b8d7e0009824..dcfb2338586c git log b8d7e0009824..dcfb2338586c --date=short --first-parent --format='%ad %ae %s' 2020-05-13 adlai@google.com Enable kernel caching in GrMatrixConvolutionEffect 2020-05-13 bsalomon@google.com Add workaround for TecnoSpark 3 Pro MIP mapping 2020-05-13 egdaniel@google.com Add GrContext getter to SkSurface. 2020-05-13 michaelludwig@google.com Simplify GrClip::getConservativeBounds() signature 2020-05-13 brianosman@google.com SkRuntimeEffect: Support late bound uniforms in raster 2020-05-13 egdaniel@google.com A flush and submit apis to public headers. 2020-05-13 borenet@google.com [infra] chrome_release_branch: maintain the last 3 branches 2020-05-13 brianosman@google.com Plumbing SkMatrixProvider into the raster backend Created with: gclient setdep -r src/third_party/skia@dcfb2338586c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I671c7d47149c5b069e55fbe4bcd1967f8b6115a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199428Reviewed-by:
-
David Bertoni authored
DeveloperPrivateApiUnitTest.UpdateHostAccessCheck was disabled for flakiness on ChromeOS, but it's no longer flaky. It passed 3000 iterations on multiple ChromeOS configurations with no flakes. Bug: 937355 Change-Id: Ia407ac24e6a79167d6003b3b6e74075490370ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197506Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768485}
-
John Delaney authored
This is a reland of 87691864 This change was reverted on https://crrev.com/c/2199924 as it introduced a flaky test. This was due to a simple error of passing "false" as debug_mode to a test which expects "true". This change fixes that and modifies the test a bit so that it is more likely to flake. This is not much better, but the function being tested is cheap so running it a bit more is not problematic. Original change's description: > [conversions] Do not use a noise provider in debug_mode > > Fixes flakes in ConversionsBrowsertest caused by a real noise > provider being used on conversiondata. > > The ternary used to allocate a noise provider is backwards, and should > use a null NoiseProvider in debug mode. > > Bug: 1082236,1082168,1082134 > Change-Id: Ibaa23ed16aaed1a80aa90f9e25a9ba8fd211f4bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198367 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768354} Bug: 1082236, 1082168, 1082134 Change-Id: I04dcdf69cec5a1e18c0982ef63a0b013f6104e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199925Reviewed-by:
-
Regan Hsu authored
Currently, hitting ctrl+F does not focus the new settings search input. This CL adds that functionality and resolves the assertion error. Fixed: 1079039 Change-Id: I6a8e518277b65ad675aacd98dbe828508993d9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199920Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768483}
-
David Bokan authored
The compositor does some basic hit testing on mouse moves in order to animate overlay scrollbars when the cursor is near the thumb. The way it does this is by hit testing a LayerImpl and then using FindScrollNodeForDeviceViewportPoint to find the associated scroller. However, FindScrollNodeForDeviceViewportPoint isn't well suited to this purpose. It's primarily used to target scrollers during a ScrollBegin and it accounts for whether or not a ScrollNode can be scrolled on the compositor. Scrollbar animations shouldn't be accounting for this. It also has some complex fallback behavior that is also likely wrong for scrollbars. Instead, we replace its use with a much simpler and self-contained HitTestScrollNode. This method simply returns a hit layer's ScrollNode, encapsulating the hit scrollbar case and correctly accounting for failed hit tests due to layer squashing. This is a small preparation for scroll unification as this method will be used for scroll targeting in that case. This change revealed a bug in the scrollbar animating code. Because FindScrollNodeForDeviceViewportPoint falls back to returning the viewport node if no layer is hit, hit tests outside the viewport would return the viewport scroll node. This is questionable for scroll targeting but definitely wrong for scrollbar animations. When the change was made, the ScrollBeforeMouseMove test started failing because it sets up a scrollbar outside the viewport and sends mouse moves to negative viewport coordinates. FindScrollNodeForDeviceViewportPoint is renamed to FindScrollNodeForCompositedScrolling to better reflect its behavior. Bug: 1047182 Change-Id: Idb20285872c0da0ef33a404cffca4fbe8347ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198598 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768482}
-
danakj authored
This moves the majority of TestRunnerForSpecificView methods over to TestRunnerBindings. Any methods that acted on the main frame or the focused frame are moved to act on the current frame instead to make them OOPIF compatible. R=nasko@chromium.org Bug: 866140, 1069111 Change-Id: I9af3666e6b56e27ca7cba7f37b9ce8594c9a3c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176102Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#768481}
-
Natalie Chouinard authored
Address lint issue by moving XML resource to the correct directory. Fixed: 1081236 Change-Id: I14a9cae34ee064e70bfe134afcac5e92842ef11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196833Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#768480}
-
Tom Anderson authored
libxcb has a separate length field for lists because it uses C-style arrays to implement lists. We use std::vector which has a length field built-in, so we can derive the length from that to send over the wire. However, the length field can actually be a general expression in xcbproto (eg. the sum of two other fields). In cases like these where it's tricky or impossible to derive fields from the length (eg. x + y = length has many solutions for x and y), the fields are left in the user-visible structures. BUG=1066670 R=sky Change-Id: I0db56e0b6582eddf903e7b8d8943533b2d7901f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189702 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Daniel Murphy authored
This CL adds a new method to AppRegistrarObserver, allowing clients to listen to when apps become locally installed (or not). This allows the app service to listen to this effect, and fire an app update appropriately with the new icon data. R=dominickn@chromium.org, loyso@chromium.org Bug: 1080370 Change-Id: Id138bbbc2035d046e6d11e342fe33b501652dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194335 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#768478}
-
Vincent Boisselle authored
Change-Id: I682665b6f914b786345b928b788bc5a9a39524a3 Bug: 1082457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199021Reviewed-by:
-
John Williams authored
This CL only makes it possible to start a presentation; more work is needed to make it possible to send message to the receiver. Bug: 1069126 Change-Id: Iffe72e3c142dd460817f08cc30f52a2651cfb181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180743 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768476}
-
