- 28 May, 2020 40 commits
-
-
Austin Eng authored
This tests SharedImage interop on Dawn's CQ and CI bots. It prevents changes in Dawn from breaking SharedImages in Chromium. CI bots: Dawn Linux x64 Release (Intel + NVIDIA) Dawn Mac x64 Release (Intel + AMD) Dawn Win10 x64/x86 Release (Intel + NVIDIA) Trybots: linux-dawn-rel mac-dawn-rel win-dawn-rel dawn-try-win10-x86-rel Bug: dawn:396 Change-Id: If3b649208450a60884ae970ae8c5f00761f5d565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219239Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#772524}
-
Rachel Carpenter authored
The language that is currently used in loadtimedata has had the region code stripped out. This means that we can't tell the difference between en-GB and en-US, or zh-CN and zh-TW. That means they fall back to english for our app. Using application locale solves this. Bug: b/157427039 Change-Id: Id83d420752aa9da0808652693194ecf6bc9b5702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215158Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772523}
-
Frank Liberato authored
GLImageDXGI should always have a d3d11 texture. This CL sets the texture unconditionally, even if an error occurs. Since error notification is asynchronous, the frame might still be drawn. Bug: 1077645 Change-Id: I72c9aab078fcc8facb72870f5b9be30dc7cfa01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217857Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#772522}
-
Hugo Benichi authored
Now that ArcNetHostImpl overrides chromeos::networkStatehandlerObserver NetworkPropertiesUpdated and fetches shill properties asynchronously, it is not necessary anymore to force NetworkState updates via chromeos::NetworkStateHandler to obtain properties that may be missing like IP configuration data. This patch removes this logic and partially reverts Change-Id I24d26d6492f133e0c38949c8c3b4403687bfac21 and Change-Id I2a39ba9c8d14cf42b6b0dbdd10c885bf5be09cfa. BUG=b:145960788 BUG=b:143258259 TEST=Flashed chrome, tested various connectivity setup with multiple networks, including L2TP connections and Chrome 3p VPN connections. Change-Id: I030a706740986d30830454a3308ea13a05790ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217276 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#772521}
-
David Munro authored
Records the type (e.g. sparse qcow2) of the user's disk. Emitted every time CrostiniRestarter is called, max once per 12 hours, since we care about user counts per histogram bucket, not restarter counts. Some disk types are vulnerable to disk corruption in certain scenarios so this metric tracks our progress in moving people off them and informs the priority of more pushy ways to migrate users. Bug: chromium:1072916 Test: Manual. Launch Crostini a couple times and check for 1x metric. Change-Id: I318449211e37d05bd043c5942c678ad694aa37ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214808 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#772520}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4348097fd4be..22534f2098e7 2020-05-27 michaelludwig@google.com Expose sk_FragCoord for runtime effects 2020-05-27 michaelludwig@google.com Store float value for settings in SkSL v2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Id446cbd631e81a7a54c18425226a6453d17d394c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772519}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590609462-f9ab96859e162a96cc1f1ba3f4ac827a4c53be85.profdata to chrome-win32-master-1590623692-fd13f36c8de9694ea1ca21c5ca06784931c585b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I513ec69ff80053a9fa8d2d067f55200dca3a53c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218660Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590594916-ea624ec669480df16e05aa1202066a2c230a60a5.profdata to chrome-win64-master-1590623692-442abbb1e080c04fab88844b2b8eca58e501203d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If904a3105e47d902c70cbf3c04c76c163a54350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218659Reviewed-by:
-
chrome://flagsTakashi Toyoshima authored
Now that the in-process configuration is not supported on desktops, and default on Android, we do not provide a flag at chrome://flags. The configuration can be modified through the base::Feature to run tests for Android on Linux, but it isn't supported configuration as well. Bug: 1087170 Change-Id: I5b0d41a8dec783524895d57dfee56ab80c24711d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215154 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772516}
-
Kenichi Ishibashi authored
This method will be exposed as a mojo method as a part of service worker storage migration to the storage service. Mojom doesn't support set so we need to use different container type. Use vector instead of set. Bug: 1055677 Change-Id: Ie16b729d078b549b177d7650b0da988a2cb97cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214875 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#772515}
-
Sreeja Kamishetty authored
!RenderFrameHostImpl::is_active() is used to check if the RenderFrameHost is either in the BackForwardCache or in pending deletion state. For cases when RenderFrameHost IPC handler or navigation related events starts with: if (!is_active()) return; This is problematic because ignoring the IPCs when the page is in the BackForwardCache might break the page. To avoid this, we evict the document from cache along with ignoring such calls to prevent discrepancies between the renderer and browser process once the page is restored from cache. This CL adds IsInactiveAndDisallowReactivation() method which returns true when RFH is either in pending deletion or in BackForwardCache and evicts the document from cache if it is called from BackForwardCache. This is part of effort to remove all |is_active()| occurrences and replace with the most appropriate method so that we don’t break pages and avoid unexpected behavior when a page is in BackForwardCache. For more information on inactive frame and back-forward cache please refer to: https://docs.google.com/document/d/1Q8vbcj0kQRukab_seqTJXVYDgpqLzWMOW_XnM6XitGk/edit?usp=sharing Detailed list of investigations for each is_active usage is presented in this spreadsheet: https://docs.google.com/spreadsheets/d/1TTzZ5r0m7nHBS_TkrEAdcFGs0M2iXO_tS0-lJmbQ3EY/edit?usp=sharing BUG=1073449 Change-Id: I82be7e38b3162e9bcd216c4376cf69b92101826e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183194Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#772514}
-
Ben Pastene authored
This reverts commit 3a8d37c3. Reason for revert: blocking uprevs; crbug.com/1087179 Original change's description: > chromeos: Add only the current SDK version's items to a test's data. > > Instead of adding every version of a given item, this will add only the > current version's. This is a bit tricky since individual versions of an > item are keyed by symlink. And since isolate doesn't follow symlinks, > we have to follow them ourselves. > > Bug: 1027382 > Change-Id: I6b3ea4ec15de3804e99fd6af768daac64f490d5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931155 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771959} TBR=thakis@chromium.org,dpranke@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027382, 1087179 Change-Id: Ie097ba50d36d7eba3865d5cee1775afd5d605354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219315Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#772513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/64cadfcf..47bf5f46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iba86646d79f94ac9acf8a388c379ca3b10d8a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217874Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772512}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590609462-0a980a885be44e446b55c280ee660f43e0ab11a0.profdata to chrome-mac-master-1590623692-0f578bc687b2561083fd54c973f9fd861443060a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3872e1740efd3b54198c5730aadb065d95c7b5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218657Reviewed-by:
-
Kai Ninomiya authored
Bug: 1084377 Bug: 1087130, 1087131 Change-Id: Iebd8bc4b8eaecbb379ae32bba374199662b6f274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218486 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772510}
-
Moe Ahmadi authored
Previously every <ntp-realbox-match> element listened for the entity images and favicons becoming available from the browser and picked up the entity image or the favicon that applied to them. This CL moves the listener for entity images and favicons up in the hierarchy to <ntp-realbox-dropdown>. This eliminates the race condition between <ntp-realbox-match> elements being up-to-date in the DOM and the entity images and favicons becoming available from the browser. This CL also adds tracking for BitmapFetcherService requests and cancels out of date requests in order to reduce chances of the service rejecting new ones. Signed-off-by:
Moe Ahmadi <mahmadi@chromium.org> Bug: 1086755 Change-Id: I1c9c07265f20abe93b40fedf1f49139eccc4492c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216883Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772509}
-
Jian Li authored
Bug: 1044139 Change-Id: I1952a1ab6f09dfe4c946dc3d81a5223262cc872f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219029Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772508}
-
Christopher Lam authored
Bug: 1018654 Change-Id: Idec68bbbcf642f7048d06490de765d423218a61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217511Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#772507}
-
charleszhao authored
Bug: 1012936 Change-Id: Ib5e6e015f19472573038da0b08d3488abb349c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210073Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772506}
-
Etienne Bergeron authored
This CL is fixing two issues related to text direction in RenderText. 1) There was no invalidation after appending text. Initially setting a direction neutral codepoint and calling GetTextDirection force the caching the neutral direction. After appending a strong codepoint, the direction may change. Thus, cached direction must be cleared. 2) GetTextDirection(...) was applied on layout text, and on display text. After eliding, they may not have the same direction. Also, if an external API call GetTextDirection(text) with the original text, the incorrect value was cached. This CL proposed to cache text_direction_ and display_text_direction_ separately. Bug: 1025561 Change-Id: I612c8d57ff14c11d1e0dcbf046fc6ab095cfb995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218566 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772505}
-
Kenichi Ishibashi authored
To figure out what an appropriate way to reduce OOM crashes. Bug: 848194 Change-Id: Ic74d6a496b5a8a38c2211f21622e527a3871acd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215800 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9129f940933f..f58d7039ba44 2020-05-27 chrche@microsoft.com Add customization to collect scripts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id08aff0c0b4c36ec6fbf4ab696f7fe303bc92873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218655Reviewed-by:
-
Alexey Baskakov authored
We should always return kBrowser to run not locally installed app as a tab. Bug: 1086369 Change-Id: I041190811ebd17aaca67790f50af9223cc45c991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217677Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#772502}
-
Joey Scarr authored
This is to enable the bot to be sheriffed. Bug: 1086320 Change-Id: I0e379f7b168ce3d13874a399d953c251bede8a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215763Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#772501}
-
Becca Hughes authored
This is a reland of b7d9656d TBR=dalecurtis@chromium.org Original change's description: > [Media History] Do not record background or muted watchtime > > Adds a fix so that Media History does not record > background or muted watchtime since they are not > useful to us (we only want foreground unmuted). > > BUG=1086511 > > Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771995} Bug: 1086511 Change-Id: I8bc4c8a4d73df513e8a1c48f772c7af9de256faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219109 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772500}
-
Mustafa Emre Acer authored
SafeBrowsing Delayed Warnings experiment can block a download if the current page has a delayed warning. In that case, this CL prints a message to the console. Bug: 1081317 Change-Id: Ib11dd687ef66eba1dc42e02f1929067f714bb4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215450Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772499}
-
Ken Rockot authored
Implements a test for backward-compatibility between any two versions of a mojom interface definition. Bug: 1070663 Change-Id: I832d7ecaf6d8b2c778eb9f1378f183c027585d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216910Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772498}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cdaf0be1f4ce..6e7ddb698ba0 2020-05-27 agable@chromium.org Remove agable from depot_tools OWNERS and TODOs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3e2023130e6d295798d20e14df6a4e153e569b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218650Reviewed-by:
-
Moe Ahmadi authored
The crash in crbug/1086848 is likely due to the page method calls being handled before |autocomplete_controller_| is initialized. The page calls StopAutocomplete when the realbox loses focus. |autocomplete_controller_| *should* have been created when the realbox got focus in the first place. However, there may be edge cases around autofocus that could cause the realbox to get focus without QueryAutocomplete being called. Bug: 1086848 Change-Id: I4cc2f429a7420c6ba7f8dc66062e17fba8d40664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219105Reviewed-by:
-
Brian Sheedy authored
Adds "os", "os_version", and "os_version_detail_string" to the the JSON data that is uploaded to Gold when an image is compared. This will make it easier to tell what bot produced an image. Also adds "driver_version". Example output is "win", "win10", "10.0.18362", and "26.21.14.3102" respectively. Bug: 1086751 Change-Id: I8a722db102808502a8100d700942a8348d2b5c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218479 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. This CL is thus a no-op. These changes are required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This CL was uploaded by git cl split. R=djacobo@chromium.org Bug: 1026641, 968047 Change-Id: I0009714cea5659d154e7f278b18499e41ff745fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219169 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772494}
-
Vasiliy Telezhnikov authored
This CL handles adds handling of few more cases: * Small videos have bad matrix. We get small sizes likely because decoding errors * Shrink amount other than 1.0. This is best guess approach as there is no way knowing what shrink amount was used. * Empty matrix case (when either of scales is zero). Shouldn't happen outside of small size case. This CL also add fallback to visible_size if coded_size/visible_rect seem wrong or matrix was broken and adds DumpWithoutCrashing for that case. Bug: 1081695, 1086624, 1076564 Change-Id: Ife0b70bc85b9249fa2805df1db59733ac8cdbd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216731 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772493}
-
Trent Begin authored
Bug: chromium:1084295 Change-Id: Ia6f53b3f49a2472180e20f80fc189187fdda2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218575Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772492}
-
Yuichiro Hanada authored
This CL will prevent normal apps and web pages from intercepting the key. Bug: b:156526777 Change-Id: Id51309805f6478f9e8e3647241c2b4649bd0011c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212102Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#772491}
-
Giovanni Ortuño Urquidi authored
Adds some simple tests to ensure imported constants and constants specified in terms of other constants have the correct values. The CL used to do more, but https://crrev.com/c/2204846 made it all redundant. Bug: 1002798,1008761 Change-Id: I2de4b945848c8b4ad358fbcd296189c8d989cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839752Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#772490}
-
My Nguyen authored
Add the function based on design doc at http://go/e14s-autocorrect-window. Bug: 1068807 Test: Will add later in browsertest for the api Change-Id: I7e9c65af3598cbb6e0e3077d193f5a1f6555816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166228 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#772489}
-
Filip Gorski authored
Bug: 1075602 Change-Id: I37e8037ab6c362bd388c595fe278bdee34ebdf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198546 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#772488}
-
Yury Semikhatsky authored
Bug: 1085150 Change-Id: I4c69b33a89708ac2c7e3d9edf5d1ad3066facc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218485 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772487}
-
Nazih Almalki authored
Ack a pending surface early the client's scheduler to schedule frames for future surface changes This case happens when screen rotation takes place while there is an active frame when this takes place it has a unique signature of 2 consecutive submit frame requests with clients_needs_begin_frame_ is set (high) and 1st frame is not a new surface and 2nd frame is a new surface. Bug: 1060058 Change-Id: I7020d10aade334e7fda20749217747cea2a2c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190049 Commit-Queue: Nazih Almalki <nalmalki@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#772486}
-
Rouslan Solomakhin authored
Before this patch, the C++ payment app interface omitted app identifiers, minimal UI fields, and deduplication fields that are used on Android. It also required each individual app implementation to convert from PaymentDetails to PaymentRequestDetailsUpdate mojo struct, although Android performed the conversion in a central place and passed the Update struct to the payment app. These discrepancies prevented using a C++ payment app in Java (through a JNI wrapper). This patch adds the ID, minimal UI, and deduplication fields to the C++ payment app interface, implements the minimal UI and deduplication fields in the C++ service worker payment app, as well as changes the UpdateWith() method to accept a PaymentRequestDetailsUpdate mojo struct. After this patch, using a C++ payment app in Java (through a JNI wrapper) is easier. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I39146a08fcd74fe9a883c67107c8fc8cbc17a400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217847Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772485}
-
