- 19 Jun, 2020 40 commits
-
-
Yoichi Osato authored
This CL implements a part of https://fetch.spec.whatwg.org/#dom-request: " 37: If body is non-null and body’s source is null, then: 1. If r’s request’s mode is neither "same-origin" nor "cors", then throw a TypeError. 2. Set r’s request’s use-CORS-preflight flag. " Bug: 688906 Change-Id: Ie8bb1ba8ae9a3e4dca69d73b9de4078791d5f39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235132Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#780238}
-
Christian Dullweber authored
This string is an example for a valid content settings pattern. Most translations leave it untouched but some change the url to something that is not a valid example domain or breaks the syntax. Bug: 1095878 Change-Id: I95fa441d9c356fe55e893b6a3ea4f191e03fd9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249762 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#780237}
-
Andy Paicu authored
TBR=mfoltz@chromium.org Bug: 1096988 Change-Id: I04e9202842d4e4e8c9929f77087e58d2b2c0684d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253760Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780236}
-
Colin Blundell authored
This CL adds a basic test that the infobar container responds to scrolling as expected in WebLayer. To enable this test we also made the following changes: - Factored out some support for setting up scrolling in tests from BrowserControlsTest.java for reuse - Extended EventUtils.java's simulation of dragging to post the finger down/move/up events sequentially. This change is necessary to get the scroll events to be fully processed within //content and ripple out to the infobar container. Bug: 1093846 Change-Id: Ifb94f33c498a13d711336165029370e259e330c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247894 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#780235}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0436547843d6b2b0d311ef29fb454b45524fb413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780234}
-
Dominic Battre authored
TBR=drubery@chromium.org Bug: 1068623 Change-Id: I7dafe5af78aa2d898d748df74842ede742b0e504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253759Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#780233}
-
Oleh Lamzin authored
Expose empty Mojo probe service to Telemetry Extension. The Telemetry Extension is a prototype System Web App only installed on non-official builds and only if the chromeos::features::kTelemetryExtension feature is enabled. The exposed Mojo APIs are being used to prototype the app. In the final version, it's quite likely the APIs will be exposed a different way e.g. Extensions or Web APIs, which will go through security review. Bug: b:158658869 Test: existing browser test verifies that we don't crash when bind to service Change-Id: I4e0ebf5b74559cb2b11955dce2ba975c0fff94ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235716Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#780232}
-
Koji Ishii authored
FragmentItem keeps all inline items in a flat list. When inline box fragments are nested, |CreateBoxFragment| handles the same item twice; once for its parent and another for its grand parent. This patch fixes this by skipping non-direct children. Bug: 1096957 Change-Id: If5acba0c5bd687d156cc4530fbe6123bca9840ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251643Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780231}
-
Omid Tourzan authored
It clamps the banner text in case of passing the limit and adds ellipsis at the end, so the banner text doesn't overflow over/under the sibling elements. There is line-clamp property made for this purpose to do it simply by css, and it's built on -webkit-box display. As webkit-box deprecated, the css presubmit fails. https://www.chromestatus.com/feature/5680142707851264 https://gist.github.com/bfgeek/b1dc3cb741681523ae043045411eb526 So the other solution is setting the property through the js code while presubmit process updated. Comparing patchset 2 and 5 shows the difference. Tested RTL manually and it's fine. There was a change in behavior on line clamp recently supposed to be released in M85, as tested it works as expected. Bug: 1082539 Change-Id: Ie677b367eb9fa28704d89eda7ea54af9ba5a81bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251859 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#780230}
-
Mario Sanchez Prada authored
Instead of using a routingID for the |hit_frame_routing_id| field, let's use a frame token instead, which uniquely identifies a frame as well in a similar fashion to the routing ID, paving the way for future Onion Souping of content/renderer/accessibility. This also comes with a shorter term benefit, since we are in the process of removing AXContentNodeData and, along with it, the |child_routing_id| attribute that it's currently used to refer to a child frame being hit on RenderAccessibilityImpl::HitTest(). By using a frame token instead we can remove that dependency on |child_routing_id|, and therefore helpìng with the process of removing AXContentNodeData along with other AXContent* classes. Bug: 1094150 Change-Id: I2091abf6a5195ffd0128eeebc24c214eb5d5d254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251827Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#780229}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b76d781b4f8f..0ec56611a754 2020-06-19 mathias@chromium.org Fix stylelint path resolution on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46bbef7ff62aa9670ad8d2885d8253910643b39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780228}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/99651228b238..545d158a2ff9 2020-06-18 stevenperron@google.com Use structured order to unroll loops. (#3443) 2020-06-18 jaebaek@google.com Debug info preservation in dead branch elimination (#3425) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I6368917b890212225d048482f5fd484a6522c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780227}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c81f0b7b921f..e7ae237eb9e9 2020-06-19 syoussefi@chromium.org Vulkan: ANGLE_copy_texture_3d support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: CopyTexImage*Vulkan:Texture3DCopy*Vulkan:Texture2DArrayCopy*VulkanTest: Test: dEQP.KHR_GLES3/copy_tex_image_conversions_required_cubemap*cubemap* Change-Id: Id9612e2620abd4b706a8fa005ce66aac1828720b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780226}
-
Andy Paicu authored
TBR=drubery@chromium.org Bug: 1096975 Change-Id: I89b93e62d1dbb3d8d84c98cc7b75e047db4c2fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252006Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780225}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ia7798c8bba2eaf5c5bb27b27a9fd8a89ed19ff5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248574 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#780224}
-
Rune Lillesveen authored
This is a revert of [1] which causes at least one of potentially several missing image resources updates on Chrome internal pages. I have not been able to reduce these pages and understand how MatchedPropertiesCache is involved here. I have confirmed that this fixes the issue on chrome://downloads. This flag was necessary to reproduce issue 1094185: --disable-blink-features=CSSMatchedPropertiesCacheDependencies [1] https://crrev.com/bd57436c85636c1ff62fc83f0deca55282437c0a Bug: 1094185 Change-Id: I90c4660b5cd4aa095c072033d23bdf3304e3a48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252799Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#780223}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. TBR=sergeyu Bug: 1031540 Change-Id: Iefe53b4fbb4575b8b7bbf9d7ced13e742a4b910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249802Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780222}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/581c407cd20b..693e88ae8516 2020-06-19 enga@chromium.org Vulkan: consider VK_ERROR_OUT_OF_HOST_MEMORY an OOM error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4f47a63257028b9de431b849d6909a1f6b6f6c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780221}
-
Richard Stotz authored
Bug: 914488 Change-Id: I81a96bc4f395d82d7a0c1d804eef25a861eb1fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228152 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#780220}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8ee14407329b..d257440b81e5 2020-06-19 thestig@chromium.org Rearrange CFX_CSSSelector::FromString(). 2020-06-19 thestig@chromium.org Use more WideStringViews in CFX_CSSSelector. 2020-06-18 thestig@chromium.org Remove a TODO related to C++14. 2020-06-18 thestig@chromium.org Remove CFX_CSSSelector::set_next(). 2020-06-18 thestig@chromium.org Remove CFX_CSSSelectorType. 2020-06-18 thestig@chromium.org Make CFX_CSSSelector better match Chromium style. 2020-06-18 thestig@chromium.org Clean up CFX_CSSSelector: 2020-06-18 thestig@chromium.org Reset context after running CXFA_TextLayout::LayoutInternal(). 2020-06-18 virens@microsoft.com Add function to get FPDF_ANNOTATION from FPDF_LINK 2020-06-18 thestig@chromium.org Clang format the code base. 2020-06-18 thestig@chromium.org Mark more parameters in image loading code const. 2020-06-18 thestig@chromium.org Change several enums to follow the style guide. 2020-06-18 thestig@chromium.org Check input param consistently in FPDFPageObjMark_*. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:997412 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifb941c78e966a22f8b9f521634e135dc60c9a403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780219}
-
Andy Paicu authored
TBR=drubery@chromium.org Bug: 1096972 Change-Id: Ie7f263090e0b1810c22d3a0c4402a3edd23ca473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253741Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780218}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592524547-1d6c7cf94491bfcfe03077087e03362dbc4dc51a.profdata to chrome-win64-master-1592545853-4aad13dd3d5b31e6b22212a49c45cb09e0a49e05.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I07f17ab4f967f5471bf1e8ef4b90ce46317d476c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253718Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780217}
-
Nohemi Fernandez authored
Part of the cleanup effort to fully support the new sign-in architecture. Bug: 971989 Change-Id: Iddc3e58ecb08cb0bc7bbd4f74f9bc3e5af3f650c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251922Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#780216}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Icc338ca2394f1f32265d318ab7ea530784f4b29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249403 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#780215}
-
Rahul Singh (EDGE) authored
This CL adds support for Shortcuts Menu to be updated when an installed PWA's manifest is updated. Code in manifest_update_task.cc detects changes to the shortcuts member of the manifest. It then triggers a reinstallation of the PWA per the new info in the manifest. As part of this flow we Unregister the existing Shortcuts Menu with the OS and then Reregister it as part of the reinstallation flow. To help detect changes in the manifest, this CL adds new methods to AppRegistrar that help read existing ShortcutsMenu related info. These methods have been implemented for both BookmarkApp and WebApp systems. Testing: This CL adds Shortcuts Menu related browser tests in manifest_update_manager_browsertest.cc. It also adds new tests in web_app_install_task_unittest.cc for invoking UpdateWebAppFromInfo with Shortcuts Menu data. Design doc: https://docs.google.com/document/d/1KhHWikx1z-604LIjDKEdnL9MyezJklxM8kEYNnMLIQs/ Bug: 1087212 Change-Id: Ie825494ab137724e07e55bc12098cbfb386fb6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244111Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780214}
-
Hajime Hoshi authored
We are adding a new metrics related to back-forward cache e.g., first input delay after back-forward cache navigation happens. This CL is a preparation for that change. Bug: 1014174 Change-Id: I38549e4acb0659877bcd3aa976f0697a596e45dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246360 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780213}
-
Side Yilmaz authored
This CL replaces usages of |profile_key_util.cc#GetLastUsedProfileKey| with |profile_key_util.cc#GetLastUsedRegularProfileKey| in notifications classes. Note: This CL is only clean-up and does not change code behaviour. Bug: 1041781 Change-Id: Id4583df9615bded3a779834d9bf7a78e10ad5f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247773Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#780212}
-
Kenichi Ishibashi authored
This CL adds a storage operation called GetStorageUsageForOrigin() which calculates the total resource size stored in the database for a given origin. ServiceWorkerQuotaClient::GetOriginUsage() uses the new operation instead of GetAllOriginsInfo(). The motivation of this change is to eliminate unnecessary memory allocations and data conversions GetAllOriginsInfo() performs (see [1] for details). When the browser has many service worker registrations for different origins, these allocations/conversions have considerable performance impact. In my local experiment, this CL makes GetOriginUsage() ~10x faster when there are 15k registrations/origins (340-390ms -> 40-45ms). [1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA Bug: 807440 Change-Id: Ice16640811a0f9f92ac0a71134e7b5666b13e29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250141 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#780211}
-
Rachel Wong authored
This CL defines and implements the search service proxy API. - IndexProxy implements an interface that is a wrapper around an Index; - LocalSearchServiceProxy implements an interface that is a wrapper around LocalSearchService and owns various IndexProxies; - LocalSearchServiceProxyFactory is responsible for the creation of LocalSearchServiceProxies. Bug: 1092767 Change-Id: Icb2fa359fe9d05bc4ae5b5bc977550ed659e8262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249428 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#780210}
-
Andy Paicu authored
TBR=battre@chromium.org Bug: 1096966 Change-Id: I01e9d9d0acc27c8651b7a27bd09b132cd183914e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252193Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780209}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d25c77940d2..889563cbeb36 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fa3d64bf72d6 to c81f0b7b921f (6 revisions) 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7a1d99d0be42 to eb6824408d08 (3 revisions) 2020-06-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2adbb514 to 4a914f21 (507 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1096510 Tbr: djsollen@google.com Test: Test: Test: angle_perftests --gtest_filter="*Trace*" Change-Id: I1a8fe09803d08e91f185ea5495720f1576a37eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780208}
-
Alexander Dunaev authored
The drag handler delegate should receive the resulting drag and drop operation via its OnDragFinished, but the Ozone/X11 implementation returned 0 always. This CL fixes that. Bug: 1014860 Change-Id: Ie339b7c7beb374bc58d08a332c2b817b8dc0b04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253738Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#780207}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. By this CL, HistoryManager uses IdentityServicesProvider functions with the profile generated regarding to isIncognito parameter from the constructor. Bug: 1041781, 1075562 Change-Id: I04c0a14b5f9e912cda7fb34a581bea4d18023518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242078Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#780206}
-
Tal Pressman authored
For now, the only active strategy is a "no-op" strategy that has no effect on scheduling behavior. This CL also includes 2 implementations of strategies that (i) disables or (ii) de-prioritzes timer queues for non-main agents, if there are still main frames waiting for FMP. This CL also fixes a UAF bug exposed in frame_scheduler_impl_unittest: frame_scheduler_ was reset after delegate_, but could still access the "old" delegate. Now, the new delegate is created first, passed to the new (reset) frame_scheduler_, and finally delegate_ is reset. Change-Id: Ibd24fc742de5b048495af924122e2a095462f4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206301 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#780205}
-
Matt Falkenhagen authored
This adds initial support for doing full prefetching of subresources, beyond preconnecting to their hosts. The code is gated behind a feature flag kLoadingPredictorPrefetch. The PrefetchManager logic is strongly based on the PreconnectManager. But splitting them into two separate classes seemed cleaner overall. Bug: 1092329 Change-Id: I26b244105d59e8765fc24c109ec165b7def39f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235192 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780204}
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: Ibd0c765f6a6af28ae91eccdc69997bc53ee4abfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249400 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780203}
-
calamity authored
Bug: 1096670 TBR=ntfschr@chromium.org Change-Id: Id46aea904a83e918c0a819d604f24db4654723f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251782Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#780202}
-
Christopher Lam authored
This CL refactors the model to more closely match the data. In particular, the model used to be colors[mode][name] and is now colors[name][mode], which matches the data. This is in preparation for implementing opacities, a 'generate-dark-mode-only' mode, and dark-mode-agnostic properties. Other minor changes: - BaseGenerator.colors is now BaseGenerator.model[VariableType.COLOR] - ModeVariables now has methods that let it be used more like a dict() Bug: 1018654 Change-Id: I5422178053434b49ac64a6290983092cbbbf0ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245968 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#780201}
-
Tal Pressman authored
Change-Id: I9689fd0a2501e810e0ea1ac91d8042e697b5f422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253599 Commit-Queue: Tal Pressman <talp@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#780200}
-
Alexander Alekseev authored
This adds settings page to Ash HUD and makes HUT semi-transparent. Just the HUD: https://screenshot.googleplex.com/ZBqYnQDomH5.png With the settings button: https://screenshot.googleplex.com/pNCfTAw9J92.png With settings UI displayed: https://screenshot.googleplex.com/SwyNb0xVDbc.png Bug: 1075612 Change-Id: I9f26e8b99f03e0d638f854312820f10ec25ee6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223974 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#780199}
-