- 29 Dec, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609124291-e7a0465f695fe158abf9ec0e9104d31fe42b886f.profdata to chrome-win64-master-1609221064-65e0288b21a9cea51e4f1fac1a8b654b327fc015.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6be5402fa1653bf63a397d32465415f4c1bf4964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839574}
-
Thomas Tellier authored
Bug: 1101326 Change-Id: I0a43e246b5e659f4e246bf0ec3eb32e3d627c1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603572 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839573}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f0df96659ae..5994a16ca076 2020-12-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b264ce95..0afd0128 (839451:839551) 2020-12-28 deadbeef@webrtc.org Correct "DSAWithSHA256" OID. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I913a3426afc8b6f2e45648f9ae89d6517d9b39a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839572}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/220642a93da1..095fd1d3ad25 2020-12-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e02e8b37 to aba6331a (134 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: If1498e4636469af2c292b9e23c46977a1a524dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839571}
-
Henrique Ferreiro authored
effectAllowed and dropEffect are limited to at most 9 different strings. Additionally, since drag-and-drop is only used in the UI thread, it should be thread-safe. Given these conditions, AtomicString will be more efficient and safe to use. This was mentioned as a TODO in https://bugs.webkit.org/show_bug.cgi?id=33607#c9. Bug: 1093536 Change-Id: I161ee9ad5d772aa70f0c2f7615abe23c0ec624c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599533 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839570}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I50448436c46e54a58698f5b117f5c1ee9c32da38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605592Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839569}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41dde25e96c5..2382e63de188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4db7d55eb7ff3a0cfae62c74e2a3061cecfc1b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604303Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839568}
-
Sergey Poromov authored
Some tests were already disabled in https://crrev.com/c/2605403 But others are still failing: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/19334/overview TBR=jdarpinian@chromium.org Bug: 1162117 Change-Id: I615aaba11b736e81c9051dc867c2605ddcdd1615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602435Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#839567}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bcfb0a5a..ef6c6121 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8e79cd0faaaef97317de4dfecff0dfcc3a688d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603466Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839566}
-
Sergey Poromov authored
The test is flaky: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Sample run: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21913/overview TBR=dmazzoni@chromium.org TBR=dtseng@chromium.org Bug: 1162238 Change-Id: I05ea294ec4cfb46761552b1fc972895444a7987b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605747Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#839565}
-
Kuo Jen Wei authored
This CL introduce following |#mode-selector| changes: 1. Set the fadding effect area to 24px. 2. Fine tune scrollbar height, color, border-radius. 3. Makes gap between |.mode-item| to 16px, 4. Remove 5px top/bottom padding of #mode-group, let the gap between scrollbar and |.mode-items| solely determined by top/bottom margin of |.mode-times| and avoid focus ring overlapped with scrollbar. Bug: b/172340037 Test: Manuall verify with UX spec. Change-Id: I52db56f1a309748d1bfcaa585143301e09ca7233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600432Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#839564}
-
Danila Kuzmin authored
Bug: 1156662 Change-Id: I2be68f5013ddad64c16c8036d53c0be9ef437e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600746 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839563}
-
Kuo Jen Wei authored
Bug: b/172340037 Test: Manuall verify with UX spec. Change-Id: I4b831b3e73314441793adf98f7e19fe4d2866906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596714Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#839562}
-
Sergey Poromov authored
This reverts commit 451e2db2. Reason for revert: All Mac builds are consistently failing after this CL: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/33289/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/12001/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/7041/overview Original change's description: > Add platform specific expected files for select-event.html test > > Bug: 1161590 > Change-Id: I17f1fadfba815efa42bff7afe7abc3f27960e533 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605394 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839496} TBR=jarhar@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org Change-Id: I12afff6389f413e076d58671c68711933092b017 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605746Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#839561}
-
Wei Lee authored
Since currently the layout in CCA does not support zoom in/out, we should prevent user from zooming-in/out in the app. Bug: b/176455103 Test: CCA is not scalable with pinch gesture or hotkeys Change-Id: Ib52fbe2264bc3ac8f4d99dbfb61548731fa85915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602306 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#839560}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I14b80c6dbdef7b48cf70bcfa32cf52430edfa892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606124Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839559}
-
rajendrant authored
TBR=mcrouse@chromium.org Bug: 1162052 Change-Id: I7fa97b383b8f70d5f17e277434874c6ac5c1779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604945Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#839558}
-
Alice Wang authored
This CL refactors the AccountHolder usage in FirstRunUtilsTest. Bug: 1161437 Change-Id: I3baac52615f15ce7457875526220f2cd9cc54748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603852Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839557}
-
Kuo Jen Wei authored
Fine tune the inner window size of 4:3/16:9/minimal to 788x538/788x428/505x428 px and left/right/bottom line to 44/50/44 px. Bug: b/172340037 Test: Manually verify with UX spec. Change-Id: Ia5761337cd3c0734bee30e8ba6bcccb0b67c2587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596713 Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#839556}
-
Noel Gordon authored
Add Content Security Policy (CSP) to file manager SWA frontend code to allow the Metadata Shared Worker code to load without error. That code loads from chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj, so add 'script-src' and 'worker-src' policy to allow code from that origin. Once those policies are specified, one also has to include 'self', and also 'chrome://resources' for scripts loaded from that source. Scripts chrome://resources/mojo/mojo/public/js/mojo_bindings_lite.js chrome://resources/polymer/v1_0/html-imports/html-imports.min.js would be blocked by CSP if their origin is not present in 'script-src' policy for example. Bug: 1113981 Change-Id: I524aa0e3dba5c4c5b6252eb1330cb19f152dec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602967 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839555}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609199712-53d931f587c8bfb3642e1d3559fa944b25ac41c0.profdata to chrome-mac-master-1609221064-1228ab180b0732d4cc578b7cded2cefd740548bb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia22bc04530147b552c29ceddc9a2ba52c99ad3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839554}
-
Colin Blundell authored
SubresourceFilterProfileContext will shortly be needed in the context of //weblayer. In preparation, this CL adds SubresourceFilterProfileContextFactory to //weblayer. The configuration of the class follows that of //chrome's configuration, with one exception: //chrome's factory integrates with history (via SubresourceFilterHistoryObserver), while //weblayer does not integrate //components/history at all. Bug: 1116095 Change-Id: I134b9c59d0f4bcc48c242bdeaba2033143ec8d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603571Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#839553}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609199712-7e463f0207d055b7b562c386dc767d4724824c2c.profdata to chrome-linux-master-1609221064-24424bfd2155989c442b2a02c4811561491f33e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2addfff1126d8361c2e16b83454ca0d76d032a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839552}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7c0ea8a48cf..41dde25e96c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: Change-Id: I80c71a537de260b0463532b9a89b20965adfb65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602254Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839551}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5a1f14e..bcfb0a5a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieae7becd5585cdfd62689084863aa9056598edae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605834Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839550}
-
Eugene Zemtsov authored
This reverts: https://crrev.com/670be8adae8396738fb2b9c3ba146b34ff578f38 The overread bug in libyuv has been fixed. Bug: 1158178 Change-Id: I3440b601fd0a49e5a8b21a7aeb11d04c4a40e471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605835Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#839549}
-
David Tseng authored
According to test output, the speech generated is slightly different than what's expected: pending speech utterances... "Select-to-Speak button Status tray, time 5:06 AM, ... Unsatisfied expectations... ExpectSpeechPattern("Status tray*") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc:186 Change the pattern to match accordingly. Original change's description: > Re-enable SelectToSpeakTest.SpeakStatusTray excluding official builds > > On official builds, the unified status tray appears to be inactive; test > always fails. Re-enable for non-officila builds, which still exercises > views UI + STS reading. > > R=akihiroota@chromium.org > > Fixed: 1158879 > Change-Id: I2fc7b4e6bb922c6d60aa819a73ce3a41b3afc003 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595491 > Auto-Submit: David Tseng <dtseng@chromium.org> > Commit-Queue: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837680} R=josiahk@chromium.org TBR=akihiroota@chromium.org, chromium-scoped@luci-project-accounts.iam.gserviceaccount.com, dtseng@chromium.org Bug: 1158879 Change-Id: Id2d9b301188fb2ee024d8d300eba3c33a2fed39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605296Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Josiah Krutz <josiahk@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839548}
-
Darwin Huang authored
Following up on https://crrev.com/c/2178473, remove unused flag descriptions. Bug: 926083 Change-Id: I4a6a97664da558836f091e7ab83118590ac8382b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600321 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839547}
-
Nicholas Hollingum authored
This allows E to be something like unique_ptr, where previously it could not be. Bug: b/175360169 Change-Id: Ibfbb1441763c1892feae988008ad6c2ccb5ff4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592244 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#839546}
-
Alex Danilo authored
Remove the faked out load time string data for the time remaining feature that is now enabled by default. No change in functionality. Bug: 953308, 1093603 Change-Id: I02b40501deb72d9c8aab639e710e3f4cb3c2dc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600435 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#839545}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I96004af70c5ae312dfc63c9b4304b298543820c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839544}
-
Lingqi Chi authored
RenderFrameHostImpl This CL adds a new param is_prerendering to LoadURLParams struct, the param indicates if the created navigation is a prerendering one. NavigationRequest stores the flag and shares the flag with RenderFrameHostImpl when committing a navigation to it. Please note that for now only the main frame of the page knows the prerendering state. More changes will be made in follow-up CLs. Bug: 1142658 Change-Id: Ib351172dadfcf1c46d08276bd3ef527e61a65a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583677 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#839543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41d57aeba946..f7c0ea8a48cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I24f0751a16a47128757396a009598f21774d88a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602843Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839542}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48107c9a..a5a1f14e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I946bf821f7d5c2e660c603494f7f3a187292a403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605615Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839541}
-
Dominic Mazzoni authored
This is just a pure refactoring to improve readability. AXTreeSnapshotterImpl is used in several places that don't depend on RenderAccessibilityImpl at all, so it really makes sense in its own file. This patch doesn't contain any unrelated changes, it just moves the existing code. Bug: 1161541 Change-Id: I691051b1902fcd79d4f77be86f81552ada5ada20 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602083Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#839540}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9882688674c5..b5f42f1dedca 2020-12-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id84146d30619ef56e3448483629e00de72151d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839539}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I89c036b33e34ac1bf24edf54718de1c316dfbf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605867Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839538}
-
Chris Lu authored
Bug: 790886 Change-Id: I42ce96ba15b3ba9d54e90a1333b1569a100cd8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576789 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#839537}
-
Sam Thorogood authored
This will later be used by a TSDoc generator. See https://github.com/GoogleChrome/developer.chrome.com/issues/61 for more context. Bug: N/A Change-Id: Id62ca4b340297b3e89705ba03d3fb5cd7caff093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596901 Commit-Queue: Sam Thorogood <thorogood@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#839536}
-
Jeevan Shikaram authored
Check to see if a browser is in Incognito mode before returning a DGAPI interface. Bug: 1159592 Change-Id: Ia1619ad87ff2dc3cd689801b1e014b7fe39f78b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596556 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839535}
-