GitLab

This reverts commit 6e85e7a4.

Reason for revert: crbug.com/1147678

Original change's description:
> Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar"
>
> This is a reland of ba7d8814. Two changes were made:
> 1) A null pointer check is added to AutofillSaveCardInfoBar.java, and
> 2) In AutofillUpstreamTest.java, startMainActivityWithURL() is replaced with loadUrl().
>
> Original change's description:
> > [AF] Add account indication footer to AutofillSaveCardInfoBar
> >
> > The footer is shown only to signed-in users have more than one account, and who do not sync.
> >
> > Screenshot with feature enabled in light mode:
> > https://screenshot.googleplex.com/ApVmkMVQakM6ai9
> >
> > Screenshot with feature enabled in dark mode:
> > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM
> >
> > Bug: 1135847, 1146186
> > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184
> > Commit-Queue: Anne Lim <annelim@google.com>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Reviewed-by: Matthew Jones <mdjones@chromium.org>
> > Reviewed-by: Jared Saul <jsaul@google.com>
> > Cr-Commit-Position: refs/heads/master@{#823710}
>
> Bug: 1135847
> Change-Id: Ifd9d514234a3af82330686373578f54ffd3427c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522219
> Commit-Queue: Anne Lim <annelim@google.com>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Jared Saul <jsaul@google.com>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825853}

TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com

Change-Id: I09677d00d3c73763eb0c95ba56fee01bedbb149a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1135847, 1147678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531084Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826176}

Records if the user has the Nearby Share feature enabled, and if not,
records why the feature is not enabled. For example, the feature is not
allowed by policy, or the user onboarded but later disabled the feature.
Emitted when the Nearby Share service starts. This happens at login for
the primary profile if the feature flag is on.

Manually tested all scenarios except disallowed by policy.

Bug: 1105579
Change-Id: I7674b70017069f5ee1a4f4afd5c0fe6c2cb7445c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523310
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826175}

After chrome.metricsPrivate fakes landed, CL:2500642 does not need use
these window.metrics fakes. Remove them.

Bug: 1113981
Change-Id: Iefcd5881a31a147e9387a9a175723a571412e5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531597
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826174}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/82f6a0e5..c6f52c21

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I854c1e174f62b38ad72d23b4ac7fcf8ea781c5af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530526Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826173}

This CL moves the logic to disable lite videos on seek
behind experiment parameter, and also disables that by default.

The param can be enabled again once we are reasonably confident
that it's not too aggressive and we can run an experiment to
verify that.

Bug: 1145646
Change-Id: Iedeb82abc1124568986f8d87cf92ef2f48c5eb2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524925
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826172}

Bug: 1129778
Fixed: 1145079
Change-Id: Ibb1b1aceff989163377d33a746a812268864e322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520481
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826171}

This commit adds PlatformSensor(Provider)ChromeOS in generic sensor for
chromebooks. They get data by registering a Sensor Hal Client to Sensor
Hal Dispatcher, and waits for a mojo connection to IIO Service.

BUG=chromium:1116940
TEST=unit tests and run on octopus

Change-Id: I63af90d8b617acb275e35422e2c667904c10b450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400398
Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826170}

adding Husain to reviewer just so it won't get submitted without him
giving +1 for the survey contents.

link to survey:
https://docs.google.com/forms/d/e/1FAIpQLSe5X3Al_esm00XL3jUMG78xD9_CSy9bdMl6XZWVfdUJP5wSqg/viewform

R=dalecurtis,hbengali@google.com

Change-Id: I0318d41fe444bad968711a0b1f1276b55e7a9494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522882Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826169}

Previously audio and video decryptor creation logic was not consistent:
audio stream decryptor was created in FuchsiaClearStreamDecryptor::Create(),
while video stream decryptor is allocated in FuchsiaCdm. This CL removes
Create() from FuchsiaClearStreamDecryptor and adds

FuchsiaCdm: :CreateAudioDecryptor().
Change-Id: I17b4ad0d9e8b0949de9951ec2534c15f678d2e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531053
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826168}

These tests were disabled for flakiness, but they exhibited no
flakes in 3000 iterations on the bots.

Bug: 658050, 660366, 875908
Change-Id: Id07368376216fdbe01a9b43351f5ec94925eccc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503311Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826167}

This CL removes uses of:
  DOMArrayBufferBase::DeprecatedByteLengthAsUnsigned
  DOMArrayBufferView::deprecatedByteLengthAsUnsigned

Because TypeConverters cannot signal failure, another layer of maximum
size checking under penalty of DOMExceptions needed to be added in
credentials_container.cc.

Bug: 1030717
Change-Id: I91598413d0762ffc5fa09d1cd19d79e2a5ce72de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213526
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826166}

Fixed: 1147136
Change-Id: Ic6ce9384eda8f59d4fbb223cbf2decb2e0ea668b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527857
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826165}

Correct a RFC reference and other tweaks to improve clarity.

Change-Id: I547b4f1c12cbae91fe3f58eed73428344e87dc65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531071Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826164}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

Bug: 1052397
Change-Id: Id409a4633f9ff666636e4e2fc47ed549c829c861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494283
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826163}

Add actual storage to the SWA chrome.storage fake, to allow removal of
of more "if (window.isSWA) {...}" code from CL:2500642. Implementation
code derived from

  ui/file_manager/file_manager/test/js/chrome_api_test_impl.js

Bug: 1113981
Tbr: Bo
Change-Id: I5dafeb94616ef9e051f8a3fb829f1204f039c69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529270
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826162}

https://skia.googlesource.com/skia.git/+log/7006e15df59d..480d950d3c3a

2020-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4ed9d3498dcf to 019feda602ec (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jlavrova@google.com
Change-Id: I1ec9104ff4d80b43f5391fb627c94ef99ee7470a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826161}

Bug: 1147192,1147526
Test: Resolves reproducible crash on a test device

Change-Id: Ie9dadf1b1165e32c45fa2878ca7cd11be823b384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527845Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Auto-Submit: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826160}

This is a reland of commit 933ec987, using GetProcAddress to locate ::GetCurrentInputMessageSource and skip loading it if the function is not supported by the Windows client (i.e. Win7).

Original change's description:
> Ignore rogue window management mouse move events
>
> Do not process window management mouse messages (WMMMs) when the pen is active over the client area.
>
> Windows sends window management mouse messages at the mouse position when windows open or close (e.g. Aura tooltips and Status Bubbles), including WM_MOUSEMOVE, WM_NCMOUSEMOVE, and WM_SETCURSOR. This is a longstanding Windows behavior designed to ensure that mouse cursor visuals and hover states update when the foreground window changes. However, this behavior does not extend to pen input, so WMMMs always come with the mouse coordinates instead of with the pen coordinates even if there is an active pen.
>
> In Chromium, WM_POINTER processing in the window non-client area are "promoted" to mouse messages in order to allow for interaction with the native window frame (e.g. resize handles, title bar, and window caption buttons). However, WM_POINTER messages in the window client area are handled as Chromium events without any mouse promotion; in this latter case, mouse position and pen position are not guaranteed to be in sync.
>
> Since Aura tooltips and Status Bubbles appear as custom windows on pen hover, opening/closing them causes Windows to send WMMMs. Consequently, users might see visual flickering as hover states flip back and forth between pen and mouse positions. In order to ensure that these WMMMs do not interfere with hover states, we must ignore such messages until the pen is no longer active.
>
> This change affects only Windows 8 and newer clients, which use the WM_POINTER API.
>
> Bug: 1147222
> Change-Id: I44335348f933f48edcfe665b396f133388169957
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525220
> Commit-Queue: Brian Liu Xu <brx@microsoft.com>
> Auto-Submit: Brian Liu Xu <brx@microsoft.com>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825665}

Bug: 1147222
Change-Id: I651ee271826a60ff33556cc472bbb86f5190a650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531066Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Auto-Submit: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#826159}

Bug: None
Change-Id: Icc993fb862f71b41b22e45e8c560332c53d8f621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531175Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826158}

On backward/forward navigations, backward/forward cache changes some
behavior around the navigation.

This CL updates a test navigation/back-to-get-after-post to work
with backward/forward cache.


Bug: 1132180
Change-Id: I86a99eddffbe8c25dc932258035214a60314b34b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520557Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826157}

This reverts commit 5f1112ab.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 826153 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVmMTExMmFiMDE4MDgzYmI3ZmQ4NzA0NDc3MGIyYWYwMmFjYzgwMDIM

Sample Failed Build: https://ci.chromium.org/b/8863951380802392720

Sample Failed Step: compile

Original change's description:
> [BreakoutBox] Add MediaStreamTrackProcessor
> 
> This CL introduces MediaStreamTrackProcessor, an object that allows
> exposing a MediaStreamTrack's media frames as a readable stream,
> enabling applications to perform custom processing.
> This basically allows the creation of a custom sink, in terms of the
> model proposed by the Media Capture and Streams spec [1].
> A MediaStreamTrackProcessor can be combined with a TransformStream and a
> MediaStreamTrackGenerator to effectively insert a processing step inside
> an existing track.
> 
> [1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings
> 
> Bug: 1142955
> Change-Id: I2a119f0c2ea9ce50432509286bd0f43758d8a272
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524322
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826153}


Change-Id: I39765bc5c0ae5ef193a9e6f805b2ba798a7e901c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1142955
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530595
Cr-Commit-Position: refs/heads/master@{#826156}

AutofillProvider uses WebContents's container getLocationOnScreen()
to transform the field's bund to screen coordinates before notify
the AutofillService focus change.

WebLayer intentionally leaves the space to it's top control, but
can't set the margin to ContentView which hosts the WebContents.

This patch adds RenderCoordinates.getContentOffsetYPixInt() API
for AutofillProvider to get the top margin.

Test: the autofill pop is in correct location, and I didn't see
side effect.

Bug: 1085294, 1135076
Change-Id: I163f67375e0177a5f75717a3069124ec2ff53894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523525
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826155}

Bug: 1145539
Change-Id: I27926823cbda91fcbec67ccd9828dd440c4d43d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517529
Commit-Queue: Yunke Zhou <yunkez@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826154}

This CL introduces MediaStreamTrackProcessor, an object that allows
exposing a MediaStreamTrack's media frames as a readable stream,
enabling applications to perform custom processing.
This basically allows the creation of a custom sink, in terms of the
model proposed by the Media Capture and Streams spec [1].
A MediaStreamTrackProcessor can be combined with a TransformStream and a
MediaStreamTrackGenerator to effectively insert a processing step inside
an existing track.

[1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings

Bug: 1142955
Change-Id: I2a119f0c2ea9ce50432509286bd0f43758d8a272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524322
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826153}

Currently the TabStripRegionView controls are flush with the window's
caption buttons on Windows, Linux and ChromeOS and sitting flush with
the browser window itself on Mac.

This CL introduces an 8pt padding to the TabStripRegionView when tab
strip controls are present in keeping with UX guidance. Presently the
only applicable control is the TabSearchBubtton.

This introduces the desired spacing between window caption buttons
and right aligned controls. It also correctly aligns the rightmost
control over the 3 dot menu in the toolbar on Mac.

Bug: 1145277
Change-Id: Ic199b7f21f158723559d82dc37046ff463ae6c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522167Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826152}

This CL sets the result icon based on answer type, for applicable
results.

The title and details handling is also moved around so that logic
for the rich entity experiment is clearly separate.


Change-Id: I2f3512b9e597295b14f865e65d73bd598a9a0c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437710Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826151}

In the network service, no one sets the property. In content/browser,
some code read bytes into the property but no one uses the read content.

Bug: None
Change-Id: I16f347a1d70ca98aabf56fefc20c7423e6b52f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526825Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826150}

When a user clicks done they'll return to the initial scanning page.
The next CL will add a "Show file location" link to this page.

http://screen/3M4mPRveuCzYjoQ

Bug: 1059779
Change-Id: I74950fa83370b8339d000ec9b18d29b493587d0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528089
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826149}

A cached WebView's WebContents in WebUIBubbleManager may not
necessarily be in a visible state that enables processing of
rendering events.

Call WasShown() before reloading to ensure the WebContents propagates
these events and ShowUI() is eventually called.

Bug: None
Change-Id: I810b2e10e286e8cca1948ee6aab014efa843db86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530192Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826148}

This change makes close tab more efficient. According to the performance
benchmark https://pinpoint-dot-chromeperf.appspot.com/job/15a9cbdd520000
It reduces close tab latency from 105ms to 37ms.

Bug: 1099917
Change-Id: I987a98006d5b8788af8ab844a8871458a620b20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527625
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826147}

This CL adds messages for all cases where the user keyboard focuses a
tab and uses CTRL+[SHIFT+]RIGHT/LEFT to move the focused tab.

Messages include:
- Tab moved right/left/start/end
- Tab added to/removed from group

Currently there is no feedback if the tab cannot be moved. We can always
add some.

Note: no screenshots because these are announce-only messages.

Bug: 1110426
Change-Id: I7ac14e840769a54304e128ce809823b7231f9ec2
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530733Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826146}

It is flaky:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome

We should use async semantics rather than wait runloop at GetPlugins().

TBR=sky@chromium.org
BUG=1147726

Change-Id: I003bee856004e0f7476cf008429d68284776173f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531418Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826145}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5db9eeec2f2e..45bafa0558b1

2020-11-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4dcc83ad10e6953abcdb6edb69c5eb07b1f3e69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531068Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826144}

In //ui/file_manager/image_loader:
- load_image_request.js
- image_loader_client.js
- image_loader_client_unittest.js

Bug: 1133186
Change-Id: Iaef19a8bcafc298d8e91cd398b92e3fc881dda6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531335
Auto-Submit: Jeremie Boulic <jboulic@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826143}

This reverts commit ee2f8113.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 825930 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWUyZjgxMTM1MTFjZTRiNzE5YzAwNTA4OTFjMzJjNGZiMWJlMzM2ZAw

Sample Failed Build: https://ci.chromium.org/b/8863960967178909888

Sample Failed Step: blink_web_tests on Mac-10.15

Sample Flaky Test: external/wpt/webauthn/createcredential-resident-key.https.html

Original change's description:
> webauthn: move create credential tests for residentKey/credProps to WPT
> 
> Bug: 1117630
> Change-Id: I2fa4d73b7a4cfe5e7f19fd835cb32e1bb4926d2f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508878
> Reviewed-by: Nina Satragno <nsatragno@chromium.org>
> Commit-Queue: Martin Kreichgauer <martinkr@google.com>
> Cr-Commit-Position: refs/heads/master@{#825930}


Change-Id: I54688bd7288995c66a1a361f361e6c1694e1378d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1117630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531219
Cr-Commit-Position: refs/heads/master@{#826142}

In //ui/file_manager/file_manager/foreground/js/metadata:
- byte_reader.js
- exif_constants.js
- external_metadata_provider.js
- external_metadata_provider_unittest.js
- file_system_metadata_provider.js
- file_system_metadata_provider_unittest.js
- function_parallel.js
- function_sequence.js
- image_parsers.js
- metadata_cache_item.js
- metadata_cache_item_unittest.js
- metadata_parser.js
- mpeg_parser.js

In //ui/file_manager/externs:
- metadata_worker_window.js

Bug: 1133186
Change-Id: I78221a455d67da3662cb7a0317eb12c01f7aef46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529371
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826141}

This seems safe and correct and hopefully fixes the ClusterFuzz issue.
Also separates the failing CHECK into pieces so if this _doesn't_ fix
the problem I can more easily see why.

Bug: 1136149
Change-Id: Ic974940335fd03204ff1a1fee720ac85fe130f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522572
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826140}

Roll Chrome Win64 PGO profile from chrome-win64-master-1605020074-68960f639156f9ccbd07438455ce3664424ac683.profdata to chrome-win64-master-1605041937-1449424af661a723772729965b60b3f566868499.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I406fcc0437f499c7913a063c7f81d7de26982453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530978Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826139}

https://chromium.googlesource.com/catapult.git/+log/c80cb7a957ea..994d3835f535

2020-11-11 bsheedy@chromium.org [typ] Fix ResultSink unicode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1147329
Tbr: oysteine@google.com
Change-Id: Ib7a7c48f3e1c1d95d57e1193095b5349aea324a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530627Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826138}

pdf viewer

If chrome is not the default pdf viewer, clicking on a pdf will
trigger a download. After download completes, Chrome will invoke
the system viewer to auto-open the pdf file. However, the system
viewer might be chrome itself, and that will trigger downloading
the file URL, and causing an infinite number of download.

This CL fixes the issue by blocking the pdf download if it is a file
URL. An alternative to fix the issue is to block the auto-open if Chrome
is not the default pdf viewer

BUG=851650

Change-Id: Ie12105408f80650463a6eae4f57cb6de23d1a875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531217Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826137}