GitLab

Fixes for:
https://code.google.com/p/cld2/issues/detail?id=11
https://code.google.com/p/cld2/issues/detail?id=12

BUG=

Review URL: https://codereview.chromium.org/213623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261474 0039d316-1c4b-4281-b951-d872f2087c98

Moves the transient parent utilities to gtk2_util and makes both
dialogs use it.

This is a reland of r259318 with a fix of test failures.

BUG=334331
TBR=erg@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/221813010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261473 0039d316-1c4b-4281-b951-d872f2087c98

The timestamp generation is moved from libjingle/renderer to the browser. The renderer sends the absolute system time for each message in the IPC, which is used by WebRtcLoggingHandlerHost to calculate the timestamp relative to the logging started time.

BUG=339478

Review URL: https://codereview.chromium.org/218403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261472 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Provide unhandled tap event notifications (https://codereview.chromium.org/218633008/)

Reason for revert:
Legitimate browsertest failure.

Original issue's description:
> [Android] Provide unhandled tap event notifications
> 
> Allow notifications of unhandled taps via the GestureStateListener.  This change
> makes GestureTap events blocking, but there are several use-cases for which this
> will be necessary, e.g., WebView and contextual search.
> 
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261431

TBR=mkosiba@chromium.org,donnd@chromium.org,tedchoc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/224273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261470 0039d316-1c4b-4281-b951-d872f2087c98

The sync engine/api won't act on them yet; this just lays the groundwork for
passing context changes around.

BUG=345420

Review URL: https://codereview.chromium.org/220043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261469 0039d316-1c4b-4281-b951-d872f2087c98

This is not used for anything anymore.

BUG=None

Review URL: https://codereview.chromium.org/223813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358028

Review URL: https://codereview.chromium.org/219363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261466 0039d316-1c4b-4281-b951-d872f2087c98

Consider the following sequence of events:
1. The view is initialized with a size of 0x0
2. A frame comes in at a size of 50x50. Nothing is drawn.
3. The view is resized to 50x50.

We should re-draw the full frame at step 3, but we don't. This patch
makes it so that we do.

BUG=358450

Review URL: https://codereview.chromium.org/217283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261465 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative fix for the flaky test
RenderingStatsUnitTest.testScrollLatencyFromTimeline  (crbug.com/358673)

I am not sure about the root cause and can't repro this locally.
Buy inspecting the code I feel there could be problems if the
default timer.Advance() advances 0ms. So lets always pass in explicit
low & high parameters into timer.Advance(low, high) and see if this fix
the flaky test.

Note: the root cause could have been fixed by 
https://src.chromium.org/viewvc/chrome?revision=261034&view=revision

This is CL could be just a nice add-on.
BUG=358673
TEST=unittests RenderingStatsUnitTest.* pass.

Review URL: https://codereview.chromium.org/220113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261464 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the test used a hardcoded distiller template which didn't
help test the distiller. Updates the test to use the real distiller and
adds tests for relativization of images and anchors.

In the process, attempts to handle a few failure modes of the distiller.

BUG=353349,354737
TBR=blundell

Review URL: https://codereview.chromium.org/211493008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355617

Review URL: https://codereview.chromium.org/223613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261462 0039d316-1c4b-4281-b951-d872f2087c98

[Reason for revert: failure in WindowUtilTest.RecreateLayers
 in test suite wm_core_unittests
 on bot Linux ChromiumOS Tests (dbg)(1) Build]

> cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture
> 
> These are not used anymore except for clearing the client-provided texture, so
> this removes 1 of 4 TextureLayer paths, and simplifies externally-exposed state.
> 
> BUG=337922
> 
> Review URL: https://codereview.chromium.org/213743005

TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/224153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261460 0039d316-1c4b-4281-b951-d872f2087c98

Previously left in for prefs migration.

BUG=339486

Review URL: https://codereview.chromium.org/222783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261459 0039d316-1c4b-4281-b951-d872f2087c98

This is step 2 of 5 in moving HistoryController to content/, as described in http://crbug.com/357327

These calls will allow content/ to be responsible for updating history state in step 3, and eventually to implement history state management in step 4.

BUG=357327

Review URL: https://codereview.chromium.org/218993014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261458 0039d316-1c4b-4281-b951-d872f2087c98

This more or less reverts r149968.

BUG=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/218683013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261457 0039d316-1c4b-4281-b951-d872f2087c98

Sadly, no tests caught that this was broken. I'll try to add a test to detect
this, but I want to get a fix in quickly.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/222123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261456 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use apps::AppEventRouter to launch app_shell apps (https://codereview.chromium.org/219513005/)

Reason for revert:
This creates an unwanted dependency from app_shell back onto apps (we're moving it to depend only on extensions to keep the binary small).


Original issue's description:
> Use apps::AppEventRouter to launch app_shell apps
> 
> Now that the app_runtime API has moved to //apps we can eliminate a small
> amount of code duplication in app_shell.
> 
> BUG=357818
> TEST=app_shell launches calculator
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260647

TBR=rockot@chromium.org
NOTRY=true
BUG=357818

Review URL: https://codereview.chromium.org/224173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261455 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary fix for a problem that is tightly packed I420 video frame can not be created easily.

BUG=359587

Review URL: https://codereview.chromium.org/224013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261454 0039d316-1c4b-4281-b951-d872f2087c98

The current mechanism of "searching" for the Users section fails on non-English installs because search operates in the user's language while we're hard-coding a search for "Users".

BUG=280919

Review URL: https://codereview.chromium.org/220403012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261453 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261452 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/223403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261450 0039d316-1c4b-4281-b951-d872f2087c98

So it turned out that the "Prepare push to trunk" isn't guaranteed anymore, so the new v8 mapping to bleeding edge wasn't quite right.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/218083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261449 0039d316-1c4b-4281-b951-d872f2087c98

Integrates the SegregatedPrefStore with chrome_pref_service_factory.cc .

BUG=349158

Review URL: https://codereview.chromium.org/218583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261448 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to take SetReadOnlyProperty out of PPB_NaCl_Private. Hooray.

BUG=236959
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/222203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261447 0039d316-1c4b-4281-b951-d872f2087c98

Another DCHECK fix.
Very simple error, without this 'return' we call the callback twice
which hits assertion in the receiver side in the renderer.

BUG=359438
TEST=manually tested with non-existent service-worker URL in debug build

Review URL: https://codereview.chromium.org/223383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359138
For c/b/sync tests:

R=calamity@chromium.org, jennyz@chromium.org, xiyuan@chromium.org
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/222553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261445 0039d316-1c4b-4281-b951-d872f2087c98

fileBrowserPrivate.getSizeStats takes volumeId as the argument,
not the root URL.

BUG=350101

Review URL: https://codereview.chromium.org/218623020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352805
R=erg@chromium.org, jennyz@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/217483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261443 0039d316-1c4b-4281-b951-d872f2087c98

This is the really simple implementation that can be refined if consumer wants it.

BUG=318450

Review URL: https://codereview.chromium.org/220303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WebRTC demos on Windows using a capture device which supports 192kHz.

Review URL: https://codereview.chromium.org/223933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261441 0039d316-1c4b-4281-b951-d872f2087c98

support.

BUG=108012
R=cmumford,jsbell

Review URL: https://codereview.chromium.org/203833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261440 0039d316-1c4b-4281-b951-d872f2087c98

Browser expects to know paths to mips native client executables, so these
need to be provided in manifest files. Lack of these causes the related
browser tests to fail on MIPS arch.

Review URL: https://codereview.chromium.org/219193017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261439 0039d316-1c4b-4281-b951-d872f2087c98

Refactored the helper functions into views-specific code and rest (so that the non-views code can be used in more places).

Fixed a bug where if you have two extensions simultaneously overwriting settings, the bubble now knows which one is active.

Also prevent the bubble from writing the suppress flag when the user choses to disable the extension (that way they get the bubble again if the extension becomes enabled for some reason).

BUG=356204
R=sky@chromium.org, yoz@chromium.org
TBR=sky

Review URL: https://codereview.chromium.org/219593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261438 0039d316-1c4b-4281-b951-d872f2087c98

Change its only user, adb_gdb, to instead use pylib.constants.

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/221933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327256

Review URL: https://codereview.chromium.org/223163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261435 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261434 0039d316-1c4b-4281-b951-d872f2087c98

Original patch is https://codereview.chromium.org/196503005/.
But it was reverted because of memory leaks.
https://codereview.chromium.org/223583002/

This is the fixed version.

BUG=327256

Review URL: https://codereview.chromium.org/223123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261432 0039d316-1c4b-4281-b951-d872f2087c98

Allow notifications of unhandled taps via the GestureStateListener.  This change
makes GestureTap events blocking, but there are several use-cases for which this
will be necessary, e.g., WebView and contextual search.

NOTRY=true

Review URL: https://codereview.chromium.org/218633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261431 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261430 0039d316-1c4b-4281-b951-d872f2087c98

Previously, synthetic gesture completion callbacks were triggered as soon as
the last generated event was *sent*.  A truer indicator of completion, however,
is when the last generated event was *ack'ed*.  For now, this is accomplished
by blocking the completion notification until all events have been flushed
through the pipeline.

In the future, a better solution will be inserting event
fences with an appropriate callback to indicate completion.  Note that this
approach fails to properly wait until all timeout events have been flushed
(e.g., GestureTap events on desktop sites on Android).

BUG=357505

Review URL: https://codereview.chromium.org/217163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261429 0039d316-1c4b-4281-b951-d872f2087c98